@truedat/dq 7.13.6 → 7.13.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "7.13.6",
+  "version": "7.13.8",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "module": "src/index.js",
@@ -53,7 +53,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "7.13.6",
+    "@truedat/test": "7.13.8",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -86,5 +86,5 @@
     "semantic-ui-react": "^3.0.0-beta.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "5c369d5a90a39be6362493db19e597a91d5a907d"
+  "gitHead": "14e97850f4591da2e3b26dfd5192da159812a39a"
 }

package/src/components/ConceptRules.js

@@ -115,17 +115,26 @@ ConceptRules.propTypes = {
   showExpandableColumn: PropTypes.bool,
 };
 
-const mapStateToProps = ({ conceptRules, concept, conceptRulesActions }) => ({
+const mapStateToProps = ({
+  conceptRules,
   concept,
-  conceptRules: _.flow(
-    _.reject("deleted_at"),
-    _.orderBy(["business_concept_id", "df_name"], ["desc", "asc"])
-  )(conceptRules),
-  showExpandableColumn: _.some("business_concept_name")(conceptRules),
-  createRuleUrl: conceptRulesActions?.create
-    ? linkTo.CONCEPT_RULES_NEW(concept)
-    : null,
-  visible: _.prop("status")(concept) != "deprecated",
-});
+  conceptRulesActions,
+  conceptPermissions = {},
+}) => {
+  const manageQualityRule = !!_.prop("manage_quality_rule")(conceptPermissions);
+  return {
+    concept,
+    conceptRules: _.flow(
+      _.reject("deleted_at"),
+      _.orderBy(["business_concept_id", "df_name"], ["desc", "asc"])
+    )(conceptRules),
+    showExpandableColumn: _.some("business_concept_name")(conceptRules),
+    createRuleUrl: conceptRulesActions?.create
+      ? linkTo.CONCEPT_RULES_NEW(concept)
+      : null,
+    visible:
+      _.prop("status")(concept) != "deprecated" && manageQualityRule,
+  };
+};
 
 export default connect(mapStateToProps)(ConceptRules);

package/src/components/__tests__/ConceptRules.spec.js

@@ -1,5 +1,6 @@
-import { render } from "@truedat/test/render";
+import { render, waitForLoad } from "@truedat/test/render";
 import { ConceptRules } from "../ConceptRules";
+import { linkTo } from "@truedat/core/routes";
 
 describe("<ConceptRules />", () => {
   const createRuleUrl = "/concepts/1/versions/2/rules/new";
@@ -83,4 +84,59 @@ describe("<ConceptRules />", () => {
 
     expect(queryByText(/Create/)).toBeTruthy();
   });
+
+  it("shows create button when concept is not deprecated and user has manageQualityRule permission", async () => {
+    const concept = { id: "1", business_concept_id: "8", status: "current" };
+    const props = {
+      conceptRules: [],
+      showExpandableColumn: false,
+      createRuleUrl: linkTo.CONCEPT_RULES_NEW(concept),
+      visible: true,
+    };
+    const rendered = render(<ConceptRules {...props} />, renderOpts);
+    await waitForLoad(rendered);
+
+    expect(rendered.queryByText(/Create/i)).toBeInTheDocument();
+  });
+
+  it("does not show create button when concept is deprecated even with manageQualityRule permission", async () => {
+    const concept = { id: "1", business_concept_id: "8", status: "deprecated" };
+    const props = {
+      conceptRules: [],
+      showExpandableColumn: false,
+      createRuleUrl: linkTo.CONCEPT_RULES_NEW(concept),
+      visible: false,
+    };
+    const rendered = render(<ConceptRules {...props} />, renderOpts);
+    await waitForLoad(rendered);
+
+    expect(rendered.queryByText(/Create/i)).not.toBeInTheDocument();
+  });
+
+  it("does not show create button when user does not have manageQualityRule permission", async () => {
+    const concept = { id: "1", business_concept_id: "8", status: "current" };
+    const props = {
+      conceptRules: [],
+      showExpandableColumn: false,
+      createRuleUrl: linkTo.CONCEPT_RULES_NEW(concept),
+      visible: false,
+    };
+    const rendered = render(<ConceptRules {...props} />, renderOpts);
+    await waitForLoad(rendered);
+
+    expect(rendered.queryByText(/Create/i)).not.toBeInTheDocument();
+  });
+
+  it("does not show create button when conceptRulesActions.create is not available", async () => {
+    const props = {
+      conceptRules: [],
+      showExpandableColumn: false,
+      createRuleUrl: null,
+      visible: true,
+    };
+    const rendered = render(<ConceptRules {...props} />, renderOpts);
+    await waitForLoad(rendered);
+
+    expect(rendered.queryByText(/Create/i)).not.toBeInTheDocument();
+  });
 });