@truedat/dq 7.12.7 → 7.13.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "7.12.7",
+  "version": "7.13.0",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "module": "src/index.js",
@@ -86,5 +86,5 @@
     "semantic-ui-react": "^3.0.0-beta.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "4fcf1a96c366bb13af6261808308a00cc7480a82"
+  "gitHead": "fce3d82fdde98cdd99f6fe5a8a0a0a52a7de9669"
 }

package/src/api.js

@@ -22,8 +22,7 @@ const API_RULE_IMPLEMENTATIONS_XLSX_UPLOAD_JOBS =
   "/api/rule_implementations/xlsx/upload_jobs";
 const API_RULE_IMPLEMENTATIONS_XLSX_UPLOAD_JOB =
   "/api/rule_implementations/xlsx/upload_jobs/:id";
-const API_RULE_IMPLEMENTATIONS_FROM_RULE =
-  "/api/rules/:id/rule_implementations";
+const API_RULE_IMPLEMENTATIONS_FROM_RULE = "/api/rules/rule_implementations";
 const API_RULE_IMPLEMENTATIONS_SEARCH = "/api/rule_implementations/search";
 const API_RULE_IMPLEMENTATION_FILTERS_SEARCH =
   "/api/rule_implementation_filters/search";

package/src/components/RuleFormImplementations.js

@@ -4,7 +4,7 @@ import { connect } from "react-redux";
 import { Container } from "semantic-ui-react";
 import { getLinkedImplementationsToRulesColumns } from "../selectors";
 import {
-  useRuleImplementationSearch,
+  useRuleImplementationFromRulesSearch,
   useRuleImplementationFilters,
 } from "../hooks/useImplementations";
 import RuleImplementationsTable from "./RuleImplementationsTable";
@@ -15,7 +15,7 @@ export const RuleFormImplementations = ({ rule, columns }) => {
   const searchProps = {
     initialSortColumn: "implementation_key.raw",
     initialSortDirection: "ascending",
-    useSearch: useRuleImplementationSearch,
+    useSearch: useRuleImplementationFromRulesSearch,
     useFilters: useRuleImplementationFilters,
     pageSize: 20,
     defaultFilters: {

package/src/components/__tests__/RuleFormImplementations.spec.js

@@ -1,6 +1,28 @@
 import { render, waitForLoad } from "@truedat/test/render";
+import { useSearchContext } from "@truedat/core/search/SearchContext";
+import {
+  useRuleImplementationFromRulesSearch,
+  useRuleImplementationFilters,
+} from "../../hooks/useImplementations";
 import { RuleFormImplementations } from "../RuleFormImplementations";
 
+jest.mock("@truedat/core/search/SearchContext", () => {
+  const originalModule = jest.requireActual(
+    "@truedat/core/search/SearchContext"
+  );
+
+  return {
+    __esModule: true,
+    ...originalModule,
+    useSearchContext: jest.fn(),
+  };
+});
+
+jest.mock("../../hooks/useImplementations", () => ({
+  useRuleImplementationFromRulesSearch: jest.fn(),
+  useRuleImplementationFilters: jest.fn(),
+}));
+
 describe("<RuleFormImplementations />", () => {
   const rule = { id: 1, name: "rule name" };
   const updateDeletionQuery = jest.fn();
@@ -10,6 +32,24 @@ describe("<RuleFormImplementations />", () => {
     deletedRender: false,
   };
 
+  beforeEach(() => {
+    jest.clearAllMocks();
+    useRuleImplementationFromRulesSearch.mockReturnValue({
+      trigger: jest.fn(),
+    });
+    useRuleImplementationFilters.mockReturnValue({
+      trigger: jest.fn(),
+    });
+    useSearchContext.mockReturnValue({
+      searchData: {
+        data: [],
+        scroll_id: null,
+      },
+      searchMust: { status: ["pending"] },
+      setOnSearchChange: jest.fn(),
+    });
+  });
+
   it("matches the latest snapshot", async () => {
     const rendered = render(<RuleFormImplementations {...props} />);
     await waitForLoad(rendered);
@@ -31,4 +71,11 @@ describe("<RuleFormImplementations />", () => {
       rendered.container.querySelector(".implementation-actions")
     ).toBeInTheDocument();
   });
+
+  it("uses useRuleImplementationFromRulesSearch hook", async () => {
+    const rendered = render(<RuleFormImplementations {...props} />);
+    await waitForLoad(rendered);
+
+    expect(useRuleImplementationFromRulesSearch).toHaveBeenCalled();
+  });
 });

package/src/hooks/__tests__/useImplementations.spec.js

@@ -0,0 +1,35 @@
+import _ from "lodash/fp";
+import useSWRMutations from "swr/mutation";
+import { renderHook } from "@testing-library/react";
+import { apiJsonPost } from "@truedat/core/services/api";
+import { API_RULE_IMPLEMENTATIONS_FROM_RULE } from "../../api";
+import { useRuleImplementationFromRulesSearch } from "../useImplementations";
+
+jest.mock("swr/mutation", () => ({
+  __esModule: true,
+  ...jest.requireActual("swr/mutation"),
+  default: jest.fn(),
+}));
+
+jest.mock("@truedat/core/services/api", () => ({
+  __esModule: true,
+  ...jest.requireActual("@truedat/core/services/api"),
+  apiJsonPost: jest.fn(),
+}));
+
+describe("useRuleImplementationFromRulesSearch", () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it("calls useSWRMutations with correct api route", () => {
+    renderHook(() => useRuleImplementationFromRulesSearch());
+    const [url, func] = _.last(useSWRMutations.mock.calls);
+    const arg = { rule_id: 1, page: 1 };
+    expect(url).toBe(API_RULE_IMPLEMENTATIONS_FROM_RULE);
+    func(url, { arg });
+
+    expect(apiJsonPost).toHaveBeenCalledWith(url, arg);
+  });
+});
+

package/src/hooks/useImplementations.js

@@ -11,6 +11,7 @@ import {
 import {
   API_RULE_IMPLEMENTATIONS_SEARCH,
   API_RULE_IMPLEMENTATION_FILTERS_SEARCH,
+  API_RULE_IMPLEMENTATIONS_FROM_RULE,
   API_RULE_IMPLEMENTATIONS_XLSX_DOWNLOAD,
   API_RULE_IMPLEMENTATIONS_XLSX_UPLOAD,
   API_RULE_IMPLEMENTATIONS_XLSX_UPLOAD_JOBS,
@@ -41,6 +42,12 @@ export const useRuleImplementationSearch = () => {
   });
 };
 
+export const useRuleImplementationFromRulesSearch = () => {
+  return useSWRMutations(API_RULE_IMPLEMENTATIONS_FROM_RULE, (url, { arg }) => {
+    return apiJsonPost(url, arg);
+  });
+};
+
 export const useImplementationsDownload = () => {
   return useSWRMutations(
     API_RULE_IMPLEMENTATIONS_XLSX_DOWNLOAD,