@truedat/dq 6.12.6 → 6.13.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "6.12.6",
+  "version": "6.13.1",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -92,8 +92,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.7.1",
-    "@truedat/core": "6.12.6",
-    "@truedat/df": "6.12.6",
+    "@truedat/core": "6.13.1",
+    "@truedat/df": "6.13.1",
     "decode-uri-component": "^0.2.2",
     "graphql": "^15.5.3",
     "moment": "^2.29.4",
@@ -118,5 +118,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 2.0.3 < 2.2"
   },
-  "gitHead": "6ee7f5e8767d2149347997223377f91f0164ee34"
+  "gitHead": "3803d8c4a416f1e1f56d88989c6c7503a08467d8"
 }

package/src/components/NewRule.js

@@ -19,6 +19,7 @@ ConceptRuleForm.propTypes = {
 
 export const NewRule = ({ createRule, concept }) => {
   const { business_concept_id } = useParams();
+
   return (
     <Container as={Segment} text>
       <Header as="h2">

package/src/components/RuleResultDecorator.js

@@ -48,12 +48,15 @@ export const calculateResultDecoration = ({
     _.prop("results"),
     (results) => _.isArray(results) && !_.isEmpty(results)
   );
+  const hasRequiredFields = (ruleImplementation) =>
+    _.has("goal")(ruleImplementation) && _.has("minimum")(ruleImplementation);
   const firstResult = _.flow(_.prop("results"), _.first);
   const defaultValue = { goal: null, minimum: null };
 
   const { goal, minimum } = _.cond([
     [executionInfoIsObject, _.prop("execution_result_info")],
     [notEmptyResults, firstResult],
+    [hasRequiredFields, _.pick(["goal", "minimum"])],
     [_.stubTrue, () => defaultValue],
   ])(ruleImplementation);
 

package/src/components/__tests__/NewRule.spec.js

@@ -3,6 +3,11 @@ import { waitFor } from "@testing-library/react";
 import { render } from "@truedat/test/render";
 import NewRule from "../NewRule";
 
+jest.mock("react-router-dom", () => ({
+  ...jest.requireActual("react-router-dom"),
+  useParams: () => ({ business_concept_id: 123 }),
+}));
+
 const state = {
   concept: { business_concept_id: 123, domain_id: 22 },
   conceptActiveFilters: {},
@@ -11,9 +16,10 @@ const renderOpts = { fallback: "lazy", state };
 
 describe("<NewRule />", () => {
   it("matches the latest snapshot (with concept)", async () => {
-    // falla el snapshot porque viene sin description y falta algún campo
-    const { container, findByText } = render(<NewRule />, renderOpts);
-    await findByText(/No results found./);
-    expect(container).toMatchSnapshot();
+    const { container, getByText } = render(<NewRule />, renderOpts);
+    await waitFor(() => {
+      expect(getByText(/Template/i)).toBeInTheDocument();
+      expect(container).toMatchSnapshot();
+    });
   });
 });

package/src/components/__tests__/__snapshots__/NewRule.spec.js.snap

@@ -219,6 +219,60 @@ exports[`<NewRule /> matches the latest snapshot (with concept) 1`] = `
           </div>
         </label>
       </div>
+      <div
+        class="required field"
+      >
+        <label>
+          Template
+          <div
+            class="ui left pointing label"
+          >
+            Empty required field
+          </div>
+        </label>
+        <div
+          class="field"
+        >
+          <div
+            aria-busy="true"
+            aria-expanded="false"
+            class="ui loading search selection dropdown"
+            name="template"
+            role="combobox"
+          >
+            <input
+              aria-autocomplete="list"
+              autocomplete="off"
+              class="search"
+              tabindex="0"
+              type="text"
+              value=""
+            />
+            <div
+              aria-atomic="true"
+              aria-live="polite"
+              class="divider default text"
+              role="alert"
+            >
+              loading...
+            </div>
+            <i
+              aria-hidden="true"
+              class="dropdown icon"
+            />
+            <div
+              class="menu transition"
+              role="listbox"
+            >
+              <div
+                class="message"
+              >
+                No results found.
+              </div>
+            </div>
+          </div>
+        </div>
+      </div>
       <div
         class="actions"
       >