@truedat/dq 4.58.3 → 4.58.5

package/src/components/ruleImplementationForm/__tests__/RuleImplementationBasicForm.spec.js

@@ -0,0 +1,136 @@
+import _ from "lodash/fp";
+import React from "react";
+import { waitFor } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { render } from "@truedat/test/render";
+import { DOMAIN_QUERY, DOMAINS_QUERY } from "@truedat/core/api/queries";
+import { multipleTemplatesMock } from "@truedat/test/mocks";
+import { RuleImplementationBasicForm } from "../RuleImplementationBasicForm";
+
+jest.setTimeout(30000);
+
+const domains = [
+  { id: 1, name: "domain1", actions: ["publishImplementation"] },
+];
+const domainsMock = {
+  request: { query: DOMAINS_QUERY },
+  result: { data: { domains: domains } },
+};
+
+const domainMock = {
+  request: { query: DOMAIN_QUERY },
+  result: { data: { domain: domains } },
+};
+
+const renderOpts = {
+  mocks: [
+    multipleTemplatesMock({ scope: "ri", domainIds: [1] }),
+    domainMock,
+    domainsMock,
+  ],
+  state: {
+    rule: { domain_id: 1 },
+    ruleImplementationCreating: false,
+  },
+  fallback: "lazy",
+};
+
+const props = {
+  onChange: jest.fn(),
+  onSubmit: jest.fn(),
+  implementationKey: "",
+  isSubmitting: false,
+  ruleImplementation: {
+    id: 1,
+    goal: "10",
+    minimum: "1",
+    result_type: "percentage",
+  },
+};
+
+describe("<RuleImplementationBasicForm />", () => {
+  it("matches the latest snapshot", async () => {
+    const updatedProps = _.flow(_.set("ruleImplementation.domain_id", 1))(
+      props
+    );
+    const { container, queryByText } = render(
+      <RuleImplementationBasicForm {...updatedProps} />,
+      renderOpts
+    );
+    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument(), {
+      timeout: 10000,
+    });
+    await waitFor(() =>
+      expect(queryByText(/loading/i)).not.toBeInTheDocument()
+    );
+    expect(container).toMatchSnapshot();
+  });
+
+  it("Implementation_key field is editable with status published", () => {
+    const updatedProps = _.flow(
+      _.set("ruleImplementation.domain_id", 1),
+      _.set("ruleImplementation.status", "published"),
+      _.set("ruleImplementation.implementation_key", "implementation_test")
+    )(props);
+    const { queryByPlaceholderText } = render(
+      <RuleImplementationBasicForm {...updatedProps} />,
+      renderOpts
+    );
+    expect(
+      queryByPlaceholderText("Rule Implementation Key")
+    ).not.toBeDisabled();
+  });
+
+  it("submit button enabled if there is valid content in form without rule", async () => {
+    const updatedProps = _.flow(
+      _.set("ruleImplementation.domain_id", 1),
+      _.set("ruleImplementation.dfName", "template1"),
+      _.set("ruleImplementation.dfContent", { field1: "foo" })
+    )(props);
+    const customProps = {
+      ...updatedProps,
+    };
+
+    const { getByRole } = render(
+      <RuleImplementationBasicForm {...customProps} />,
+      renderOpts
+    );
+    await waitFor(() => {
+      expect(getByRole("button", { name: "Save" })).toBeEnabled();
+    });
+  });
+
+  it("submit button enabled if there is valid content in form with rule", async () => {
+    const updatedProps = _.flow(
+      _.set("ruleImplementation.domain_id", 1),
+      _.set("ruleImplementation.dfName", "template1"),
+      _.set("ruleImplementation.dfContent", { field1: "foo" })
+    )(props);
+    const customProps = {
+      ...updatedProps,
+      rule: { id: 5, name: "regla" },
+    };
+
+    const { findByRole } = render(
+      <RuleImplementationBasicForm {...customProps} />,
+      renderOpts
+    );
+    expect(await findByRole("button", { name: /save/i })).toBeEnabled();
+  });
+
+  it("submit button disabled if there is invalid content in form", async () => {
+    const updatedProps = _.flow(
+      _.set("ruleImplementation.domain_id", 1),
+      _.set("ruleImplementation.dfName", "template1"),
+      _.set("ruleImplementation.dfContent", {})
+    )(props);
+    const customProps = {
+      ...updatedProps,
+    };
+    const { queryByRole } = render(
+      <RuleImplementationBasicForm {...customProps} />,
+      renderOpts
+    );
+    expect(queryByRole("button", { name: /save/i })).toBeDisabled();
+  });
+});

package/src/components/ruleImplementationForm/__tests__/__snapshots__/RuleImplementationBasicForm.spec.js.snap

@@ -0,0 +1,273 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleImplementationBasicForm /> matches the latest snapshot 1`] = `
+<div>
+  <form
+    class="ui form rule"
+    style=""
+  >
+    <div
+      class="field"
+    >
+      <label>
+        Implementation Key
+        <i
+          aria-hidden="true"
+          class="question circle outline icon rule-form-popup"
+        />
+      </label>
+      <div
+        class="required field"
+      >
+        <div
+          class="ui input"
+        >
+          <input
+            autocomplete="off"
+            name="implementation_key"
+            placeholder="Rule Implementation Key"
+            required=""
+            type="text"
+            value=""
+          />
+        </div>
+      </div>
+    </div>
+    <div
+      class="field"
+    />
+    <div
+      class="ui segment"
+    >
+      <div
+        class="field"
+      >
+        <label
+          class="rule-form-label"
+        >
+          Result Type
+          <span>
+            *
+          </span>
+          <i
+            aria-hidden="true"
+            class="question circle outline icon rule-form-popup"
+          />
+        </label>
+        <div
+          class="inline fields"
+        >
+          <div
+            class="field"
+          >
+            <div
+              class="ui checked radio checkbox"
+            >
+              <input
+                checked=""
+                class="hidden"
+                name="result_type"
+                readonly=""
+                tabindex="0"
+                type="radio"
+                value="percentage"
+              />
+              <label>
+                Percentage
+              </label>
+            </div>
+          </div>
+          <div
+            class="field"
+          >
+            <div
+              class="ui radio checkbox"
+            >
+              <input
+                class="hidden"
+                name="result_type"
+                readonly=""
+                tabindex="0"
+                type="radio"
+                value="deviation"
+              />
+              <label>
+                Deviation
+              </label>
+            </div>
+          </div>
+          <div
+            class="field"
+          >
+            <div
+              class="ui radio checkbox"
+            >
+              <input
+                class="hidden"
+                name="result_type"
+                readonly=""
+                tabindex="0"
+                type="radio"
+                value="errors_number"
+              />
+              <label>
+                Error count
+              </label>
+            </div>
+          </div>
+        </div>
+      </div>
+      <div
+        class="field"
+      >
+        <label
+          class="rule-form-label"
+        >
+          Threshold
+          <span>
+            *
+          </span>
+          <i
+            aria-hidden="true"
+            class="question circle outline icon rule-form-popup"
+          />
+        </label>
+        <div
+          class="field"
+        >
+          <div
+            class="ui input"
+          >
+            <input
+              autocomplete="off"
+              name="minimum"
+              placeholder="Threshold value"
+              type="text"
+              value="1"
+            />
+          </div>
+        </div>
+      </div>
+      <div
+        class="field"
+      >
+        <label
+          class="rule-form-label"
+        >
+          Goal
+          <span>
+            *
+          </span>
+          <i
+            aria-hidden="true"
+            class="question circle outline icon rule-form-popup"
+          />
+        </label>
+        <div
+          class="field"
+        >
+          <div
+            class="ui input"
+          >
+            <input
+              autocomplete="off"
+              name="goal"
+              placeholder="Goal value"
+              type="text"
+              value="10"
+            />
+          </div>
+        </div>
+      </div>
+    </div>
+    <div
+      class="required field"
+    >
+      <label>
+        Template
+        <div
+          class="ui left pointing label"
+        >
+          Empty required field
+        </div>
+      </label>
+      <div
+        class="field"
+      >
+        <div
+          aria-busy="false"
+          aria-expanded="false"
+          class="ui search selection dropdown"
+          name="template"
+          role="combobox"
+        >
+          <input
+            aria-autocomplete="list"
+            autocomplete="off"
+            class="search"
+            tabindex="0"
+            type="text"
+            value=""
+          />
+          <div
+            aria-atomic="true"
+            aria-live="polite"
+            class="divider default text"
+            role="alert"
+          >
+            Select a template...
+          </div>
+          <i
+            aria-hidden="true"
+            class="dropdown icon"
+          />
+          <div
+            class="menu transition"
+            role="listbox"
+          >
+            <div
+              aria-checked="false"
+              aria-selected="true"
+              class="selected item"
+              role="option"
+              style="pointer-events: all;"
+            >
+              <span
+                class="text"
+              >
+                template1
+              </span>
+            </div>
+            <div
+              aria-checked="false"
+              aria-selected="false"
+              class="item"
+              role="option"
+              style="pointer-events: all;"
+            >
+              <span
+                class="text"
+              >
+                template2
+              </span>
+            </div>
+          </div>
+        </div>
+      </div>
+    </div>
+    <button
+      class="ui primary disabled right floated button"
+      disabled=""
+      tabindex="-1"
+      type="submit"
+    >
+      Save
+    </button>
+    <button
+      class="ui secondary right floated button"
+    >
+      Cancel
+    </button>
+  </form>
+</div>
+`;

package/src/messages/en.js

@@ -72,6 +72,7 @@ export default {
     "This implementation will be executed. Are you sure?",
   "implementationStructures.empty": "No structures found",
   "implementations.actions.create": "Create implementation",
+  "implementations.actions.create_basic": "Create basic implementation",
   "implementations.actions.create_raw": "Create raw implementation",
   "implementations.actions.do_execution": "Execute implementations",
   "implementations.actions.download.empty":
@@ -141,6 +142,7 @@ export default {
   "quality.result.percentage.description": "{result}%",
   "quality.result_type": "Result Type",
   "quality.rule.actions.create": "New Implementation",
+  "quality.rule.actions.create_basic": "New basic Implementation",
   "quality.rule.actions.create_raw": "New raw Implementation",
   "quality.rule.description": "Description",
   "quality.rule.failed": "Failed",

package/src/messages/es.js

@@ -72,7 +72,8 @@ export default {
     "Se va a solicitar la ejecución de esta implementación. ¿Estás seguro?",
   "implementationStructures.empty": "Ningúna estructura encontrada",
   "implementations.actions.create": "Crear implementación",
-  "implementations.actions.create_raw": "Crear implementacion nativa",
+  "implementations.actions.create_basic": "Crear implementación básica",
+  "implementations.actions.create_raw": "Crear implementación nativa",
   "implementations.actions.do_execution": "Ejecutar implementaciones",
   "implementations.actions.download.empty":
     "No hay implementaciones para descargar",
@@ -145,6 +146,7 @@ export default {
   "quality.result.percentage.description": "{result}%",
   "quality.result_type": "Tipo resultado",
   "quality.rule.actions.create": "Nueva Implementación",
+  "quality.rule.actions.create_basic": "Nueva implementación básica",
   "quality.rule.actions.create_raw": "Nueva implementación nativa",
   "quality.rule.description": "Descripción",
   "quality.rule.failed": "Failed",