@truedat/dq 4.56.0 → 4.56.2

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [4.56.2] 2022-11-24
+
+### Changed
+
+- [TD-5247] Display the name of the table together with field in implementations
+  details
+
 ## [4.54.12] 2022-11-14
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.56.0",
+  "version": "4.56.2",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -93,8 +93,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.7.0",
-    "@truedat/core": "4.56.0",
-    "@truedat/df": "4.56.0",
+    "@truedat/core": "4.56.2",
+    "@truedat/df": "4.56.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
     "prop-types": "^15.8.1",
@@ -114,5 +114,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "17277e6b9438363c6baa26f8975a2ab585a61f76"
+  "gitHead": "d76f2da5ed4892e557e4aa159d4e9ff009e0e853"
 }

package/src/components/ConditionSummary.js

@@ -125,11 +125,11 @@ OperatorMessage.propTypes = {
 };
 
 const ConditionCell = ({ row, alias, validationPopulationCondition }) => {
-  const alias_text = _.flow(
-    _.find({ index: row.structure?.parent_index }),
-    _.propOr(null, "text")
-  )(alias);
-
+  const alias_text =
+    _.flow(
+      _.find({ index: row.structure?.parent_index }),
+      _.propOr(null, "text")
+    )(alias) || (row.structure ? _.last(row.structure.path) : null);
   const values = getValues(row);
   const operator = _.prop("operator")(row);
   const { formatMessage } = useIntl();

package/src/components/NewRuleImplementation.js

@@ -358,7 +358,7 @@ export const NewRuleImplementation = ({
         }
   );
 
-  const withoutUnusedAliasText = (dataset) => {
+  const withAliasText = (dataset) => {
     const duplicatedStructures = _.flow(
       _.groupBy("structure.id"),
       _.pickBy((x) => x.length > 1),
@@ -366,23 +366,24 @@ export const NewRuleImplementation = ({
       _.map(Number)
     )(dataset);
     return _.map((ds) =>
-      _.has("structure.id")(ds) &&
-      _.includes(ds.structure.id)(duplicatedStructures)
-        ? _.path("alias.text")(ds)
-          ? ds
-          : {
-              ...ds,
-              alias: {
-                ...ds.alias,
-                text: `${ds.structure.name} (${ds.alias.index})`,
-              },
-            }
-        : { ...ds, alias: { ...ds.alias, text: null } }
+      _.path("alias.text")(ds)
+        ? ds
+        : {
+            ...ds,
+            alias: {
+              ...ds.alias,
+              text:
+                _.has("structure.id")(ds) &&
+                _.includes(ds.structure.id)(duplicatedStructures)
+                  ? `${ds.structure?.name} (${ds.alias?.index})`
+                  : `${ds.structure?.name}`,
+            },
+          }
     )(dataset);
   };
 
   const setDataset = (dataset) => {
-    const cleanDataset = withoutUnusedAliasText(dataset);
+    const cleanDataset = withAliasText(dataset);
     //remove invalid references of fields in validations and populations after dataset edition
     const datasetStructures = _.map(_.path("structure.id"))(cleanDataset);
     const all_fields = _.flow(

package/src/components/__tests__/ConditionSummary.spec.js

@@ -5,7 +5,12 @@ import { ConditionSummary } from "../ConditionSummary";
 describe("<ConditionSummary />", () => {
   const rows = [
     {
-      structure: { field_type: "string", name: "Mes", id: 2598 },
+      structure: {
+        field_type: "string",
+        name: "Mes",
+        id: 2598,
+        parent_index: 1,
+      },
       operator: { name: "in_list", value_type: "string_list" },
       value: [{ raw: ["4", "5", "6"] }],
     },
@@ -14,6 +19,12 @@ describe("<ConditionSummary />", () => {
     icon: "setting",
     type: "filters",
     rows,
+    alias: [
+      {
+        index: 1,
+        text: "foo_alias",
+      },
+    ],
   };
   const renderOpts = {
     messages: {

package/src/components/__tests__/__fixtures__/NewRuleImplementationProps.js

@@ -37,6 +37,10 @@ export const newRuleImplementationProps = {
   ruleImplementationProps: {
     dataset: [
       {
+        alias: {
+          index: 1,
+          text: "FS",
+        },
         clauses: [],
         structure: {
           external_id: "/data/example.txt",
@@ -53,6 +57,10 @@ export const newRuleImplementationProps = {
         },
       },
       {
+        alias: {
+          index: 2,
+          text: "table2",
+        },
         clauses: [
           {
             left: {
@@ -67,6 +75,7 @@ export const newRuleImplementationProps = {
                 tablename: "table2",
                 type: "string",
               },
+              parent_index: 2,
               name: "capital",
               path: ["bucket", "table2"],
               system: {
@@ -82,6 +91,7 @@ export const newRuleImplementationProps = {
               metadata: {
                 metadata: { order: "8" },
               },
+              parent_index: 1,
               name: "external",
               path: ["Main", "example.txt"],
               system: {
@@ -112,6 +122,7 @@ export const newRuleImplementationProps = {
           },
           type: "Table",
         },
+        join_type: "inner"
       },
     ],
     deleted_at: null,

package/src/components/__tests__/__snapshots__/ConditionSummary.spec.js.snap

@@ -59,6 +59,7 @@ exports[`<ConditionSummary /> matches the latest snapshot 1`] = `
               <span
                 class="highlighted"
               >
+                (foo_alias).
                  
                 "Mes"
               </span>

package/src/components/__tests__/__snapshots__/NewRuleImplementation.spec.js.snap

@@ -494,7 +494,7 @@ exports[`<NewRuleImplementation /> calculate aliases when not informed 1`] = `
                 </a>
                 <span>
                   (
-                  example.txt (0)
+                  FS
                   )
                 </span>
               </td>
@@ -520,7 +520,7 @@ exports[`<NewRuleImplementation /> calculate aliases when not informed 1`] = `
                 </a>
                 <span>
                   (
-                  table2 (1)
+                  table2
                   )
                 </span>
                 <div
@@ -532,6 +532,25 @@ exports[`<NewRuleImplementation /> calculate aliases when not informed 1`] = `
                     class="item"
                     role="listitem"
                   >
+                    <div
+                      class="header"
+                    >
+                      Union type
+                    </div>
+                    <div
+                      class="join_type"
+                    >
+                      <div
+                        class="circle circle-left"
+                      >
+                        <div
+                          class="circle circle-center fill"
+                        />
+                      </div>
+                      <div
+                        class="circle circle-right"
+                      />
+                    </div>
                     <div
                       class="header"
                     >
@@ -542,10 +561,10 @@ exports[`<NewRuleImplementation /> calculate aliases when not informed 1`] = `
                     class="item"
                     role="listitem"
                   >
-                    (table2 (1)).capital
+                    (table2).capital
                      =
                      
-                    (example.txt (0)).external
+                    (FS).external
                   </div>
                 </div>
               </td>
@@ -610,7 +629,7 @@ exports[`<NewRuleImplementation /> calculate aliases when not informed 1`] = `
                   <span
                     class="highlighted"
                   >
-                    (table2 (1)).
+                    (table2).
                      
                     "descripcion"
                   </span>
@@ -700,7 +719,7 @@ exports[`<NewRuleImplementation /> calculate aliases when not informed 1`] = `
                   <span
                     class="highlighted"
                   >
-                    (example.txt (0)).
+                    (FS).
                      
                     "agent"
                   </span>
@@ -775,7 +794,7 @@ exports[`<NewRuleImplementation /> calculate aliases when not informed 1`] = `
                   <span
                     class="highlighted"
                   >
-                    (example.txt (0)).
+                    (FS).
                      
                     "agent"
                   </span>