@truedat/dq 4.53.9 → 4.53.11

package/src/components/__tests__/RuleImplementationResults.spec.js

@@ -1,28 +1,11 @@
 import _ from "lodash/fp";
 import React from "react";
 import { render } from "@truedat/test/render";
-import { intl } from "@truedat/test/intl-stub";
 import {
   RuleImplementationResults,
   getCustomColumnsWithData,
 } from "../RuleImplementationResults";
 
-const renderOpts = {
-  messages: {
-    en: {
-      "ruleResult.props.date": "date",
-      "ruleResult.props.quality": "quality",
-      "ruleResult.props.records": "records",
-      "ruleResult.props.errors": "errors",
-      "quality.error": "errors",
-    },
-  },
-};
-
-// workaround for enzyme issue with React.useContext
-// see https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526
-jest.spyOn(React, "useContext").mockImplementation(() => intl);
-
 describe("<RuleImplementationResults />", () => {
   const ruleImplementation = {
     id: 1,
@@ -36,21 +19,21 @@ describe("<RuleImplementationResults />", () => {
         results: [
           {
             errors: 2,
-            has_remediation: false,
-            has_segments: true,
+            hasRemediation: false,
+            hasSegments: true,
             id: "66577",
             records: 31,
             result: "93.54",
-            result_type: "percentage",
+            resultType: "percentage",
           },
           {
             errors: 2,
-            has_remediation: false,
-            has_segments: true,
+            hasRemediation: false,
+            hasSegments: true,
             id: "66578",
             records: 31,
             result: "93.54",
-            result_type: "percentage",
+            resultType: "percentage",
           },
         ],
       },
@@ -62,21 +45,21 @@ describe("<RuleImplementationResults />", () => {
         results: [
           {
             errors: 2,
-            has_remediation: false,
-            has_segments: true,
+            hasRemediation: false,
+            hasSegments: true,
             id: "66579",
             records: 31,
             result: "93.54",
-            result_type: "percentage",
+            resultType: "percentage",
           },
           {
             errors: 2,
-            has_remediation: false,
-            has_segments: true,
+            hasRemediation: false,
+            hasSegments: true,
             id: "66580",
             records: 31,
             result: "93.54",
-            result_type: "percentage",
+            resultType: "percentage",
           },
         ],
       },
@@ -89,10 +72,7 @@ describe("<RuleImplementationResults />", () => {
   };
 
   it("matches the latest snapshot", () => {
-    const { container } = render(
-      <RuleImplementationResults {...props} />,
-      renderOpts
-    );
+    const { container } = render(<RuleImplementationResults {...props} />);
     expect(container).toMatchSnapshot();
   });
 });
@@ -105,18 +85,9 @@ describe("getCustomColumnsWithData", () => {
       { result: 20, params: { p1: "2" } },
     ];
     const customColumns = [
-      {
-        name: "p1",
-        fieldSelector: _.path("params.p1"),
-      },
-      {
-        name: "p2",
-        fieldSelector: _.path("params.p2"),
-      },
-      {
-        name: "p3",
-        fieldSelector: _.path("params.p3"),
-      },
+      { name: "p1", fieldSelector: _.path("params.p1") },
+      { name: "p2", fieldSelector: _.path("params.p2") },
+      { name: "p3", fieldSelector: _.path("params.p3") },
     ];
 
     const filteredColumns = getCustomColumnsWithData(

package/src/components/__tests__/RuleImplementationTabs.spec.js

@@ -3,20 +3,6 @@ import { render } from "@truedat/test/render";
 import { RuleImplementationTabs } from "../RuleImplementationTabs";
 
 describe("<RuleImplementationTabs />", () => {
-  const renderOpts = {
-    messages: {
-      en: {
-        "tabs.dq.ruleImplementation": "ruleImplementation",
-        "tabs.dq.implementation.links.concepts": "concepts",
-        "tabs.dq.implementation.structures": "structures",
-        "tabs.dq.ruleImplementation.results": "results",
-        "tabs.dq.ruleImplementation.details": "details",
-        "tabs.dq.ruleImplementation.audit": "audit",
-        "tabs.dq.ruleImplementation.history": "history",
-      },
-    },
-  };
-
   const props = {
     rule: { id: 8 },
     ruleImplementation: { id: 1 },
@@ -24,10 +10,7 @@ describe("<RuleImplementationTabs />", () => {
     canCreateLink: true,
   };
   it("matches the latest snapshot", () => {
-    const { container } = render(
-      <RuleImplementationTabs {...props} />,
-      renderOpts
-    );
+    const { container } = render(<RuleImplementationTabs {...props} />);
     expect(container).toMatchSnapshot();
   });
 });

package/src/components/__tests__/RuleResultDecorator.spec.js

@@ -7,64 +7,44 @@ describe("<RuleResultDecorator />", () => {
     ruleResult: {
       result: 42,
       errors: 1234,
-      result_text: "result_text",
-    },
-  };
-  const renderOpts = {
-    messages: {
-      en: {
-        result_text: "result_message",
-        no_data: "no_data_message",
-        "quality.result.percentage.description": "{result}%",
-        "quality.result.errors_number.description": "{result} errors",
-        "quality.result.no.data": "No data",
-      },
+      result_text: "Something happened",
     },
   };
 
   it("decorates a percentage result", () => {
-    const ruleImplementation = { result_type: "percentage" };
+    const ruleImplementation = { resultType: "percentage" };
     const { container, queryByTitle } = render(
-      <RuleResultDecorator
-        ruleImplementation={ruleImplementation}
-        {...props}
-      />,
-      renderOpts
+      <RuleResultDecorator ruleImplementation={ruleImplementation} {...props} />
     );
     expect(container).toMatchSnapshot();
     expect(container).toHaveTextContent("42%");
-    expect(queryByTitle("result_message")).not.toBeNull();
+    expect(queryByTitle("Something happened")).toBeInTheDocument();
   });
 
   it("decorates an error count result", () => {
-    const ruleImplementation = { result_type: "errors_number" };
+    const ruleImplementation = { resultType: "errors_number" };
     const { container, queryByTitle } = render(
-      <RuleResultDecorator
-        ruleImplementation={ruleImplementation}
-        {...props}
-      />,
-      renderOpts
+      <RuleResultDecorator ruleImplementation={ruleImplementation} {...props} />
     );
     expect(container).toMatchSnapshot();
     expect(container).toHaveTextContent("1,234 errors");
-    expect(queryByTitle("result_message")).not.toBeNull();
+    expect(queryByTitle("Something happened")).toBeInTheDocument();
   });
 
   it("decorates an implementation without result data", () => {
-    const ruleImplementation = { result_type: "errors_number" };
+    const ruleImplementation = { resultType: "errors_number" };
     const ruleResult = { result_text: "no_data" };
     const props = { ruleImplementation, ruleResult };
     const { container, queryByTitle } = render(
-      <RuleResultDecorator {...props} />,
-      renderOpts
+      <RuleResultDecorator {...props} />
     );
     expect(container).toMatchSnapshot();
-    expect(container).toHaveTextContent("No data");
-    expect(queryByTitle("no_data_message")).not.toBeNull();
+    expect(container).toHaveTextContent("No information about quality");
+    expect(queryByTitle("no_data")).toBeInTheDocument();
   });
 
   it("handles missing execution result", () => {
-    const { container } = render(<RuleResultDecorator />, renderOpts);
+    const { container } = render(<RuleResultDecorator />);
     expect(container).toBeEmptyDOMElement();
   });
 });

package/src/components/__tests__/RuleResultDetails.spec.js

@@ -25,7 +25,7 @@ const commonProps = {
     implementation_key: "key",
     minimum: 10,
     goal: 20,
-    result_type: "percentage",
+    resultType: "percentage",
   },
   ruleResult: {
     id: 100,
@@ -35,8 +35,8 @@ const commonProps = {
     records: 31,
     date: "2022-06-24",
     errors: 2,
-    has_remediation: true,
-    has_segments: true,
+    hasRemediation: true,
+    hasSegments: true,
   },
 };
 

package/src/components/__tests__/RuleResultRemediations.spec.js

@@ -23,7 +23,7 @@ describe("<RuleResultRemediations />", () => {
         id: 852,
         minimum: 1,
         goal: 10,
-        result_type: "percentage",
+        resultType: "percentage",
       },
       ruleResult: {
         id: 65599,
@@ -33,8 +33,8 @@ describe("<RuleResultRemediations />", () => {
         records: 31,
         date: "2022-06-24",
         errors: 2,
-        has_remediation: true,
-        has_segments: true,
+        hasRemediation: true,
+        hasSegments: true,
       },
     };
 

package/src/components/__tests__/RuleResultRoutes.spec.js

@@ -5,7 +5,7 @@ import {
   IMPLEMENTATION_RESULT_SEGMENTS_RESULTS,
   IMPLEMENTATION_RESULT_REMEDIATION_PLAN,
 } from "@truedat/core/routes";
-import { IMPLEMENTATION_RESULT } from "../../api/queries";
+import { IMPLEMENTATION_RESULT_QUERY } from "../../api/queries";
 import { RuleResultsRoutes } from "../RuleResultsRoutes";
 
 jest.mock("react-router-dom", () => ({
@@ -18,19 +18,19 @@ describe("<RuleResultsRoutes>", () => {
     implementationResult: {
       date: "2022-06-24",
       errors: 2,
-      has_remediation: true,
-      has_segments: true,
+      hasRemediation: true,
+      hasSegments: true,
       id: 1,
       records: 31,
       details: {},
       result: "93.54",
       params: {},
-      result_type: "percentage",
+      resultType: "percentage",
     },
   };
 
   const mock = {
-    request: { query: IMPLEMENTATION_RESULT, variables: { id: 1 } },
+    request: { query: IMPLEMENTATION_RESULT_QUERY, variables: { id: 1 } },
     result: { data: implementationResult },
   };
   const key = "mi implementación molona";

package/src/components/__tests__/RuleResultRow.spec.js

@@ -1,16 +1,18 @@
 import _ from "lodash/fp";
 import React from "react";
-import { shallow } from "enzyme";
-import { intl } from "@truedat/test/intl-stub";
+import { useAuthorized } from "@truedat/core/hooks";
+import { render } from "@truedat/test/render";
 import { RuleResultRow } from "../RuleResultRow";
 
-// workaround for enzyme issue with React.useContext
-// see https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526
-jest.spyOn(React, "useContext").mockImplementation(() => intl);
+jest.mock("@truedat/core/hooks");
+
+beforeEach(() => {
+  useAuthorized.mockImplementation(() => true);
+});
 
 describe("<RuleResultRow />", () => {
   it("renders customColumns values when passed", () => {
-    const ruleResultRowProps = {
+    const props = {
       rule: { id: 10 },
       ruleResult: {
         id: 54,
@@ -18,47 +20,33 @@ describe("<RuleResultRow />", () => {
         params: { p1: "1", p2: "2", p3: "no" },
       },
       customColumns: [
-        {
-          name: "m_parm1",
-          fieldSelector: _.path("params.p1"),
-        },
-        {
-          name: "m_parm2",
-          fieldSelector: _.path("params.p2"),
-        },
+        { name: "m_parm1", fieldSelector: _.path("params.p1") },
+        { name: "m_parm2", fieldSelector: _.path("params.p2") },
       ],
       date: "2019-08-12T02:00:00Z",
       ruleImplementation: {
         id: 23,
         minimum: 1,
         goal: 10,
-        result_type: "percentage",
+        resultType: "percentage",
       },
     };
 
-    const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-
-    const customColumn = wrapper
-      .find("TableRow")
-      .find("TableCell")
-      .at(2)
-      .props().children;
-
-    expect(customColumn).toBe("1");
-
-    const customColumn2 = wrapper
-      .find("TableRow")
-      .find("TableCell")
-      .at(3)
-      .props().children;
-
-    expect(customColumn2).toBe("2");
-
-    expect(wrapper.find("TableRow").find("TableCell")).toHaveLength(4);
+    const { queryByText, getAllByRole } = render(
+      <table>
+        <tbody>
+          <RuleResultRow {...props} />
+        </tbody>
+      </table>
+    );
+    expect(queryByText("1")).toBeInTheDocument();
+    expect(queryByText("2")).toBeInTheDocument();
+    expect(getAllByRole("row")).toHaveLength(1);
+    expect(getAllByRole("cell")).toHaveLength(5);
   });
 
   it("green icon when result is over goal", () => {
-    const ruleResultRowProps = {
+    const props = {
       rule: { id: 10 },
       ruleResult: { id: 54, result: 80 },
       date: "2019-08-12T02:00:00Z",
@@ -66,22 +54,24 @@ describe("<RuleResultRow />", () => {
         id: 23,
         minimum: 1,
         goal: 10,
-        result_type: "percentage",
+        resultType: "percentage",
       },
     };
 
-    const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const cell = wrapper.find("TableRow").find("TableCell").at(1).dive();
-
-    expect(cell.find("td").find("Icon")).toHaveLength(1);
-
-    const icon = cell.find("td").find("Icon").at(0);
-
-    expect(icon.props().color).toBe("green");
+    const { container } = render(
+      <table>
+        <tbody>
+          <RuleResultRow {...props} />
+        </tbody>
+      </table>
+    );
+    expect(
+      container.querySelector("td > i.green.circle.icon")
+    ).toBeInTheDocument();
   });
 
   it("red icon when result is under minimum", () => {
-    const ruleResultRowProps = {
+    const props = {
       rule: { id: 10 },
       ruleResult: { id: 54, result: 80 },
       date: "2019-08-12T02:00:00Z",
@@ -89,82 +79,96 @@ describe("<RuleResultRow />", () => {
         id: 23,
         minimum: 81,
         goal: 90,
-        result_type: "percentage",
+        resultType: "percentage",
       },
     };
 
-    const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const cell = wrapper.find("TableRow").find("TableCell").at(1).dive();
-
-    expect(cell.find("td").find("Icon")).toHaveLength(1);
-
-    const icon = cell.find("td").find("Icon").at(0);
-
-    expect(icon.props().color).toBe("red");
+    const { container } = render(
+      <table>
+        <tbody>
+          <RuleResultRow {...props} />
+        </tbody>
+      </table>
+    );
+    expect(
+      container.querySelector("td > i.red.circle.icon")
+    ).toBeInTheDocument();
   });
 
   it("yellow icon when result is between minimum and goal", () => {
-    const ruleResultRowProps = {
+    const props = {
       rule: { id: 10 },
       ruleImplementation: {
         id: 23,
         minimum: 81,
         goal: 90,
-        result_type: "percentage",
+        resultType: "percentage",
       },
       ruleResult: { id: 54, result: 82 },
       date: "2019-08-12T02:00:00Z",
     };
 
-    const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const cell = wrapper.find("TableRow").find("TableCell").at(1).dive();
-
-    expect(cell.find("td").find("Icon")).toHaveLength(1);
-
-    const icon = cell.find("td").find("Icon").at(0);
-
-    expect(icon.props().color).toBe("yellow");
+    const { container } = render(
+      <table>
+        <tbody>
+          <RuleResultRow {...props} />
+        </tbody>
+      </table>
+    );
+    expect(
+      container.querySelector("td > i.yellow.circle.icon")
+    ).toBeInTheDocument();
   });
 
-  it("renders delete cell in RuleResultRow when user isAdmin is true", () => {
-    const ruleResultRowProps = {
+  it("renders delete cell in RuleResultRow when user is admin", () => {
+    const props = {
       rule: { id: 10 },
       ruleImplementation: {
         id: 23,
         minimum: 81,
         goal: 90,
-        result_type: "percentage",
+        resultType: "percentage",
       },
       ruleResult: { id: 54, result: 82 },
       date: "2019-08-12T02:00:00Z",
-      isAdmin: true,
       deleteRuleResult: jest.fn(),
     };
-    const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const modal = wrapper
-      .find("TableRow")
-      .find("TableCell")
-      .at(2)
-      .find("ConfirmModal");
-    expect(modal).toHaveLength(1);
+    const { container } = render(
+      <table>
+        <tbody>
+          <RuleResultRow {...props} />
+        </tbody>
+      </table>
+    );
+    expect(
+      container.querySelector("td > i.red.trash.alternate.outline.icon")
+    ).toBeInTheDocument();
   });
 
-  it("does not render delete cell in RuleResultRow when user isAdmin is false", () => {
-    const ruleResultRowProps = {
+  it("does not render delete cell in RuleResultRow when user is not admin", () => {
+    useAuthorized.mockImplementation(() => false);
+
+    const props = {
       rule: { id: 10 },
       ruleImplementation: {
         id: 23,
         minimum: 81,
         goal: 90,
-        result_type: "percentage",
+        resultType: "percentage",
       },
       ruleResult: { id: 54, result: 82 },
       date: "2019-08-12T02:00:00Z",
-      isAdmin: false,
       deleteRuleResult: jest.fn(),
     };
-    const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const modal = wrapper.find("ConfirmModal");
-    expect(modal).toHaveLength(0);
+    const { container } = render(
+      <table>
+        <tbody>
+          <RuleResultRow {...props} />
+        </tbody>
+      </table>
+    );
+    expect(
+      container.querySelector("td > i.red.trash.alternate.outline.icon")
+    ).not.toBeInTheDocument();
   });
 });

package/src/components/__tests__/RuleResultSegmentRow.spec.js

@@ -32,7 +32,7 @@ describe("<RuleResultSegmentRow />", () => {
         id: 23,
         minimum: 1,
         goal: 10,
-        result_type: "percentage",
+        resultType: "percentage",
       },
     };
 
@@ -69,7 +69,7 @@ describe("<RuleResultSegmentRow />", () => {
         id: 23,
         minimum: 1,
         goal: 10,
-        result_type: "percentage",
+        resultType: "percentage",
       },
     };
 
@@ -94,7 +94,7 @@ describe("<RuleResultSegmentRow />", () => {
         id: 23,
         minimum: 81,
         goal: 90,
-        result_type: "percentage",
+        resultType: "percentage",
       },
     };
 
@@ -117,7 +117,7 @@ describe("<RuleResultSegmentRow />", () => {
         id: 23,
         minimum: 81,
         goal: 90,
-        result_type: "percentage",
+        resultType: "percentage",
       },
       segmentResult: { id: 54, result: 82, params: { segment_name: "foo" } },
       date: "2019-08-12T02:00:00Z",
@@ -142,7 +142,7 @@ describe("<RuleResultSegmentRow />", () => {
         id: 23,
         minimum: 81,
         goal: 90,
-        result_type: "percentage",
+        resultType: "percentage",
       },
       segmentResult: { id: 54, result: 82, params: { segment_name: "foo" } },
       date: "2019-08-12T02:00:00Z",
@@ -167,7 +167,7 @@ describe("<RuleResultSegmentRow />", () => {
         id: 23,
         minimum: 81,
         goal: 90,
-        result_type: "percentage",
+        resultType: "percentage",
       },
       segmentResult: { id: 54, result: 82, params: { segment_name: "foo" } },
       date: "2019-08-12T02:00:00Z",

package/src/components/__tests__/RuleResultSegments.spec.js

@@ -13,7 +13,7 @@ jest.spyOn(React, "useContext").mockImplementation(() => intl);
 
 describe("<RuleResultSegments />", () => {
   const rule = {
-    result_type: "percentage",
+    resultType: "percentage",
     minimum: 50,
     goal: 100,
   };