@truedat/dq 4.53.8 → 4.53.10

package/src/components/__tests__/__fixtures__/executionMocks.js

@@ -0,0 +1,80 @@
+import {
+  IMPLEMENTATION_EXECUTIONS_QUERY,
+  IMPLEMENTATION_EXECUTION_FILTERS_QUERY,
+} from "../../../api/queries";
+
+const executionFilters = [
+  {
+    field: "status",
+    values: ["FAILED", "PENDING", "SUCCEEDED"],
+  },
+];
+
+export const implementationExecutionFiltersMock = (variables) => ({
+  request: {
+    query: IMPLEMENTATION_EXECUTION_FILTERS_QUERY,
+    variables,
+  },
+  result: {
+    data: {
+      implementation: {
+        id: "123",
+        executionFilters,
+      },
+    },
+  },
+});
+
+export const implementationExecutionsMock = (variables) => ({
+  request: {
+    query: IMPLEMENTATION_EXECUTIONS_QUERY,
+    variables,
+  },
+  result: {
+    data: {
+      implementation: {
+        id: "123",
+        executionFilters,
+        executionsConnection: {
+          totalCount: 100,
+          page: [
+            {
+              id: "444",
+              insertedAt: "2020-01-01T12:34:56.000Z",
+              implementation: {
+                id: "123",
+                version: 2,
+              },
+              latestEvent: {
+                id: "10001",
+                insertedAt: "2020-01-01T12:34:56.000Z",
+                type: "STARTED",
+                message: null,
+              },
+            },
+            {
+              id: "445",
+              insertedAt: "2020-01-01T12:34:56.000Z",
+              implementation: {
+                id: "123",
+                version: 2,
+              },
+              latestEvent: {
+                id: "10002",
+                insertedAt: "2020-01-01T12:34:56.000Z",
+                type: "SUCCEEDED",
+                message: "Execution succeeded",
+              },
+            },
+          ],
+          pageInfo: {
+            endCursor: null,
+            startCursor: "FOO",
+            hasNextPage: false,
+            hasPreviousPage: true,
+          },
+        },
+      },
+    },
+  },
+});

package/src/components/__tests__/__snapshots__/ExecutionGroups.spec.js.snap

@@ -17,7 +17,6 @@ exports[`<ExecutionGroups /> matches the latest snapshot with a row per executio
       <div
         aria-label="Latest"
         class="disabled item"
-        to="[object Object]"
       >
         «
       </div>

package/src/components/__tests__/__snapshots__/ImplementationExecutionFilters.spec.js.snap

@@ -0,0 +1,37 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<ImplementationExecutionFilters /> matches snapshot with filter links 1`] = `
+<div>
+  <div
+    class="ui compact pointing secondary menu"
+  >
+    <a
+      class="active link item"
+      href="/"
+    >
+      All
+    </a>
+    <a
+      class="link item"
+      href="/?status=FAILED"
+      value="FAILED"
+    >
+      Failed
+    </a>
+    <a
+      class="link item"
+      href="/?status=PENDING"
+      value="PENDING"
+    >
+      Pending
+    </a>
+    <a
+      class="link item"
+      href="/?status=SUCCEEDED"
+      value="SUCCEEDED"
+    >
+      Succeeded
+    </a>
+  </div>
+</div>
+`;

package/src/components/__tests__/__snapshots__/ImplementationExecutions.spec.js.snap

@@ -0,0 +1,194 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<ImplementationExecutions /> matches snapshot with executions table 1`] = `
+<div>
+  <div
+    class="ui bottom attached segment"
+  >
+    <div
+      class="ui grid"
+    >
+      <div
+        class="two column row"
+      >
+        <div
+          class="column"
+        >
+          <div
+            class="ui compact pointing secondary menu"
+          >
+            <a
+              class="active link item"
+              href="/"
+            >
+              All
+            </a>
+            <a
+              class="link item"
+              href="/?status=FAILED"
+              value="FAILED"
+            >
+              Failed
+            </a>
+            <a
+              class="link item"
+              href="/?status=PENDING"
+              value="PENDING"
+            >
+              Pending
+            </a>
+            <a
+              class="link item"
+              href="/?status=SUCCEEDED"
+              value="SUCCEEDED"
+            >
+              Succeeded
+            </a>
+          </div>
+        </div>
+        <div
+          class="right aligned column"
+        >
+          <div
+            class="ui pagination menu"
+            role="navigation"
+          >
+            <div
+              aria-label="Latest"
+              class="disabled item"
+            >
+              «
+            </div>
+            <div
+              aria-label="Later"
+              class="disabled item"
+            >
+              ⟨
+            </div>
+            <a
+              aria-label="Earlier"
+              class="link item"
+              href="/?before=FOO"
+            >
+              ⟩
+            </a>
+          </div>
+        </div>
+      </div>
+    </div>
+    <table
+      class="ui very basic table"
+    >
+      <thead
+        class=""
+      >
+        <tr
+          class=""
+        >
+          <th
+            class="right aligned one wide"
+          >
+            Version
+          </th>
+          <th
+            class="two wide"
+          >
+            Execution
+          </th>
+          <th
+            class="two wide"
+          >
+            Latest event
+          </th>
+          <th
+            class="two wide"
+          >
+            Event type
+          </th>
+          <th
+            class=""
+          >
+            Message
+          </th>
+        </tr>
+      </thead>
+      <tbody
+        class=""
+      >
+        <tr
+          class="warning"
+        >
+          <td
+            class="right aligned one wide"
+          >
+            2
+          </td>
+          <td
+            class="two wide"
+          >
+            <time
+              datetime="1577882096000"
+            >
+              2020-01-01 12:34
+            </time>
+          </td>
+          <td
+            class="two wide"
+          >
+            <time
+              datetime="1577882096000"
+            >
+              2020-01-01 12:34
+            </time>
+          </td>
+          <td
+            class="two wide"
+          >
+            Started
+          </td>
+          <td
+            class=""
+          />
+        </tr>
+        <tr
+          class="positive"
+        >
+          <td
+            class="right aligned one wide"
+          >
+            2
+          </td>
+          <td
+            class="two wide"
+          >
+            <time
+              datetime="1577882096000"
+            >
+              2020-01-01 12:34
+            </time>
+          </td>
+          <td
+            class="two wide"
+          >
+            <time
+              datetime="1577882096000"
+            >
+              2020-01-01 12:34
+            </time>
+          </td>
+          <td
+            class="two wide"
+          >
+            Succeeded
+          </td>
+          <td
+            class=""
+          >
+            Execution succeeded
+          </td>
+        </tr>
+      </tbody>
+    </table>
+  </div>
+</div>
+`;

package/src/components/__tests__/__snapshots__/RuleImplementation.spec.js.snap

@@ -148,6 +148,12 @@ exports[`<RuleImplementation /> matches the latest snapshot 1`] = `
     >
       Results
     </a>
+    <a
+      class="item"
+      href="/implementations/1/executions"
+    >
+      Executions
+    </a>
     <a
       class="item"
       href="/implementations/1/history"

package/src/components/__tests__/__snapshots__/RuleImplementationHistory.spec.js.snap

@@ -54,7 +54,9 @@ exports[`<RuleImplementationHistory matches the latest snapshot 1`] = `
                 <td
                   class=""
                 >
-                  some implementation key 34
+                  <a
+                    href="/implementations/34/history"
+                  />
                 </td>
                 <td
                   class=""
@@ -68,13 +70,7 @@ exports[`<RuleImplementationHistory matches the latest snapshot 1`] = `
                 </td>
                 <td
                   class=""
-                >
-                  <time
-                    datetime="1644506527000"
-                  >
-                    2022-02-10 15:22
-                  </time>
-                </td>
+                />
               </tr>
               <tr
                 class="active"
@@ -82,7 +78,9 @@ exports[`<RuleImplementationHistory matches the latest snapshot 1`] = `
                 <td
                   class=""
                 >
-                  some implementation key 23
+                  <a
+                    href="/implementations/23/history"
+                  />
                 </td>
                 <td
                   class=""
@@ -96,13 +94,7 @@ exports[`<RuleImplementationHistory matches the latest snapshot 1`] = `
                 </td>
                 <td
                   class=""
-                >
-                  <time
-                    datetime="1644506527000"
-                  >
-                    2022-02-10 15:22
-                  </time>
-                </td>
+                />
               </tr>
               <tr
                 class=""
@@ -110,7 +102,9 @@ exports[`<RuleImplementationHistory matches the latest snapshot 1`] = `
                 <td
                   class=""
                 >
-                  some implementation key 22
+                  <a
+                    href="/implementations/22/history"
+                  />
                 </td>
                 <td
                   class=""
@@ -124,13 +118,7 @@ exports[`<RuleImplementationHistory matches the latest snapshot 1`] = `
                 </td>
                 <td
                   class=""
-                >
-                  <time
-                    datetime="1644506527000"
-                  >
-                    2022-02-10 15:22
-                  </time>
-                </td>
+                />
               </tr>
             </tbody>
           </table>

package/src/components/__tests__/__snapshots__/RuleImplementationResults.spec.js.snap

@@ -14,22 +14,22 @@ exports[`<RuleImplementationResults /> matches the latest snapshot 1`] = `
         <th
           class=""
         >
-          ruleResult.props.date
+          Date
         </th>
         <th
           class=""
         >
-          ruleResult.props.quality
+          Quality
         </th>
         <th
           class=""
         >
-          ruleResult.props.records
+          Records
         </th>
         <th
           class=""
         >
-          ruleResult.props.errors
+          Errors
         </th>
         <th
           class=""
@@ -44,12 +44,12 @@ exports[`<RuleImplementationResults /> matches the latest snapshot 1`] = `
       >
         <td
           class=""
-          colspan="8"
         >
           <a
             class="ui active ribbon label"
+            href="/implementations/1"
           >
-            ruleImplementations.props.version: undefined
+            Version: undefined
           </a>
         </td>
       </tr>
@@ -128,12 +128,12 @@ exports[`<RuleImplementationResults /> matches the latest snapshot 1`] = `
       >
         <td
           class=""
-          colspan="8"
         >
           <a
             class="ui ribbon label"
+            href="/implementations/2"
           >
-            ruleImplementations.props.version: undefined
+            Version: undefined
           </a>
         </td>
       </tr>

package/src/components/__tests__/__snapshots__/RuleImplementationTabs.spec.js.snap

@@ -9,37 +9,43 @@ exports[`<RuleImplementationTabs /> matches the latest snapshot 1`] = `
       class="item"
       href="/implementations/1"
     >
-      ruleImplementation
+      Implementation
     </a>
     <a
       class="item"
       href="/implementations/1/links/concepts"
     >
-      concepts
+      Link to concepts
     </a>
     <a
       class="item"
       href="/implementations/1/structures"
     >
-      structures
+      Structures
     </a>
     <a
       class="item"
       href="/implementations/1/results"
     >
-      results
+      Results
+    </a>
+    <a
+      class="item"
+      href="/implementations/1/executions"
+    >
+      Executions
     </a>
     <a
       class="item"
       href="/implementations/1/history"
     >
-      history
+      History
     </a>
     <a
       class="item"
       href="/implementations/1/events"
     >
-      audit
+      Audit
     </a>
   </div>
 </div>

package/src/components/__tests__/__snapshots__/RuleResultDecorator.spec.js.snap

@@ -5,7 +5,7 @@ exports[`<RuleResultDecorator /> decorates a percentage result 1`] = `
   <i
     aria-hidden="true"
     class="green circle icon"
-    title="result_message"
+    title="Something happened"
   />
   42%
 </div>
@@ -16,7 +16,7 @@ exports[`<RuleResultDecorator /> decorates an error count result 1`] = `
   <i
     aria-hidden="true"
     class="green circle icon"
-    title="result_message"
+    title="Something happened"
   />
   1,234 errors
 </div>
@@ -27,8 +27,8 @@ exports[`<RuleResultDecorator /> decorates an implementation without result data
   <i
     aria-hidden="true"
     class="grey circle icon"
-    title="no_data_message"
+    title="no_data"
   />
-  No data
+  No information about quality
 </div>
 `;

package/src/functions/selectors.js

@@ -1,8 +1,16 @@
 import _ from "lodash/fp";
 
-export const selectColor = ({ errors, result, minimum, goal, result_type }) => {
+export const selectColor = ({
+  errors,
+  result,
+  minimum,
+  goal,
+  result_type,
+  resultType,
+}) => {
+  const type = _.defaultTo(result_type)(resultType);
   if (_.isNil(errors) && _.isNil(result)) return "grey";
-  else if (result_type == "percentage") {
+  else if (type == "percentage") {
     if (result < minimum) {
       return "red";
     } else if (result < goal) {
@@ -10,7 +18,7 @@ export const selectColor = ({ errors, result, minimum, goal, result_type }) => {
     } else {
       return "green";
     }
-  } else if (result_type == "errors_number") {
+  } else if (type == "errors_number") {
     if (errors > minimum) {
       return "red";
     } else if (errors > goal) {
@@ -18,7 +26,7 @@ export const selectColor = ({ errors, result, minimum, goal, result_type }) => {
     } else {
       return "green";
     }
-  } else if (result_type == "deviation") {
+  } else if (type == "deviation") {
     if (result > minimum) {
       return "red";
     } else if (result > goal) {

package/src/messages/en.js

@@ -28,6 +28,11 @@ export default {
   "dataset.form.button.add_structure": "Add Structure",
   "datasetForm.implementation_key.tooltip":
     "Leave empty for autogeneration of implementation key after saving implementation",
+  "execution": "Execution",
+  "execution.insertedAt": "Created",
+  "execution.latestEvent.insertedAt": "Latest event",
+  "execution.latestEvent.message": "Message",
+  "execution.latestEvent.type": "Event type",
   "executionGroup.failedCount": "Failed",
   "executionGroup.insertedAt": "Created",
   "executionGroup.pendingCount": "Pending",
@@ -623,6 +628,7 @@ export default {
   "tabs.dq.ruleImplementation": "Implementation",
   "tabs.dq.ruleImplementation.audit": "Audit",
   "tabs.dq.ruleImplementation.details": "Details",
+  "tabs.dq.ruleImplementation.executions": "Executions",
   "tabs.dq.ruleImplementation.history": "History",
   "tabs.dq.ruleImplementation.results": "Results",
   "tabs.dq.ruleImplementationResult.info": "Information",

package/src/messages/es.js

@@ -28,6 +28,11 @@ export default {
   "dataset.form.button.add_structure": "Añadir Estructura",
   "datasetForm.implementation_key.tooltip":
     "En caso de no introducir clave de implementación, se autogenerará al guardar la implementación",
+  "execution": "Ejecución",
+  "execution.insertedAt": "Creado",
+  "execution.latestEvent.insertedAt": "Evento más reciente",
+  "execution.latestEvent.message": "Detalle",
+  "execution.latestEvent.type": "Tipo de evento",
   "executionGroup.failedCount": "Error",
   "executionGroup.insertedAt": "Creado",
   "executionGroup.pendingCount": "Pendiente",
@@ -645,6 +650,7 @@ export default {
   "tabs.dq.ruleImplementation": "Implementación",
   "tabs.dq.ruleImplementation.audit": "Auditoría",
   "tabs.dq.ruleImplementation.details": "Detalles",
+  "tabs.dq.ruleImplementation.executions": "Ejecuciones",
   "tabs.dq.ruleImplementation.history": "Historial",
   "tabs.dq.ruleImplementation.results": "Resultados",
   "tabs.dq.ruleImplementationResult.info": "Información",

package/src/selectors/getRuleImplementationColumns.js

@@ -11,8 +11,10 @@ import RuleLink from "../components/RuleLink";
 const translateDecorator = (id) =>
   id ? <FormattedMessage id={id} defaultMessage={id} /> : null;
 
-const resultTypeDecorator = (result, result_type) =>
-  result_type === "errors_number" ? formatNumber(result) : `${result}%`;
+const resultTypeDecorator = (result, result_type, resultType) =>
+  _.defaultTo(result_type)(resultType) === "errors_number"
+    ? formatNumber(result)
+    : `${result}%`;
 
 export const defaultImplementationColumns = [
   {

package/src/selectors/index.js

@@ -4,7 +4,7 @@ export { getRuleAvailableFilters } from "./getRuleAvailableFilters";
 export { getRuleSelectedFilters } from "./getRuleSelectedFilters";
 export { getRuleSelectedFilterActiveValues } from "./getRuleSelectedFilterActiveValues";
 export { getRuleSelectedFilterValues } from "./getRuleSelectedFilterValues";
-export { getRuleResultsColumns } from "./getRuleResultsColumns";
+export { ruleResultsColumnsSelector } from "./ruleResultsColumnsSelector";
 export {
   getSystemInRuleDetail,
   getGroupsInRuleDetail,

package/src/selectors/{getRuleResultsColumns.js → ruleResultsColumnsSelector.js}

@@ -3,7 +3,7 @@ import { createSelector } from "reselect";
 
 export const defaultRuleResultsColumns = [];
 
-export const getRuleResultsColumns = createSelector(
+export const ruleResultsColumnsSelector = createSelector(
   _.prop("ruleResultsColumns"),
   _.defaultTo(defaultRuleResultsColumns)
 );