@truedat/dq 4.53.7 → 4.53.8

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.53.8] 2022-10-17
+
+### Added
+
+- [TD-5027] support for restoring deprecated `Implementations`
+
 ## [4.53.7] 2022-10-14
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.53.7",
+  "version": "4.53.8",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.16.4",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.53.7",
+    "@truedat/test": "4.53.8",
     "babel-jest": "^28.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -93,8 +93,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.53.7",
-    "@truedat/df": "4.53.7",
+    "@truedat/core": "4.53.8",
+    "@truedat/df": "4.53.8",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
     "prop-types": "^15.8.1",
@@ -114,5 +114,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "beccd8ba2a5af9a3e0e1690b97d7c756b59e9c2b"
+  "gitHead": "56190c74eddc249134cb973cc21470c36a4701d0"
 }

package/src/api/mutations.js

@@ -23,3 +23,11 @@ export const PUBLISH_IMPLEMENTATION = gql`
     }
   }
 `;
+
+export const RESTORE_IMPLEMENTATION = gql`
+  mutation restoreImplementation($id: ID!) {
+    restoreImplementation(id: $id) {
+      id
+    }
+  }
+`;

package/src/components/ImplementationActions.js

@@ -12,6 +12,7 @@ import {
   submitImplementation,
   publishImplementation,
   rejectImplementation,
+  restoreImplementation,
   deleteImplementation,
 } from "../routines";
 import ExecutionPopup from "./ExecutionPopup";
@@ -59,6 +60,7 @@ export const ImplementationActions = ({
   deleteImplementation,
   publishImplementation,
   rejectImplementation,
+  restoreImplementation,
   ruleImplementation,
   submitImplementation,
 }) => {
@@ -96,6 +98,18 @@ export const ImplementationActions = ({
           }
         />
       ) : null}
+      {actions?.restore ? (
+        <Button
+          primary
+          content={formatMessage({ id: "actions.restore" })}
+          onClick={() =>
+            restoreImplementation({
+              id,
+              redirectUrl: linkTo.IMPLEMENTATION({ implementation_id: id }),
+            })
+          }
+        />
+      ) : null}
       {actions?.reject ? (
         <Button
           secondary
@@ -132,6 +146,7 @@ ImplementationActions.propTypes = {
   deleteImplementation: PropTypes.func,
   publishImplementation: PropTypes.func,
   rejectImplementation: PropTypes.func,
+  restoreImplementation: PropTypes.func,
   ruleImplementation: PropTypes.object,
   submitImplementation: PropTypes.func,
 };
@@ -149,5 +164,6 @@ export default connect(mapStateToProps, {
   deleteImplementation,
   publishImplementation,
   rejectImplementation,
+  restoreImplementation,
   submitImplementation,
 })(ImplementationActions);

package/src/components/ImplementationSearchResults.js

@@ -5,7 +5,10 @@ import { connect } from "react-redux";
 import { Dimmer, Header, Icon, Loader, Segment } from "semantic-ui-react";
 import { FormattedMessage } from "react-intl";
 import { useActiveRoute } from "@truedat/core/hooks";
-import { IMPLEMENTATIONS_PENDING } from "@truedat/core/routes";
+import {
+  IMPLEMENTATIONS_PENDING,
+  IMPLEMENTATIONS_DEPRECATED,
+} from "@truedat/core/routes";
 import { getExecutionQuery } from "../selectors";
 import RuleImplementationsActions from "./RuleImplementationsActions";
 import RuleImplementationsLabelResults from "./RuleImplementationsLabelResults";
@@ -24,11 +27,16 @@ const usePrevious = (value) => {
 
 export const ImplementationSearchResultsHeader = () => {
   const pending = useActiveRoute(IMPLEMENTATIONS_PENDING);
+  const deprecated = useActiveRoute(IMPLEMENTATIONS_DEPRECATED);
   const header = pending
     ? "implementations.header.manage"
+    : deprecated
+    ? "implementations.header.deprecated"
     : "implementations.header";
   const subheader = pending
     ? "implementations.subheader.manage"
+    : deprecated
+    ? "implementations.subheader.deprecated"
     : "implementations.subheader";
   return (
     <Header as="h2">

package/src/components/ImplementationSummary.js

@@ -117,16 +117,22 @@ const DatasetSummary = ({ rows, alias }) =>
                 {_.has("structure")(row) && (
                   <Table.Cell>
                     {_.path("structure.type")(row) !== "reference_dataset" ? (
-                      <Link
-                        to={linkTo.STRUCTURE({
-                          id: _.pathOr("", "structure.id")(row),
-                        })}
-                      >
-                        <p className="highlighted">
-                          <Icon name="table" size="small" />
-                          {`"${path(_.propOr({}, "structure")(row))}"`}
-                        </p>
-                      </Link>
+                      _.path("structure.id")(row) ? (
+                        <Link
+                          to={linkTo.STRUCTURE({
+                            id: _.path("structure.id")(row),
+                          })}
+                        >
+                          <p className="highlighted">
+                            <Icon name="table" size="small" />
+                            {`"${path(_.propOr({}, "structure")(row))}"`}
+                          </p>
+                        </Link>
+                      ) : (
+                        <FormattedMessage
+                          id={`ruleImplementation.summary.invalid_structure`}
+                        />
+                      )
                     ) : (
                       <span>
                         <Icon name="list ol" size="small" />{" "}

package/src/components/ImplementationsRoutes.js

@@ -23,6 +23,7 @@ import {
   IMPLEMENTATION_STRUCTURES,
   IMPLEMENTATION,
   IMPLEMENTATIONS,
+  IMPLEMENTATIONS_DEPRECATED,
   IMPLEMENTATIONS_PENDING,
 } from "@truedat/core/routes";
 import {
@@ -340,6 +341,17 @@ export const ImplementationsRoutes = ({
           />
         )}
       />
+      <Route
+        exact
+        path={IMPLEMENTATIONS_DEPRECATED}
+        render={() => (
+          <Implementations
+            defaultFilters={{
+              status: ["deprecated"],
+            }}
+          />
+        )}
+      />
     </Switch>
   );
 };

package/src/components/QualityRoutes.js

@@ -6,6 +6,7 @@ import {
   EXECUTION_GROUP,
   EXECUTION_GROUPS,
   IMPLEMENTATIONS,
+  IMPLEMENTATIONS_DEPRECATED,
   IMPLEMENTATIONS_PENDING,
   RULES,
 } from "@truedat/core/routes";
@@ -55,6 +56,12 @@ const QualityRoutes = () => {
           authorized ? <ImplementationsRoutes /> : <Unauthorized />
         }
       />
+      <Route
+        path={IMPLEMENTATIONS_DEPRECATED}
+        render={() =>
+          authorized ? <ImplementationsRoutes /> : <Unauthorized />
+        }
+      />
     </>
   );
 };

package/src/components/RuleImplementation.js

@@ -27,15 +27,7 @@ export const RuleImplementation = ({ children, ruleImplementation }) => {
         </Grid.Column>
         <Grid.Column width={8} textAlign="right">
           <>
-            {deletedAt ? (
-              <Label
-                className="alert warning"
-                content={formatMessage({
-                  id: "ruleImplementation.props.status.deprecated",
-                })}
-                icon={{ name: "warning circle", color: "red" }}
-              />
-            ) : (
+            {deletedAt ? null : (
               <Subscription
                 resource={ruleImplementation}
                 resourceType="implementation"

package/src/messages/en.js

@@ -78,9 +78,11 @@ export default {
   "implementations.execute.filtered": "{count} implementations to execute",
   "implementations.header": "Quality Implementations",
   "implementations.header.manage": "Implementation Management",
+  "implementations.header.deprecated": "Deprecated Implementations",
   "implementations.search.placeholder": "Search implementations...",
   "implementations.subheader": "Quality implementations list and details",
   "implementations.subheader.manage": "Implementation Versions in Progress",
+  "implementations.subheader.deprecated": "List of deprecated quality implementations",
   "implementationsStructures.delete.confirmation.content":
     "The relation will be deleted. Are you sure?",
   "implementationsStructures.delete.confirmation.header":
@@ -438,7 +440,6 @@ export default {
   "ruleImplementation.props.reference_dataset": "Reference dataset",
   "ruleImplementation.props.reference_dataset.placeholder":
     "Search reference dataset",
-  "ruleImplementation.props.status.deprecated": "Deprecated Implementation",
   "ruleImplementation.props.structure": "Structure",
   "ruleImplementation.props.structure.alias": "Alias",
   "ruleImplementation.props.structure.placeholder": "Search structure",
@@ -460,6 +461,7 @@ export default {
   "ruleImplementation.summary.population": "Population",
   "ruleImplementation.summary.source": "Data source",
   "ruleImplementation.summary.structure": "Structure",
+  "ruleImplementation.summary.invalid_structure": "Invalid structure",
   "ruleImplementation.summary.system": "System",
   "ruleImplementation.summary.validations": "Validations",
   "ruleImplementation.summary.values": "Values",

package/src/messages/es.js

@@ -79,9 +79,12 @@ export default {
   "implementations.execute.filtered": "{count} implementaciones a ejecutar",
   "implementations.header": "Implementaciones de calidad",
   "implementations.header.manage": "Gestión de Implementaciones",
+  "implementations.header.deprecated": "Implementaciones archivadas",
   "implementations.search.placeholder": "Buscar implementaciones...",
   "implementations.subheader":
     "Listado y detalle de implementaciones de calidad",
+  "implementations.subheader.deprecated":
+    "Listado de implementaciones de calidad archivadas",
   "implementations.subheader.manage":
     "Versiones de Implementaciones en Progreso",
   "implementationsStructures.delete.confirmation.content":
@@ -447,8 +450,6 @@ export default {
   "ruleImplementation.props.reference_dataset": "Datos de referencia",
   "ruleImplementation.props.reference_dataset.placeholder":
     "Buscar datos de referencia",
-  "ruleImplementation.props.status.deprecated":
-    "Esta Implementación está archivada",
   "ruleImplementation.props.structure": "Estructura",
   "ruleImplementation.props.structure.alias": "Alias",
   "ruleImplementation.props.structure.placeholder": "Buscar estructura",
@@ -470,6 +471,7 @@ export default {
   "ruleImplementation.summary.population": "Población",
   "ruleImplementation.summary.source": "Origen de datos",
   "ruleImplementation.summary.structure": "Estructura",
+  "ruleImplementation.summary.invalid_structure": "Estructura inválida",
   "ruleImplementation.summary.system": "Sistema",
   "ruleImplementation.summary.validations": "Validaciones",
   "ruleImplementation.summary.values": "Valores",

package/src/reducers/ruleRedirect.js

@@ -12,6 +12,7 @@ import {
   deleteRule,
   publishImplementation,
   rejectImplementation,
+  restoreImplementation,
   submitImplementation,
   updateRule,
   uploadRules,
@@ -56,6 +57,8 @@ export const ruleRedirect = (state = initialState, { type, payload, meta }) => {
       return payload?.redirectUrl || state;
     case rejectImplementation.SUCCESS:
       return payload?.redirectUrl || state;
+    case restoreImplementation.SUCCESS:
+      return payload?.redirectUrl || state;
     default:
       return state;
   }

package/src/routines.js

@@ -71,6 +71,7 @@ export const openImplementationFilter = createRoutine(
 );
 export const openRuleFilter = createRoutine("OPEN_RULE_FILTER");
 export const publishImplementation = createRoutine("PUBLISH_IMPLEMENTATION");
+export const restoreImplementation = createRoutine("RESTORE_IMPLEMENTATION");
 export const rejectImplementation = createRoutine("REJECT_IMPLEMENTATION");
 export const removeImplementationFilter = createRoutine(
   "REMOVE_IMPLEMENTATION_FILTERS"

package/src/sagas/index.js

@@ -21,6 +21,7 @@ import { fetchRulesRequestSaga } from "./fetchRules";
 import { fetchSegmentResultsRequestSaga } from "./fetchSegmentResults";
 import { publishImplementationRequestSaga } from "./publishImplementation";
 import { rejectImplementationRequestSaga } from "./rejectImplementation";
+import { restoreImplementationRequestSaga } from "./restoreImplementation";
 import { searchRuleImplementationsRequestSaga } from "./searchRuleImplementations";
 import { submitImplementationRequestSaga } from "./submitImplementation";
 import { updateRemediationRequestSaga } from "./updateRemediation";
@@ -54,6 +55,7 @@ export {
   fetchSegmentResultsRequestSaga,
   publishImplementationRequestSaga,
   rejectImplementationRequestSaga,
+  restoreImplementationRequestSaga,
   searchRuleImplementationsRequestSaga,
   submitImplementationRequestSaga,
   updateRemediationRequestSaga,
@@ -88,6 +90,7 @@ export default [
   fetchSegmentResultsRequestSaga(),
   publishImplementationRequestSaga(),
   rejectImplementationRequestSaga(),
+  restoreImplementationRequestSaga(),
   searchRuleImplementationsRequestSaga(),
   submitImplementationRequestSaga(),
   updateRemediationRequestSaga(),

package/src/sagas/restoreImplementation.js

@@ -0,0 +1,24 @@
+import { call, put, takeLatest, getContext } from "redux-saga/effects";
+import { RESTORE_IMPLEMENTATION } from "../api/mutations";
+import { restoreImplementation } from "../routines";
+
+export function* restoreImplementationSaga({ payload }) {
+  const client = yield getContext("client");
+  try {
+    const { id, redirectUrl } = payload;
+    yield put(restoreImplementation.request({ id }));
+    const { data } = yield call(client.mutate, {
+      mutation: RESTORE_IMPLEMENTATION,
+      variables: payload,
+    });
+    yield put(restoreImplementation.success({ data, redirectUrl }));
+  } catch (error) {
+    yield put(restoreImplementation.failure(error.message));
+  } finally {
+    yield put(restoreImplementation.fulfill());
+  }
+}
+
+export function* restoreImplementationRequestSaga() {
+  yield takeLatest(restoreImplementation.TRIGGER, restoreImplementationSaga);
+}