@truedat/dq 4.53.6 → 4.53.8

package/src/components/__tests__/__fixtures__/NewRuleImplementationProps.js

@@ -205,32 +205,34 @@ export const newRuleImplementationProps = {
       df_content: {},
     },
     validations: [
-      {
-        operator: {
-          name: "length_not_eq",
-          value_type: "number",
-        },
-        structure: {
-          external_id: "/data/example.txt[agent]",
-          id: 4814766,
-          metadata: {
-            metadata: { order: "6" },
+      [
+        {
+          operator: {
+            name: "length_not_eq",
+            value_type: "number",
           },
-          name: "agent",
-          path: ["Main", "example.txt"],
-          system: {
-            external_id: "file_system",
-            id: 33,
-            name: "File System",
+          structure: {
+            external_id: "/data/example.txt[agent]",
+            id: 4814766,
+            metadata: {
+              metadata: { order: "6" },
+            },
+            name: "agent",
+            path: ["Main", "example.txt"],
+            system: {
+              external_id: "file_system",
+              id: 33,
+              name: "File System",
+            },
+            type: "Column",
           },
-          type: "Column",
+          value: [
+            {
+              raw: 2,
+            },
+          ],
         },
-        value: [
-          {
-            raw: 2,
-          },
-        ],
-      },
+      ],
     ],
     segments: [
       {

package/src/components/__tests__/__fixtures__/newRuleImplementationHelper.js

@@ -13,7 +13,6 @@ const structuresFields = {
   11127104: [
     {
       data_structure_id: 11127108,
-      data_type_class: "number",
       deleted_at: null,
       description:
         "Department id where employee works; foreign key to department_id column of the departments table",
@@ -21,6 +20,7 @@ const structuresFields = {
       links: [],
       name: "DEPARTMENT_ID",
       metadata: {
+        data_type_class: "number",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -34,13 +34,13 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127111,
-      data_type_class: "string",
       deleted_at: null,
       description: "First name of the employee. A not null column.",
       inserted_at: "2022-04-12T14:28:06.057667Z",
       links: [],
       name: "FIRST_NAME",
       metadata: {
+        data_type_class: "string",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -54,7 +54,6 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127117,
-      data_type_class: "number",
       deleted_at: null,
       description:
         "Monthly salary of the employee. Must be greater than zero (enforced by constraint emp_salary_min)",
@@ -75,7 +74,6 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127116,
-      data_type_class: "string",
       deleted_at: null,
       description:
         "Phone number of the employee; includes country code and area code",
@@ -84,6 +82,7 @@ const structuresFields = {
       name: "PHONE_NUMBER",
       type: "column",
       metadata: {
+        data_type_class: "string",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -97,7 +96,6 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127115,
-      data_type_class: "number",
       deleted_at: null,
       description:
         "Manager id of the employee; has same domain as manager_id in departments table. Foreign key to employee_id column of employees table. (useful for reflexive joins and CONNECT BY query)",
@@ -106,6 +104,7 @@ const structuresFields = {
       name: "MANAGER_ID",
       type: "NUMBER",
       metadata: {
+        data_type_class: "number",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -118,7 +117,6 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127109,
-      data_type_class: "string",
       deleted_at: null,
       description: "Email id of the employee",
       inserted_at: "2022-04-12T14:28:06.057667Z",
@@ -126,6 +124,7 @@ const structuresFields = {
       name: "EMAIL",
       type: "column",
       metadata: {
+        data_type_class: "string",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -139,13 +138,13 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127110,
-      data_type_class: "number",
       deleted_at: null,
       description: "Primary key of employees table.",
       inserted_at: "2022-04-12T14:28:06.057667Z",
       links: [],
       name: "EMPLOYEE_ID",
       metadata: {
+        data_type_class: "number",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -160,13 +159,13 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127114,
-      data_type_class: "string",
       deleted_at: null,
       description: "Last name of the employee. A not null column.",
       inserted_at: "2022-04-12T14:28:06.057667Z",
       links: [],
       name: "LAST_NAME",
       metadata: {
+        data_type_class: "string",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -180,7 +179,6 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127112,
-      data_type_class: "date",
       deleted_at: null,
       description:
         "Date when the employee started on this job. A not null column.",
@@ -188,6 +186,7 @@ const structuresFields = {
       links: [],
       name: "HIRE_DATE",
       metadata: {
+        data_type_class: "date",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -201,7 +200,6 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127113,
-      data_type_class: "string",
       deleted_at: null,
       description:
         "Current job of the employee; foreign key to job_id column of the jobs table. A not null column.",
@@ -209,6 +207,7 @@ const structuresFields = {
       links: [],
       name: "JOB_ID",
       metadata: {
+        data_type_class: "string",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -222,7 +221,6 @@ const structuresFields = {
     },
     {
       data_structure_id: 11127107,
-      data_type_class: "number",
       deleted_at: null,
       description:
         "Commission percentage of the employee; Only employees in sales department elgible for commission percentage",
@@ -230,6 +228,7 @@ const structuresFields = {
       links: [],
       name: "COMMISSION_PCT",
       metadata: {
+        data_type_class: "number",
         database: "xe",
         default: "None",
         host: "localhost",
@@ -374,7 +373,7 @@ const ruleImplementation = {
   rule_id: null,
   segments: [],
   status: "draft",
-  validations: [],
+  validations: [[]],
   version: 2,
 };
 

package/src/components/__tests__/__snapshots__/NewRuleImplementation.spec.js.snap

@@ -653,7 +653,7 @@ exports[`<NewRuleImplementation /> calculate aliases when not informed 1`] = `
         <div
           class="content"
         >
-          Validation
+          Validations
         </div>
       </h3>
       <div
@@ -1370,6 +1370,67 @@ exports[`<NewRuleImplementation /> matches the latest snapshot 1`] = `
           </div>
         </div>
       </div>
+      <h3
+        class="ui header"
+      >
+        <i
+          aria-hidden="true"
+          class="setting small icon"
+        />
+        <div
+          class="content"
+        >
+          Validations
+        </div>
+      </h3>
+      <div
+        class="ui segment"
+      >
+        <table
+          class="ui very basic table"
+        >
+          <thead
+            class=""
+          >
+            <tr
+              class=""
+            >
+              <th
+                class=""
+              >
+                Field
+              </th>
+              <th
+                class=""
+              >
+                Operator
+              </th>
+              <th
+                class=""
+              >
+                Values
+              </th>
+            </tr>
+          </thead>
+          <tbody
+            class=""
+          >
+            <tr
+              class=""
+            >
+              <td
+                class="five wide"
+              />
+              <td
+                class="five wide"
+              />
+              <td
+                class="five wide"
+              />
+            </tr>
+          </tbody>
+        </table>
+      </div>
     </div>
   </div>
 </div>

package/src/components/ruleImplementationForm/FiltersGrid.js

@@ -142,7 +142,7 @@ export const FiltersGrid = ({
 
   return (
     <>
-      <Grid verticalAlign="middle" divided="vertically">
+      <Grid verticalAlign="middle">
         <FiltersGroup
           activeConditionIndex={activeConditionIndex}
           allOperators={allOperators}

package/src/components/ruleImplementationForm/FiltersGroup.js

@@ -1,7 +1,7 @@
 import _ from "lodash/fp";
-import React, { useState } from "react";
+import React, { Fragment, useState } from "react";
 import { useIntl } from "react-intl";
-import { Accordion, Grid, Icon, Popup } from "semantic-ui-react";
+import { Accordion, Divider, Grid, Icon, Popup } from "semantic-ui-react";
 import PropTypes from "prop-types";
 import ValueConditions from "./ValueConditions";
 import FiltersFormGroup from "./FiltersFormGroup";
@@ -158,24 +158,26 @@ export const FiltersGroup = ({
   scope,
 }) => {
   return rows.map((clause, index) => (
-    <Filter
-      key={index}
-      activeConditionIndex={activeConditionIndex}
-      allOperators={allOperators}
-      operators={operators}
-      composeValue={composeValue}
-      clause={clause}
-      index={index}
-      onConditionChange={onConditionChange}
-      onOperatorChange={onOperatorChange}
-      onStructureChange={onStructureChange}
-      onValueChange={onValueChange}
-      onModifierChange={onModifierChange}
-      parentStructures={parentStructures}
-      setActiveConditionIndex={setActiveConditionIndex}
-      setRowValue={setRowValue}
-      scope={scope}
-    />
+    <Fragment key={index}>
+      <Filter
+        activeConditionIndex={activeConditionIndex}
+        allOperators={allOperators}
+        operators={operators}
+        composeValue={composeValue}
+        clause={clause}
+        index={index}
+        onConditionChange={onConditionChange}
+        onOperatorChange={onOperatorChange}
+        onStructureChange={onStructureChange}
+        onValueChange={onValueChange}
+        onModifierChange={onModifierChange}
+        parentStructures={parentStructures}
+        setActiveConditionIndex={setActiveConditionIndex}
+        setRowValue={setRowValue}
+        scope={scope}
+      />
+      {index < rows.length - 1 ? <Divider /> : null}
+    </Fragment>
   ));
 };
 

package/src/components/ruleImplementationForm/RuleImplementationForm.js

@@ -1,5 +1,5 @@
 import _ from "lodash/fp";
-import React, { useEffect, useState } from "react";
+import React, { Fragment, useEffect, useState } from "react";
 import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { useHistory } from "react-router-dom";
@@ -45,7 +45,8 @@ RuleImplementationStep.propTypes = {
 
 export const RuleImplementationForm = ({
   addPopulation,
-  addSegments,
+  addSegment,
+  addValidation,
   isSubmitting,
   onChange,
   onSubmit,
@@ -122,10 +123,6 @@ export const RuleImplementationForm = ({
       !!ruleImplementation?.domain_id &&
       areLimitsValid(ruleImplementation);
 
-    const validValidations = () =>
-      _.every(_.negate(_.isEmpty))(validations) &&
-      validationsComplete(validations);
-
     const validSegments = () => _.every(_.negate(_.isEmpty))(segments);
 
     const validDataSet = () => areStructuresComplete();
@@ -158,7 +155,7 @@ export const RuleImplementationForm = ({
         {
           name: "validations",
           icon: "setting",
-          isValid: () => validValidations(),
+          isValid: () => validValidations(validations),
         },
         ...(canManageSegmentsAnyDomain
           ? [
@@ -192,7 +189,13 @@ export const RuleImplementationForm = ({
     _.every(_.negate(_.isEmpty))(population) &&
     _.every((p) => itemComplete(p, attrsFromProfile(p)))(population);
 
+  const validValidations = (validationsSet) =>
+    _.every(
+      (validations) => _.negate(_.isEmpty) && validationsComplete(validations)
+    )(validationsSet);
+
   const validationsComplete = (validations) =>
+    _.negate(_.isEmpty)(validations) &&
     _.every((v) => itemComplete(v, attrsFromProfile(v)))(validations);
 
   const attrsFromProfile = (p) => {
@@ -361,14 +364,23 @@ export const RuleImplementationForm = ({
             {activeStep == "populations" ? (
               <>
                 {populations.map((population, i) => (
-                  <Segment key={i}>
-                    <PopulationForm
-                      population={population}
-                      setPopulation={(p) => setPopulations(p, i)}
-                      structures={structures}
-                      typeOperators={operators}
-                    />
-                  </Segment>
+                  <Fragment key={i}>
+                    <Segment>
+                      <PopulationForm
+                        population={population}
+                        setPopulation={(p) => setPopulations(p, i)}
+                        structures={structures}
+                        typeOperators={operators}
+                      />
+                    </Segment>
+                    {i < populations.length - 1 ? (
+                      <Divider horizontal>
+                        {formatMessage({
+                          id: "ruleImplementations.or",
+                        })}
+                      </Divider>
+                    ) : null}
+                  </Fragment>
                 ))}
                 {_.flow(_.flatten, _.isEmpty)(populations) ? (
                   <PopulationTypeForm createFilter={() => addPopulation()} />
@@ -383,18 +395,42 @@ export const RuleImplementationForm = ({
                 ) : null}
               </>
             ) : null}
-            {activeStep == "validations" && (
-              <ValidationsForm
-                validations={validations}
-                setValidations={setValidations}
-                structures={structures}
-                typeOperators={operators}
-              />
-            )}
+            {activeStep == "validations" ? (
+              <>
+                {validations.map((validation, i) => (
+                  <Fragment key={i}>
+                    <Segment>
+                      <ValidationsForm
+                        validations={validation}
+                        setValidations={(v) => setValidations(v, i)}
+                        structures={structures}
+                        typeOperators={operators}
+                      />
+                    </Segment>
+                    {i < validations.length - 1 ? (
+                      <Divider horizontal>
+                        {formatMessage({
+                          id: "ruleImplementations.or",
+                        })}
+                      </Divider>
+                    ) : null}
+                  </Fragment>
+                ))}
+                {validValidations(validations) ? (
+                  <Button
+                    secondary
+                    onClick={() => addValidation()}
+                    content={formatMessage({
+                      id: "ruleImplementationForm.validations.add",
+                    })}
+                  />
+                ) : null}
+              </>
+            ) : null}
             {activeStep == "segments" ? (
               <>
                 {_.flow(_.flatten, _.isEmpty)(segments) ? (
-                  <SegmentsTypeForm createFilter={() => addSegments()} />
+                  <SegmentsTypeForm createFilter={() => addSegment()} />
                 ) : (
                   <SegmentsForm
                     segments={segments}
@@ -466,7 +502,8 @@ export const RuleImplementationForm = ({
 
 RuleImplementationForm.propTypes = {
   addPopulation: PropTypes.func,
-  addSegments: PropTypes.func,
+  addValidation: PropTypes.func,
+  addSegment: PropTypes.func,
   authManageSegments: PropTypes.bool,
   isAdmin: PropTypes.bool,
   isSubmitting: PropTypes.bool,

package/src/components/ruleImplementationForm/ValidationsForm.js

@@ -17,8 +17,7 @@ export const ValidationsForm = ({
       const validation = { ..._.nth(index)(validations), ...value };
       setValidations(replaceAt(index, validation)(validations));
     } else {
-      const array = dropAt(index)(validations);
-      setValidations(_.isEmpty(array) ? [{}] : array);
+      setValidations(dropAt(index)(validations));
     }
   };
 

package/src/messages/en.js

@@ -78,9 +78,11 @@ export default {
   "implementations.execute.filtered": "{count} implementations to execute",
   "implementations.header": "Quality Implementations",
   "implementations.header.manage": "Implementation Management",
+  "implementations.header.deprecated": "Deprecated Implementations",
   "implementations.search.placeholder": "Search implementations...",
   "implementations.subheader": "Quality implementations list and details",
   "implementations.subheader.manage": "Implementation Versions in Progress",
+  "implementations.subheader.deprecated": "List of deprecated quality implementations",
   "implementationsStructures.delete.confirmation.content":
     "The relation will be deleted. Are you sure?",
   "implementationsStructures.delete.confirmation.header":
@@ -438,7 +440,6 @@ export default {
   "ruleImplementation.props.reference_dataset": "Reference dataset",
   "ruleImplementation.props.reference_dataset.placeholder":
     "Search reference dataset",
-  "ruleImplementation.props.status.deprecated": "Deprecated Implementation",
   "ruleImplementation.props.structure": "Structure",
   "ruleImplementation.props.structure.alias": "Alias",
   "ruleImplementation.props.structure.placeholder": "Search structure",
@@ -460,6 +461,7 @@ export default {
   "ruleImplementation.summary.population": "Population",
   "ruleImplementation.summary.source": "Data source",
   "ruleImplementation.summary.structure": "Structure",
+  "ruleImplementation.summary.invalid_structure": "Invalid structure",
   "ruleImplementation.summary.system": "System",
   "ruleImplementation.summary.validations": "Validations",
   "ruleImplementation.summary.values": "Values",
@@ -467,12 +469,14 @@ export default {
   "ruleImplementation.system.placeholder": "Select a system",
   "ruleImplementation.table": "Table",
   "ruleImplementation.table.placeholder": "Select a table",
+  "ruleImplementationForm.condition.add": "Add condition",
   "ruleImplementationForm.populations.add": "Add population",
   "ruleImplementationForm.step.dataset": "Data Set",
   "ruleImplementationForm.step.information": "Information",
   "ruleImplementationForm.step.populations": "Populations",
   "ruleImplementationForm.step.segments": "Segments",
   "ruleImplementationForm.step.validations": "Validations",
+  "ruleImplementationForm.validations.add": "Add validations",
   "ruleImplementationRawForm.props.database": "Database",
   "ruleImplementationRawForm.props.database.placeholder": "Select database",
   "ruleImplementationRawForm.props.dataset": "Dataset",
@@ -512,6 +516,7 @@ export default {
   "ruleImplementations.events.action_restored": "Implementation restored",
   "ruleImplementations.events.action_updated": "Implementation updated",
   "ruleImplementations.events.action_versioned": "Implementation versioned",
+  "ruleImplementations.or": "OR",
   "ruleImplementations.props.business_concept": "Concept",
   "ruleImplementations.props.executable": "Executable",
   "ruleImplementations.props.executable.false": "Internal",
@@ -549,9 +554,10 @@ export default {
   "ruleImplementations.summary.headers.filters": "Filters",
   "ruleImplementations.summary.headers.implementation": "Rule Implementation",
   "ruleImplementations.summary.headers.population": "Population",
-  "ruleImplementations.summary.headers.populations": "Populations",
+  "ruleImplementations.summary.headers.population.plural": "Populations",
   "ruleImplementations.summary.headers.segments": "Segments",
-  "ruleImplementations.summary.headers.validations": "Validation",
+  "ruleImplementations.summary.headers.validations": "Validations",
+  "ruleImplementations.summary.headers.validations.plural": "Validations",
   "ruleImplementations.update.success.header.implementation_unchanged":
     "The implementation has not changed",
   "ruleImplementations.upload.failed.header":

package/src/messages/es.js

@@ -79,9 +79,12 @@ export default {
   "implementations.execute.filtered": "{count} implementaciones a ejecutar",
   "implementations.header": "Implementaciones de calidad",
   "implementations.header.manage": "Gestión de Implementaciones",
+  "implementations.header.deprecated": "Implementaciones archivadas",
   "implementations.search.placeholder": "Buscar implementaciones...",
   "implementations.subheader":
     "Listado y detalle de implementaciones de calidad",
+  "implementations.subheader.deprecated":
+    "Listado de implementaciones de calidad archivadas",
   "implementations.subheader.manage":
     "Versiones de Implementaciones en Progreso",
   "implementationsStructures.delete.confirmation.content":
@@ -447,8 +450,6 @@ export default {
   "ruleImplementation.props.reference_dataset": "Datos de referencia",
   "ruleImplementation.props.reference_dataset.placeholder":
     "Buscar datos de referencia",
-  "ruleImplementation.props.status.deprecated":
-    "Esta Implementación está archivada",
   "ruleImplementation.props.structure": "Estructura",
   "ruleImplementation.props.structure.alias": "Alias",
   "ruleImplementation.props.structure.placeholder": "Buscar estructura",
@@ -470,6 +471,7 @@ export default {
   "ruleImplementation.summary.population": "Población",
   "ruleImplementation.summary.source": "Origen de datos",
   "ruleImplementation.summary.structure": "Estructura",
+  "ruleImplementation.summary.invalid_structure": "Estructura inválida",
   "ruleImplementation.summary.system": "Sistema",
   "ruleImplementation.summary.validations": "Validaciones",
   "ruleImplementation.summary.values": "Valores",
@@ -477,12 +479,14 @@ export default {
   "ruleImplementation.system.placeholder": "Seleccionar sistema",
   "ruleImplementation.table": "Tabla",
   "ruleImplementation.table.placeholder": "Seleccionar tabla",
+  "ruleImplementationForm.condition.add": "Añadir condición",
   "ruleImplementationForm.populations.add": "Añadir población",
   "ruleImplementationForm.step.dataset": "Datos",
   "ruleImplementationForm.step.information": "Información",
   "ruleImplementationForm.step.populations": "Poblaciones",
   "ruleImplementationForm.step.segments": "Segmentos",
   "ruleImplementationForm.step.validations": "Validaciones",
+  "ruleImplementationForm.validations.add": "Añadir validación",
   "ruleImplementationRawForm.props.database": "Base de datos",
   "ruleImplementationRawForm.props.database.placeholder":
     "Seleccionar base de datos",
@@ -528,6 +532,7 @@ export default {
   "ruleImplementations.events.action_restored": "Implementación restaurada",
   "ruleImplementations.events.action_updated": "Implementación actualizada",
   "ruleImplementations.events.action_versioned": "Implementación versionada",
+  "ruleImplementations.or": "OR",
   "ruleImplementations.props.business_concept": "Concepto",
   "ruleImplementations.props.executable": "Ejecutable",
   "ruleImplementations.props.executable.false": "Interna",
@@ -570,9 +575,10 @@ export default {
   "ruleImplementations.summary.headers.implementation":
     "Implementación de una Regla",
   "ruleImplementations.summary.headers.population": "Población",
-  "ruleImplementations.summary.headers.populations": "Poblaciones",
+  "ruleImplementations.summary.headers.population.plural": "Poblaciones",
   "ruleImplementations.summary.headers.segments": "Segmentos",
   "ruleImplementations.summary.headers.validations": "Validaciones",
+  "ruleImplementations.summary.headers.validations.plural": "Validaciones",
   "ruleImplementations.update.success.header.implementation_unchanged":
     "La implementación no ha cambiado",
   "ruleImplementations.upload.failed.header":

package/src/reducers/ruleImplementation.js

@@ -39,7 +39,10 @@ const ruleImplementation = (state = initialState, { type, payload }) => {
     case fetchRuleImplementation.TRIGGER:
       return initialState;
     case fetchRuleImplementation.SUCCESS:
-      return pickFields(payload.data);
+      return pickFields({
+        ...payload.data,
+        validations: payload.data.validation,
+      });
     case clearRuleImplementation.TRIGGER:
       return initialState;
     default: