@truedat/dq 4.53.2 → 4.53.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.53.4] 2022-10-07
+
+### Fixed
+
+- [TD-5098] Missing value modifier parameter translations, put key in Fragment
+
 ## [4.53.2] 2022-10-07
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.53.2",
+  "version": "4.53.4",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.16.4",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.53.2",
+    "@truedat/test": "4.53.4",
     "babel-jest": "^28.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -93,8 +93,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.53.2",
-    "@truedat/df": "4.53.2",
+    "@truedat/core": "4.53.4",
+    "@truedat/df": "4.53.4",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
     "prop-types": "^15.8.1",
@@ -114,5 +114,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "e29af66624aad6ecce065ced88c8cc2e320d67e2"
+  "gitHead": "b21b4051e9370c3a28d4f0e43a53e34d3ccd59d5"
 }

package/src/components/ConditionSummary.js

@@ -163,12 +163,12 @@ const ConditionCell = ({ row, alias }) => {
                 {_.flow(
                   _.prop("modifier.params"),
                   _.toPairs,
-                  _.map(([key, value]) => (
-                    <div key={key} className="smaller">
+                  _.map(([paramName, paramValue]) => (
+                    <div key={paramName} className="smaller">
                       {`${formatMessage({
-                        id: `filtersGrid.field.modifier.${row.modifier.name}.${key}`,
-                        defaultMessage: key,
-                      })}: ${value}`}
+                        id: `filtersGrid.field.modifier.${row.modifier.name}.${paramName}`,
+                        defaultMessage: paramName,
+                      })}: ${paramValue}`}
                     </div>
                   ))
                 )(row)}
@@ -201,9 +201,12 @@ const ConditionCell = ({ row, alias }) => {
                 {_.flow(
                   _.prop("modifier.params"),
                   _.toPairs,
-                  _.map(([key, value]) => (
-                    <div key={key} className="smaller">
-                      {value}
+                  _.map(([paramName, paramValue]) => (
+                    <div key={paramName} className="smaller">
+                      {`${formatMessage({
+                        id: `filtersGrid.field.modifier.${value.modifier.name}.${paramName}`,
+                        defaultMessage: paramName,
+                      })}: ${paramValue}`}
                     </div>
                   ))
                 )(value)}

package/src/components/ruleImplementationForm/FieldModifier.js

@@ -1,6 +1,6 @@
 import { getOr, isEmpty } from "lodash/fp";
 import PropTypes from "prop-types";
-import React from "react";
+import React, { Fragment } from "react";
 import { useIntl } from "react-intl";
 import { Form, Icon, Segment } from "semantic-ui-react";
 
@@ -29,15 +29,14 @@ export default function FieldModifier({
           {getOr(
             [],
             "params"
-          )(modifier).map((param, key) => (
-            <>
+          )(modifier).map((param) => (
+            <Fragment key={`${param.name}`}>
               <label>
                 {formatMessage({
                   id: `filtersGrid.field.modifier.${modifier.name}.${param.name}`,
                 })}
               </label>
               <input
-                key={key}
                 placeholder={formatMessage({
                   id: `filtersGrid.field.modifier.${modifier.name}.${param.name}`,
                 })}
@@ -52,7 +51,7 @@ export default function FieldModifier({
                   });
                 }}
               />
-            </>
+            </Fragment>
           ))}
         </Segment>
       )}