@truedat/dq 4.52.0 → 4.52.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.52.1] 2022-09-21
+
+### Fixed
+
+- [TD-5164] RuleEventDecorator exception if quality_events is empty
+
 ## [4.52.0] 2022-09-20
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.52.0",
+  "version": "4.52.1",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -114,5 +114,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "1d43cb9b9b8531eb6c054c7f430741976d59f592"
+  "gitHead": "3eea3b93dcb8dc264af0779fd621971216f0e8aa"
 }

package/src/components/RuleEventDecorator.js

@@ -1,26 +1,30 @@
-import { flow, last, prop, sortBy } from "lodash/fp";
+import { flow, last, prop, propOr, sortBy } from "lodash/fp";
 import React from "react";
 import PropTypes from "prop-types";
 import { Icon } from "semantic-ui-react";
 
+const PENDING = { name: "info circle", color: "green" };
+
 export const icons = {
-  PENDING: { name: "info circle", color: "green" },
+  PENDING,
   STARTED: { name: "play circle outline", color: "green" },
   SUCCEEDED: { name: "check circle outline", color: "green" },
-  FAILED: { name: "warning circle", color: "red" }
+  FAILED: { name: "warning circle", color: "red" },
 };
-export const RuleResultDecorator = ({ _embedded }) => {
+
+export const RuleEventDecorator = ({ _embedded }) => {
   const event = flow(
+    propOr([], "quality_events"),
     sortBy("inserted_at"),
     last,
     prop("type")
-  )(_embedded.quality_events);
-  const icon = icons[event] || { name: "question circle outline" };
+  )(_embedded);
+  const icon = propOr(PENDING, event)(icons);
   return <Icon size="large" {...icon} />;
 };
 
-RuleResultDecorator.propTypes = {
-  _embedded: PropTypes.object
+RuleEventDecorator.propTypes = {
+  _embedded: PropTypes.object,
 };
 
-export default RuleResultDecorator;
+export default RuleEventDecorator;

package/src/components/__tests__/RuleEventDecorator.spec.js

@@ -0,0 +1,10 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { RuleEventDecorator } from "../RuleEventDecorator";
+
+describe("<RuleEventDecorator />", () => {
+  it("matches latest snapshot (no events)", () => {
+    const { container } = render(<RuleEventDecorator />);
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/__snapshots__/ExecutionGroup.spec.js.snap

@@ -92,7 +92,7 @@ exports[`<ExecutionGroup /> matches the latest snapshot 1`] = `
         >
           <i
             aria-hidden="true"
-            class="question circle outline large icon"
+            class="green info circle large icon"
           />
         </td>
         <td

package/src/components/__tests__/__snapshots__/RuleEventDecorator.spec.js.snap

@@ -0,0 +1,10 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleEventDecorator /> matches latest snapshot (no events) 1`] = `
+<div>
+  <i
+    aria-hidden="true"
+    class="green info circle large icon"
+  />
+</div>
+`;