@truedat/dq 4.51.7 → 4.52.1

package/CHANGELOG.md

@@ -1,11 +1,18 @@
 # Changelog
 
-## [4.51.7] 2022-09-21
+## [4.52.1] 2022-09-21
 
 ### Fixed
 
 - [TD-5164] RuleEventDecorator exception if quality_events is empty
 
+## [4.52.0] 2022-09-20
+
+### Fixed
+
+- [TD-5135] Error in implementation audit component when field value is an
+  object
+
 ## [4.51.3] 2022-09-16
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.51.7",
+  "version": "4.52.1",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.16.4",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.51.6",
+    "@truedat/test": "4.52.0",
     "babel-jest": "^28.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -93,8 +93,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.51.6",
-    "@truedat/df": "4.51.6",
+    "@truedat/core": "4.52.0",
+    "@truedat/df": "4.52.0",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
     "prop-types": "^15.8.1",
@@ -114,5 +114,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "6f13ba98bcb7ca657e3e8043dfdc5e6716862aa7"
+  "gitHead": "3eea3b93dcb8dc264af0779fd621971216f0e8aa"
 }

package/src/components/RuleEventDecorator.js

@@ -1,26 +1,30 @@
-import { flow, last, prop, sortBy } from "lodash/fp";
+import { flow, last, prop, propOr, sortBy } from "lodash/fp";
 import React from "react";
 import PropTypes from "prop-types";
 import { Icon } from "semantic-ui-react";
 
+const PENDING = { name: "info circle", color: "green" };
+
 export const icons = {
-  PENDING: { name: "info circle", color: "green" },
+  PENDING,
   STARTED: { name: "play circle outline", color: "green" },
   SUCCEEDED: { name: "check circle outline", color: "green" },
   FAILED: { name: "warning circle", color: "red" },
 };
-export const RuleResultDecorator = ({ _embedded }) => {
+
+export const RuleEventDecorator = ({ _embedded }) => {
   const event = flow(
+    propOr([], "quality_events"),
     sortBy("inserted_at"),
     last,
     prop("type")
-  )(_embedded?.quality_events);
-  const icon = icons[event] || { name: "question circle outline" };
+  )(_embedded);
+  const icon = propOr(PENDING, event)(icons);
   return <Icon size="large" {...icon} />;
 };
 
-RuleResultDecorator.propTypes = {
+RuleEventDecorator.propTypes = {
   _embedded: PropTypes.object,
 };
 
-export default RuleResultDecorator;
+export default RuleEventDecorator;

package/src/components/RuleImplementationEventRow.js

@@ -29,7 +29,7 @@ export const RuleImplementationEventRow = ({
             text
             content={formatMessage(
               { id: "ruleImplementations.events.action_" + action },
-              [field, value]
+              [field, _.isObject(value) ? JSON.stringify(value) : value]
             )}
           />
         ))}

package/src/components/__tests__/RuleEventDecorator.spec.js

@@ -0,0 +1,10 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { RuleEventDecorator } from "../RuleEventDecorator";
+
+describe("<RuleEventDecorator />", () => {
+  it("matches latest snapshot (no events)", () => {
+    const { container } = render(<RuleEventDecorator />);
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/RuleImplementationEvents.spec.js

@@ -20,23 +20,22 @@ describe("<RuleImplementationEvents />", () => {
       ts: "2019-09-12T02:00:00Z",
       payload: [{ field: "bar", action: "deprecated" }],
     },
-  ];
-  const renderOpts = {
-    messages: {
-      en: {
-        "ruleImplementations.events.action_deprecated": "deprecated",
-        "ruleImplementations.events.action_restored": "restored",
-      },
+    {
+      id: 3,
+      service: "service",
+      event: "implementation_changed",
+      resource_id: 100,
+      ts: "2019-09-12T02:00:00Z",
+      payload: [
+        { field: "bar", action: "changed", value: { id: 123, name: "foo" } },
+      ],
     },
-  };
+  ];
 
   const props = { events };
 
   it("matches the latest snapshot", () => {
-    const { container } = render(
-      <RuleImplementationEvents {...props} />,
-      renderOpts
-    );
+    const { container } = render(<RuleImplementationEvents {...props} />);
     expect(container).toMatchSnapshot();
   });
 });

package/src/components/__tests__/__snapshots__/ExecutionGroup.spec.js.snap

@@ -92,7 +92,7 @@ exports[`<ExecutionGroup /> matches the latest snapshot 1`] = `
         >
           <i
             aria-hidden="true"
-            class="question circle outline large icon"
+            class="green info circle large icon"
           />
         </td>
         <td

package/src/components/__tests__/__snapshots__/RuleEventDecorator.spec.js.snap

@@ -0,0 +1,10 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleEventDecorator /> matches latest snapshot (no events) 1`] = `
+<div>
+  <i
+    aria-hidden="true"
+    class="green info circle large icon"
+  />
+</div>
+`;

package/src/components/__tests__/__snapshots__/RuleImplementationEvents.spec.js.snap

@@ -34,7 +34,7 @@ exports[`<RuleImplementationEvents /> matches the latest snapshot 1`] = `
           <div
             class="text extra"
           >
-            restored
+            Implementation restored
           </div>
         </div>
       </div>
@@ -64,7 +64,37 @@ exports[`<RuleImplementationEvents /> matches the latest snapshot 1`] = `
           <div
             class="text extra"
           >
-            deprecated
+            Implementation deprecated
+          </div>
+        </div>
+      </div>
+      <div
+        class="event"
+      >
+        <div
+          class="content"
+        >
+          <div
+            class="summary"
+          >
+            <a
+              class="user"
+            />
+             
+            <div
+              class="date"
+            >
+              <time
+                datetime="1568253600000"
+              >
+                2019-09-12 02:00
+              </time>
+            </div>
+          </div>
+          <div
+            class="text extra"
+          >
+            Field bar changed to {"id":123,"name":"foo"}
           </div>
         </div>
       </div>