@truedat/dq 4.49.8 → 4.50.0

package/CHANGELOG.md

@@ -1,12 +1,30 @@
 # Changelog
 
-## [4.49.6] 2022-10-08
+## [4.50.0] 2022-08-18
+
+## Changed
+
+- [TD-5118] Disable submit buttons when update implementation
+
+## [4.49.10] 2022-08-16
+
+## Changed
+
+- [TD-5070] Filter versioned rule implementations in rule implementation from rule loader
+
+## [4.49.9] 2022-08-12
+
+### Fixed
+
+- [TD-5116] Fix `if` condition when value is 0 in implementation validations
+
+## [4.49.6] 2022-08-10
 
 ### Fixed
 
 - [TD-4945] User with permission can save or published on edition
 
-## [4.48.13] 2022-26-07
+## [4.48.13] 2022-07-26
 
 ### Fixed
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.49.8",
+  "version": "4.50.0",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -93,8 +93,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.49.8",
-    "@truedat/df": "4.49.8",
+    "@truedat/core": "4.49.10",
+    "@truedat/df": "4.49.10",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
     "prop-types": "^15.8.1",
@@ -114,5 +114,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "74f5005d8059e15d346982d6b31c5b97e0dd8b79"
+  "gitHead": "2392ed87cfb39ef7b9326265f4bccf100b52153a"
 }

package/src/components/NewRuleImplementation.js

@@ -25,7 +25,7 @@ const updateDatasetKey = (data) =>
 
 // object either field, raw value, list of fields, list of raw values
 const updateValueKeyContent = (value) => {
-  if (value?.id || value?.raw || value?.fields) {
+  if (value?.id || _.negate(_.isUndefined)(value?.raw) || value?.fields) {
     return value?.id || value?.type === "reference_dataset_field"
       ? _.pick(["id", "parent_index", "name", "type"])(value)
       : _.pick(["raw", "fields"])(value);

package/src/components/RuleImplementationsFromRuleLoader.js

@@ -16,7 +16,14 @@ export const RuleImplementationsFromRuleLoader = ({
   const { id } = useParams();
   useEffect(() => {
     if (id) {
-      fetchRuleImplementations({ id });
+      fetchRuleImplementations({
+        id,
+        filters: {
+          must_not: {
+            status: ["versioned"],
+          },
+        },
+      });
     }
   }, [clearRuleImplementations, fetchRuleImplementations, id]);
 

package/src/components/__tests__/RuleImplementationsFromRuleLoader.spec.js

@@ -32,7 +32,10 @@ describe("<RuleImplementationsFromRuleLoader />", () => {
     const wrapper = mount(<RuleImplementationsFromRuleLoader {...props} />);
     expect(clearRuleImplementations).toHaveBeenCalledTimes(0);
     expect(fetchRuleImplementations).toHaveBeenCalledTimes(1);
-    expect(fetchRuleImplementations).toHaveBeenCalledWith({ id: 1 });
+    expect(fetchRuleImplementations).toHaveBeenCalledWith({
+      id: 1,
+      filters: { must_not: { status: ["versioned"] } },
+    });
     wrapper.unmount();
     expect(clearRuleImplementations).toHaveBeenCalledTimes(1);
     expect(fetchRuleImplementations).toHaveBeenCalledTimes(1);

package/src/components/__tests__/__snapshots__/RuleImplementationsFromRuleLoader.spec.js.snap

@@ -13,6 +13,13 @@ exports[`<RuleImplementationsFromRuleLoader /> matches the latest snapshot 1`] =
       "calls": Array [
         Array [
           Object {
+            "filters": Object {
+              "must_not": Object {
+                "status": Array [
+                  "versioned",
+                ],
+              },
+            },
             "id": 1,
           },
         ],

package/src/components/ruleImplementationForm/RuleImplementationForm.js

@@ -277,7 +277,8 @@ export const RuleImplementationForm = ({
       : _.prop("name")(prevStep);
   };
 
-  const isButtonDisabled = (currentStep) => !validStep(currentStep);
+  const isButtonDisabled = (currentStep) =>
+    !validStep(currentStep) || isSubmitting;
 
   const validStep = (stepName) => {
     return _.flow(

package/src/reducers/ruleImplementationCreating.js

@@ -1,10 +1,15 @@
-import { createRuleImplementation } from "../routines";
+import {
+  createRuleImplementation,
+  updateRuleImplementation,
+} from "../routines";
 
 const ruleImplementationCreating = (state = false, { type }) => {
   switch (type) {
     case createRuleImplementation.TRIGGER:
+    case updateRuleImplementation.TRIGGER:
       return true;
     case createRuleImplementation.FULFILL:
+    case updateRuleImplementation.FULFILL:
       return false;
     default:
       return state;

package/src/sagas/fetchRuleImplementations.js

@@ -4,11 +4,19 @@ import { apiJsonPost, JSON_OPTS } from "@truedat/core/services/api";
 import { fetchRuleImplementations } from "../routines";
 import { API_RULE_IMPLEMENTATIONS_FROM_RULE } from "../api";
 
-const fetchPayload = (deleted) => (deleted ? { status: "deleted" } : {});
+const fetchPayload = (deleted, filters) => {
+  const statusPayload = deleted ? { status: "deleted" } : {};
+  const filtersPayload = filters ? { filters } : {};
+
+  return {
+    ...statusPayload,
+    ...filtersPayload,
+  };
+};
 
 export function* fetchRuleImplementationsSaga({ payload }) {
   try {
-    const { id, deleted } = payload;
+    const { id, deleted, filters } = payload;
     const url = compile(API_RULE_IMPLEMENTATIONS_FROM_RULE)({ id });
 
     yield put(fetchRuleImplementations.request());
@@ -16,7 +24,7 @@ export function* fetchRuleImplementationsSaga({ payload }) {
     const { data } = yield call(
       apiJsonPost,
       url,
-      fetchPayload(deleted),
+      fetchPayload(deleted, filters),
       JSON_OPTS
     );
     yield put(fetchRuleImplementations.success(data));