@truedat/dq 4.48.6 → 4.48.7

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.48.7]
+
+### Added
+
+- [TD-5029] Reenable submit test commented out in [TD-4661]
+
 ## [4.48.6] 2022-07-15
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.48.6",
+  "version": "4.48.7",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -88,8 +88,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.48.6",
-    "@truedat/df": "4.48.6",
+    "@truedat/core": "4.48.7",
+    "@truedat/df": "4.48.7",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -110,5 +110,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "06ed478bb99a0fb6ab5f5cc557808f8ee00d5e24"
+  "gitHead": "f4a20ecf51eb101c2c25facfec48ee8cd0e621a3"
 }

package/src/components/__tests__/NewRuleImplementation.spec.js

@@ -207,126 +207,133 @@ describe("<NewRuleImplementation> NewRuleImplementation doSubmit", () => {
     });
   });
 
-  // it("doSubmit: unique across fields operator", async () => {
-  //   const expectedRuleImplementation = {
-  //     ...expectedRuleImplementationBase,
-  //     validations: [
-  //       {
-  //         modifier: null,
-  //         operator: { name: "unique", value_type: "field_list" },
-  //         population: [],
-  //         structure: { id: 11127109, parent_index: 4, name: "EMAIL", type: "VARCHAR2" },
-  //         value: [
-  //           {
-  //             fields: [
-  //               {
-  //                 id: 11127109,
-  //                 name: "EMAIL",
-  //                 parent_index: 4,
-  //                 path: undefined,
-  //               },
-  //               {
-  //                 id: 11127116,
-  //                 name: "PHONE_NUMBER",
-  //                 parent_index: 4,
-  //                 path: undefined,
-  //               },
-  //             ],
-  //           },
-  //         ],
-  //         value_modifier: [],
-  //       },
-  //     ],
-  //   };
-
-  //   const { queryByText, getByRole, findByRole, findByTestId } = render(
-  //     <NewRuleImplementation {...props} />,
-  //     renderOptsImplementationEdit
-  //   );
-
-  //   // Information Form
-
-  //   await waitFor(() => {
-  //     expect(queryByText(/Template/)).toBeTruthy();
-  //   });
-
-  //   userEvent.click(await findByRole("option", { name: "template1" }));
-
-  //   await waitFor(() => {
-  //     expect(getByRole("button", { name: "Next" })).toBeEnabled();
-  //   });
-  //   userEvent.click(await getByRole("button", { name: "Next" }));
-
-  //   // Dataset Form
-
-  //   await waitFor(() => {
-  //     expect(getByRole("button", { name: "Next" })).toBeEnabled();
-  //   });
-  //   userEvent.click(await getByRole("button", { name: "Next" }));
-
-  //   // Population Form
-
-  //   await waitFor(() => {
-  //     expect(getByRole("button", { name: "Next" })).toBeEnabled();
-  //   });
-  //   userEvent.click(await getByRole("button", { name: "Next" }));
-
-  //   // Validations Form
-
-  //   userEvent.click(await findByRole("button", { name: "add-condition-row" }));
-
-  //   const row = await findByTestId("row-0");
-
-  //   const field = row.querySelector('div[label="Field"]');
-  //   const operator = row.querySelector('div[label="Operator"]');
-
-  //   userEvent.click(field);
-  //   const fieldOptions = await within(field).findByRole("listbox");
-  //   const emailFieldOption = within(fieldOptions).getByText("EMAIL");
-  //   userEvent.click(emailFieldOption);
-  //   const selectedField = fieldOptions.querySelector(".selected>span");
-  //   expect(within(selectedField).queryByText(/EMAIL/)).toBeInTheDocument();
-
-  //   userEvent.click(operator);
-  //   const operatorOptions = await within(operator).findByRole("listbox");
-  //   const uniqueAcrossFieldsOperatorOption = within(operatorOptions).getByText(
-  //     "unique across fields"
-  //   );
-  //   userEvent.click(uniqueAcrossFieldsOperatorOption);
-  //   const selectedOperator = operatorOptions.querySelector(".selected>span");
-  //   expect(
-  //     within(selectedOperator).queryByText(/unique across fields/)
-  //   ).toBeInTheDocument();
-
-  //   const updatedRow = await findByTestId("row-0");
-  //   const value = updatedRow.querySelector('div[label="Value"]');
-  //   userEvent.click(value);
-  //   const valueOptions = await within(value).findByRole("listbox");
-  //   const valueEmailFieldOption = within(valueOptions).getByText("EMAIL");
-  //   const valuePhoneNumberFieldOption =
-  //     within(valueOptions).getByText("PHONE_NUMBER");
-
-  //   userEvent.click(valueEmailFieldOption);
-  //   userEvent.click(valuePhoneNumberFieldOption);
-
-  //   const selectedFieldValues = updatedRow.querySelectorAll(".label");
-
-  //   const selectedFieldTexts = [...selectedFieldValues].map(
-  //     (selectedFieldValue) => selectedFieldValue.text
-  //   );
-
-  //   expect(_.difference(selectedFieldTexts, ["EMAIL", "PHONE_NUMBER"])).toEqual(
-  //     []
-  //   );
-
-  //   await waitFor(() => {
-  //     expect(getByRole("button", { name: "Save" })).toBeEnabled();
-  //   });
-  //   userEvent.click(await getByRole("button", { name: "Save" }));
-
-  //   expect(dispatch).toHaveBeenCalledWith({
-  //     ...ruleImplementationLoaderActions.updateRuleImplementation(),
-  //     payload: { rule_implementation: expectedRuleImplementation },
-  //   });
-  // });
+  it("doSubmit: unique across fields operator", async () => {
+    const expectedRuleImplementation = {
+      ...expectedRuleImplementationBase,
+      validations: [
+        {
+          modifier: null,
+          operator: { name: "unique", value_type: "field_list" },
+          population: [],
+          structure: {
+            id: 11127109,
+            parent_index: 4,
+            name: "EMAIL",
+            type: "VARCHAR2",
+          },
+          value: [
+            {
+              fields: [
+                {
+                  id: 11127109,
+                  name: "EMAIL",
+                  parent_index: 4,
+                  path: undefined,
+                  type: "VARCHAR2",
+                },
+                {
+                  id: 11127116,
+                  name: "PHONE_NUMBER",
+                  parent_index: 4,
+                  path: undefined,
+                  type: "VARCHAR2",
+                },
+              ],
+            },
+          ],
+          value_modifier: [],
+        },
+      ],
+    };
+
+    const { queryByText, getByRole, findByRole, findByTestId } = render(
+      <NewRuleImplementation {...props} />,
+      renderOptsImplementationEdit
+    );
+
+    // Information Form
+
+    await waitFor(() => {
+      expect(queryByText(/Template/)).toBeTruthy();
+    });
+
+    userEvent.click(await findByRole("option", { name: "template1" }));
+
+    await waitFor(() => {
+      expect(getByRole("button", { name: "Next" })).toBeEnabled();
+    });
+    userEvent.click(await getByRole("button", { name: "Next" }));
+
+    // Dataset Form
+
+    await waitFor(() => {
+      expect(getByRole("button", { name: "Next" })).toBeEnabled();
+    });
+    userEvent.click(await getByRole("button", { name: "Next" }));
+
+    // Population Form
+
+    await waitFor(() => {
+      expect(getByRole("button", { name: "Next" })).toBeEnabled();
+    });
+    userEvent.click(await getByRole("button", { name: "Next" }));
+
+    // Validations Form
+
+    userEvent.click(await findByRole("button", { name: "add-condition-row" }));
+
+    const row = await findByTestId("row-0");
+
+    const field = row.querySelector('div[label="Field"]');
+    const operator = row.querySelector('div[label="Operator"]');
+
+    userEvent.click(field);
+    const fieldOptions = await within(field).findByRole("listbox");
+    const emailFieldOption = within(fieldOptions).getByText("EMAIL");
+    userEvent.click(emailFieldOption);
+    const selectedField = fieldOptions.querySelector(".selected>span");
+    expect(within(selectedField).queryByText(/EMAIL/)).toBeInTheDocument();
+
+    userEvent.click(operator);
+    const operatorOptions = await within(operator).findByRole("listbox");
+    const uniqueAcrossFieldsOperatorOption = within(operatorOptions).getByText(
+      "unique across fields"
+    );
+    userEvent.click(uniqueAcrossFieldsOperatorOption);
+    const selectedOperator = operatorOptions.querySelector(".selected>span");
+    expect(
+      within(selectedOperator).queryByText(/unique across fields/)
+    ).toBeInTheDocument();
+
+    const updatedRow = await findByTestId("row-0");
+    const value = updatedRow.querySelector('div[label="Value"]');
+    userEvent.click(value);
+    const valueOptions = await within(value).findByRole("listbox");
+    const valueEmailFieldOption = within(valueOptions).getByText("EMAIL");
+    const valuePhoneNumberFieldOption =
+      within(valueOptions).getByText("PHONE_NUMBER");
+
+    userEvent.click(valueEmailFieldOption);
+    userEvent.click(valuePhoneNumberFieldOption);
+
+    const selectedFieldValues = updatedRow.querySelectorAll(".label");
+
+    const selectedFieldTexts = [...selectedFieldValues].map(
+      (selectedFieldValue) => selectedFieldValue.text
+    );
+
+    expect(_.difference(selectedFieldTexts, ["EMAIL", "PHONE_NUMBER"])).toEqual(
+      []
+    );
+
+    await waitFor(() => {
+      expect(getByRole("button", { name: "Save" })).toBeEnabled();
+    });
+    userEvent.click(await getByRole("button", { name: "Save" }));
+
+    expect(dispatch).toHaveBeenCalledWith({
+      ...ruleImplementationLoaderActions.updateRuleImplementation(),
+      payload: { rule_implementation: expectedRuleImplementation },
+    });
+  });
 });