@truedat/dq 4.48.11 → 4.49.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.48.13] 2022-26-07
+
+### Fixed
+
+- [TD-5072] Edit quality rule was broken by 4.48.6
+
 ## [4.48.9] 2022-07-18
 
 ### Added
@@ -173,7 +179,7 @@
 
 ## [4.43.5] 2022-05-05
 
-# Added
+### Added
 
 - [TD-4538] Add more coding for segments configuration and segment results for
   implementations
@@ -193,13 +199,13 @@
 
 ## [4.43.1] 2022-04-28
 
-# Added
+### Added
 
 - [TD-4538] Add Segment configuration and segment results for implementations
 
 ## [4.43.0] 2022-04-26
 
-# Added
+### Added
 
 - [TD-3186] Support for linking Implementations and Structures
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.48.11",
+  "version": "4.49.0",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -93,8 +93,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.48.11",
-    "@truedat/df": "4.48.11",
+    "@truedat/core": "4.49.0",
+    "@truedat/df": "4.49.0",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -115,5 +115,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "c174776672b9079d23a00a6561db635d43cbeb32"
+  "gitHead": "7260126df6067fe59b11c5dc2b94dbdd881fed7b"
 }

package/src/components/ImplementationsRoutes.js

@@ -95,9 +95,9 @@ export const ImplementationsRoutes = ({
               ]}
               filter="all"
             />
-            {!structuresAliasesLoading && !systemsLoading && (
-              <NewRuleImplementation edition={false} />
-            )}
+            {!structuresAliasesLoading && !systemsLoading ? (
+              <NewRuleImplementation />
+            ) : null}
           </>
         )}
       />
@@ -114,9 +114,9 @@ export const ImplementationsRoutes = ({
               filter="all"
             />
             <TemplatesLoader scope="ri" />
-            {!structuresAliasesLoading && !systemsLoading && (
-              <NewRuleImplementation edition={false} implementationType="raw" />
-            )}
+            {!structuresAliasesLoading && !systemsLoading ? (
+              <NewRuleImplementation implementationType="raw" />
+            ) : null}
           </>
         )}
       />

package/src/components/NewRule.js

@@ -1,9 +1,9 @@
-import _ from "lodash/fp";
 import React from "react";
 import PropTypes from "prop-types";
+import { FormattedMessage } from "react-intl";
 import { connect } from "react-redux";
+import { useParams } from "react-router-dom";
 import { Container, Header, Icon, Segment } from "semantic-ui-react";
-import { FormattedMessage } from "react-intl";
 import { createRule } from "../routines";
 import RuleForm from "./RuleForm";
 
@@ -11,25 +11,41 @@ const DomainsLoader = React.lazy(() =>
   import("@truedat/bg/taxonomy/components/DomainsLoader")
 );
 
-export const NewRule = ({ rule, createRule }) => (
-  <Container as={Segment} text>
-    <Header as="h2">
-      <Icon name="wrench" />
-      <Header.Content>
-        {!_.isEmpty(rule) && <FormattedMessage id="rule.actions.create" />}
-        {_.isEmpty(rule) && <FormattedMessage id="rules.actions.create" />}
-      </Header.Content>
-    </Header>
-    <DomainsLoader actions="manage_quality_rule" />
-    <RuleForm onSubmit={createRule} />
-  </Container>
-);
+export const ConceptRuleForm = ({ createRule, concept }) => {
+  if (!concept?.business_concept_id) return null;
+  return <RuleForm concept={concept} onSubmit={createRule} />;
+};
+
+ConceptRuleForm.propTypes = {
+  createRule: PropTypes.func.isRequired,
+  concept: PropTypes.object,
+};
+
+export const NewRule = ({ createRule, concept }) => {
+  const { business_concept_id } = useParams();
+  return (
+    <Container as={Segment} text>
+      <Header as="h2">
+        <Icon name="wrench" />
+        <Header.Content>
+          <FormattedMessage id="rules.actions.create" />
+        </Header.Content>
+      </Header>
+      <DomainsLoader actions="manage_quality_rule" />
+      {business_concept_id ? (
+        <ConceptRuleForm concept={concept} createRule={createRule} />
+      ) : (
+        <RuleForm onSubmit={createRule} />
+      )}
+    </Container>
+  );
+};
 
 NewRule.propTypes = {
-  rule: PropTypes.object,
+  concept: PropTypes.object,
   createRule: PropTypes.func.isRequired,
 };
 
-const mapStateToProps = ({ rule }) => ({ rule });
+export const mapStateToProps = ({ concept }) => ({ concept });
 
 export default connect(mapStateToProps, { createRule })(NewRule);

package/src/components/NewRuleImplementation.js

@@ -244,10 +244,10 @@ const withConditionDefaultAlias = (conditions, structures) =>
   })(conditions);
 
 export const NewRuleImplementation = ({
-  clone,
+  clone = false,
   createRuleImplementation,
   updateRuleImplementation,
-  edition,
+  edition = false,
   rule,
   ruleImplementationProps,
   structuresFields,

package/src/components/Rule.js

@@ -10,7 +10,7 @@ import RuleSummary from "./RuleSummary";
 
 export const Rule = ({ rule, userRulePermissions, implementations }) => {
   return _.isEmpty(rule) ? null : (
-    <React.Fragment>
+    <>
       <Grid>
         <Grid.Column width={8}>
           <Header as="h2">
@@ -29,7 +29,7 @@ export const Rule = ({ rule, userRulePermissions, implementations }) => {
         </Grid.Column>
       </Grid>
       <RuleTabs />
-    </React.Fragment>
+    </>
   );
 };
 

package/src/components/RuleForm.js

@@ -82,7 +82,6 @@ export class RuleForm extends React.Component {
     domain_id: null,
     name: "",
     description: null,
-    type_params: {},
     df_name: "",
     df_content: {},
     template: null,
@@ -101,7 +100,11 @@ export class RuleForm extends React.Component {
         },
       });
     } else if (!_.isEmpty(concept)) {
-      this.setState({ concept });
+      this.setState({
+        business_concept_id: concept?.business_concept_id,
+        domain_id: concept?.domain_id,
+        concept,
+      });
     }
 
     this.updateDescription(description);
@@ -148,29 +151,16 @@ export class RuleForm extends React.Component {
     e.preventDefault();
     if (this.messagesInformed(this.generateValidationMessages())) return;
     const { onSubmit, match } = this.props;
-
-    const {
-      concept,
-      domain_id,
-      active,
-      description,
-      df_content,
-      df_name,
-      name,
-    } = this.state;
+    const rule = _.omit([
+      "activeSelection",
+      "concept",
+      "template",
+      "templatesLoading",
+      "valid",
+    ])(this.state);
 
     onSubmit({
-      rule: {
-        ...(concept?.business_concept_id && {
-          business_concept_id: concept?.business_concept_id,
-        }),
-        domain_id,
-        active,
-        description,
-        df_content,
-        df_name,
-        name,
-      },
+      rule,
       ids: match.params,
     });
   };
@@ -227,13 +217,10 @@ export class RuleForm extends React.Component {
     const { domain_id } = rule;
     const { concept, domainOptions } = this.props;
     const messages = this.generateValidationMessages();
-    const hasDomainSelected = _.flow(
-      _.reject((id) => _.isNil(id) || id === ""),
-      _.negate(_.isEmpty)
-    )([domain_id]);
-    const defaultFilters = !hasDomainSelected
-      ? filters
-      : { ...filters, domain_ids: [domain_id] };
+    const hasDomainSelected = !!domain_id;
+    const defaultFilters = hasDomainSelected
+      ? { ...filters, domain_ids: [domain_id] }
+      : filters;
 
     return (
       <>

package/src/components/RuleProperties.js

@@ -52,7 +52,7 @@ export const RuleProperties = ({
               <FormattedMessage id="quality.business_concept" />
             </List.Header>
             <Link
-              to={linkTo.CONCEPT_VERSION({
+              to={linkTo.CONCEPT_RULES({
                 business_concept_id,
                 id: "current",
               })}

package/src/components/RuleRoutes.js

@@ -10,7 +10,6 @@ import {
   RULE_EVENTS,
   RULE_IMPLEMENTATION_NEW,
   RULE_IMPLEMENTATION_NEW_RAW,
-  RULE_NEW,
   RULE_IMPLEMENTATIONS,
 } from "@truedat/core/routes";
 import {
@@ -18,7 +17,6 @@ import {
   getImplementationStructuresLoaded,
 } from "../selectors";
 import EditRule from "./EditRule";
-import NewRule from "./NewRule";
 import NewRuleImplementation from "./NewRuleImplementation";
 import Rule from "./Rule";
 import RuleCrumbs from "./RuleCrumbs";
@@ -57,113 +55,95 @@ export const RuleRoutes = ({
   systemsLoading,
   template,
   templatesLoaded,
-}) => {
-  return (
-    <>
-      <Route
-        exact
-        path={RULE_NEW}
-        render={() => (
-          <>
-            <DomainsLoader actions="manage_quality_rule" />
-            <NewRule />
-          </>
-        )}
-      />
-      <Route
-        path={RULE}
-        render={() => (
-          <>
-            <RuleLoader />
-            <Route
-              exact
-              path={RULE}
-              render={() => (
-                <>
-                  <RuleCrumbs />
-                  <Segment>
-                    <RuleSubscriptionLoader />
-                    <QualityTemplatesLoader />
-                    <RuleImplementationsFromRuleLoader />
-                    {ruleLoaded ? <Rule /> : null}
-                    {ruleLoaded ? <RuleProperties /> : null}
-                    {templatesLoaded && template ? (
-                      <DynamicFormViewer
-                        template={template}
-                        content={rule.df_content}
-                      />
-                    ) : null}
-                  </Segment>
-                </>
-              )}
-            />
-
-            <Route
-              exact
-              path={RULE_EDIT}
-              render={() => (
-                <>
-                  <DomainsLoader actions="manage_quality_rule" />
-                  <EditRule />
-                </>
-              )}
-            />
-            <Route
-              exact
-              path={RULE_EVENTS}
-              render={() => (
-                <>
-                  <RuleCrumbs />
-                  <Segment>
-                    <RuleEventsLoader />
-                    {ruleLoaded ? <Rule /> : null}
-                    {ruleLoaded ? <RuleEvents /> : null}
-                  </Segment>
-                </>
-              )}
-            />
-            <Route
-              exact
-              path={RULE_IMPLEMENTATIONS}
-              render={() => (
-                <>
-                  <RuleCrumbs />
-                  <Segment>
-                    <RuleSubscriptionLoader />
-                    <RuleImplementationsFromRuleLoader />
-                    {ruleLoaded ? <Rule /> : null}
-                    {ruleLoaded ? <RuleFormImplementations /> : null}
-                  </Segment>
-                </>
-              )}
-            />
-            <Route
-              exact
-              path={RULE_IMPLEMENTATION_NEW}
-              render={() =>
-                structuresAliasesLoading || systemsLoading ? null : (
-                  <NewRuleImplementation edition={false} />
-                )
-              }
-            />
-            <Route
-              exact
-              path={RULE_IMPLEMENTATION_NEW_RAW}
-              render={() =>
-                structuresAliasesLoading || systemsLoading ? null : (
-                  <NewRuleImplementation
-                    edition={false}
-                    implementationType="raw"
+}) => (
+  <Route
+    path={RULE}
+    render={() => (
+      <>
+        <RuleLoader />
+        <Route
+          exact
+          path={RULE}
+          render={() => (
+            <>
+              <RuleCrumbs />
+              <Segment>
+                <RuleSubscriptionLoader />
+                <QualityTemplatesLoader />
+                <RuleImplementationsFromRuleLoader />
+                {ruleLoaded ? <Rule /> : null}
+                {ruleLoaded ? <RuleProperties /> : null}
+                {templatesLoaded && template ? (
+                  <DynamicFormViewer
+                    template={template}
+                    content={rule.df_content}
                   />
-                )
-              }
-            />
-          </>
-        )}
-      />
-    </>
-  );
-};
+                ) : null}
+              </Segment>
+            </>
+          )}
+        />
+        <Route
+          exact
+          path={RULE_EDIT}
+          render={() => (
+            <>
+              <DomainsLoader actions="manage_quality_rule" />
+              <EditRule />
+            </>
+          )}
+        />
+        <Route
+          exact
+          path={RULE_EVENTS}
+          render={() => (
+            <>
+              <RuleCrumbs />
+              <Segment>
+                <RuleEventsLoader />
+                {ruleLoaded ? <Rule /> : null}
+                {ruleLoaded ? <RuleEvents /> : null}
+              </Segment>
+            </>
+          )}
+        />
+        <Route
+          exact
+          path={RULE_IMPLEMENTATIONS}
+          render={() => (
+            <>
+              <RuleCrumbs />
+              <Segment>
+                <RuleSubscriptionLoader />
+                <RuleImplementationsFromRuleLoader />
+                {ruleLoaded ? <Rule /> : null}
+                {ruleLoaded ? <RuleFormImplementations /> : null}
+              </Segment>
+            </>
+          )}
+        />
+        <Route
+          exact
+          path={RULE_IMPLEMENTATION_NEW}
+          render={() =>
+            structuresAliasesLoading || systemsLoading ? null : (
+              <NewRuleImplementation />
+            )
+          }
+        />
+        <Route
+          exact
+          path={RULE_IMPLEMENTATION_NEW_RAW}
+          render={() =>
+            structuresAliasesLoading || systemsLoading ? null : (
+              <NewRuleImplementation implementationType="raw" />
+            )
+          }
+        />
+      </>
+    )}
+  />
+);
 
 RuleRoutes.propTypes = {
   rule: PropTypes.object,

package/src/components/RulesRoutes.js

@@ -29,16 +29,7 @@ const RulesRoutes = () => (
       )}
     />
     <Switch>
-      <Route
-        exact
-        path={RULE_NEW}
-        render={() => (
-          <>
-            <DomainsLoader actions="manage_quality_rule" />
-            <NewRule />
-          </>
-        )}
-      />
+      <Route exact path={RULE_NEW} render={() => <NewRule />} />
       <Route path={RULE} render={() => <RuleRoutes />} />
     </Switch>
   </>

package/src/components/__tests__/NewRule.spec.js

@@ -1,14 +1,18 @@
 import React from "react";
-import { shallow } from "enzyme";
-import { NewRule } from "../NewRule";
+import { waitFor } from "@testing-library/react";
+import { render } from "@truedat/test/render";
+import NewRule from "../NewRule";
 
-describe("<NewRule />", () => {
-  const createRule = jest.fn();
-  const rule = { id: 1, name: "nn", description: "dd" };
-  const props = { rule, createRule };
+const state = {
+  concept: { business_concept_id: 123, domain_id: 22 },
+  conceptActiveFilters: {},
+};
+const renderOpts = { fallback: "lazy", state };
 
-  it("matches the latest snapshot", () => {
-    const wrapper = shallow(<NewRule {...props} />);
-    expect(wrapper).toMatchSnapshot();
+describe("<NewRule />", () => {
+  it("matches the latest snapshot (with concept)", async () => {
+    const { container, queryByText } = render(<NewRule />, renderOpts);
+    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
+    expect(container).toMatchSnapshot();
   });
 });

package/src/components/__tests__/Rules.spec.js

@@ -11,7 +11,6 @@ describe("<Rules />", () => {
       name: "control1",
       description: "desc1",
       type: "type1",
-      type_params: {},
       status: "status1",
     },
     {
@@ -20,7 +19,6 @@ describe("<Rules />", () => {
       name: "control2",
       description: "desc2",
       type: "type2",
-      type_params: {},
       status: "status2",
     },
   ];

package/src/components/__tests__/__snapshots__/NewRule.spec.js.snap

@@ -1,28 +1,339 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<NewRule /> matches the latest snapshot 1`] = `
-<Container
-  as={[Function]}
-  text={true}
->
-  <Header
-    as="h2"
+exports[`<NewRule /> matches the latest snapshot (with concept) 1`] = `
+<div>
+  <div
+    class="ui segment ui text container"
+    style=""
   >
-    <Icon
-      as="i"
-      name="wrench"
-    />
-    <HeaderContent>
-      <MemoizedFormattedMessage
-        id="rule.actions.create"
+    <h2
+      class="ui header"
+    >
+      <i
+        aria-hidden="true"
+        class="wrench icon"
       />
-    </HeaderContent>
-  </Header>
-  <lazy
-    actions="manage_quality_rule"
-  />
-  <withRouter(injectIntl(Connect(RuleForm)))
-    onSubmit={[MockFunction]}
-  />
-</Container>
+      <div
+        class="content"
+      >
+        New Quality Rule
+      </div>
+    </h2>
+    <form
+      class="ui form rule-form"
+    >
+      <div
+        class="field rule-form__field-right"
+      >
+        <div
+          class="ui checked toggle checkbox"
+        >
+          <input
+            checked=""
+            class="hidden"
+            name="active"
+            readonly=""
+            tabindex="0"
+            type="radio"
+            value=""
+          />
+          <label>
+            Active
+          </label>
+        </div>
+      </div>
+      <div
+        class="field"
+      >
+        <label
+          class="rule-form-label"
+        >
+          Name
+          <span>
+            *
+          </span>
+          <div
+            class="ui left pointing label"
+          >
+            Required field is empty
+          </div>
+        </label>
+        <div
+          class="field"
+        >
+          <div
+            class="ui input"
+          >
+            <input
+              aria-label="Rule name"
+              autocomplete="off"
+              name="name"
+              placeholder="Rule name"
+              type="text"
+              value=""
+            />
+          </div>
+        </div>
+      </div>
+      <div
+        class="field"
+      >
+        <label
+          class="rule-form-label"
+        >
+          Description
+        </label>
+        <div>
+          <div
+            style="border: 1px solid rgba(34, 36, 38, 0.15); border-radius: 0.28571429rem;"
+          >
+            <div
+              class="ui menu"
+            >
+              <div
+                class="disabled icon item"
+              >
+                <i
+                  aria-hidden="true"
+                  class="bold icon"
+                />
+              </div>
+              <div
+                class="disabled icon item"
+              >
+                <i
+                  aria-hidden="true"
+                  class="italic icon"
+                />
+              </div>
+              <div
+                class="disabled icon item"
+              >
+                <i
+                  aria-hidden="true"
+                  class="underline icon"
+                />
+              </div>
+              <div
+                class="disabled icon item"
+              >
+                <i
+                  aria-hidden="true"
+                  class="header icon"
+                />
+              </div>
+              <div
+                class="disabled icon item"
+              >
+                <i
+                  aria-hidden="true"
+                  class="h icon"
+                />
+              </div>
+              <div
+                class="disabled icon item"
+              >
+                <i
+                  aria-hidden="true"
+                  class="list ol icon"
+                />
+              </div>
+              <div
+                class="disabled icon item"
+              >
+                <i
+                  aria-hidden="true"
+                  class="list ul icon"
+                />
+              </div>
+              <div
+                class="disabled icon item"
+              >
+                <i
+                  aria-hidden="true"
+                  class="linkify icon"
+                />
+              </div>
+            </div>
+            <div
+              style="padding: 10px;"
+            >
+              <div
+                autocorrect="on"
+                contenteditable="true"
+                data-gramm="false"
+                data-key="0"
+                data-slate-editor="true"
+                role="textbox"
+                spellcheck="true"
+                style="outline: none; white-space: pre-wrap; word-wrap: break-word;"
+              >
+                <div
+                  data-key="1"
+                  data-slate-object="block"
+                  style="position: relative;"
+                >
+                  <span
+                    data-key="3"
+                    data-slate-object="text"
+                  >
+                    <span
+                      data-offset-key="3:0"
+                      data-slate-leaf="true"
+                    >
+                      <span>
+                        <span
+                          contenteditable="false"
+                          style="pointer-events: none; display: inline-block; width: 0px; max-width: 100%; white-space: nowrap; opacity: 0.333; vertical-align: text-top;"
+                        />
+                        <span
+                          data-slate-length="0"
+                          data-slate-zero-width="n"
+                        >
+                          
+                          <br />
+                        </span>
+                      </span>
+                    </span>
+                  </span>
+                </div>
+              </div>
+            </div>
+          </div>
+        </div>
+      </div>
+      <div
+        class="field"
+      >
+        <label
+          class="rule-form-label"
+        >
+          Domain
+          <span>
+            *
+          </span>
+        </label>
+        <div
+          class="field"
+        >
+          <div
+            class="field"
+          >
+            <div
+              aria-expanded="false"
+              class="ui fluid search selection dropdown"
+              name="domain"
+              role="combobox"
+            >
+              <input
+                aria-autocomplete="list"
+                autocomplete="off"
+                class="search"
+                tabindex="0"
+                type="text"
+                value=""
+              />
+              <div
+                aria-atomic="true"
+                aria-live="polite"
+                class="divider text"
+                role="alert"
+              >
+                Select a domain...
+              </div>
+              <i
+                aria-hidden="true"
+                class="dropdown icon clear"
+              />
+              <div
+                aria-multiselectable="false"
+                class="menu transition"
+                role="listbox"
+              >
+                <div
+                  class="message"
+                >
+                  No results found.
+                </div>
+              </div>
+            </div>
+          </div>
+        </div>
+      </div>
+      <div
+        class="required field"
+      >
+        <label>
+          Template
+          <div
+            class="ui left pointing label"
+          >
+            Empty required field
+          </div>
+        </label>
+        <div
+          class="field"
+        >
+          <div
+            aria-busy="true"
+            aria-expanded="false"
+            class="ui loading search selection dropdown"
+            name="template"
+            role="combobox"
+          >
+            <input
+              aria-autocomplete="list"
+              autocomplete="off"
+              class="search"
+              tabindex="0"
+              type="text"
+              value=""
+            />
+            <div
+              aria-atomic="true"
+              aria-live="polite"
+              class="divider default text"
+              role="alert"
+            >
+              loading...
+            </div>
+            <i
+              aria-hidden="true"
+              class="dropdown icon"
+            />
+            <div
+              class="menu transition"
+              role="listbox"
+            >
+              <div
+                class="message"
+              >
+                No results found.
+              </div>
+            </div>
+          </div>
+        </div>
+      </div>
+      <div
+        class="actions"
+      >
+        <a
+          class="ui secondary button"
+          href="/"
+          role="button"
+        >
+          Cancel
+        </a>
+        <button
+          class="ui primary disabled button"
+          disabled=""
+          tabindex="-1"
+          type="submit"
+        >
+          Save
+        </button>
+      </div>
+    </form>
+  </div>
+</div>
 `;

package/src/components/__tests__/__snapshots__/Rules.spec.js.snap

@@ -101,7 +101,6 @@ exports[`<Rules /> matches the latest snapshot 1`] = `
             "name": "control1",
             "status": "status1",
             "type": "type1",
-            "type_params": Object {},
           }
         }
       />
@@ -144,7 +143,6 @@ exports[`<Rules /> matches the latest snapshot 1`] = `
             "name": "control2",
             "status": "status2",
             "type": "type2",
-            "type_params": Object {},
           }
         }
       />

package/src/messages/en.js

@@ -135,7 +135,6 @@ export default {
   "quality.threshold": "Threshold",
   "quality.thresholds": "Limits",
   "quality.type": "Type",
-  "quality.type_params": "Params",
   "quality_result.no_execution": "Not executed",
   "quality_result.over_goal": "Over goal",
   "quality_result.under_goal": "Under goal",
@@ -232,8 +231,6 @@ export default {
   "rule.props.name.placeholder": "Rule name",
   "rule.props.type": "Rule Type",
   "rule.props.type.placeholder": "Values range",
-  "rule.props.type_params": "Parameters",
-  "rule.props.type_params.placeholder": "Parameters",
   "rule.ruleImplementation.results.empty":
     "No results found for current implementation",
   "rule.ruleImplementation.results.details.empty":
@@ -256,12 +253,6 @@ export default {
   "rule.type.min_value": "Has a minimum value",
   "rule.type.numeric_format": "Has a numeric format",
   "rule.type.unique_values": "Has unique values",
-  "rule.type_params.error.max_date.cast.date": "Max date invalid",
-  "rule.type_params.error.max_date.must.be.greater.than.or.equal.to.min_date":
-    "Date not valid",
-  "rule.type_params.error.max_date.required": "Max date required",
-  "rule.type_params.error.min_date.cast.date": "Min date invalid",
-  "rule.type_params.error.min_date.required": "Min date required",
   "rule.values_list": "List values",
   "ruleImplementation.action.deprecate": "deprecated",
   "ruleImplementation.actions.clone": "Clone implementation",

package/src/messages/es.js

@@ -143,7 +143,6 @@ export default {
   "quality.template": "Plantilla",
   "quality.threshold": "Umbral",
   "quality.thresholds": "Umbrales",
-  "quality.type_params": "Parámetros",
   "quality.type": "Tipo",
   "remediation": "Plan de remediación",
   "remediation.actions.create": "Crear plan de remediación",
@@ -212,8 +211,6 @@ export default {
   "rule.props.implementations": "Implementaciones",
   "rule.props.name.placeholder": "Nombre de la regla",
   "rule.props.name": "Nombre",
-  "rule.props.type_params.placeholder": "Parametros a cumplimentar",
-  "rule.props.type_params": "Parametros",
   "rule.props.type": "Tipo de regla",
   "rule.props.type.placeholder": "Rango de valores",
   "rule.ruleImplementation.results.details.empty":
@@ -222,12 +219,6 @@ export default {
     "No existen resultados para esta implementación",
   "rule.ruleImplementations.empty":
     "No existen reglas de implementación de esta regla",
-  "rule.type_params.error.max_date.cast.date": "Fecha máxima inválida",
-  "rule.type_params.error.max_date.must.be.greater.than.or.equal.to.min_date":
-    "Fecha no valida",
-  "rule.type_params.error.max_date.required": "Fecha máxima requerida",
-  "rule.type_params.error.min_date.cast.date": "Fecha mínima inválida",
-  "rule.type_params.error.min_date.required": "Fecha mínima requerida",
   "rule.type.custom_validation": "Es una validación a medida",
   "rule.type.date_format": "Tiene formato de fecha",
   "rule.type.dates_range": "Pertenece a un rango de fechas",

package/src/reducers/rule.js

@@ -4,19 +4,18 @@ import { clearRule, fetchRule } from "../routines";
 const initialState = {};
 
 const pickFields = _.pick([
-  "id",
   "active",
   "business_concept_id",
+  "current_business_concept_version",
   "deleted_at",
+  "description",
+  "df_content",
+  "df_name",
   "domain",
   "domain_id",
-  "current_business_concept_version",
+  "id",
   "name",
-  "description",
   "system_values",
-  "type_params",
-  "df_name",
-  "df_content",
 ]);
 
 const rule = (state = initialState, { type, payload }) => {
@@ -24,7 +23,7 @@ const rule = (state = initialState, { type, payload }) => {
     case fetchRule.TRIGGER:
       return initialState;
     case fetchRule.SUCCESS:
-      return pickFields(payload.data) || {};
+      return pickFields(payload.data) || initialState;
     case clearRule.TRIGGER:
       return initialState;
     default:

package/src/reducers/rules.js

@@ -4,18 +4,18 @@ import { fetchRules } from "../routines";
 const initialState = [];
 
 const pickFields = _.pick([
-  "id",
-  "current_business_concept_version",
-  "domain",
+  "active",
   "business_concept_id",
+  "current_business_concept_version",
   "deleted_at",
-  "name",
   "description",
+  "df_content",
+  "df_name",
+  "domain",
   "goal",
+  "id",
   "minimum",
-  "type_params",
-  "active",
-  "df_content",
+  "name",
   "result_type",
 ]);
 

package/src/sagas/createRule.js

@@ -6,13 +6,12 @@ import { API_RULES } from "../api";
 
 export function* createRuleSaga({ payload }) {
   try {
-    const { rule, ids } = payload;
+    const { rule } = payload;
     const url = API_RULES;
     const requestData = { rule };
-    const meta = { bc_id: _.prop("id")(ids) };
-    yield put({ meta, ...createRule.request() });
+    yield put(createRule.request());
     const { data } = yield call(apiJsonPost, url, requestData, JSON_OPTS);
-    yield put({ meta, ...createRule.success(data) });
+    yield put(createRule.success(data));
   } catch (error) {
     if (error.response) {
       const { status, data } = error.response;

package/src/selectors/ruleColumnsSelector.js

@@ -56,11 +56,6 @@ export const optionalRuleColumns = [
     name: "active",
     fieldDecorator: (field) => translateDecorator(`quality.active.${field}`),
   },
-  {
-    name: "params",
-    fieldSelector: _.prop("type_params"),
-    fieldDecorator: dynamicDecorator,
-  },
   {
     name: "template",
     fieldSelector: _.prop("df_content"),