@truedat/dq 4.47.9 → 4.48.2

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # Changelog
 
+## [4.48.2] 2022-07-08
+
+### Changed
+
+- [TD-4995] Support localization of template fields and fixed values
+
+## [4.48.1] 2022-07-07
+
+### Added
+
+- [TD-4945] User with permission can save or published on edition
+
+## [4.48.0] 2022-07-07
+
+### Added
+
+- [TD-4925] Add info messages on implementation updates
+  (like 'implementation unchanged')
+
 ## [4.47.9] 2022-07-05
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.47.9",
+  "version": "4.48.2",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -88,8 +88,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.47.9",
-    "@truedat/df": "4.47.9",
+    "@truedat/core": "4.48.2",
+    "@truedat/df": "4.48.2",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -110,5 +110,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "21954b7a0ea8240d2a9e8dc5014372eceed3b047"
+  "gitHead": "93133e957332713e64c97eecdf45cc283c29bd32"
 }

package/src/components/__tests__/__snapshots__/RemediationPlan.spec.js.snap

@@ -31,9 +31,13 @@ exports[`<RemediationPlan /> matches the latest snapshot 1`] = `
         class="ui negative message"
       >
         <div
-          class="header"
+          class="content"
         >
-          Error: Invalid template
+          <div
+            class="header"
+          >
+            Error: Invalid template
+          </div>
         </div>
       </div>
     </div>

package/src/components/ruleImplementationForm/RuleImplementationForm.js

@@ -207,10 +207,9 @@ export const RuleImplementationForm = ({
     return _.prop("isValid")(_.nth(index)(steps))();
   };
 
-  const doSubmit = () => {
+  const doSubmit = (params) => {
     if (_.every((s) => _.prop("isValid")(s)())(steps)) {
-      const canPublish = !!actions?.publish;
-      onSubmit(canPublish ? { status: "published" } : {});
+      onSubmit(params);
     }
   };
 
@@ -309,21 +308,40 @@ export const RuleImplementationForm = ({
       </Grid.Row>
       <Divider hidden />
       <Grid.Row stretched>
-        <Button
-          floated="right"
-          disabled={isButtonDisabled(activeStep)}
-          type="submit"
-          primary
-          loading={isSubmitting}
-          onClick={() =>
-            getNextStep(activeStep) ? setNextStep(activeStep) : doSubmit()
-          }
-          content={
-            getNextStep(activeStep)
-              ? formatMessage({ id: "actions.next" })
-              : formatMessage({ id: "actions.save" })
-          }
-        />
+        {getNextStep(activeStep) == null ? (
+          <>
+            {!!actions?.publish ? (
+              <Button
+                floated="right"
+                disabled={isButtonDisabled(activeStep)}
+                type="submit"
+                primary
+                loading={isSubmitting}
+                onClick={() => doSubmit({ status: "published" })}
+                content={formatMessage({ id: "actions.publish" })}
+              />
+            ) : null}
+            <Button
+              floated="right"
+              disabled={isButtonDisabled(activeStep)}
+              type="submit"
+              primary
+              loading={isSubmitting}
+              onClick={() => doSubmit({})}
+              content={formatMessage({ id: "actions.save" })}
+            />
+          </>
+        ) : (
+          <Button
+            floated="right"
+            disabled={isButtonDisabled(activeStep)}
+            type="submit"
+            primary
+            loading={isSubmitting}
+            onClick={() => setNextStep(activeStep)}
+            content={formatMessage({ id: "actions.next" })}
+          />
+        )}
         <Button
           floated="right"
           secondary

package/src/messages/en.js

@@ -551,6 +551,7 @@ export default {
   "ruleImplementations.summary.headers.populations": "Populations",
   "ruleImplementations.summary.headers.segments": "Segments",
   "ruleImplementations.summary.headers.validations": "Validation",
+  "ruleImplementations.update.success.header.implementation_unchanged": "The implementation has not changed",
   "ruleImplementations.upload.success.errors":
     "Error in {implementation_key} attribute: {key} message: {message} ",
   "ruleImplementations.upload.success.header":

package/src/messages/es.js

@@ -570,6 +570,7 @@ export default {
   "ruleImplementations.summary.headers.populations": "Poblaciones",
   "ruleImplementations.summary.headers.segments": "Segmentos",
   "ruleImplementations.summary.headers.validations": "Validaciones",
+  "ruleImplementations.update.success.header.implementation_unchanged": "La implementación no ha cambiado",
   "ruleImplementations.upload.success.errors":
     "Error en {name} atributo: {key} mensaje: {message} ",
   "ruleImplementations.upload.success.header":

package/src/reducers/dqMessage.js

@@ -5,6 +5,7 @@ import {
   uploadImplementations,
   uploadResults,
   fetchRemediation,
+  updateRuleImplementation,
 } from "../routines";
 
 const initialState = {};
@@ -133,6 +134,15 @@ const dqMessage = (state = initialState, { type, payload }) => {
       }
     case fetchRemediation.FAILURE:
       return { error: false };
+    case updateRuleImplementation.SUCCESS:
+      if (_.has("message")(payload)) {
+        return {
+          error: false,
+          header: `ruleImplementations.update.success.header.${payload.message}`,
+          icon: "attention",
+          color: "blue",
+        };
+      }
     default:
       return state;
   }

package/src/components/DropdownI18n.js

@@ -1,92 +0,0 @@
-import _ from "lodash/fp";
-import React from "react";
-import PropTypes from "prop-types";
-import { Form } from "semantic-ui-react";
-import { useIntl } from "react-intl";
-
-const toOptions = (
-  formatMessage,
-  property,
-  translateValues,
-  sortBy
-) => values =>
-  _.flow(
-    _.map(v => ({
-      text: formatMessage({ id: `${property}.${v}`, defaultMessage: v }),
-      value: v
-    })),
-    sortBy ? _.sortBy(sortBy) : _.identity,
-    _.map(translateValues ? ({ text }) => ({ text, value: text }) : _.identity),
-    _.map.convert({ cap: false })(({ text, value }, key) => ({
-      key,
-      text,
-      value
-    }))
-  )(values);
-
-export const DropdownI18n = ({
-  allowAdditions,
-  basic,
-  label,
-  multiple,
-  name,
-  onAddItem,
-  onChange,
-  property,
-  required,
-  search,
-  selection,
-  sortBy,
-  translateValues = false,
-  value,
-  values
-}) => {
-  const { formatMessage } = useIntl();
-  return (
-    <Form.Dropdown
-      allowAdditions={allowAdditions}
-      basic={basic}
-      label={
-        label ? formatMessage({ id: label, defaultMessage: label }) : false
-      }
-      multiple={multiple}
-      name={name}
-      onAddItem={onAddItem}
-      onChange={onChange}
-      options={toOptions(
-        formatMessage,
-        property,
-        translateValues,
-        sortBy
-      )(values)}
-      placeholder={formatMessage({
-        id: `${property}.placeholder`,
-        defaultMessage: " "
-      })}
-      required={required}
-      search={search}
-      selection={selection}
-      value={value}
-    />
-  );
-};
-
-DropdownI18n.propTypes = {
-  allowAdditions: PropTypes.bool,
-  basic: PropTypes.bool,
-  label: PropTypes.oneOfType([PropTypes.string, PropTypes.bool]),
-  multiple: PropTypes.bool,
-  name: PropTypes.string,
-  onAddItem: PropTypes.func,
-  onChange: PropTypes.func,
-  property: PropTypes.string,
-  required: PropTypes.bool,
-  search: PropTypes.bool,
-  selection: PropTypes.bool,
-  sortBy: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
-  translateValues: PropTypes.bool,
-  value: PropTypes.string,
-  values: PropTypes.arrayOf(PropTypes.string)
-};
-
-export default DropdownI18n;

package/src/components/__tests__/DropdownI18n.spec.js

@@ -1,31 +0,0 @@
-import React from "react";
-import { shallow } from "enzyme";
-import { intl } from "@truedat/test/intl-stub";
-import { DropdownI18n } from "../DropdownI18n";
-
-// workaround for enzyme issue with React.useContext
-// see https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526
-jest.spyOn(React, "useContext").mockImplementation(() => intl);
-
-describe("<DropdownI18n />", () => {
-  const props = {
-    allowAdditions: true,
-    basic: true,
-    label: "label",
-    multiple: true,
-    name: "name",
-    onChange: jest.fn(),
-    onAddItem: jest.fn(),
-    options: ["foo", "bar", "baz"],
-    property: "some.i18n.prop",
-    required: true,
-    search: true,
-    selection: true,
-    value: "foo"
-  };
-
-  it("matches the latest snapshot", () => {
-    const wrapper = shallow(<DropdownI18n {...props} />);
-    expect(wrapper).toMatchSnapshot();
-  });
-});

package/src/components/__tests__/__snapshots__/DropdownI18n.spec.js.snap

@@ -1,21 +0,0 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
-
-exports[`<DropdownI18n /> matches the latest snapshot 1`] = `
-<FormDropdown
-  allowAdditions={true}
-  as={[Function]}
-  basic={true}
-  control={[Function]}
-  label="label"
-  multiple={true}
-  name="name"
-  onAddItem={[MockFunction]}
-  onChange={[MockFunction]}
-  options={Array []}
-  placeholder=" "
-  required={true}
-  search={true}
-  selection={true}
-  value="foo"
-/>
-`;