@truedat/dq 4.47.5 → 4.47.8

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [4.47.6] 2022-07-01
+
+### Fixed
+
+- [TD-4993]
+  - RuleImplementationForm visibility with correct permissions
+  - Show quality event errors on results view using graphql
+  - Add exclusive subscription events
+
 ## [4.47.5] 2022-06-30
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.47.5",
+  "version": "4.47.8",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.16.4",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.47.5",
+    "@truedat/test": "4.47.8",
     "babel-jest": "^28.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -88,8 +88,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.47.5",
-    "@truedat/df": "4.47.5",
+    "@truedat/core": "4.47.8",
+    "@truedat/df": "4.47.8",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -110,5 +110,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "1265272aa7b8fcb415592916f0e557ae226befe3"
+  "gitHead": "dccc0d92c419a5ee257a8e15b64c1b98d909809a"
 }

package/src/api/queries.js

@@ -20,6 +20,11 @@ export const IMPLEMENTATION_RESULTS = gql`
     implementation(id: $id) {
       id
       implementation_key
+      last_quality_event {
+        inserted_at
+        message
+        type
+      }
       versions {
         id
         implementation_key

package/src/components/NewRuleImplementation.js

@@ -4,8 +4,6 @@ import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { Divider, Header, Grid } from "semantic-ui-react";
 import { FormattedMessage } from "react-intl";
-import { gql, useQuery } from "@apollo/client";
-import { Loading } from "@truedat/core/components";
 import { getFieldType } from "@truedat/core/services/fieldType";
 import {
   createRuleImplementation,
@@ -248,8 +246,6 @@ export const NewRuleImplementation = ({
   edition,
   rule,
   ruleImplementationProps,
-  sources,
-  sourcesLoading,
   structuresFields,
   structuresSiblings,
   operators,
@@ -458,8 +454,9 @@ export const NewRuleImplementation = ({
   const setImplementationKey = (implementationKey) =>
     setRuleImplementation({ ...ruleImplementation, implementationKey });
 
-  const setImplementationRawContent = (rawContent) =>
+  const setImplementationRawContent = (rawContent) => {
     setRuleImplementation({ ...ruleImplementation, rawContent });
+  };
 
   const doSubmit = (props = {}) => {
     const populations = _.reject(_.isEmpty)(ruleImplementation.populations);
@@ -467,8 +464,6 @@ export const NewRuleImplementation = ({
     const segments = _.reject(_.isEmpty)(ruleImplementation.segments);
 
     const raw_content = _.prop("rawContent")(ruleImplementation);
-    const source_id = _.prop("source_id")(raw_content);
-    const source = _.find({ id: source_id })(sources);
 
     const rule_implementation =
       ruleImplementation.implementationType == "raw"
@@ -479,7 +474,7 @@ export const NewRuleImplementation = ({
             df_name: ruleImplementation?.dfName,
             df_content: ruleImplementation?.dfContent,
             rule_id: rule ? rule.id : ruleImplementation.rule_id,
-            raw_content: { ...raw_content, source },
+            raw_content: { ...raw_content },
             result_type: ruleImplementation.result_type,
             minimum: ruleImplementation.minimum,
             goal: ruleImplementation.goal,
@@ -546,8 +541,6 @@ export const NewRuleImplementation = ({
               ruleImplementation={ruleImplementation}
               onChange={onChange}
               onSubmit={doSubmit}
-              sources={sources}
-              sourcesLoading={sourcesLoading}
             />
           ) : (
             <RuleImplementationForm
@@ -583,39 +576,11 @@ NewRuleImplementation.propTypes = {
   operators: PropTypes.object,
   rule: PropTypes.object,
   ruleImplementationProps: PropTypes.object,
-  sources: PropTypes.array,
-  sourcesLoading: PropTypes.bool,
   structuresFields: PropTypes.object,
   structuresSiblings: PropTypes.object,
   updateRuleImplementation: PropTypes.func,
 };
 
-export const SOURCES_WITH_CONFIG = gql`
-  query SOURCES_WITH_CONFIG($jobTypes: String) {
-    sources(jobTypes: $jobTypes) {
-      id
-      externalId
-      config
-    }
-  }
-`;
-
-export const NewRuleImplementationLoader = (props) => {
-  const { data, error, loading } = useQuery(SOURCES_WITH_CONFIG, {
-    variables: { jobTypes: "quality" },
-  });
-  if (error) return null;
-  if (loading) return <Loading />;
-  const sources = data?.sources || [];
-  return (
-    <NewRuleImplementation
-      sources={sources}
-      sourcesLoading={loading}
-      {...props}
-    />
-  );
-};
-
 const mapStateToProps = (state) => ({
   rule: state.rule,
   ruleImplementationProps: {
@@ -631,4 +596,4 @@ const mapStateToProps = (state) => ({
 export default connect(mapStateToProps, {
   createRuleImplementation,
   updateRuleImplementation,
-})(NewRuleImplementationLoader);
+})(NewRuleImplementation);

package/src/components/RuleImplementationResults.js

@@ -46,9 +46,11 @@ export const RuleImplementationResults = ({
     formatMessage,
   };
 
+  const { last_quality_event } = ruleImplementation;
+
   return (
     <>
-      {ruleImplementation.event_type === "FAILED" ? (
+      {last_quality_event?.type === "FAILED" ? (
         <Message negative style={{ marginTop: "14px" }}>
           <Message.Header>
             {formatMessage({
@@ -63,7 +65,7 @@ export const RuleImplementationResults = ({
               right: "21px",
             }}
             locale={locale}
-            date={ruleImplementation.event_inserted_at}
+            date={last_quality_event.inserted_at}
             format="YYYY-MM-DD HH:mm"
           />
           <p
@@ -71,7 +73,7 @@ export const RuleImplementationResults = ({
               whiteSpace: "pre-wrap",
             }}
           >
-            {ruleImplementation.event_message}
+            {last_quality_event.message}
           </p>
         </Message>
       ) : null}

package/src/components/__test_samples__/{newRuleImplementationLoader.js → newRuleImplementationHelper.js}

@@ -956,272 +956,272 @@ const ruleImplementationOperators = {
   },
 };
 
-export const sourcesRuleImplementationLoader = [
-  {
-    __typename: "Source",
-    id: "190",
-    externalId: "Redshift",
-    config: {
-      alias: "Redshift",
-      databases: ["dev"],
-      domain: {
-        external_id: "Truedat",
-        id: 2,
-        name: "Truedat",
-        parent_id: null,
-        updated_at: "2020-07-28 13:21:21.938189Z",
-      },
-      host: "redshift-cluster-1.czitmavv4gjx.eu-west-1.redshift.amazonaws.com",
-      job_types: ["quality", "profile", "catalog"],
-      port: "5439",
-      system: {
-        external_id: "Redshift",
-        id: 139,
-        name: "Redshift",
-      },
-      user: "awsuser",
-    },
-  },
-  {
-    __typename: "Source",
-    id: "178",
-    externalId: "test_athena",
-    config: {
-      aliases: ["asd", "glue"],
-      aws_region: "eu-west-1",
-      aws_role_arn: "",
-      job_types: ["profile", "quality"],
-      output_location: "",
-      workgroup: "primary",
-    },
-  },
-  {
-    __typename: "Source",
-    id: "187",
-    externalId: "postgres-temp",
-    config: {
-      alias: "postgres-temp",
-      blacklist_schemas: [],
-      databases: ["prueba", "postgres"],
-      domain: {
-        external_id: "Truedat",
-        id: 2,
-        name: "Truedat",
-        parent_id: null,
-        updated_at: "2020-07-28 13:21:21.938189Z",
-      },
-      host: "localhost",
-      job_types: ["profile", "quality", "catalog"],
-      password: "yourStrong(!)Password",
-      port: "5432",
-      system: {
-        external_id: "Postgres-Test",
-        id: 106,
-        name: "Postgres-Test",
-      },
-      user: "postgres",
-    },
-  },
-  {
-    __typename: "Source",
-    id: "119",
-    externalId: "Teradata",
-    config: {
-      alias: "Teradata",
-      databases: ["HR"],
-      domain: {
-        external_id: "Dominio Prueba",
-        id: 83,
-        name: "Dominio Prueba",
-        parent_id: null,
-        updated_at: "2022-02-16 09:28:19.391331Z",
-      },
-      evidences_host: "localhost",
-      evidences_path: "interfases",
-      evidences_port: "445",
-      evidences_size: "10",
-      job_types: ["profile", "quality", "catalog"],
-      object_types: ["View", "Table"],
-      protocol: "SMB",
-      save_evidences: "No",
-      system: {
-        external_id: "Teradata",
-        id: 79,
-        name: "Teradata",
-      },
-    },
-  },
-  {
-    __typename: "Source",
-    id: "130",
-    externalId: "SQLServer",
-    config: {},
-  },
-  {
-    __typename: "Source",
-    id: "177",
-    externalId: "SQLServer test",
-    config: {},
-  },
-  {
-    __typename: "Source",
-    id: "176",
-    externalId: "borrar",
-    config: {
-      alias: "borrar",
-      databases: ["ORCLPDB1.localdomain"],
-      domain: {
-        external_id: "Truedat",
-        id: 2,
-        name: "Truedat",
-        parent_id: null,
-        updated_at: "2020-07-28 13:21:21.938189Z",
-      },
-      host: "localhost",
-      job_types: ["quality", "profile", "catalog"],
-      password: "yourpassword",
-      port: "1521",
-      save_evidences: "No",
-      schemas: ["OT"],
-      system: null,
-      user: "OT",
-    },
-  },
-  {
-    __typename: "Source",
-    id: "201",
-    externalId: "Athena_eu_west_2",
-    config: {
-      aliases: ["Glue_eu_west_2"],
-      aws_region: "eu-west-2",
-      aws_role_arn: "",
-      job_types: ["profile", "quality"],
-      workgroup: "primary",
-    },
-  },
-  {
-    __typename: "Source",
-    id: "151",
-    externalId: "MySQL",
-    config: {
-      alias: "MySQL",
-      domain: {
-        external_id: "Truedat",
-        id: 2,
-        name: "Truedat",
-        parent_id: null,
-        updated_at: "2020-07-28 13:21:21.938189Z",
-      },
-      filter_type: "Whitelist Databases",
-      host: "localhost",
-      job_types: ["profile", "quality", "catalog"],
-      port: "3306",
-      system: {
-        external_id: "MySQL",
-        id: 103,
-        name: "MySQL",
-      },
-      whitelist_databases: ["classicmodels"],
-    },
-  },
-  {
-    __typename: "Source",
-    id: "196",
-    externalId: "Oracle 12",
-    config: {
-      alias: "Oracle 12",
-      databases: ["ORCLPDB1.localdomain"],
-      domain: {
-        external_id: "Truedat",
-        id: 2,
-        name: "Truedat",
-        parent_id: null,
-        updated_at: "2020-07-28 13:21:21.938189Z",
-      },
-      evidences_host: "samba",
-      evidences_password: "badpass",
-      evidences_path: "interfases",
-      evidences_port: "445",
-      evidences_size: "10",
-      evidences_user: "example1",
-      filter_type: "Whitelist",
-      host: "oracle_12",
-      job_types: ["profile", "quality", "catalog"],
-      password: "Oradoc_db1",
-      port: "1521",
-      protocol: "SMB",
-      save_evidences: "Yes",
-      schemas: ["OT"],
-      system: {
-        external_id: "Oracle 12",
-        id: 141,
-        name: "Oracle 12",
-      },
-      tables_whitelist: ["REGIONS", "CUSTOMERS"],
-      user: "system",
-    },
-  },
-  {
-    __typename: "Source",
-    id: "181",
-    externalId: "PostgreSQL",
-    config: {
-      alias: "PostgreSQL",
-      databases: [
-        "td_audit",
-        "td_auth",
-        "td_bg",
-        "td_dd",
-        "td_df",
-        "td_ie",
-        "td_lm",
-        "td_metrics",
-      ],
-      domain: {
-        external_id: "Truedat",
-        id: 2,
-        name: "Truedat",
-        parent_id: null,
-        updated_at: "2020-07-28 13:21:21.938189Z",
-      },
-      job_types: ["profile", "quality", "catalog"],
-      system: {
-        external_id: "postgres",
-        id: 7,
-        name: "Truedat PostgreSQL",
-      },
-    },
-  },
-  {
-    __typename: "Source",
-    id: "162",
-    externalId: "oracle-temp",
-    config: {
-      alias: "oracle-temp",
-      databases: ["xe"],
-      domain: {
-        external_id: "Truedat",
-        id: 2,
-        name: "Truedat",
-        parent_id: null,
-        updated_at: "2020-07-28 13:21:21.938189Z",
-      },
-      filter_type: null,
-      host: "localhost",
-      job_types: ["profile", "catalog", "quality"],
-      password: "oracle",
-      port: "1521",
-      save_evidences: "No",
-      schemas: ["HR"],
-      system: {
-        external_id: "oracle2",
-        id: 2,
-        name: "BBDD Oracle",
-      },
-      user: "system",
-    },
-  },
-];
+// export const sourcesRuleImplementationLoader = [
+//   {
+//     __typename: "Source",
+//     id: "190",
+//     externalId: "Redshift",
+//     config: {
+//       alias: "Redshift",
+//       databases: ["dev"],
+//       domain: {
+//         external_id: "Truedat",
+//         id: 2,
+//         name: "Truedat",
+//         parent_id: null,
+//         updated_at: "2020-07-28 13:21:21.938189Z",
+//       },
+//       host: "redshift-cluster-1.czitmavv4gjx.eu-west-1.redshift.amazonaws.com",
+//       job_types: ["quality", "profile", "catalog"],
+//       port: "5439",
+//       system: {
+//         external_id: "Redshift",
+//         id: 139,
+//         name: "Redshift",
+//       },
+//       user: "awsuser",
+//     },
+//   },
+//   {
+//     __typename: "Source",
+//     id: "178",
+//     externalId: "test_athena",
+//     config: {
+//       aliases: ["asd", "glue"],
+//       aws_region: "eu-west-1",
+//       aws_role_arn: "",
+//       job_types: ["profile", "quality"],
+//       output_location: "",
+//       workgroup: "primary",
+//     },
+//   },
+//   {
+//     __typename: "Source",
+//     id: "187",
+//     externalId: "postgres-temp",
+//     config: {
+//       alias: "postgres-temp",
+//       blacklist_schemas: [],
+//       databases: ["prueba", "postgres"],
+//       domain: {
+//         external_id: "Truedat",
+//         id: 2,
+//         name: "Truedat",
+//         parent_id: null,
+//         updated_at: "2020-07-28 13:21:21.938189Z",
+//       },
+//       host: "localhost",
+//       job_types: ["profile", "quality", "catalog"],
+//       password: "yourStrong(!)Password",
+//       port: "5432",
+//       system: {
+//         external_id: "Postgres-Test",
+//         id: 106,
+//         name: "Postgres-Test",
+//       },
+//       user: "postgres",
+//     },
+//   },
+//   {
+//     __typename: "Source",
+//     id: "119",
+//     externalId: "Teradata",
+//     config: {
+//       alias: "Teradata",
+//       databases: ["HR"],
+//       domain: {
+//         external_id: "Dominio Prueba",
+//         id: 83,
+//         name: "Dominio Prueba",
+//         parent_id: null,
+//         updated_at: "2022-02-16 09:28:19.391331Z",
+//       },
+//       evidences_host: "localhost",
+//       evidences_path: "interfases",
+//       evidences_port: "445",
+//       evidences_size: "10",
+//       job_types: ["profile", "quality", "catalog"],
+//       object_types: ["View", "Table"],
+//       protocol: "SMB",
+//       save_evidences: "No",
+//       system: {
+//         external_id: "Teradata",
+//         id: 79,
+//         name: "Teradata",
+//       },
+//     },
+//   },
+//   {
+//     __typename: "Source",
+//     id: "130",
+//     externalId: "SQLServer",
+//     config: {},
+//   },
+//   {
+//     __typename: "Source",
+//     id: "177",
+//     externalId: "SQLServer test",
+//     config: {},
+//   },
+//   {
+//     __typename: "Source",
+//     id: "176",
+//     externalId: "borrar",
+//     config: {
+//       alias: "borrar",
+//       databases: ["ORCLPDB1.localdomain"],
+//       domain: {
+//         external_id: "Truedat",
+//         id: 2,
+//         name: "Truedat",
+//         parent_id: null,
+//         updated_at: "2020-07-28 13:21:21.938189Z",
+//       },
+//       host: "localhost",
+//       job_types: ["quality", "profile", "catalog"],
+//       password: "yourpassword",
+//       port: "1521",
+//       save_evidences: "No",
+//       schemas: ["OT"],
+//       system: null,
+//       user: "OT",
+//     },
+//   },
+//   {
+//     __typename: "Source",
+//     id: "201",
+//     externalId: "Athena_eu_west_2",
+//     config: {
+//       aliases: ["Glue_eu_west_2"],
+//       aws_region: "eu-west-2",
+//       aws_role_arn: "",
+//       job_types: ["profile", "quality"],
+//       workgroup: "primary",
+//     },
+//   },
+//   {
+//     __typename: "Source",
+//     id: "151",
+//     externalId: "MySQL",
+//     config: {
+//       alias: "MySQL",
+//       domain: {
+//         external_id: "Truedat",
+//         id: 2,
+//         name: "Truedat",
+//         parent_id: null,
+//         updated_at: "2020-07-28 13:21:21.938189Z",
+//       },
+//       filter_type: "Whitelist Databases",
+//       host: "localhost",
+//       job_types: ["profile", "quality", "catalog"],
+//       port: "3306",
+//       system: {
+//         external_id: "MySQL",
+//         id: 103,
+//         name: "MySQL",
+//       },
+//       whitelist_databases: ["classicmodels"],
+//     },
+//   },
+//   {
+//     __typename: "Source",
+//     id: "196",
+//     externalId: "Oracle 12",
+//     config: {
+//       alias: "Oracle 12",
+//       databases: ["ORCLPDB1.localdomain"],
+//       domain: {
+//         external_id: "Truedat",
+//         id: 2,
+//         name: "Truedat",
+//         parent_id: null,
+//         updated_at: "2020-07-28 13:21:21.938189Z",
+//       },
+//       evidences_host: "samba",
+//       evidences_password: "badpass",
+//       evidences_path: "interfases",
+//       evidences_port: "445",
+//       evidences_size: "10",
+//       evidences_user: "example1",
+//       filter_type: "Whitelist",
+//       host: "oracle_12",
+//       job_types: ["profile", "quality", "catalog"],
+//       password: "Oradoc_db1",
+//       port: "1521",
+//       protocol: "SMB",
+//       save_evidences: "Yes",
+//       schemas: ["OT"],
+//       system: {
+//         external_id: "Oracle 12",
+//         id: 141,
+//         name: "Oracle 12",
+//       },
+//       tables_whitelist: ["REGIONS", "CUSTOMERS"],
+//       user: "system",
+//     },
+//   },
+//   {
+//     __typename: "Source",
+//     id: "181",
+//     externalId: "PostgreSQL",
+//     config: {
+//       alias: "PostgreSQL",
+//       databases: [
+//         "td_audit",
+//         "td_auth",
+//         "td_bg",
+//         "td_dd",
+//         "td_df",
+//         "td_ie",
+//         "td_lm",
+//         "td_metrics",
+//       ],
+//       domain: {
+//         external_id: "Truedat",
+//         id: 2,
+//         name: "Truedat",
+//         parent_id: null,
+//         updated_at: "2020-07-28 13:21:21.938189Z",
+//       },
+//       job_types: ["profile", "quality", "catalog"],
+//       system: {
+//         external_id: "postgres",
+//         id: 7,
+//         name: "Truedat PostgreSQL",
+//       },
+//     },
+//   },
+//   {
+//     __typename: "Source",
+//     id: "162",
+//     externalId: "oracle-temp",
+//     config: {
+//       alias: "oracle-temp",
+//       databases: ["xe"],
+//       domain: {
+//         external_id: "Truedat",
+//         id: 2,
+//         name: "Truedat",
+//         parent_id: null,
+//         updated_at: "2020-07-28 13:21:21.938189Z",
+//       },
+//       filter_type: null,
+//       host: "localhost",
+//       job_types: ["profile", "catalog", "quality"],
+//       password: "oracle",
+//       port: "1521",
+//       save_evidences: "No",
+//       schemas: ["HR"],
+//       system: {
+//         external_id: "oracle2",
+//         id: 2,
+//         name: "BBDD Oracle",
+//       },
+//       user: "system",
+//     },
+//   },
+// ];
 
 export const ruleImplementationLoaderGlobalState = {
   rule: {},
@@ -1230,6 +1230,7 @@ export const ruleImplementationLoaderGlobalState = {
   ruleImplementationOperators,
   structuresFields,
   structuresSiblings,
+  domains: [{ id: 2, name: "domain1" }],
 };
 
 export const ruleImplementationLoaderActions = {

package/src/components/__tests__/NewRuleImplementation.spec.js

@@ -5,28 +5,25 @@ import { render } from "@truedat/test/render";
 import { multipleTemplatesMock } from "@truedat/test/mocks";
 import userEvent from "@testing-library/user-event";
 import defaultMessages from "@truedat/test/messages";
-import {
-  NewRuleImplementation,
-  SOURCES_WITH_CONFIG,
+import NewRuleImplementation, {
+  NewRuleImplementation as NewRuleImplementationComponent,
 } from "../NewRuleImplementation";
-import NewRuleImplementationLoader from "../NewRuleImplementation";
 import { newRuleImplementationProps } from "../__test_samples__/NewRuleImplementationProps";
 import {
   ruleImplementationLoaderGlobalState,
   ruleImplementationLoaderActions,
-  sourcesRuleImplementationLoader,
-} from "../__test_samples__/newRuleImplementationLoader";
+} from "../__test_samples__/newRuleImplementationHelper";
 
 describe("<NewRuleImplementation />", () => {
   const createRuleImplementation = jest.fn();
   const updateRuleImplementation = jest.fn();
-  const sources = [{ id: 1, external_id: "foo", config: { alias: ["foo"] } }];
+
   const ruleImplementationProps = { id: 1, name: "nn", executable: true };
+
   const props = {
     ruleImplementationProps,
     createRuleImplementation,
     updateRuleImplementation,
-    sources,
   };
   const renderOpts = {
     mocks: [
@@ -44,11 +41,11 @@ describe("<NewRuleImplementation />", () => {
       <NewRuleImplementation {...props} />,
       renderOpts
     );
+
     await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
     await waitFor(() =>
       expect(queryByText(/loading/i)).not.toBeInTheDocument()
     );
-
     expect(container).toMatchSnapshot();
   });
 
@@ -59,7 +56,7 @@ describe("<NewRuleImplementation />", () => {
       applyTemplate: applyTemplate,
     };
     const { container, queryByText } = render(
-      <NewRuleImplementation {...props} />,
+      <NewRuleImplementationComponent {...props} />,
       renderOpts
     );
     await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
@@ -70,24 +67,15 @@ describe("<NewRuleImplementation />", () => {
   });
 });
 
-describe("<NewRuleImplementationLoader> NewRuleImplementation doSubmit", () => {
+describe("<NewRuleImplementation> NewRuleImplementation doSubmit", () => {
   const dispatch = jest.fn();
 
-  const sourcesWithConfigMock = {
-    request: {
-      query: SOURCES_WITH_CONFIG,
-      variables: { jobTypes: "quality" },
-    },
-    result: { data: { sources: sourcesRuleImplementationLoader } },
-  };
-
   const renderOptsImplementationEdit = {
     mocks: [
       multipleTemplatesMock({
         scope: "ri",
         domainIds: [2],
       }),
-      sourcesWithConfigMock,
     ],
     messages: {
       en: {
@@ -146,7 +134,7 @@ describe("<NewRuleImplementationLoader> NewRuleImplementation doSubmit", () => {
     };
 
     const { queryByText, getByRole, findByRole, findByTestId } = render(
-      <NewRuleImplementationLoader {...props} />,
+      <NewRuleImplementation {...props} />,
       renderOptsImplementationEdit
     );
 
@@ -247,7 +235,7 @@ describe("<NewRuleImplementationLoader> NewRuleImplementation doSubmit", () => {
     };
 
     const { queryByText, getByRole, findByRole, findByTestId } = render(
-      <NewRuleImplementationLoader {...props} />,
+      <NewRuleImplementation {...props} />,
       renderOptsImplementationEdit
     );
 

package/src/components/ruleImplementationForm/RuleImplementationRawForm.js

@@ -4,6 +4,8 @@ import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { useHistory } from "react-router-dom";
 import { FormattedMessage, useIntl } from "react-intl";
+import { gql, useQuery } from "@apollo/client";
+import { Loading } from "@truedat/core/components";
 import { Button, Form, Icon, Popup } from "semantic-ui-react";
 import { accentInsensitivePathOrder } from "@truedat/core/services/sort";
 import LimitsForm from "./LimitsForm";
@@ -80,6 +82,7 @@ export const RuleImplementationRawForm = ({
     setImplementationRawContent({
       ...rawContent,
       source_id: value,
+      source: _.find({ id: value })(sources),
       database: "",
     });
   };
@@ -334,6 +337,32 @@ RuleImplementationRawForm.propTypes = {
   sourcesLoading: PropTypes.bool,
 };
 
+export const SOURCES_WITH_CONFIG = gql`
+  query SOURCES_WITH_CONFIG($jobTypes: String) {
+    sources(jobTypes: $jobTypes) {
+      id
+      externalId
+      config
+    }
+  }
+`;
+
+export const RuleImplementationRawFormLoader = (props) => {
+  const { data, error, loading } = useQuery(SOURCES_WITH_CONFIG, {
+    variables: { jobTypes: "quality" },
+  });
+  if (error) return null;
+  if (loading) return <Loading />;
+  const sources = data?.sources || [];
+  return (
+    <RuleImplementationRawForm
+      sources={sources}
+      sourcesLoading={loading}
+      {...props}
+    />
+  );
+};
+
 const mapStateToProps = ({
   implementationActions,
   rule,
@@ -344,4 +373,4 @@ const mapStateToProps = ({
   rule,
 });
 
-export default connect(mapStateToProps)(RuleImplementationRawForm);
+export default connect(mapStateToProps)(RuleImplementationRawFormLoader);

package/src/components/ruleImplementationForm/__tests__/RuleImplementationRawForm.spec.js

@@ -4,7 +4,7 @@ import { waitFor } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import { render } from "@truedat/test/render";
 import { multipleTemplatesMock } from "@truedat/test/mocks";
-import RuleImplementationRawForm from "../RuleImplementationRawForm";
+import { RuleImplementationRawForm } from "../RuleImplementationRawForm";
 
 jest.setTimeout(30000);
 
@@ -13,6 +13,7 @@ const renderOpts = {
   state: {
     rule: { domain_id: 1 },
     ruleImplementationCreating: false,
+    domains: [{ id: 1, name: "domain1" }],
   },
   fallback: "lazy",
 };
@@ -35,6 +36,7 @@ const props = {
     minimum: "1",
     result_type: "percentage",
   },
+  sourcesLoading: false,
   sources: [
     {
       id: "1",
@@ -56,8 +58,11 @@ const props = {
 
 describe("<RuleImplementationRawForm />", () => {
   it("matches the latest snapshot", async () => {
+    const updatedProps = _.flow(_.set("ruleImplementation.domain_id", 1))(
+      props
+    );
     const { container, queryByText } = render(
-      <RuleImplementationRawForm {...props} />,
+      <RuleImplementationRawForm {...updatedProps} />,
       renderOpts
     );
     await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument(), {
@@ -141,6 +146,7 @@ describe("<RuleImplementationRawForm />", () => {
 
   it("submit button enabled if there is valid content in form with database", async () => {
     const updatedProps = _.flow(
+      _.set("ruleImplementation.domain_id", 1),
       _.set("ruleImplementation.dfName", "template1"),
       _.set("ruleImplementation.dfContent", { field1: "foo" })
     )(props);
@@ -156,13 +162,11 @@ describe("<RuleImplementationRawForm />", () => {
       rule: { id: 5, name: "regla" },
     };
 
-    const { queryByRole } = render(
+    const { findByRole } = render(
       <RuleImplementationRawForm {...customProps} />,
       renderOpts
     );
-    await waitFor(() =>
-      expect(queryByRole("button", { name: /save/i })).toBeEnabled()
-    );
+    expect(await findByRole("button", { name: /save/i })).toBeEnabled();
   });
 
   it("submit button disabled if databases are available and not selected", async () => {
@@ -176,14 +180,10 @@ describe("<RuleImplementationRawForm />", () => {
       },
     };
 
-    const { queryByText, getByRole } = render(
+    const { getByRole } = render(
       <RuleImplementationRawForm {...customProps} />,
       renderOpts
     );
-    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
     expect(getByRole("button", { name: "Save" })).toBeDisabled();
   });
 
@@ -221,6 +221,15 @@ describe("<RuleImplementationRawForm />", () => {
       population: "",
       source_id: "2",
       validations: "",
+      source: {
+        id: "2",
+        config: {
+          alias: "source2",
+          job_types: ["quality"],
+          databases: ["db1", "db2"],
+        },
+        externalId: "ext_id_2",
+      },
     });
   });
 
@@ -239,17 +248,12 @@ describe("<RuleImplementationRawForm />", () => {
         validations: "a.city='MADRID'",
       },
     };
-    const { queryByRole, queryByText } = render(
+    const { findByRole } = render(
       <RuleImplementationRawForm {...customProps} />,
       renderOpts
     );
-    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
-    await waitFor(() =>
-      expect(queryByRole("button", { name: /save/i })).toBeEnabled()
-    );
+
+    expect(await findByRole("button", { name: /save/i })).toBeEnabled();
   });
 
   it("submit button disabled if there is invalid content in form", async () => {
@@ -266,14 +270,10 @@ describe("<RuleImplementationRawForm />", () => {
         validations: "a.city='MADRID'",
       },
     };
-    const { queryByRole, queryByText } = render(
+    const { queryByRole } = render(
       <RuleImplementationRawForm {...customProps} />,
       renderOpts
     );
-    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
     expect(queryByRole("button", { name: /save/i })).toBeDisabled();
   });
 

package/src/components/ruleImplementationForm/__tests__/__snapshots__/RuleImplementationRawForm.spec.js.snap

@@ -53,6 +53,72 @@ exports[`<RuleImplementationRawForm /> matches the latest snapshot 1`] = `
         </div>
       </div>
     </div>
+    <div
+      class="field"
+    >
+      <div
+        class="required field"
+      >
+        <label>
+          Domain
+        </label>
+        <div
+          class="field"
+        >
+          <div
+            aria-expanded="false"
+            class="ui fluid search selection dropdown"
+            name="domain"
+            role="combobox"
+          >
+            <input
+              aria-autocomplete="list"
+              autocomplete="off"
+              class="search"
+              tabindex="0"
+              type="text"
+              value=""
+            />
+            <div
+              aria-atomic="true"
+              aria-live="polite"
+              class="divider text"
+              role="alert"
+            >
+              domain1
+            </div>
+            <i
+              aria-hidden="true"
+              class="dropdown icon clear"
+            />
+            <div
+              aria-multiselectable="false"
+              class="menu transition"
+              role="listbox"
+            >
+              <div
+                aria-checked="true"
+                aria-selected="true"
+                class="active selected item"
+                role="option"
+                style="pointer-events: all;"
+              >
+                <div
+                  class="text"
+                  style="margin-left: 0px;"
+                >
+                  <i
+                    aria-hidden="true"
+                    class="icon"
+                  />
+                  domain1
+                </div>
+              </div>
+            </div>
+          </div>
+        </div>
+      </div>
+    </div>
     <div
       class="ui segment"
     >
@@ -279,6 +345,7 @@ exports[`<RuleImplementationRawForm /> matches the latest snapshot 1`] = `
         Data source
       </label>
       <div
+        aria-busy="false"
         aria-expanded="false"
         class="ui search selection dropdown"
         name="source_id"