@truedat/dq 4.47.4 → 4.47.7

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## [4.47.6] 2022-07-01
+
+### Fixed
+
+- [TD-4993]
+  - RuleImplementationForm visibility with correct permissions
+  - Show quality event errors on results view using graphql
+  - Add exclusive subscription events
+
+## [4.47.5] 2022-06-30
+
+### Added
+
+- [TD-4894] Multiple column operator in implementation creation
+
 ## [4.47.4] 2022-06-29
 
 - [TD-4921] Add implementation workflow events
@@ -20,7 +35,7 @@
 
 ## [4.46.12] 2022-06-20
 
-### Reverted
+### Removed
 
 - [TD-4894] Multiple column operator in implementation creation
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.47.4",
+  "version": "4.47.7",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.16.4",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.47.4",
+    "@truedat/test": "4.47.7",
     "babel-jest": "^28.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -88,8 +88,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.47.4",
-    "@truedat/df": "4.47.4",
+    "@truedat/core": "4.47.7",
+    "@truedat/df": "4.47.7",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -110,5 +110,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "9d38ae9759ce669fe1b459a3ee80c314d33871e0"
+  "gitHead": "5e85149774b055fd61014633988cdf6aa9b9da4f"
 }

package/src/api/queries.js

@@ -20,6 +20,11 @@ export const IMPLEMENTATION_RESULTS = gql`
     implementation(id: $id) {
       id
       implementation_key
+      last_quality_event {
+        inserted_at
+        message
+        type
+      }
       versions {
         id
         implementation_key

package/src/components/ConditionSummary.js

@@ -8,43 +8,85 @@ import { linkTo } from "@truedat/core/routes";
 
 const concatValues = (values, link) => _.join(link)(values);
 
-const FormattedLink = ({ value, operator = {} }) =>
-  _.propEq("value_type", "field")(operator) ? (
+const LinkToStructure = ({ value }) =>
+  value?.id ? (
     <Link to={linkTo.STRUCTURE({ id: value.id })}>
       <span className="highlighted">{`"${
         !_.isEmpty(value.path) ? path(value) : value.name
       }"`}</span>{" "}
     </Link>
-  ) : (
-    <span className="highlighted">
-      <FormattedMessage
-        id={`ruleImplementation.filtersField.${value.raw}`}
-        defaultMessage={`"${
-          _.isArray(value.raw) ? _.join(", ")(value.raw) : value.raw
-        }"`}
-      ></FormattedMessage>
-    </span>
-  );
+  ) : null;
+
+const FormattedLink = ({ value, operator = {} }) => {
+  switch (operator?.value_type) {
+    case "field":
+      return <LinkToStructure value={value} />;
+    case "field_list":
+      return (
+        <>
+          {_.map.convert({ cap: false })((v, i) => (
+            <LinkToStructure key={i} value={v} />
+          ))(value)}
+        </>
+      );
+    default:
+      return (
+        <span className="highlighted">
+          <FormattedMessage
+            id={`ruleImplementation.filtersField.${value.raw}`}
+            defaultMessage={`"${
+              _.isArray(value.raw) ? _.join(", ")(value.raw) : value.raw
+            }"`}
+          ></FormattedMessage>
+        </span>
+      );
+  }
+};
 
 FormattedLink.propTypes = {
-  value: PropTypes.object,
+  value: PropTypes.oneOfType([PropTypes.object, PropTypes.array]),
   operator: PropTypes.object,
 };
 
 const nilOrEmpty = (v) => _.isNil(v) || v === "";
 
-const filterNilOrEmpties = (values, keys) =>
-  _.filter((v) => _.every((k) => !nilOrEmpty(_.prop(k)(v.kv)))(keys))(values);
+const filterNilOrEmpties = (values, keys) => {
+  if ("kv" in values) {
+    return _.every((k) => !nilOrEmpty(values.kv[k]))(keys) ? values : null;
+  }
+
+  return _.flow(
+    _.map((v) => filterNilOrEmpties(v, keys)),
+    _.filter((v) => !!v)
+  )(values);
+};
+
+const pick = (value, keys, optionalKeys) => ({
+  kv: _.pick(keys)(value),
+  optv: _.pick(optionalKeys)(value),
+});
+
+const convert = (v, index, value_modifier) => {
+  if (_.has("kv")(v)) {
+    return { ...v.kv, ...v.optv, modifier: _.nth(index)(value_modifier) };
+  }
+
+  return _.map.convert({ cap: false })((v, i) => {
+    return convert(v, i, value_modifier);
+  })(v);
+};
 
 const valuesFromKeys = (values, keys, optionalKeys, value_modifier) =>
   _.flow(
-    _.map((v) => {
-      return { kv: _.pick(keys)(v), optv: _.pick(optionalKeys)(v) };
+    _.map((value) => {
+      return Array.isArray(value?.fields)
+        ? _.map((innerValue) => pick(innerValue, keys, optionalKeys))(
+            value?.fields
+          )
+        : pick(value, keys, optionalKeys);
     }),
     (v) => filterNilOrEmpties(v, keys),
-    _.map.convert({ cap: false })((v, i) => {
-      return { ...v.kv, ...v.optv, modifier: _.nth(i)(value_modifier) };
-    })
+    (v) => convert(v, 0, value_modifier)
   )(values);
 
 export const empty = (rows) =>
@@ -52,7 +94,7 @@ export const empty = (rows) =>
 
 export const getValues = ({ value = [], operator = {}, value_modifier }) => {
   const defaultOrValue = value || [];
-  return _.propEq("value_type", "field")(operator)
+  return ["field", "field_list"].includes(operator?.value_type)
     ? valuesFromKeys(defaultOrValue, ["id", "name"], ["path"], value_modifier)
     : valuesFromKeys(defaultOrValue, ["raw"], [], value_modifier);
 };

package/src/components/NewRuleImplementation.js

@@ -4,8 +4,6 @@ import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { Divider, Header, Grid } from "semantic-ui-react";
 import { FormattedMessage } from "react-intl";
-import { gql, useQuery } from "@apollo/client";
-import { Loading } from "@truedat/core/components";
 import { getFieldType } from "@truedat/core/services/fieldType";
 import {
   createRuleImplementation,
@@ -25,6 +23,19 @@ const updateDatasetKey = (data) =>
     {}
   )(data);
 
+// object either field, raw value, list of fields, list of raw values
+const updateValueKeyContent = (object) => {
+  if (object?.id || object?.raw || object?.fields) {
+    return object?.id
+      ? _.pick(["id", "parent_index"])(object)
+      : _.pick(["raw", "fields"])(object);
+  }
+
+  return (object || []).map((v) => {
+    return updateValueKeyContent(v);
+  });
+};
+
 const updateConditionValue = (acc, value, key) => {
   if (key === "structure") {
     return _.set(key, _.pick(["id", "parent_index"])(value))(acc);
@@ -48,13 +59,9 @@ const updateConditionValue = (acc, value, key) => {
         _.pick(["name", "value_type", "value_type_filter"])(value)
       )
     )(acc);
-  if (key == "value")
-    return _.set(
-      key,
-      _.map((v) =>
-        _.has("id")(v) ? _.pick(["id", "parent_index"])(v) : _.pick(["raw"])(v)
-      )(value)
-    )(acc);
+  if (key == "value") {
+    return { ...acc, value: updateValueKeyContent(value) };
+  }
   if (key === "population") return _.set(key, conditionAttributes(value))(acc);
 
   return acc;
@@ -103,6 +110,7 @@ const fieldTypeFromStructure = (row, structures, operators, scope) => {
     field_type,
     _.prop("operator")(row)
   );
+
   const updatedRow = {
     ...row,
     operator,
@@ -238,8 +246,6 @@ export const NewRuleImplementation = ({
   edition,
   rule,
   ruleImplementationProps,
-  sources,
-  sourcesLoading,
   structuresFields,
   structuresSiblings,
   operators,
@@ -448,8 +454,9 @@ export const NewRuleImplementation = ({
   const setImplementationKey = (implementationKey) =>
     setRuleImplementation({ ...ruleImplementation, implementationKey });
 
-  const setImplementationRawContent = (rawContent) =>
+  const setImplementationRawContent = (rawContent) => {
     setRuleImplementation({ ...ruleImplementation, rawContent });
+  };
 
   const doSubmit = (props = {}) => {
     const populations = _.reject(_.isEmpty)(ruleImplementation.populations);
@@ -457,8 +464,6 @@ export const NewRuleImplementation = ({
     const segments = _.reject(_.isEmpty)(ruleImplementation.segments);
 
     const raw_content = _.prop("rawContent")(ruleImplementation);
-    const source_id = _.prop("source_id")(raw_content);
-    const source = _.find({ id: source_id })(sources);
 
     const rule_implementation =
       ruleImplementation.implementationType == "raw"
@@ -469,7 +474,7 @@ export const NewRuleImplementation = ({
             df_name: ruleImplementation?.dfName,
             df_content: ruleImplementation?.dfContent,
             rule_id: rule ? rule.id : ruleImplementation.rule_id,
-            raw_content: { ...raw_content, source },
+            raw_content: { ...raw_content },
             result_type: ruleImplementation.result_type,
             minimum: ruleImplementation.minimum,
             goal: ruleImplementation.goal,
@@ -536,8 +541,6 @@ export const NewRuleImplementation = ({
               ruleImplementation={ruleImplementation}
               onChange={onChange}
               onSubmit={doSubmit}
-              sources={sources}
-              sourcesLoading={sourcesLoading}
             />
           ) : (
             <RuleImplementationForm
@@ -573,39 +576,11 @@ NewRuleImplementation.propTypes = {
   operators: PropTypes.object,
   rule: PropTypes.object,
   ruleImplementationProps: PropTypes.object,
-  sources: PropTypes.array,
-  sourcesLoading: PropTypes.bool,
   structuresFields: PropTypes.object,
   structuresSiblings: PropTypes.object,
   updateRuleImplementation: PropTypes.func,
 };
 
-export const SOURCES_WITH_CONFIG = gql`
-  query SOURCES_WITH_CONFIG($jobTypes: String) {
-    sources(jobTypes: $jobTypes) {
-      id
-      externalId
-      config
-    }
-  }
-`;
-
-export const NewRuleImplementationLoader = (props) => {
-  const { data, error, loading } = useQuery(SOURCES_WITH_CONFIG, {
-    variables: { jobTypes: "quality" },
-  });
-  if (error) return null;
-  if (loading) return <Loading />;
-  const sources = data?.sources || [];
-  return (
-    <NewRuleImplementation
-      sources={sources}
-      sourcesLoading={loading}
-      {...props}
-    />
-  );
-};
-
 const mapStateToProps = (state) => ({
   rule: state.rule,
   ruleImplementationProps: {
@@ -621,4 +596,4 @@ const mapStateToProps = (state) => ({
 export default connect(mapStateToProps, {
   createRuleImplementation,
   updateRuleImplementation,
-})(NewRuleImplementationLoader);
+})(NewRuleImplementation);

package/src/components/RuleImplementationResults.js

@@ -46,9 +46,11 @@ export const RuleImplementationResults = ({
     formatMessage,
   };
 
+  const { last_quality_event } = ruleImplementation;
+
   return (
     <>
-      {ruleImplementation.event_type === "FAILED" ? (
+      {last_quality_event?.type === "FAILED" ? (
         <Message negative style={{ marginTop: "14px" }}>
           <Message.Header>
             {formatMessage({
@@ -63,7 +65,7 @@ export const RuleImplementationResults = ({
               right: "21px",
             }}
             locale={locale}
-            date={ruleImplementation.event_inserted_at}
+            date={last_quality_event.inserted_at}
             format="YYYY-MM-DD HH:mm"
           />
           <p
@@ -71,7 +73,7 @@ export const RuleImplementationResults = ({
               whiteSpace: "pre-wrap",
             }}
           >
-            {ruleImplementation.event_message}
+            {last_quality_event.message}
           </p>
         </Message>
       ) : null}