@truedat/dq 4.45.8 → 4.46.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [4.46.2] 2022-06-16
+
+### Changed
+
+- [TD-4739] Don't lazily load components from `@truedat/core`
+
+## [4.46.0] 2022-06-13
+
+### Fixed
+
+- [TD-4918] Implementations workflow permissions
+
 ## [4.45.7] 2022-06-07
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.45.8",
+  "version": "4.46.2",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.16.4",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.45.8",
+    "@truedat/test": "4.46.2",
     "babel-jest": "^28.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -88,8 +88,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.6.4",
-    "@truedat/core": "4.45.8",
-    "@truedat/df": "4.45.8",
+    "@truedat/core": "4.46.2",
+    "@truedat/df": "4.46.2",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -110,5 +110,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "1b5acb1dc1233181e5a47353fd8a5da1424e7a47"
+  "gitHead": "161f3fae4428ee4e4e26b62fd2f9764ce389d0e2"
 }

package/src/components/ImplementationActions.js

@@ -17,38 +17,41 @@ import {
 import ExecutionPopup from "./ExecutionPopup";
 
 export const implementationActions = ({
+  actions,
   id,
   deleteImplementation,
   formatMessage,
-}) => [
-  {
-    key: "clone",
-    icon: "copy outline",
-    text: formatMessage({ id: "ruleImplementation.actions.clone" }),
-    value: "clone",
-    as: Link,
-    to: linkTo.IMPLEMENTATION_CLONE({ implementation_id: id }),
-  },
-  {
-    key: "move",
-    icon: "share square",
-    text: formatMessage({ id: "ruleImplementation.actions.move" }),
-    value: "move",
-    as: Link,
-    to: linkTo.IMPLEMENTATION_MOVE({ implementation_id: id }),
-  },
-  {
-    key: "delete",
-    value: "delete",
-    as: OptionModal,
-    headerMessage: "ruleImplementation.actions.delete.confirmation.header",
-    contentMessage: "ruleImplementation.actions.delete.confirmation.content",
-    iconName: "trash alternate outline",
-    iconColor: "red",
-    option: "ruleImplementation.actions.delete",
-    onConfirm: () => deleteImplementation({ id, redirectUrl: IMPLEMENTATIONS }),
-  },
-];
+}) =>
+  _.filter(({ key }) => _.flow(Object.keys, _.includes(key))(actions))([
+    {
+      key: "clone",
+      icon: "copy outline",
+      text: formatMessage({ id: "ruleImplementation.actions.clone" }),
+      value: "clone",
+      as: Link,
+      to: linkTo.IMPLEMENTATION_CLONE({ implementation_id: id }),
+    },
+    {
+      key: "move",
+      icon: "share square",
+      text: formatMessage({ id: "ruleImplementation.actions.move" }),
+      value: "move",
+      as: Link,
+      to: linkTo.IMPLEMENTATION_MOVE({ implementation_id: id }),
+    },
+    {
+      key: "delete",
+      value: "delete",
+      as: OptionModal,
+      headerMessage: "ruleImplementation.actions.delete.confirmation.header",
+      contentMessage: "ruleImplementation.actions.delete.confirmation.content",
+      iconName: "trash alternate outline",
+      iconColor: "red",
+      option: "ruleImplementation.actions.delete",
+      onConfirm: () =>
+        deleteImplementation({ id, redirectUrl: IMPLEMENTATIONS }),
+    },
+  ]);
 
 export const ImplementationActions = ({
   actions,
@@ -66,6 +69,7 @@ export const ImplementationActions = ({
     createExecutionGroup({ ...query, df_content });
   };
   const secondaryActions = implementationActions({
+    actions,
     id,
     deleteImplementation,
     formatMessage,
@@ -116,7 +120,9 @@ export const ImplementationActions = ({
         />
       ) : null}
       {actions?.execute ? <ExecutionPopup onSubmit={handleExecute} /> : null}
-      <GroupActions availableActions={secondaryActions} />
+      {_.isEmpty(secondaryActions) ? null : (
+        <GroupActions availableActions={secondaryActions} />
+      )}
     </>
   );
 };

package/src/components/ImplementationSearchResults.js

@@ -101,7 +101,9 @@ export const ImplementationSearchResults = ({
       selectedImplementations
     );
   };
-
+  const withoutColumns = useActiveRoute(IMPLEMENTATIONS_PENDING)
+    ? []
+    : ["status"];
   return (
     <Segment>
       <ImplementationSearchResultsHeader />
@@ -130,6 +132,7 @@ export const ImplementationSearchResults = ({
             executeImplementationsOn={executeImplementationsOn}
             isRowChecked={isRowChecked}
             selectedImplementations={selectedImplementations}
+            withoutColumns={withoutColumns}
           />
           <RuleImplementationsPagination />
         </Dimmer.Dimmable>

package/src/components/QualityRoutes.js

@@ -14,7 +14,7 @@ import ImplementationsRoutes from "./ImplementationsRoutes";
 import RulesRoutes from "./RulesRoutes";
 
 const QualityRoutes = () => {
-  const authorized = useAuthorized("data_quality");
+  const authorized = useAuthorized("quality");
 
   return (
     <>

package/src/components/RuleForm.js

@@ -16,17 +16,13 @@ import {
   Popup,
   Icon,
 } from "semantic-ui-react";
-import { HistoryBackButton } from "@truedat/core/components";
+import { HistoryBackButton, RichTextEditor } from "@truedat/core/components";
 import { getDomainSelectorOptions } from "@truedat/bg/selectors";
 
 const DomainDropdownSelector = React.lazy(() =>
   import("@truedat/bg/taxonomy/components/DomainDropdownSelector")
 );
 
-const RichTextEditor = React.lazy(() =>
-  import("@truedat/core/components/RichTextEditor")
-);
-
 const ConceptSelector = React.lazy(() =>
   import("@truedat/bg/concepts/relations/components/ConceptSelector")
 );

package/src/components/RuleImplementationActions.js

@@ -37,9 +37,9 @@ RuleImplementationActions.propTypes = {
   canCreateRaw: PropTypes.bool,
 };
 
-const mapStateToProps = ({ userRulePermissions }) => ({
-  canCreate: !!userRulePermissions?.manage_quality_rule_implementations,
-  canCreateRaw: !!userRulePermissions?.manage_raw_quality_rule_implementations,
+const mapStateToProps = ({ implementationActions }) => ({
+  canCreate: !!implementationActions?.create,
+  canCreateRaw: !!implementationActions?.createRaw,
 });
 
 export default connect(mapStateToProps)(RuleImplementationActions);

package/src/components/RuleImplementationsActions.js

@@ -82,7 +82,7 @@ export const RuleImplementationsActions = ({
           />
         </>
       ) : null}
-      {actions?.createRaw ? (
+      {actions?.createRawRuleLess ? (
         <Button
           as={Link}
           to={IMPLEMENTATION_NEW_RAW}
@@ -91,7 +91,7 @@ export const RuleImplementationsActions = ({
           })}
         />
       ) : null}
-      {actions?.create ? (
+      {actions?.createRuleLess ? (
         <Button
           primary
           as={Link}

package/src/components/RuleProperties.js

@@ -6,12 +6,9 @@ import { connect } from "react-redux";
 import { Link } from "react-router-dom";
 import { List, Label } from "semantic-ui-react";
 import "rc-slider/assets/index.css";
+import { RichTextEditor } from "@truedat/core/components";
 import { linkTo } from "@truedat/core/routes";
 
-const RichTextEditor = React.lazy(() =>
-  import("@truedat/core/components/RichTextEditor")
-);
-
 const getStatusColor = (active) =>
   ({
     false: "teal",

package/src/components/__tests__/ImplementationActions.spec.js

@@ -9,6 +9,9 @@ const renderOpts = {
     },
     implementationActions: {
       execute: { method: "POST" },
+      move: { method: "POST" },
+      clone: { method: "POST" },
+      delete: { method: "POST" },
     },
   },
 };

package/src/components/__tests__/ImplementationSearchResults.spec.js

@@ -2,6 +2,13 @@ import React from "react";
 import { shallow } from "enzyme";
 import { ImplementationSearchResults } from "../ImplementationSearchResults";
 
+jest.mock("@truedat/core/hooks", () => ({
+  useAuthorized: jest.fn(() => true),
+  useActiveRoute: jest.fn((param) =>
+    param === "/pendingImplementations" ? true : false
+  ),
+}));
+
 describe("<ImplementationSearchResults />", () => {
   it("matches the latest snapshot", () => {
     const props = {

package/src/components/__tests__/RuleImplementation.spec.js

@@ -19,6 +19,9 @@ const stateExecutePermission = {
     manage: true,
     link_concept: true,
     execute: true,
+    move: true,
+    clone: true,
+    delete: true,
   },
 };
 
@@ -28,6 +31,9 @@ const stateNoExecutePermission = {
     manage: true,
     link_concept: true,
     execute: false,
+    move: true,
+    clone: true,
+    delete: true,
   },
 };
 

package/src/components/__tests__/RuleImplementationsActions.spec.js

@@ -13,8 +13,8 @@ describe("<RuleImplementationsActions />", () => {
   const props = {
     actions: {
       uploadResults: {},
-      create: {},
-      createRaw: {},
+      createRuleLess: {},
+      createRawRuleLess: {},
       download: {},
       execute: {},
     },

package/src/components/__tests__/__snapshots__/ImplementationSearchResults.spec.js.snap

@@ -33,6 +33,7 @@ exports[`<ImplementationSearchResults /> matches the latest snapshot 1`] = `
         executeImplementationsOn={false}
         isRowChecked={[Function]}
         selectedImplementations={Array []}
+        withoutColumns={Array []}
       />
       <Connect(Pagination) />
     </DimmerDimmable>
@@ -82,6 +83,7 @@ exports[`<ImplementationSearchResults /> renders executions on when executionEna
         executeImplementationsOn={true}
         isRowChecked={[Function]}
         selectedImplementations={Array []}
+        withoutColumns={Array []}
       />
       <Connect(Pagination) />
     </DimmerDimmable>

package/src/components/__tests__/__snapshots__/RuleForm.spec.js.snap

@@ -145,23 +145,23 @@ exports[`<RuleForm /> matches the latest snapshot (edit mode) 1`] = `
               autocorrect="on"
               contenteditable="true"
               data-gramm="false"
-              data-key="5"
+              data-key="4"
               data-slate-editor="true"
               role="textbox"
               spellcheck="true"
               style="outline: none; white-space: pre-wrap; word-wrap: break-word;"
             >
               <div
-                data-key="6"
+                data-key="5"
                 data-slate-object="block"
                 style="position: relative;"
               >
                 <span
-                  data-key="8"
+                  data-key="7"
                   data-slate-object="text"
                 >
                   <span
-                    data-offset-key="8:0"
+                    data-offset-key="7:0"
                     data-slate-leaf="true"
                   >
                     <span>
@@ -602,11 +602,11 @@ exports[`<RuleForm /> matches the latest snapshot 1`] = `
                 style="position: relative;"
               >
                 <span
-                  data-key="4"
+                  data-key="3"
                   data-slate-object="text"
                 >
                   <span
-                    data-offset-key="4:0"
+                    data-offset-key="3:0"
                     data-slate-leaf="true"
                   >
                     <span>

package/src/components/__tests__/__snapshots__/RuleProperties.spec.js.snap

@@ -5,7 +5,6 @@ exports[`<RuleProperties /> matches the latest snapshot 1`] = `
   <div
     class="ui big relaxed list"
     role="list"
-    style=""
   >
     <div
       class="ui olive label"

package/src/components/ruleImplementationForm/FiltersFormGroup.js

@@ -3,15 +3,12 @@ import React from "react";
 import { Form, Dropdown } from "semantic-ui-react";
 import PropTypes from "prop-types";
 import { useIntl } from "react-intl";
+import { OptionGroup } from "@truedat/core/components";
 import { getStructureFields } from "../../selectors/getStructureFields";
 import FiltersField from "./FiltersField";
 import FieldModifier from "./FieldModifier";
 import operatorFunctions from "./operators";
 
-const OptionGroup = React.lazy(() =>
-  import("@truedat/core/components/OptionGroup")
-);
-
 const StructureFieldsDropdown = React.lazy(() =>
   import("@truedat/dd/components/StructureFieldsDropdown")
 );

package/src/components/ruleImplementationForm/__tests__/RuleImplementationRawForm.spec.js

@@ -6,6 +6,8 @@ import { render } from "@truedat/test/render";
 import { multipleTemplatesMock } from "@truedat/test/mocks";
 import RuleImplementationRawForm from "../RuleImplementationRawForm";
 
+jest.setTimeout(30000);
+
 const renderOpts = {
   mocks: [multipleTemplatesMock({ scope: "ri", domainIds: [1] })],
   state: {

package/src/components/ruleImplementationForm/__tests__/__snapshots__/FiltersFormGroup.spec.js.snap

@@ -17,7 +17,42 @@ exports[`<FiltersFormGroup /> matches the latest snapshot 1`] = `
     </div>
     <div
       class="field"
-    />
+    >
+      <label>
+        Operator
+      </label>
+      <div
+        aria-expanded="false"
+        class="ui search dropdown selection"
+        label="Operator"
+        role="combobox"
+      >
+        <input
+          aria-autocomplete="list"
+          autocomplete="off"
+          class="search"
+          tabindex="0"
+          type="text"
+          value=""
+        />
+        <div
+          aria-atomic="true"
+          aria-live="polite"
+          class="divider text"
+          role="alert"
+        >
+          Operator Dropdown
+        </div>
+        <i
+          aria-hidden="true"
+          class="dropdown icon"
+        />
+        <div
+          class="menu transition"
+          role="listbox"
+        />
+      </div>
+    </div>
     <div
       class="nine wide field"
     />

package/src/components/ruleImplementationForm/__tests__/__snapshots__/FiltersGroup.spec.js.snap

@@ -23,7 +23,42 @@ exports[`<FiltersGroup /> matches the latest snapshot when siblings provided 1`]
         </div>
         <div
           class="field"
-        />
+        >
+          <label>
+            Operator
+          </label>
+          <div
+            aria-expanded="false"
+            class="ui search dropdown selection"
+            label="Operator"
+            role="combobox"
+          >
+            <input
+              aria-autocomplete="list"
+              autocomplete="off"
+              class="search"
+              tabindex="0"
+              type="text"
+              value=""
+            />
+            <div
+              aria-atomic="true"
+              aria-live="polite"
+              class="divider text"
+              role="alert"
+            >
+              Operator Dropdown
+            </div>
+            <i
+              aria-hidden="true"
+              class="dropdown icon"
+            />
+            <div
+              class="menu transition"
+              role="listbox"
+            />
+          </div>
+        </div>
         <div
           class="nine wide field"
         />

package/src/components/ruleImplementationForm/__tests__/__snapshots__/ValueConditions.spec.js.snap

@@ -23,7 +23,42 @@ exports[`<ValueConditions /> matches the latest snapshot when siblings provided
         </div>
         <div
           class="field"
-        />
+        >
+          <label>
+            Operator
+          </label>
+          <div
+            aria-expanded="false"
+            class="ui search dropdown selection"
+            label="Operator"
+            role="combobox"
+          >
+            <input
+              aria-autocomplete="list"
+              autocomplete="off"
+              class="search"
+              tabindex="0"
+              type="text"
+              value=""
+            />
+            <div
+              aria-atomic="true"
+              aria-live="polite"
+              class="divider text"
+              role="alert"
+            >
+              Operator Dropdown
+            </div>
+            <i
+              aria-hidden="true"
+              class="dropdown icon"
+            />
+            <div
+              class="menu transition"
+              role="listbox"
+            />
+          </div>
+        </div>
         <div
           class="nine wide field"
         />

package/src/reducers/implementationActions.js

@@ -1,13 +1,20 @@
 import _ from "lodash/fp";
-import { clearRuleImplementations, fetchRuleImplementation } from "../routines";
+import {
+  clearRuleImplementation,
+  clearRuleImplementations,
+  fetchRuleImplementation,
+  fetchRuleImplementations,
+} from "../routines";
 
 const initialState = {};
 
 const implementationActions = (state = initialState, { type, payload }) => {
   switch (type) {
     case fetchRuleImplementation.SUCCESS:
+    case fetchRuleImplementations.SUCCESS:
       return _.pathOr(initialState, "_actions")(payload);
     case clearRuleImplementations.TRIGGER:
+    case clearRuleImplementation.TRIGGER:
       return initialState;
     default:
       return state;

package/src/reducers/ruleImplementations.js

@@ -26,6 +26,7 @@ const pickFields = _.pick([
   "goal",
   "dataset",
   "valdations",
+  "status",
 ]);
 
 const ruleImplementations = (state = initialState, { type, payload }) => {

package/src/selectors/getRuleImplementationColumns.js

@@ -28,6 +28,13 @@ export const defaultImplementationColumns = [
     fieldDecorator: RuleLink,
     width: 2,
   },
+  {
+    name: "status",
+    fieldDecorator: (value) =>
+      translateDecorator(`ruleImplementation.status.${value}`),
+    sort: { name: "status" },
+    width: 2,
+  },
   {
     name: "business_concept",
     fieldSelector: _.path("current_business_concept_version.name"),