@truedat/dq 4.44.2 → 4.44.3

package/src/components/__tests__/RuleForm.spec.js

@@ -1,222 +1,95 @@
 import React from "react";
-import { shallowWithIntl } from "@truedat/test/intl-stub";
-import { applyTemplate } from "@truedat/df/utils";
-import { RuleForm, FieldLabelWrapping } from "../RuleForm";
-
-describe("<RuleForm />", () => {
-  const rule = {
-    id: 123,
-    business_concept_id: "2D2B3",
-    name: "control1",
-    description: {
-      document: {
-        data: {},
-        object: "document",
-        nodes: [
-          {
-            data: {},
-            nodes: [
-              { marks: [{ data: {}, object: "text", text: "description" }] },
-            ],
-          },
-        ],
-      },
+import { waitFor } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { render } from "@truedat/test/render";
+import { TEMPLATES_QUERY } from "@truedat/core/api/queries";
+import RuleForm from "../RuleForm";
+
+const templatesMock = {
+  request: { query: TEMPLATES_QUERY, variables: { scope: "remediation" } },
+  result: {
+    data: {
+      templates: [
+        {
+          id: "1",
+          name: "template1",
+          label: "template1",
+          scope: "remediation",
+          content: [
+            { name: "g1", fields: [{ name: "field1", label: "field1" }] },
+          ],
+        },
+        {
+          id: "2",
+          name: "template2",
+          label: "template2",
+          scope: "remediation",
+          content: {},
+        },
+      ],
     },
-    current_business_concept_version: { name: "My Concept" },
-  };
-  const handleSubmit = jest.fn();
-  const selectDomain = jest.fn();
-  const isSubmitting = false;
-  const business_concept_id = 123;
-
-  const templatesLoaded = true;
-  const template = {};
-
-  const history = { goBack: jest.fn() };
-  const match = { params: {} };
-  const domain = { id: 1, name: "foo", external_id: "foo" };
-  const defaultProps = {
-    handleSubmit,
-    templatesLoaded,
-    isSubmitting,
-    template,
-    business_concept_id,
-    history,
-    match,
-    selectDomain,
-    applyTemplate: applyTemplate(template),
-  };
+  },
+};
 
-  const eventMock = {
-    preventDefault: jest.fn(),
-  };
-  const findField = (wrapper, name) => wrapper.find({ name });
+const rule = {
+  id: 123,
+  business_concept_id: "2D2B3",
+  name: "control1",
+  current_business_concept_version: { name: "My Concept" },
+};
 
-  it("matches the latest snapshot for editMode", () => {
-    const editMode = true;
-    const props = {
-      rule,
-      handleSubmit,
-      templatesLoaded,
-      editMode,
-      isSubmitting,
-      template,
-      business_concept_id,
-      applyTemplate: applyTemplate(template),
-    };
-
-    const wrapper = shallowWithIntl(<RuleForm {...props} />);
-    expect(wrapper).toMatchSnapshot();
-  });
-
-  it("matches the latest snapshot for create", () => {
-    const wrapper = shallowWithIntl(<RuleForm {...defaultProps} />);
-    expect(wrapper).toMatchSnapshot();
-  });
-
-  it("doesnt call handleSubmit when submitting invalid form", () => {
-    const wrapper = shallowWithIntl(<RuleForm {...defaultProps} />);
-
-    expect(handleSubmit.mock.calls.length).toBe(0);
-    const form = wrapper.find("Form");
-    form.simulate("submit", eventMock);
-    expect(handleSubmit.mock.calls.length).toBe(0);
-  });
-
-  it("calls handleSubmit when submitting valid form", () => {
-    const editMode = true;
-    const props = {
-      rule: { ...rule, domain_id: domain.id },
-      handleSubmit,
-      templatesLoaded,
-      editMode,
-      isSubmitting,
-      template,
-      business_concept_id,
-      selectDomain,
-      match,
-      applyTemplate: applyTemplate(template),
-    };
-    const wrapper = shallowWithIntl(<RuleForm {...props} />);
-
-    wrapper.find({ name: "dynamicForm" }).props().handleContentChange({});
-
-    expect(handleSubmit.mock.calls.length).toBe(0);
-    const form = wrapper.find("Form");
-    form.simulate("submit", eventMock);
-    expect(handleSubmit.mock.calls.length).toBe(1);
-  });
+const state = {
+  conceptActiveFilters: {},
+  domains: [{ id: 1, name: "domain1" }],
+};
 
-  it("handles correctly active field", () => {
-    const wrapper = shallowWithIntl(<RuleForm {...defaultProps} />);
+const renderOpts = { mocks: [templatesMock], state };
 
-    expect(findField(wrapper, "active").props().checked).toEqual(true);
-    findField(wrapper, "active").simulate("change", eventMock, {
-      name: "active",
-      checked: false,
+describe("<RuleForm />", () => {
+  it("matches the latest snapshot", async () => {
+    const props = { onSubmit: jest.fn() };
+    const { container, queryByText } = render(
+      <React.Suspense fallback="loading...">
+        <RuleForm {...props} />
+      </React.Suspense>,
+      renderOpts
+    );
+    await waitFor(() => {
+      expect(queryByText(/loading/i)).not.toBeInTheDocument();
     });
-    expect(findField(wrapper, "active").props().checked).toEqual(false);
-  });
-
-  it("handles domain selection", () => {
-    const wrapper = shallowWithIntl(<RuleForm {...defaultProps} />);
-    const DomainSelector = wrapper.find({ name: "domain" });
-    DomainSelector.simulate("change", eventMock, { value: domain.id });
-    expect(selectDomain).toHaveBeenCalledWith({ id: domain.id });
-    expect(wrapper.find({ name: "domain" }).prop("value")).toBe(domain.id);
-    expect(wrapper.find("Segment").at(0).prop("disabled")).toBeFalsy();
+    expect(container).toMatchSnapshot();
   });
 
-  describe("<FieldLabelWrapping />", () => {
-    it("matches the latest snapshot full", () => {
-      const props = {
-        children: <>child</>,
-        label: "label",
-        required: true,
-        tooltip: "tooltip",
-        messages: ["message"],
-      };
-
-      const wrapper = shallowWithIntl(<FieldLabelWrapping {...props} />);
-      expect(wrapper).toMatchSnapshot();
-    });
-    it("matches the latest snapshot no messages", () => {
-      const props = {
-        children: <>child</>,
-        label: "label",
-        required: true,
-        tooltip: "tooltip",
-      };
-
-      const wrapper = shallowWithIntl(<FieldLabelWrapping {...props} />);
-      expect(wrapper).toMatchSnapshot();
-    });
-    it("matches the latest snapshot no tooltip", () => {
-      const props = {
-        children: <>child</>,
-        label: "label",
-        required: true,
-        messages: ["message"],
-      };
-
-      const wrapper = shallowWithIntl(<FieldLabelWrapping {...props} />);
-      expect(wrapper).toMatchSnapshot();
-    });
-    it("matches the latest snapshot not required", () => {
-      const props = {
-        children: <>child</>,
-        label: "label",
-        tooltip: "tooltip",
-        messages: ["message"],
-      };
-
-      const wrapper = shallowWithIntl(<FieldLabelWrapping {...props} />);
-      expect(wrapper).toMatchSnapshot();
+  it("matches the latest snapshot (edit mode)", async () => {
+    const props = { onSubmit: jest.fn(), editMode: true };
+    const { container, queryByText } = render(
+      <React.Suspense fallback="loading...">
+        <RuleForm {...props} />
+      </React.Suspense>,
+      { ...renderOpts, state: { ...state, rule } }
+    );
+    await waitFor(() => {
+      expect(queryByText(/loading/i)).not.toBeInTheDocument();
     });
+    expect(container).toMatchSnapshot();
+  });
 
-    it("shows concept selector when concept prop is empty", () => {
-      const concept = {};
-      const props = {
-        rule,
-        handleSubmit,
-        templatesLoaded,
-        isSubmitting,
-        template,
-        business_concept_id,
-        concept,
-        applyTemplate: applyTemplate(template),
-      };
-
-      const wrapper = shallowWithIntl(<RuleForm {...props} />);
-      expect(
-        wrapper.find("AccordionContent").children().find("lazy").length
-      ).toBe(1);
-      wrapper.setProps({
-        concept: { business_concept_id: 1, name: "some name" },
-      });
-      expect(wrapper.find("Accordion").length).toBe(0);
+  it("enables save button after name and domain are specified", async () => {
+    const props = { onSubmit: jest.fn() };
+    const { getByRole, queryByText } = render(
+      <React.Suspense fallback="loading...">
+        <RuleForm {...props} />
+      </React.Suspense>,
+      renderOpts
+    );
+    await waitFor(() => {
+      expect(queryByText(/loading/i)).not.toBeInTheDocument();
     });
-
-    it("when accordion label is clicked handleConceptSelected is called", () => {
-      const concept = {};
-      const props = {
-        rule,
-        handleSubmit,
-        templatesLoaded,
-        isSubmitting,
-        template,
-        business_concept_id,
-        concept,
-        applyTemplate: applyTemplate(template),
-      };
-
-      const wrapper = shallowWithIntl(<RuleForm {...props} />);
-      const instance = wrapper.instance();
-      const label = wrapper.find("Label").find({ name: "delete" });
-      jest.spyOn(instance, "handleConceptSelected");
-      label.simulate("click", eventMock);
-      expect(instance.handleConceptSelected.mock.calls.length).toBe(1);
-      expect(instance.handleConceptSelected).toHaveBeenCalledWith(null);
+    expect(getByRole("button", { name: /save/i })).toBeDisabled();
+    userEvent.click(getByRole("option", { name: "domain1" }));
+    userEvent.type(getByRole("textbox", { name: /rule name/i }), "rule1");
+    await waitFor(() => {
+      expect(getByRole("button", { name: /save/i })).not.toBeDisabled();
     });
   });
 });

package/src/components/__tests__/RuleImplementation.spec.js

@@ -9,37 +9,60 @@ const state = {
     rule_id: 1,
     implementation_key: "impl key",
     id: 1,
+    executable: true,
   },
-  userRulePermissions: {
-    manage_quality_rule_implementations: true,
-    manage_quality_rules: true,
+};
+
+const stateExecutePermission = {
+  ...state,
+  implementationActions: {
+    manage: true,
+    link_concept: true,
+    execute: true,
   },
-  implementationActions: { link_concept: true },
 };
 
-const renderOpts = {
-  messages: {
-    en: {
-      "quality.result.no.data": "No information about quality",
-      "ruleImplementation.actions.clone": "clone",
-      "ruleImplementation.actions.delete.confirmation.content": "confirm",
-      "ruleImplementation.actions.delete.confirmation.header": "header",
-      "ruleImplementation.actions.deprecate": "archive",
-      "ruleImplementation.actions.edit": "edit",
-      "ruleImplementation.actions.move": "move",
-      "tabs.dq.implementation.links.concepts": "Related concepts",
-      "tabs.dq.implementation.structures": "Structures",
-      "tabs.dq.ruleImplementation.audit": "events",
-      "tabs.dq.ruleImplementation.results": "results",
-      "tabs.dq.ruleImplementation": "implementation",
-    },
+const stateNoExecutePermission = {
+  ...state,
+  implementationActions: {
+    manage: true,
+    link_concept: true,
+    execute: false,
   },
-  state,
+};
+
+const renderOptsNoExecutePermission = {
+  state: stateNoExecutePermission,
+};
+
+const renderOptsExecutePermission = {
+  state: stateExecutePermission,
 };
 
 describe("<RuleImplementation />", () => {
   it("matches the latest snapshot", () => {
-    const { container } = render(<RuleImplementation />, renderOpts);
+    const { container } = render(
+      <RuleImplementation />,
+      renderOptsExecutePermission
+    );
     expect(container).toMatchSnapshot();
   });
+
+  it("presence of execute permissions enables the execute button", () => {
+    const { queryByText } = render(
+      <RuleImplementation />,
+      renderOptsExecutePermission
+    );
+    const button = queryByText(/execute/i);
+    expect(button).toBeInTheDocument();
+  });
+
+  it("lack of execute permissions disables the execute button", () => {
+    const { queryByText } = render(
+      <RuleImplementation />,
+      renderOptsNoExecutePermission
+    );
+    const button = queryByText(/execute/i);
+    expect(button).not.toBeInTheDocument();
+  });
 });

package/src/components/__tests__/RuleImplementationsActions.spec.js

@@ -1,4 +1,3 @@
-import _ from "lodash/fp";
 import React from "react";
 import { shallow } from "enzyme";
 import { intl } from "@truedat/test/intl-stub";

package/src/components/__tests__/RuleImplementationsOptions.spec.js

@@ -1,22 +1,13 @@
 import React from "react";
 import { waitFor } from "@testing-library/react";
 import { render } from "@truedat/test/render";
-import coreEn from "@truedat/core/messages/en";
 import RuleImplementationsOptions from "../RuleImplementationsOptions";
-import en from "../../messages/en";
-
-const renderOpts = {
-  messages: { en: { ...coreEn, ...en } },
-};
 
 const props = { canUploadResults: true };
 
 describe("<RuleImplementationsOptions />", () => {
   it("matches the latest snapshot", async () => {
-    const { container } = render(
-      <RuleImplementationsOptions {...props} />,
-      renderOpts
-    );
+    const { container } = render(<RuleImplementationsOptions {...props} />);
     await waitFor(() => expect(container).toMatchSnapshot());
   });
 });

package/src/components/__tests__/RuleResultsUpload.spec.js

@@ -1,15 +1,11 @@
 import React from "react";
 import { waitFor } from "@testing-library/react";
 import { render } from "@truedat/test/render";
-import coreEn from "@truedat/core/messages/en";
 import RuleResultsUpload from "../RuleResultsUpload";
-import en from "../../messages/en";
-
-const renderOpts = { messages: { en: { ...coreEn, ...en } } };
 
 describe("<RuleResultsUpload />", () => {
   it("matches the latest snapshot", async () => {
-    const { container } = render(<RuleResultsUpload />, renderOpts);
+    const { container } = render(<RuleResultsUpload />);
     await waitFor(() => expect(container).toMatchSnapshot());
   });
 });

package/src/components/__tests__/RuleSummary.spec.js

@@ -1,8 +1,7 @@
 import React from "react";
-import { render } from "@truedat/test/render";
 import { fireEvent } from "@testing-library/react";
+import { render } from "@truedat/test/render";
 import { RuleSummary } from "../RuleSummary";
-import messages from "../../messages/en";
 
 describe("<RuleSummary />", () => {
   const implementationLimits = {
@@ -40,15 +39,11 @@ describe("<RuleSummary />", () => {
     },
   };
 
-  const renderOpts = {
-    messages: { en: messages },
-  };
-
   it("render 100% overGoal implementations", () => {
     const props = {
       implementations: [overGoalExecution],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
     expect(container).toHaveTextContent("100%");
   });
@@ -61,7 +56,7 @@ describe("<RuleSummary />", () => {
         underMinimumExecution,
       ],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
     expect(container).toHaveTextContent("33%");
   });
@@ -70,7 +65,7 @@ describe("<RuleSummary />", () => {
     const props = {
       implementations: [notExecuted, failedExecution],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
     expect(container).toHaveTextContent("50%");
   });
@@ -79,7 +74,7 @@ describe("<RuleSummary />", () => {
     const props = {
       implementations: [],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
   });
 
@@ -92,7 +87,7 @@ describe("<RuleSummary />", () => {
         underMinimumExecution,
       ],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
     expect(container.querySelector(".over-goal-color")).toHaveTextContent(
       "75%"

package/src/components/__tests__/__snapshots__/EditRule.spec.js.snap

@@ -20,7 +20,7 @@ exports[`<EditRule /> matches the latest snapshot 1`] = `
   </Header>
   <withRouter(injectIntl(Connect(RuleForm)))
     editMode={true}
-    handleSubmit={[MockFunction]}
+    onSubmit={[MockFunction]}
     rule={
       Object {
         "description": "dd",

package/src/components/__tests__/__snapshots__/ExecutionForm.spec.js.snap

@@ -8,8 +8,7 @@ exports[`<ExecutionForm /> matches the latest snapshot 1`] = `
     header
   </h2>
   <form
-    class="ui form"
-    style="display: none;"
+    class="ui loading form"
   >
     <p>
       content

package/src/components/__tests__/__snapshots__/NewRule.spec.js.snap

@@ -22,7 +22,7 @@ exports[`<NewRule /> matches the latest snapshot 1`] = `
     actions="manage_quality_rule"
   />
   <withRouter(injectIntl(Connect(RuleForm)))
-    handleSubmit={[MockFunction]}
+    onSubmit={[MockFunction]}
   />
 </Container>
 `;

package/src/components/__tests__/__snapshots__/RemediationForm.spec.js.snap

@@ -1,18 +1,17 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<RemediationForm /> with multiple templates matches the latest snapshot 1`] = `
+exports[`<RemediationForm /> matches the latest snapshot 1`] = `
 <div>
   <form
     aria-label="remediation-form"
     class="ui form"
-    style="display: none;"
   >
     <button
       class="ui primary disabled button"
       disabled=""
       tabindex="-1"
     >
-      actions.create
+      Create
     </button>
   </form>
 </div>