@truedat/dq 4.44.1 → 4.44.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.44.2] 2022-05-11
+
+### Fixed
+
+- [TD-4089] Segments tab was not displaying segments
+
 ## [4.44.1] 2022-05-11
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.44.1",
+  "version": "4.44.2",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -31,7 +31,7 @@
     "@babel/plugin-transform-modules-commonjs": "^7.15.0",
     "@babel/preset-env": "^7.15.0",
     "@babel/preset-react": "^7.14.5",
-    "@truedat/test": "4.44.1",
+    "@truedat/test": "4.44.2",
     "babel-jest": "^27.0.6",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -82,8 +82,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.4.10",
-    "@truedat/core": "4.44.1",
-    "@truedat/df": "4.44.1",
+    "@truedat/core": "4.44.2",
+    "@truedat/df": "4.44.2",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -103,5 +103,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "20d38381ed4cb6658d1122a4bff08a13fedc2d59"
+  "gitHead": "ca0c5fffcba96736f7a2054f3c37789da8c30a9e"
 }

package/src/components/RuleImplementationProperties.js

@@ -33,7 +33,6 @@ export const RuleImplementationProperties = ({
             </Label>
           </Grid.Column>
         </Grid.Row>
-        {console.log({ ruleImplementation })}
         {!_.isNil(ruleImplementation?.domain) && (
           <List size="big" relaxed>
             <List.Item>

package/src/components/RuleImplementationResultTabs.js

@@ -14,7 +14,6 @@ import {
 } from "@truedat/core/routes";
 
 export const RuleImplementationResultTabs = ({
-  rule,
   ruleImplementation,
   ruleResult,
   match,
@@ -54,28 +53,25 @@ export const RuleImplementationResultTabs = ({
     ) : null;
   };
 
-  return _.isEmpty(ruleImplementation) || _.isEmpty(rule) ? null : (
-    <>
-      <Menu attached="top" pointing secondary tabular>
-        <Menu.Item
-          active={match.path === IMPLEMENTATION_RESULT_DETAILS}
-          as={Link}
-          to={linkTo.IMPLEMENTATION_RESULT_DETAILS({
-            implementation_id: ruleImplementation.id,
-            rule_result_id: ruleResult.id,
-          })}
-        >
-          <FormattedMessage id="tabs.dq.ruleImplementationResult.info" />
-        </Menu.Item>
-        {renderSegmentResult()}
-        {renderRemediationPlan()}
-      </Menu>
-    </>
+  return _.isEmpty(ruleImplementation) ? null : (
+    <Menu attached="top" pointing secondary tabular>
+      <Menu.Item
+        active={match.path === IMPLEMENTATION_RESULT_DETAILS}
+        as={Link}
+        to={linkTo.IMPLEMENTATION_RESULT_DETAILS({
+          implementation_id: ruleImplementation.id,
+          rule_result_id: ruleResult.id,
+        })}
+      >
+        <FormattedMessage id="tabs.dq.ruleImplementationResult.info" />
+      </Menu.Item>
+      {renderSegmentResult()}
+      {renderRemediationPlan()}
+    </Menu>
   );
 };
 
 RuleImplementationResultTabs.propTypes = {
-  rule: PropTypes.object,
   ruleResult: PropTypes.object,
   ruleImplementation: PropTypes.object,
   match: PropTypes.object,
@@ -83,12 +79,11 @@ RuleImplementationResultTabs.propTypes = {
   templates: PropTypes.array,
 };
 
-const mapStateToProps = (
-  { rule, ruleImplementation, remediationActions, templates },
-  ownProps
-) => ({
-  rule,
-  ruleResult: ownProps.ruleResult,
+const mapStateToProps = ({
+  ruleImplementation,
+  remediationActions,
+  templates,
+}) => ({
   ruleImplementation,
   authCreateRemediation: _.has("create")(remediationActions),
   templates,

package/src/components/RuleImplementationResultsLink.js

@@ -3,11 +3,7 @@ import PropTypes from "prop-types";
 import { Link } from "react-router-dom";
 import { linkTo } from "@truedat/core/routes";
 
-export const RuleImplementationResultsLink = ({
-  id,
-  implementation_key,
-  rule_id,
-}) => (
+export const RuleImplementationResultsLink = ({ id, implementation_key }) => (
   <Link
     to={linkTo.IMPLEMENTATION_RESULTS({
       implementation_id: id,
@@ -20,7 +16,6 @@ export const RuleImplementationResultsLink = ({
 RuleImplementationResultsLink.propTypes = {
   id: PropTypes.number,
   implementation_key: PropTypes.string,
-  rule_id: PropTypes.number,
 };
 
 export default RuleImplementationResultsLink;

package/src/components/RuleResultSegmentRow.js

@@ -17,7 +17,6 @@ export const RuleResultSegmentRow = ({
   customColumns,
   isAdmin,
   ruleImplementation,
-  rule,
 }) => {
   const { formatMessage, formatNumber: _formatNumber } = useIntl();
   const formatNumber = (num) => (_.isNil(num) ? num : _formatNumber(num));
@@ -57,7 +56,6 @@ export const RuleResultSegmentRow = ({
             onConfirm={() =>
               deleteRuleResult({
                 id: segmentResult.id,
-                rule_id: rule.id,
                 rule_implementation_id: ruleImplementation.id,
               })
             }
@@ -73,7 +71,6 @@ RuleResultSegmentRow.propTypes = {
   deleteRuleResult: PropTypes.func,
   isAdmin: PropTypes.bool,
   optionalColumns: PropTypes.array,
-  rule: PropTypes.object,
   ruleImplementation: PropTypes.object,
   segmentResult: PropTypes.object,
 };

package/src/components/RuleResultSegments.js

@@ -3,7 +3,7 @@ import React from "react";
 import PropTypes from "prop-types";
 import { useIntl } from "react-intl";
 import { connect } from "react-redux";
-import { Table, Message, Divider } from "semantic-ui-react";
+import { Table, Message } from "semantic-ui-react";
 import { columnDecorator } from "@truedat/core/services";
 import { getSegmentResultsColumns } from "../selectors";
 import RuleResultSegmentRow from "./RuleResultSegmentRow";
@@ -21,7 +21,6 @@ export const getCustomColumnsWithData = (segmentResults, columns) =>
   )(columns);
 
 export const RuleResultSegments = ({
-  rule,
   isAdmin,
   ruleImplementation,
   customColumns,
@@ -31,7 +30,7 @@ export const RuleResultSegments = ({
 
   const optionalColumns = getOptionalColumnsWithData(segmentResults);
 
-  if (_.isEmpty(rule) || _.isEmpty(segmentResults)) return null;
+  if (_.isEmpty(segmentResults)) return null;
 
   return (
     <>
@@ -84,7 +83,6 @@ export const RuleResultSegments = ({
                 customColumns={customColumns}
                 isAdmin={isAdmin}
                 ruleImplementation={ruleImplementation}
-                rule={rule}
               />
             ))}
           </Table.Body>
@@ -96,14 +94,12 @@ export const RuleResultSegments = ({
 
 RuleResultSegments.propTypes = {
   ruleImplementation: PropTypes.object,
-  rule: PropTypes.object,
   segmentResults: PropTypes.object,
   customColumns: PropTypes.array,
   isAdmin: PropTypes.bool,
 };
 
 const mapStateToProps = (state) => ({
-  rule: state.rule,
   ruleImplementation: state.ruleImplementation,
   segmentResults: state.segmentResults,
   customColumns: getCustomColumnsWithData(

package/src/sagas/__tests__/deleteRuleResult.spec.js

@@ -3,7 +3,7 @@ import { testSaga } from "redux-saga-test-plan";
 import { apiJsonDelete, JSON_OPTS } from "@truedat/core/services/api";
 import {
   deleteRuleResultSaga,
-  deleteRuleResultRequestSaga
+  deleteRuleResultRequestSaga,
 } from "../deleteRuleResult";
 import { deleteRuleResult } from "../../routines";
 import { API_RULE_RESULT } from "../../api";
@@ -29,7 +29,7 @@ describe("sagas: deleteRuleResultRequestSaga", () => {
 });
 
 describe("sagas: deleteRuleResultSaga", () => {
-  const payload = { id: 1, rule_id: 2, rule_implementation_id: 3 };
+  const payload = { id: 1, rule_implementation_id: 3 };
   const { id } = payload;
   const url = compile(API_RULE_RESULT)({ id });
 
@@ -41,9 +41,7 @@ describe("sagas: deleteRuleResultSaga", () => {
         .next()
         .call(apiJsonDelete, url, JSON_OPTS)
         .next({ data: payload })
-        .put(
-          deleteRuleResult.success({ rule_id: 2, rule_implementation_id: 3 })
-        )
+        .put(deleteRuleResult.success({ rule_implementation_id: 3 }))
         .next()
         .put(deleteRuleResult.fulfill())
         .next()

package/src/sagas/deleteRuleResult.js

@@ -8,16 +8,11 @@ const toApiPath = compile(API_RULE_RESULT);
 
 export function* deleteRuleResultSaga({ payload }) {
   try {
-    const { id, rule_id, rule_implementation_id } = payload;
+    const { id, rule_implementation_id } = payload;
     const url = toApiPath({ id });
     yield put(deleteRuleResult.request());
     yield call(apiJsonDelete, url, JSON_OPTS);
-    yield put(
-      deleteRuleResult.success({
-        rule_id: rule_id,
-        rule_implementation_id: rule_implementation_id
-      })
-    );
+    yield put(deleteRuleResult.success({ rule_implementation_id }));
   } catch (error) {
     if (error.response) {
       const { status, data } = error.response;