@truedat/dq 4.44.0 → 4.44.3

package/src/components/__tests__/RuleImplementation.spec.js

@@ -9,37 +9,60 @@ const state = {
     rule_id: 1,
     implementation_key: "impl key",
     id: 1,
+    executable: true,
   },
-  userRulePermissions: {
-    manage_quality_rule_implementations: true,
-    manage_quality_rules: true,
+};
+
+const stateExecutePermission = {
+  ...state,
+  implementationActions: {
+    manage: true,
+    link_concept: true,
+    execute: true,
   },
-  implementationActions: { link_concept: true },
 };
 
-const renderOpts = {
-  messages: {
-    en: {
-      "quality.result.no.data": "No information about quality",
-      "ruleImplementation.actions.clone": "clone",
-      "ruleImplementation.actions.delete.confirmation.content": "confirm",
-      "ruleImplementation.actions.delete.confirmation.header": "header",
-      "ruleImplementation.actions.deprecate": "archive",
-      "ruleImplementation.actions.edit": "edit",
-      "ruleImplementation.actions.move": "move",
-      "tabs.dq.implementation.links.concepts": "Related concepts",
-      "tabs.dq.implementation.structures": "Structures",
-      "tabs.dq.ruleImplementation.audit": "events",
-      "tabs.dq.ruleImplementation.results": "results",
-      "tabs.dq.ruleImplementation": "implementation",
-    },
+const stateNoExecutePermission = {
+  ...state,
+  implementationActions: {
+    manage: true,
+    link_concept: true,
+    execute: false,
   },
-  state,
+};
+
+const renderOptsNoExecutePermission = {
+  state: stateNoExecutePermission,
+};
+
+const renderOptsExecutePermission = {
+  state: stateExecutePermission,
 };
 
 describe("<RuleImplementation />", () => {
   it("matches the latest snapshot", () => {
-    const { container } = render(<RuleImplementation />, renderOpts);
+    const { container } = render(
+      <RuleImplementation />,
+      renderOptsExecutePermission
+    );
     expect(container).toMatchSnapshot();
   });
+
+  it("presence of execute permissions enables the execute button", () => {
+    const { queryByText } = render(
+      <RuleImplementation />,
+      renderOptsExecutePermission
+    );
+    const button = queryByText(/execute/i);
+    expect(button).toBeInTheDocument();
+  });
+
+  it("lack of execute permissions disables the execute button", () => {
+    const { queryByText } = render(
+      <RuleImplementation />,
+      renderOptsNoExecutePermission
+    );
+    const button = queryByText(/execute/i);
+    expect(button).not.toBeInTheDocument();
+  });
 });

package/src/components/__tests__/RuleImplementationsActions.spec.js

@@ -1,4 +1,3 @@
-import _ from "lodash/fp";
 import React from "react";
 import { shallow } from "enzyme";
 import { intl } from "@truedat/test/intl-stub";

package/src/components/__tests__/RuleImplementationsOptions.spec.js

@@ -1,22 +1,13 @@
 import React from "react";
 import { waitFor } from "@testing-library/react";
 import { render } from "@truedat/test/render";
-import coreEn from "@truedat/core/messages/en";
 import RuleImplementationsOptions from "../RuleImplementationsOptions";
-import en from "../../messages/en";
-
-const renderOpts = {
-  messages: { en: { ...coreEn, ...en } },
-};
 
 const props = { canUploadResults: true };
 
 describe("<RuleImplementationsOptions />", () => {
   it("matches the latest snapshot", async () => {
-    const { container } = render(
-      <RuleImplementationsOptions {...props} />,
-      renderOpts
-    );
+    const { container } = render(<RuleImplementationsOptions {...props} />);
     await waitFor(() => expect(container).toMatchSnapshot());
   });
 });

package/src/components/__tests__/RuleResultsUpload.spec.js

@@ -1,15 +1,11 @@
 import React from "react";
 import { waitFor } from "@testing-library/react";
 import { render } from "@truedat/test/render";
-import coreEn from "@truedat/core/messages/en";
 import RuleResultsUpload from "../RuleResultsUpload";
-import en from "../../messages/en";
-
-const renderOpts = { messages: { en: { ...coreEn, ...en } } };
 
 describe("<RuleResultsUpload />", () => {
   it("matches the latest snapshot", async () => {
-    const { container } = render(<RuleResultsUpload />, renderOpts);
+    const { container } = render(<RuleResultsUpload />);
     await waitFor(() => expect(container).toMatchSnapshot());
   });
 });

package/src/components/__tests__/RuleSummary.spec.js

@@ -1,8 +1,7 @@
 import React from "react";
-import { render } from "@truedat/test/render";
 import { fireEvent } from "@testing-library/react";
+import { render } from "@truedat/test/render";
 import { RuleSummary } from "../RuleSummary";
-import messages from "../../messages/en";
 
 describe("<RuleSummary />", () => {
   const implementationLimits = {
@@ -40,15 +39,11 @@ describe("<RuleSummary />", () => {
     },
   };
 
-  const renderOpts = {
-    messages: { en: messages },
-  };
-
   it("render 100% overGoal implementations", () => {
     const props = {
       implementations: [overGoalExecution],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
     expect(container).toHaveTextContent("100%");
   });
@@ -61,7 +56,7 @@ describe("<RuleSummary />", () => {
         underMinimumExecution,
       ],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
     expect(container).toHaveTextContent("33%");
   });
@@ -70,7 +65,7 @@ describe("<RuleSummary />", () => {
     const props = {
       implementations: [notExecuted, failedExecution],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
     expect(container).toHaveTextContent("50%");
   });
@@ -79,7 +74,7 @@ describe("<RuleSummary />", () => {
     const props = {
       implementations: [],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
   });
 
@@ -92,7 +87,7 @@ describe("<RuleSummary />", () => {
         underMinimumExecution,
       ],
     };
-    const { container } = render(<RuleSummary {...props} />, renderOpts);
+    const { container } = render(<RuleSummary {...props} />);
     expect(container).toMatchSnapshot();
     expect(container.querySelector(".over-goal-color")).toHaveTextContent(
       "75%"

package/src/components/__tests__/__snapshots__/EditRule.spec.js.snap

@@ -20,7 +20,7 @@ exports[`<EditRule /> matches the latest snapshot 1`] = `
   </Header>
   <withRouter(injectIntl(Connect(RuleForm)))
     editMode={true}
-    handleSubmit={[MockFunction]}
+    onSubmit={[MockFunction]}
     rule={
       Object {
         "description": "dd",

package/src/components/__tests__/__snapshots__/ExecutionForm.spec.js.snap

@@ -8,8 +8,7 @@ exports[`<ExecutionForm /> matches the latest snapshot 1`] = `
     header
   </h2>
   <form
-    class="ui form"
-    style="display: none;"
+    class="ui loading form"
   >
     <p>
       content

package/src/components/__tests__/__snapshots__/ImplementationResultBar.spec.js.snap

@@ -8,7 +8,7 @@ exports[`<ImplementationResultBar /> render failed implementation 1`] = `
     <a
       as="div"
       class="rule-summary pointer"
-      href="/rules/8/implementations/1/results"
+      href="/implementations/1/results"
     >
       <span
         class="failed-color"
@@ -33,7 +33,7 @@ exports[`<ImplementationResultBar /> render not executed implementation 1`] = `
     <a
       as="div"
       class="rule-summary pointer"
-      href="/rules/8/implementations/1/results"
+      href="/implementations/1/results"
     >
       <span
         class="not-executed-color"
@@ -58,7 +58,7 @@ exports[`<ImplementationResultBar /> render overGoal implementation 1`] = `
     <a
       as="div"
       class="rule-summary pointer"
-      href="/rules/8/implementations/1/results"
+      href="/implementations/1/results"
     >
       <span
         class="over-goal-color"
@@ -88,7 +88,7 @@ exports[`<ImplementationResultBar /> render underGoal implementation 1`] = `
     <a
       as="div"
       class="rule-summary pointer"
-      href="/rules/8/implementations/1/results"
+      href="/implementations/1/results"
     >
       <span
         class="under-goal-color"
@@ -118,7 +118,7 @@ exports[`<ImplementationResultBar /> render underMinimum implementation 1`] = `
     <a
       as="div"
       class="rule-summary pointer"
-      href="/rules/8/implementations/1/results"
+      href="/implementations/1/results"
     >
       <span
         class="under-minimum-color"

package/src/components/__tests__/__snapshots__/NewRule.spec.js.snap

@@ -22,7 +22,7 @@ exports[`<NewRule /> matches the latest snapshot 1`] = `
     actions="manage_quality_rule"
   />
   <withRouter(injectIntl(Connect(RuleForm)))
-    handleSubmit={[MockFunction]}
+    onSubmit={[MockFunction]}
   />
 </Container>
 `;

package/src/components/__tests__/__snapshots__/NewRuleImplementation.spec.js.snap

@@ -926,6 +926,9 @@ exports[`<NewRuleImplementation /> matches the latest snapshot 1`] = `
                   </div>
                 </div>
               </div>
+              <div
+                class="field"
+              />
               <div
                 class="ui segment"
               >

package/src/components/__tests__/__snapshots__/RemediationForm.spec.js.snap

@@ -1,18 +1,17 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<RemediationForm /> with multiple templates matches the latest snapshot 1`] = `
+exports[`<RemediationForm /> matches the latest snapshot 1`] = `
 <div>
   <form
     aria-label="remediation-form"
     class="ui form"
-    style="display: none;"
   >
     <button
       class="ui primary disabled button"
       disabled=""
       tabindex="-1"
     >
-      actions.create
+      Create
     </button>
   </form>
 </div>

package/src/components/__tests__/__snapshots__/RuleCrumbs.spec.js.snap

@@ -27,58 +27,10 @@ exports[`<RuleCrumbs /> matches a snapshot with resultId 1`] = `
   <BreadcrumbDivider
     icon="right angle"
   />
-  <BreadcrumbSection
-    active={false}
-    as={
-      Object {
-        "$$typeof": Symbol(react.forward_ref),
-        "displayName": "Link",
-        "propTypes": Object {
-          "innerRef": [Function],
-          "onClick": [Function],
-          "replace": [Function],
-          "target": [Function],
-          "to": [Function],
-        },
-        "render": [Function],
-      }
-    }
-    to="/rules/1"
-  >
-    foo
-  </BreadcrumbSection>
-  <BreadcrumbDivider
-    icon="right angle"
-  />
-  <BreadcrumbSection
-    active={false}
-    as={
-      Object {
-        "$$typeof": Symbol(react.forward_ref),
-        "displayName": "Link",
-        "propTypes": Object {
-          "innerRef": [Function],
-          "onClick": [Function],
-          "replace": [Function],
-          "target": [Function],
-          "to": [Function],
-        },
-        "render": [Function],
-      }
-    }
-    to="/rules/1/implementations/2"
-  >
-    ri
-  </BreadcrumbSection>
-  <BreadcrumbDivider
-    icon="right angle"
-  />
   <BreadcrumbSection
     active={true}
   >
-    <DateTime
-      value="2021-10-14 11:57"
-    />
+    foo
   </BreadcrumbSection>
 </Breadcrumb>
 `;
@@ -110,33 +62,10 @@ exports[`<RuleCrumbs /> matches the latest snapshot 1`] = `
   <BreadcrumbDivider
     icon="right angle"
   />
-  <BreadcrumbSection
-    active={false}
-    as={
-      Object {
-        "$$typeof": Symbol(react.forward_ref),
-        "displayName": "Link",
-        "propTypes": Object {
-          "innerRef": [Function],
-          "onClick": [Function],
-          "replace": [Function],
-          "target": [Function],
-          "to": [Function],
-        },
-        "render": [Function],
-      }
-    }
-    to="/rules/1"
-  >
-    foo
-  </BreadcrumbSection>
-  <BreadcrumbDivider
-    icon="right angle"
-  />
   <BreadcrumbSection
     active={true}
   >
-    ri
+    foo
   </BreadcrumbSection>
 </Breadcrumb>
 `;