@truedat/dq 4.43.5 → 4.44.1

package/src/components/__tests__/__snapshots__/RuleCrumbs.spec.js.snap

@@ -27,58 +27,10 @@ exports[`<RuleCrumbs /> matches a snapshot with resultId 1`] = `
   <BreadcrumbDivider
     icon="right angle"
   />
-  <BreadcrumbSection
-    active={false}
-    as={
-      Object {
-        "$$typeof": Symbol(react.forward_ref),
-        "displayName": "Link",
-        "propTypes": Object {
-          "innerRef": [Function],
-          "onClick": [Function],
-          "replace": [Function],
-          "target": [Function],
-          "to": [Function],
-        },
-        "render": [Function],
-      }
-    }
-    to="/rules/1"
-  >
-    foo
-  </BreadcrumbSection>
-  <BreadcrumbDivider
-    icon="right angle"
-  />
-  <BreadcrumbSection
-    active={false}
-    as={
-      Object {
-        "$$typeof": Symbol(react.forward_ref),
-        "displayName": "Link",
-        "propTypes": Object {
-          "innerRef": [Function],
-          "onClick": [Function],
-          "replace": [Function],
-          "target": [Function],
-          "to": [Function],
-        },
-        "render": [Function],
-      }
-    }
-    to="/rules/1/implementations/2"
-  >
-    ri
-  </BreadcrumbSection>
-  <BreadcrumbDivider
-    icon="right angle"
-  />
   <BreadcrumbSection
     active={true}
   >
-    <DateTime
-      value="2021-10-14 11:57"
-    />
+    foo
   </BreadcrumbSection>
 </Breadcrumb>
 `;
@@ -110,33 +62,10 @@ exports[`<RuleCrumbs /> matches the latest snapshot 1`] = `
   <BreadcrumbDivider
     icon="right angle"
   />
-  <BreadcrumbSection
-    active={false}
-    as={
-      Object {
-        "$$typeof": Symbol(react.forward_ref),
-        "displayName": "Link",
-        "propTypes": Object {
-          "innerRef": [Function],
-          "onClick": [Function],
-          "replace": [Function],
-          "target": [Function],
-          "to": [Function],
-        },
-        "render": [Function],
-      }
-    }
-    to="/rules/1"
-  >
-    foo
-  </BreadcrumbSection>
-  <BreadcrumbDivider
-    icon="right angle"
-  />
   <BreadcrumbSection
     active={true}
   >
-    ri
+    foo
   </BreadcrumbSection>
 </Breadcrumb>
 `;

package/src/components/__tests__/__snapshots__/RuleImplementation.spec.js.snap

@@ -25,7 +25,7 @@ exports[`<RuleImplementation /> matches the latest snapshot 1`] = `
             <a
               as="div"
               class="rule-summary pointer"
-              href="/rules/1/implementations/1/results"
+              href="/implementations/1/results"
             >
               <span
                 class="not-executed-color"
@@ -44,117 +44,38 @@ exports[`<RuleImplementation /> matches the latest snapshot 1`] = `
     </div>
     <div
       class="right aligned eight wide column"
-    >
-      <div
-        aria-expanded="false"
-        class="ui floating dropdown button icon group-actions"
-        role="listbox"
-        tabindex="0"
-      >
-        <i
-          aria-hidden="true"
-          class="ellipsis vertical icon"
-        />
-        <div
-          class="left menu transition"
-        >
-          <a
-            class="item"
-          >
-            <i
-              aria-hidden="true"
-              class="black folder open outline icon"
-            />
-            archive
-          </a>
-          <a
-            aria-checked="false"
-            aria-selected="false"
-            class="item"
-            href="/rules/1/implementations/1/edit"
-            role="option"
-            style="pointer-events: all;"
-          >
-            <i
-              aria-hidden="true"
-              class="edit outline icon"
-            />
-            <span
-              class="text"
-            >
-              edit
-            </span>
-          </a>
-          <a
-            aria-checked="false"
-            aria-selected="false"
-            class="item"
-            href="/rules/1/implementations/1/move"
-            role="option"
-            style="pointer-events: all;"
-          >
-            <i
-              aria-hidden="true"
-              class="share square icon"
-            />
-            <span
-              class="text"
-            >
-              move
-            </span>
-          </a>
-          <a
-            aria-checked="false"
-            aria-selected="false"
-            class="item"
-            href="/rules/1/implementations/1/clone"
-            role="option"
-            style="pointer-events: all;"
-          >
-            <i
-              aria-hidden="true"
-              class="copy outline icon"
-            />
-            <span
-              class="text"
-            >
-              clone
-            </span>
-          </a>
-        </div>
-      </div>
-    </div>
+    />
   </div>
   <div
     class="ui pointing secondary top attached tabular menu"
   >
     <a
       class="item"
-      href="/rules/1/implementations/1"
+      href="/implementations/1"
     >
       implementation
     </a>
     <a
       class="item"
-      href="/rules/1/implementations/1/links/concepts"
+      href="/implementations/1/links/concepts"
     >
       Related concepts
     </a>
     <a
       class="item"
-      href="/rules/1/implementations/1/structures"
+      href="/implementations/1/structures"
     >
       Structures
     </a>
     <a
       class="item"
-      href="/rules/1/implementations/1/results"
+      href="/implementations/1/results"
     >
       results
     </a>
     <a
       class="item"
-      href="/rules/1/implementations/1/events"
+      href="/implementations/1/events"
     >
       events
     </a>

package/src/components/__tests__/__snapshots__/RuleImplementationResultTabs.spec.js.snap

@@ -7,7 +7,7 @@ exports[`<RuleImplementationResultTabs /> matches the latest snapshot 1`] = `
   >
     <a
       class="item"
-      href="/rules/8/implementations/1/results/2"
+      href="/implementations/1/results/2"
     >
       Information
     </a>

package/src/components/__tests__/__snapshots__/RuleImplementationResults.spec.js.snap

@@ -45,13 +45,6 @@ exports[`<RuleImplementationResults /> matches the latest snapshot 1`] = `
         }
         key="0"
         optionalColumns={Array []}
-        rule={
-          Object {
-            "goal": 100,
-            "minimum": 50,
-            "result_type": "percentage",
-          }
-        }
         ruleImplementation={
           Object {
             "results": Array [

package/src/components/__tests__/__snapshots__/RuleImplementationResultsLink.spec.js.snap

@@ -2,7 +2,7 @@
 
 exports[`<RuleImplementationResultsLink /> matches the latest snapshot 1`] = `
 <Link
-  to="/rules/4/implementations/123/results"
+  to="/implementations/123/results"
 >
   foo
 </Link>

package/src/components/__tests__/__snapshots__/RuleImplementationTabs.spec.js.snap

@@ -7,31 +7,31 @@ exports[`<RuleImplementationTabs /> matches the latest snapshot 1`] = `
   >
     <a
       class="item"
-      href="/rules/8/implementations/1"
+      href="/implementations/1"
     >
       ruleImplementation
     </a>
     <a
       class="item"
-      href="/rules/8/implementations/1/links/concepts"
+      href="/implementations/1/links/concepts"
     >
       concepts
     </a>
     <a
       class="item"
-      href="/rules/8/implementations/1/structures"
+      href="/implementations/1/structures"
     >
       structures
     </a>
     <a
       class="item"
-      href="/rules/8/implementations/1/results"
+      href="/implementations/1/results"
     >
       results
     </a>
     <a
       class="item"
-      href="/rules/8/implementations/1/events"
+      href="/implementations/1/events"
     >
       audit
     </a>

package/src/components/ruleImplementationForm/InformationForm.js

@@ -8,6 +8,9 @@ import { selectTemplate } from "@truedat/df/routines";
 
 import LimitsForm from "./LimitsForm";
 
+const DomainDropdownSelector = React.lazy(() =>
+  import("@truedat/bg/taxonomy/components/DomainDropdownSelector")
+);
 const TemplateSelector = React.lazy(() =>
   import("@truedat/df/templates/components/TemplateSelector")
 );
@@ -74,6 +77,7 @@ export const InformationForm = ({
   templates,
   onChange,
   ruleImplementation,
+  rule,
 }) => {
   const { formatMessage } = useIntl();
 
@@ -113,6 +117,14 @@ export const InformationForm = ({
           autoComplete="off"
         />
       </Form.Field>
+      {_.isEmpty(rule) && !ruleImplementation?.rule_id ? (
+        <Form.Field>
+          <DomainDropdownSelector
+            value={ruleImplementation.domain_id}
+            onChange={(_e, { value }) => onChange("domain_id", value)}
+          />
+        </Form.Field>
+      ) : null}
       <LimitsForm onChange={onChange} ruleImplementation={ruleImplementation} />
       {!_.isEmpty(templates) && (
         <ImplementationDynamicForm
@@ -134,8 +146,9 @@ InformationForm.propTypes = {
   template: PropTypes.object,
   templates: PropTypes.object,
   ruleImplementation: PropTypes.object,
+  rule: PropTypes.object,
 };
 
-const mapStateToProps = _.pick(["templates", "template"]);
+const mapStateToProps = _.pick(["templates", "template", "rule"]);
 
 export default connect(mapStateToProps, { selectTemplate })(InformationForm);

package/src/components/ruleImplementationForm/RuleImplementationForm.js

@@ -53,6 +53,7 @@ export const RuleImplementationForm = ({
   operators,
   onChange,
   template,
+  rule,
 }) => {
   const { formatMessage } = useIntl();
   const history = useHistory();
@@ -61,15 +62,17 @@ export const RuleImplementationForm = ({
     { name: "dataset", icon: "database", isValid: () => validDataSet() },
     { name: "populations", icon: "user", isValid: () => validPopulations() },
     { name: "validations", icon: "setting", isValid: () => validValidations() },
+    ...(authManageSegments
+      ? [
+          {
+            name: "segments",
+            icon: "grid layout",
+            isValid: () => validSegments(),
+          },
+        ]
+      : []),
   ];
 
-  if (authManageSegments)
-    steps.push({
-      name: "segments",
-      icon: "grid layout",
-      isValid: () => validSegments(),
-    });
-
   const [activeStep, setActiveStep] = useState("information");
   const [selector, setSelector] = useState();
 
@@ -85,6 +88,7 @@ export const RuleImplementationForm = ({
     template &&
     !_.isEmpty(template) &&
     _.size(validateContent(template)(dfContent)) == 0 &&
+    (!_.isEmpty(rule) || _.isNumber(_.prop("domain_id")(ruleImplementation))) &&
     areLimitsValid(ruleImplementation);
 
   const validPopulations = () =>
@@ -355,15 +359,16 @@ RuleImplementationForm.propTypes = {
   operators: PropTypes.object,
   onChange: PropTypes.func,
   template: PropTypes.object,
+  rule: PropTypes.object,
 };
 
 const mapStateToProps = (state) => ({
+  rule: state.rule,
   isSubmitting: state.ruleImplementationCreating,
   template: state.template,
-  authManageSegments: _.pathOr(
-    false,
-    "manage_segments"
-  )(state.userRulesPermissions),
+  authManageSegments:
+    _.pathOr(false, "userRulePermissions.manage_segments")(state) ||
+    _.pathOr(false, "implementationActions.manage_segments")(state),
 });
 
 export default connect(mapStateToProps)(RuleImplementationForm);

package/src/components/ruleImplementationForm/RuleImplementationRawForm.js

@@ -11,6 +11,10 @@ import { selectTemplate } from "@truedat/df/routines";
 import LimitsForm from "./LimitsForm";
 import { areLimitsValid } from "./limitsValidation";
 
+const DomainDropdownSelector = React.lazy(() =>
+  import("@truedat/bg/taxonomy/components/DomainDropdownSelector")
+);
+
 const Help = ({ message }) => {
   const { formatMessage } = useIntl();
   return (
@@ -77,6 +81,7 @@ ImplementationDynamicForm.propTypes = {
 };
 
 export const RuleImplementationRawForm = ({
+  rule,
   ruleImplementation,
   handleSubmit,
   isSubmitting,
@@ -145,6 +150,7 @@ export const RuleImplementationRawForm = ({
     template &&
     !_.isEmpty(template) &&
     _.size(validDfContent(template)(ruleImplementation?.dfContent)) == 0 &&
+    (!_.isEmpty(rule) || _.isNumber(_.prop("domain_id")(ruleImplementation))) &&
     areLimitsValid(ruleImplementation);
 
   const isValidForm = () => {
@@ -209,6 +215,14 @@ export const RuleImplementationRawForm = ({
           value={implementationKey}
         />
       </Form.Field>
+      {_.isEmpty(rule) && !ruleImplementation?.rule_id && (
+        <Form.Field>
+          <DomainDropdownSelector
+            value={ruleImplementation.domain_id}
+            onChange={(_e, { value }) => onChange("domain_id", value)}
+          />
+        </Form.Field>
+      )}
       <LimitsForm onChange={onChange} ruleImplementation={ruleImplementation} />
       {!_.isEmpty(templates) && (
         <ImplementationDynamicForm
@@ -361,12 +375,14 @@ RuleImplementationRawForm.propTypes = {
   templates: PropTypes.object,
   ruleImplementation: PropTypes.object,
   onChange: PropTypes.func,
+  rule: PropTypes.object,
 };
 
 const mapStateToProps = (state) => ({
   isSubmitting: state.ruleImplementationCreating,
   templates: state.templates,
   template: getTemplate(state),
+  rule: state.rule,
 });
 
 const getTemplate = ({ template, templates, ruleImplementation }) => {

package/src/components/ruleImplementationForm/__tests__/RuleImplementationForm.spec.js

@@ -1,4 +1,4 @@
-import React from "react";
+import React, { Suspense } from "react";
 import { render } from "@truedat/test/render";
 import { intl } from "@truedat/test/intl-stub";
 import { RuleImplementationForm } from "../RuleImplementationForm";
@@ -55,7 +55,9 @@ describe("<RuleImplementationForm />", () => {
 
   it("matches the latest snapshot", () => {
     const { container } = render(
-      <RuleImplementationForm {...props} />,
+      <Suspense fallback={null}>
+        <RuleImplementationForm {...props} />
+      </Suspense>,
       renderOpts
     );
     expect(container).toMatchSnapshot();

package/src/components/ruleImplementationForm/__tests__/RuleImplementationRawForm.spec.js

@@ -1,3 +1,4 @@
+import _ from "lodash/fp";
 import React from "react";
 import { shallow } from "enzyme";
 import { intl } from "@truedat/test/intl-stub";
@@ -110,6 +111,25 @@ describe("<RuleImplementationRawForm />", () => {
     expect(databaseDropdown).toHaveLength(0);
   });
 
+  it("submit button enabled if there is valid content in form with database without rule", () => {
+    const domainProps = _.set("ruleImplementation.domain_id", 5)(props);
+    const customProps = {
+      ...domainProps,
+      rawContent: {
+        dataset: "address a on c.address_id=a.id",
+        source_id: 2,
+        database: "db2",
+        population: "",
+        validations: "a.city='MADRID'",
+      },
+      template: { id: 1 },
+      dfContent: {},
+    };
+    const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
+    const submitButton = wrapper.find("FormButton[type='submit']");
+    expect(submitButton.props().disabled).toBe(false);
+  });
+
   it("submit button enabled if there is valid content in form with database", () => {
     const customProps = {
       ...props,
@@ -122,6 +142,7 @@ describe("<RuleImplementationRawForm />", () => {
       },
       template: { id: 1 },
       dfContent: {},
+      rule: { id: 5, name: "regla" },
     };
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
     const submitButton = wrapper.find("FormButton[type='submit']");
@@ -177,6 +198,24 @@ describe("<RuleImplementationRawForm />", () => {
     });
   });
 
+  it("submit button enabled if there is valid content in form without rule", () => {
+    const domainProps = _.set("ruleImplementation.domain_id", 5)(props);
+    const customProps = {
+      ...domainProps,
+      rawContent: {
+        dataset: "cliente c join address a on c.address_id=a.id",
+        source_id: 1,
+        population: "",
+        validations: "a.city='MADRID'",
+      },
+      template: { id: 1 },
+      dfContent: {},
+    };
+    const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
+    const submitButton = wrapper.find("FormButton[type='submit']");
+    expect(submitButton.props().disabled).toBe(false);
+  });
+
   it("submit button enabled if there is valid content in form", () => {
     const customProps = {
       ...props,
@@ -188,6 +227,7 @@ describe("<RuleImplementationRawForm />", () => {
       },
       template: { id: 1 },
       dfContent: {},
+      rule: { id: 5, name: "regla" },
     };
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
     const submitButton = wrapper.find("FormButton[type='submit']");

package/src/components/ruleImplementationForm/__tests__/__snapshots__/RuleImplementationForm.spec.js.snap

@@ -4,6 +4,7 @@ exports[`<RuleImplementationForm /> matches the latest snapshot 1`] = `
 <div>
   <div
     class="column"
+    style="display: none;"
   >
     <div
       class="stretched center aligned row"
@@ -136,6 +137,9 @@ exports[`<RuleImplementationForm /> matches the latest snapshot 1`] = `
             </div>
           </div>
         </div>
+        <div
+          class="field"
+        />
         <div
           class="ui segment"
         >

package/src/components/ruleImplementationForm/__tests__/__snapshots__/RuleImplementationRawForm.spec.js.snap

@@ -32,6 +32,11 @@ exports[`<RuleImplementationRawForm /> matches the latest snapshot 1`] = `
       value=""
     />
   </FormField>
+  <FormField>
+    <lazy
+      onChange={[Function]}
+    />
+  </FormField>
   <LimitsForm
     onChange={[MockFunction]}
     ruleImplementation={

package/src/messages/en.js

@@ -58,6 +58,8 @@ export default {
   "filtersGrid.field.label": "Field",
   "filtersGrid.field.operator": "Operator",
   "filtersGrid.field.value": "Value",
+  "implementations.actions.create": "Create implementation",
+  "implementations.actions.create_raw": "Create raw implementation",
   "implementations.actions.do_execution": "Execute implementations",
   "implementations.actions.download.tooltip": "Download with csv format",
   "implementations.actions.download.empty":
@@ -67,6 +69,7 @@ export default {
   "implementations.actions.execution.confirmation.header":
     "Implementations execution",
   "implementations.actions.execution.confirmation.legend": "Template fields",
+  "implementations.crumbs.top": "Implementations",
   "implementations.execute.filtered": "{count} implementations to execute",
   "implementations.search.placeholder": "Search implementations...",
   "implementationStructures.empty": "No structures found",
@@ -117,6 +120,7 @@ export default {
   "quality.result.percentage.description": "{result}%",
   "quality.result_type": "Result Type",
   "quality.rule.actions.create": "New Implementation",
+  "quality.rule.actions.create_raw": "New raw Implementation",
   "quality.rule.description": "Description",
   "quality.rule.failed": "Failed",
   "quality.rule.name": "Name",

package/src/messages/es.js

@@ -59,6 +59,8 @@ export default {
   "filtersGrid.field.label": "Campo",
   "filtersGrid.field.operator": "Operador",
   "filtersGrid.field.value": "Valor",
+  "implementations.actions.create": "Crear implementación",
+  "implementations.actions.create_raw": "Crear implementacion nativa",
   "implementations.actions.do_execution": "Ejecutar implementaciones",
   "implementations.actions.download.tooltip": "Descargar en formato csv",
   "implementations.actions.download.empty":
@@ -69,6 +71,7 @@ export default {
     "Solicitar ejecución de implementaciones",
   "implementations.actions.execution.confirmation.legend":
     "Campos de la plantilla",
+  "implementations.crumbs.top": "Implementaciones",
   "implementations.execute.filtered": "{count} implementaciones a ejecutar",
   "implementations.search.placeholder": "Buscar implementaciones...",
   "implementationStructures.empty": "Ningúna estructura encontrada",
@@ -126,6 +129,7 @@ export default {
   "quality.result.percentage.description": "{result}%",
   "quality.result": "Resultado",
   "quality.rule.actions.create": "Nueva Implementación",
+  "quality.rule.actions.create_raw": "Nueva implementación nativa",
   "quality.rule.description": "Descripción",
   "quality.rule.failed": "Failed",
   "quality.rule.name": "Nombre",

package/src/reducers/__tests__/ruleImplementationRedirect.spec.js

@@ -23,7 +23,7 @@ describe("reducers: ruleImplementationRedirect", () => {
 
   it("should be a link redirect after receiving the updateRuleImplementation.SUCCESS action", () => {
     const payload = { data: { id: 2, rule_id: 1 } };
-    const url = linkTo.RULE_IMPLEMENTATION({ id: 1, implementation_id: 2 });
+    const url = linkTo.IMPLEMENTATION({ id: 1, implementation_id: 2 });
 
     expect(
       ruleImplementationRedirect(fooState, {
@@ -49,7 +49,7 @@ describe("reducers: ruleImplementationRedirect", () => {
   it("should return a link to ruleImplementationResults after deleteRuleResult.SUCCESS action", () => {
     const payload = { rule_id: 1, rule_implementation_id: 2 };
 
-    const url = linkTo.RULE_IMPLEMENTATION_RESULTS({
+    const url = linkTo.IMPLEMENTATION_RESULTS({
       id: 1,
       implementation_id: 2,
     });

package/src/reducers/__tests__/ruleRedirect.spec.js

@@ -36,10 +36,10 @@ describe("reducers: ruleImplementationRedirect", () => {
   });
 
   it("should be a link redirect after receiving the setRuleImplementationStatus.SUCCESS action and redirect info", () => {
-    const payload = { id: 1, redirect: true };
+    const payload = { implementation_id: 1, redirect: true };
 
-    const url = linkTo.RULE_IMPLEMENTATIONS({
-      id: 1,
+    const url = linkTo.IMPLEMENTATION({
+      implementation_id: 1,
     });
     const meta = {};
     expect(

package/src/reducers/ruleImplementation.js

@@ -9,6 +9,8 @@ const pickFields = _.pick([
   "deleted_at",
   "df_content",
   "df_name",
+  "domain",
+  "domain_id",
   "event_inserted_at",
   "event_message",
   "event_type",
@@ -20,6 +22,7 @@ const pickFields = _.pick([
   "segments",
   "raw_content",
   "results",
+  "rule",
   "rule_id",
   "system",
   "validations",