@truedat/dq 4.42.6 → 4.43.0

package/src/components/__tests__/ImplementationStructuresNew.spec.js

@@ -0,0 +1,34 @@
+import React, { Suspense } from "react";
+import { render } from "@truedat/test/render";
+import { ImplementationStructuresNew } from "../ImplementationStructuresNew";
+
+describe("<ImplementationStructuresNew />", () => {
+  const renderOpts = {
+    messages: {
+      en: {
+        "actions.create": "create",
+        "actions.cancel": "cancel",
+        "implementationsStructures.new.header": "header",
+        "implementationsStructures.type": "type",
+        "implementationsStructures.type.dataset": "dataset",
+        "implementationsStructures.type.population": "population",
+        "implementationsStructures.type.validation": "validation",
+      },
+    },
+  };
+
+  it("matches the latest snapshot", () => {
+    const props = {
+      implementation: {},
+      creatingImplementationStructure: false,
+      createImplementationStructure: () => {},
+    };
+    const { container } = render(
+      <Suspense fallback={null}>
+        <ImplementationStructuresNew {...props} />,
+      </Suspense>,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/RuleImplementation.spec.js

@@ -27,7 +27,8 @@ const renderOpts = {
       "ruleImplementation.actions.deprecate": "archive",
       "ruleImplementation.actions.edit": "edit",
       "ruleImplementation.actions.move": "move",
-      "tabs.dq.implementation.links": "Related concepts",
+      "tabs.dq.implementation.links.concepts": "Related concepts",
+      "tabs.dq.implementation.structures": "Structures",
       "tabs.dq.ruleImplementation.audit": "events",
       "tabs.dq.ruleImplementation.results": "results",
       "tabs.dq.ruleImplementation": "implementation",

package/src/components/__tests__/RuleImplementationTabs.spec.js

@@ -7,7 +7,8 @@ describe("<RuleImplementationTabs />", () => {
     messages: {
       en: {
         "tabs.dq.ruleImplementation": "ruleImplementation",
-        "tabs.dq.implementation.links": "links",
+        "tabs.dq.implementation.links.concepts": "concepts",
+        "tabs.dq.implementation.structures": "structures",
         "tabs.dq.ruleImplementation.results": "results",
         "tabs.dq.ruleImplementation.details": "details",
         "tabs.dq.ruleImplementation.audit": "audit",

package/src/components/__tests__/__snapshots__/ImplementationStructureDelete.spec.js.snap

@@ -0,0 +1,10 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<ImplementationStructureDelete /> matches the latest snapshot 1`] = `
+<div>
+  <i
+    aria-hidden="true"
+    class="red trash alternate outline icon"
+  />
+</div>
+`;

package/src/components/__tests__/__snapshots__/ImplementationStructureLink.spec.js.snap

@@ -0,0 +1,11 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<ImplementationStructureLink /> matches the latest snapshot 1`] = `
+<div>
+  <a
+    href="/structures/1"
+  >
+    foo
+  </a>
+</div>
+`;

package/src/components/__tests__/__snapshots__/ImplementationStructures.spec.js.snap

@@ -0,0 +1,208 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<ImplementationStructures /> matches the latest snapshot 1`] = `
+<div>
+  <div
+    class="ui bottom attached segment"
+  >
+    <div
+      class="ui grid"
+    >
+      <div
+        class="sixteen wide column"
+      >
+        <table
+          class="ui table"
+        >
+          <thead
+            class=""
+          >
+            <tr
+              class=""
+            >
+              <th
+                class=""
+              >
+                name
+              </th>
+              <th
+                class=""
+              >
+                system
+              </th>
+              <th
+                class=""
+              >
+                path
+              </th>
+              <th
+                class=""
+              >
+                type
+              </th>
+              <th
+                class=""
+              />
+            </tr>
+          </thead>
+          <tbody
+            class=""
+          >
+            <tr
+              class=""
+            >
+              <td
+                class=""
+              >
+                <a
+                  href="/structures/1"
+                >
+                  qux
+                </a>
+              </td>
+              <td
+                class=""
+              >
+                bar
+              </td>
+              <td
+                class=""
+              >
+                <span
+                  title="baz"
+                >
+                  baz
+                </span>
+              </td>
+              <td
+                class=""
+              >
+                dataset
+              </td>
+              <td
+                class=""
+              >
+                <i
+                  aria-hidden="true"
+                  class="red trash alternate outline icon"
+                />
+              </td>
+            </tr>
+          </tbody>
+        </table>
+      </div>
+    </div>
+  </div>
+</div>
+`;
+
+exports[`<ImplementationStructures /> matches the latest snapshot without create permission 1`] = `
+<div>
+  <div
+    class="ui bottom attached segment"
+  >
+    <div
+      class="ui grid"
+    >
+      <div
+        class="sixteen wide column"
+      >
+        <table
+          class="ui table"
+        >
+          <thead
+            class=""
+          >
+            <tr
+              class=""
+            >
+              <th
+                class=""
+              >
+                name
+              </th>
+              <th
+                class=""
+              >
+                system
+              </th>
+              <th
+                class=""
+              >
+                path
+              </th>
+              <th
+                class=""
+              >
+                type
+              </th>
+            </tr>
+          </thead>
+          <tbody
+            class=""
+          >
+            <tr
+              class=""
+            >
+              <td
+                class=""
+              >
+                <a
+                  href="/structures/1"
+                >
+                  qux
+                </a>
+              </td>
+              <td
+                class=""
+              >
+                bar
+              </td>
+              <td
+                class=""
+              >
+                <span
+                  title="baz"
+                >
+                  baz
+                </span>
+              </td>
+              <td
+                class=""
+              >
+                dataset
+              </td>
+            </tr>
+          </tbody>
+        </table>
+      </div>
+    </div>
+  </div>
+</div>
+`;
+
+exports[`<ImplementationStructures /> matches the latest snapshot without data_structures 1`] = `
+<div>
+  <div
+    class="ui bottom attached segment"
+  >
+    <div
+      class="ui grid"
+    >
+      <h4
+        class="ui header"
+      >
+        <i
+          aria-hidden="true"
+          class="search icon"
+        />
+        <div
+          class="content"
+        >
+          empty
+        </div>
+      </h4>
+    </div>
+  </div>
+</div>
+`;

package/src/components/__tests__/__snapshots__/ImplementationStructuresNew.spec.js.snap

@@ -0,0 +1,106 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<ImplementationStructuresNew /> matches the latest snapshot 1`] = `
+<div>
+  <div
+    class="ui bottom attached segment"
+    style="display: none;"
+  >
+    <div
+      class="ui grid"
+    >
+      <div
+        class="column"
+        with="16"
+      >
+        <h4
+          class="ui header"
+        >
+          header
+        </h4>
+        <div
+          aria-expanded="false"
+          class="ui selection dropdown"
+          role="listbox"
+          tabindex="0"
+        >
+          <div
+            aria-atomic="true"
+            aria-live="polite"
+            class="divider text"
+            role="alert"
+          >
+            dataset
+          </div>
+          <i
+            aria-hidden="true"
+            class="dropdown icon"
+          />
+          <div
+            class="menu transition"
+          >
+            <div
+              aria-checked="true"
+              aria-selected="true"
+              class="active selected item"
+              role="option"
+              style="pointer-events: all;"
+            >
+              <span
+                class="text"
+              >
+                dataset
+              </span>
+            </div>
+            <div
+              aria-checked="false"
+              aria-selected="false"
+              class="item"
+              role="option"
+              style="pointer-events: all;"
+            >
+              <span
+                class="text"
+              >
+                population
+              </span>
+            </div>
+            <div
+              aria-checked="false"
+              aria-selected="false"
+              class="item"
+              role="option"
+              style="pointer-events: all;"
+            >
+              <span
+                class="text"
+              >
+                validation
+              </span>
+            </div>
+          </div>
+        </div>
+        <div
+          class="actions"
+        >
+          <a
+            class="ui secondary button"
+            href="/"
+            role="button"
+          >
+            cancel
+          </a>
+          <button
+            class="ui primary disabled button"
+            disabled=""
+            tabindex="-1"
+          >
+            create
+          </button>
+        </div>
+      </div>
+    </div>
+  </div>
+  
+</div>
+`;

package/src/components/__tests__/__snapshots__/RuleImplementation.spec.js.snap

@@ -136,10 +136,16 @@ exports[`<RuleImplementation /> matches the latest snapshot 1`] = `
     </a>
     <a
       class="item"
-      href="/rules/1/implementations/1/links"
+      href="/rules/1/implementations/1/links/concepts"
     >
       Related concepts
     </a>
+    <a
+      class="item"
+      href="/rules/1/implementations/1/structures"
+    >
+      Structures
+    </a>
     <a
       class="item"
       href="/rules/1/implementations/1/results"

package/src/components/__tests__/__snapshots__/RuleImplementationTabs.spec.js.snap

@@ -13,9 +13,15 @@ exports[`<RuleImplementationTabs /> matches the latest snapshot 1`] = `
     </a>
     <a
       class="item"
-      href="/rules/8/implementations/1/links"
+      href="/rules/8/implementations/1/links/concepts"
     >
-      links
+      concepts
+    </a>
+    <a
+      class="item"
+      href="/rules/8/implementations/1/structures"
+    >
+      structures
     </a>
     <a
       class="item"

package/src/messages/en.js

@@ -10,6 +10,7 @@ export default {
   "alert.createExecutionGroup.success.content":
     "{count} implementations queued for execution",
   "alert.createExecutionGroup.success.header": "Executions scheduled",
+  "alert.createImplementationStructure.failed.header": "Error linking to structure",
   "alert.createRule.failed.header": "Error creating rule",
   "alert.createRuleImplementation.failed.header":
     "Error creating implementation",
@@ -18,6 +19,8 @@ export default {
   "alert.updateRuleImplementation.failed.header":
     "Error updating implementation",
   "concepts.rules.empty": "This concept has no quality rules",
+  "createImplementationStructure.error.implementation_id.has already been taken":
+   "A link with same structure and type already exists",
   "createRule.error.domain_id.required": "Domain is required",
   "createRuleImplementation.error.implementation_key.duplicated":
     "Duplicated implementation key",
@@ -66,6 +69,14 @@ export default {
   "implementations.actions.execution.confirmation.legend": "Template fields",
   "implementations.execute.filtered": "{count} implementations to execute",
   "implementations.search.placeholder": "Search implementations...",
+  "implementationStructures.empty": "No structures found",
+  "implementationsStructures.new.header": "Link to Structure",
+  "implementationsStructures.type": "Type",
+  "implementationsStructures.type.dataset": "Dataset",
+  "implementationsStructures.type.population": "Population",
+  "implementationsStructures.type.validation": "Validation",
+  "implementationsStructures.delete.confirmation.header": "Delete Structure relation",
+  "implementationsStructures.delete.confirmation.content": "The relation will be deleted. Are you sure?",
   "navigation.quality": "Quality",
   "navigation.quality.rules": "Rules",
   "operator.dropdown.placeholder": "Operator",
@@ -571,7 +582,8 @@ export default {
   "structureFields.dropdown.label": "Select Field",
   "structureFields.dropdown.placeholder": "Fields",
   "summary.link.and": "and",
-  "tabs.dq.implementation.links": "Link to concepts",
+  "tabs.dq.implementation.links.concepts": "Link to concepts",
+  "tabs.dq.implementation.structures": "Structures",
   "tabs.dq.rule": "Rule",
   "tabs.dq.rule.audit": "Audit",
   "tabs.dq.ruleImplementation": "Implementation",

package/src/messages/es.js

@@ -11,6 +11,7 @@ export default {
   "alert.createExecutionGroup.success.content":
     "Se ha solicitado la ejecución de {count} implementaciones",
   "alert.createExecutionGroup.success.header": "Ejecuciones programadas",
+  "alert.createImplementationStructure.failed.header": "Error al vincular con estructura",
   "alert.createRule.failed.header": "Error creando regla",
   "alert.createRuleImplementation.failed.header":
     "Error creando implementación",
@@ -19,6 +20,8 @@ export default {
   "alert.updateRuleImplementation.failed.header":
     "Error actualizando implementación",
   "concepts.rules.empty": "Ese concepto no tiene reglas de calidad",
+  "createImplementationStructure.error.implementation_id.has already been taken":
+   "Una relación con misma estructura y tipo ya existe",
   "createRule.error.domain_id.required": "Dominio es requerido",
   "createRuleImplementation.error.implementation_key.duplicated":
     "Identificador duplicado",
@@ -68,6 +71,15 @@ export default {
     "Campos de la plantilla",
   "implementations.execute.filtered": "{count} implementaciones a ejecutar",
   "implementations.search.placeholder": "Buscar implementaciones...",
+  "implementationStructures.empty": "Ningúna estructura encontrada",
+  "implementationsStructures.new.header": "Vincular a una estructura",
+  "implementationsStructures.type": "Tipo",
+  "implementationsStructures.type.dataset": "Conjunto de Datos",
+  "implementationsStructures.type.population": "Populación",
+  "implementationsStructures.type.validation": "Validación",
+  "implementationsStructures.delete.confirmation.header": "Borrar relación con Estructura",
+  "implementationsStructures.delete.confirmation.content":
+    "La relación será eliminada. ¿Estás seguro?",
   "navigation.quality.rules": "Reglas",
   "navigation.quality": "Calidad",
   "operator.dropdown.placeholder": "Operador",
@@ -597,7 +609,8 @@ export default {
   "structureFields.dropdown.label": "Seleccionar Campo",
   "structureFields.dropdown.placeholder": "Campos",
   "summary.link.and": "y",
-  "tabs.dq.implementation.links": "Conceptos relacionados",
+  "tabs.dq.implementation.links.concepts": "Conceptos relacionados",
+  "tabs.dq.implementation.structures": "Estructuras",
   "tabs.dq.rule": "Regla",
   "tabs.dq.rule.audit": "Auditoría",
   "tabs.dq.ruleImplementation.audit": "Auditoría",

package/src/reducers/ruleImplementation.js

@@ -5,6 +5,7 @@ const initialState = {};
 
 const pickFields = _.pick([
   "dataset",
+  "data_structures",
   "deleted_at",
   "df_content",
   "df_name",

package/src/reducers/ruleImplementationRedirect.js

@@ -2,6 +2,7 @@ import { IMPLEMENTATIONS, linkTo } from "@truedat/core/routes";
 import { clearRedirect } from "@truedat/core/routines";
 import {
   createExecutionGroup,
+  createImplementationStructure,
   createRuleImplementation,
   updateRuleImplementation,
   deleteRuleResult,
@@ -21,6 +22,9 @@ export const ruleImplementationRedirect = (
       const id = payload?.data?.rule_id;
       return linkTo.RULE_IMPLEMENTATIONS({ id });
     }
+    case createImplementationStructure.SUCCESS: {
+      return payload?.redirectUrl;
+    }
     case createExecutionGroup.SUCCESS: {
       const id = payload?.data?.id;
       return linkTo.EXECUTION_GROUP({ id });

package/src/routines.js

@@ -96,3 +96,10 @@ export const createExecutionGroup = createRoutine("CREATE_EXECUTION_GROUP");
 export const fetchExecutionGroup = createRoutine("FETCH_EXECUTION_GROUP");
 export const clearExecutionGroup = createRoutine("CLEAR_EXECUTION_GROUP");
 export const fetchRemediation = createRoutine("FETCH_REMEDIATION");
+
+export const createImplementationStructure = createRoutine(
+  "CREATE_IMPLEMENTATION_STRUCTURE"
+);
+export const deleteImplementationStructure = createRoutine(
+  "DELETE_IMPLEMENTATION_STRUCTURE"
+);

package/src/sagas/__tests__/createImplementationStructure.spec.js

@@ -0,0 +1,86 @@
+import { compile } from "path-to-regexp";
+import { testSaga } from "redux-saga-test-plan";
+import { apiJsonPost, JSON_OPTS } from "@truedat/core/services/api";
+import {
+  createImplementationStructureRequestSaga,
+  createImplementationStructureSaga,
+} from "../createImplementationStructure";
+import { API_IMPLEMENTATIONS_STRUCTURES } from "../../api";
+import { createImplementationStructure } from "../../routines";
+
+describe("sagas: createImplementationStructureRequestSaga", () => {
+  it("should invoke createImplementationStructureSaga on trigger", () => {
+    expect(() => {
+      testSaga(createImplementationStructureRequestSaga)
+        .next()
+        .takeLatest(
+          createImplementationStructure.TRIGGER,
+          createImplementationStructureSaga
+        )
+        .finish()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should throw exception if an unhandled action is received", () => {
+    expect(() => {
+      testSaga(createImplementationStructureRequestSaga)
+        .next()
+        .takeLatest("FOO", createImplementationStructure);
+    }).toThrow();
+  });
+});
+
+describe("sagas: createImplementationStructureSaga", () => {
+  const implementationId = 1;
+  const dataStructureId = 2;
+  const type = "dataset";
+  const redirectUrl = "uri";
+
+  const url = compile(API_IMPLEMENTATIONS_STRUCTURES)({ implementationId });
+  const payload = {
+    implementationId,
+    dataStructureId,
+    type,
+    redirectUrl,
+  };
+
+  const requestData = { data_structure_id: dataStructureId, type };
+
+  const data = { response: "foo" };
+
+  it("should encode request content and put a success action when a response is returned", () => {
+    expect(() => {
+      testSaga(createImplementationStructureSaga, { payload })
+        .next()
+        .put(createImplementationStructure.request(payload))
+        .next()
+        .call(apiJsonPost, url, requestData, JSON_OPTS)
+        .next({ data })
+        .put(createImplementationStructure.success({ data, redirectUrl }))
+        .next()
+        .put(createImplementationStructure.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should put a failure action when the call returns an error", () => {
+    const message = "Request failed";
+    const error = { message };
+
+    expect(() => {
+      testSaga(createImplementationStructureSaga, { payload })
+        .next()
+        .put(createImplementationStructure.request(payload))
+        .next()
+        .call(apiJsonPost, url, requestData, JSON_OPTS)
+        .throw(error)
+        .put(createImplementationStructure.failure(message))
+        .next()
+        .put(createImplementationStructure.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+});