@truedat/dq 4.41.3 → 4.42.1

package/src/components/ruleImplementationForm/__tests__/__snapshots__/RuleImplementationRawForm.spec.js.snap

@@ -1,168 +1,171 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`<RuleImplementationRawForm /> matches the latest snapshot 1`] = `
-<Fragment>
-  <lazy />
-  <Form
-    as="form"
-    className="rule"
-  >
-    <FormRadio
-      as={[Function]}
-      checked={true}
-      control={[Function]}
-      label="ruleImplementation.props.executable"
-      name="executable"
-      onChange={[Function]}
-      toggle={true}
-    />
-    <FormField>
-      <label>
-        ruleImplementation.props.name
-        <Help
-          message="datasetForm.implementation_key.tooltip"
-        />
-      </label>
-      <FormInput
-        as={[Function]}
-        autoComplete="off"
-        control={[Function]}
-        name="implementation_key"
-        onChange={[Function]}
-        placeholder="ruleImplementation.props.name.placeholder"
-        required={true}
-        value=""
+<Form
+  as="form"
+  className="rule"
+>
+  <FormRadio
+    as={[Function]}
+    checked={true}
+    control={[Function]}
+    label="ruleImplementation.props.executable"
+    name="executable"
+    onChange={[Function]}
+    toggle={true}
+  />
+  <FormField>
+    <label>
+      ruleImplementation.props.name
+      <Help
+        message="datasetForm.implementation_key.tooltip"
       />
-    </FormField>
-    <LimitsForm
-      onChange={[MockFunction]}
-      ruleImplementation={
-        Object {
-          "executable": true,
-          "goal": "10",
-          "id": 1,
-          "minimum": "1",
-          "result_type": "percentage",
-        }
-      }
-    />
-    <FormDropdown
-      as={[Function]}
-      control={[Function]}
-      label={
-        <label>
-          <Memo(MemoizedFormattedMessage)
-            id="ruleImplementationRawForm.props.source"
-          />
-        </label>
-      }
-      name="source_id"
-      onChange={[Function]}
-      options={
-        Array [
-          Object {
-            "key": 1,
-            "text": "ext_id_1",
-            "value": 1,
-          },
-          Object {
-            "key": 2,
-            "text": "ext_id_2",
-            "value": 2,
-          },
-        ]
-      }
-      placeholder="ruleImplementationRawForm.props.source.placeholder"
-      required={true}
-      selection={true}
-      value={1}
-    />
-    <FormTextArea
+    </label>
+    <FormInput
       as={[Function]}
-      className="raw"
+      autoComplete="off"
       control={[Function]}
-      error={false}
-      label={
-        <label>
-          <Memo(MemoizedFormattedMessage)
-            id="ruleImplementationRawForm.props.dataset"
-          />
-          <Help
-            message="ruleImplementationRawForm.props.dataset.help"
-          />
-        </label>
-      }
-      name="dataset"
+      name="implementation_key"
       onChange={[Function]}
-      placeholder="ruleImplementationRawForm.props.dataset.placeholder"
+      placeholder="ruleImplementation.props.name.placeholder"
       required={true}
-      rows={4}
-      size="small"
-      value=""
-    />
-    <FormTextArea
-      as={[Function]}
-      className="raw"
-      control={[Function]}
-      error={false}
-      label={
-        <label>
-          <Memo(MemoizedFormattedMessage)
-            id="ruleImplementationRawForm.props.population"
-          />
-          <Help
-            message="ruleImplementationRawForm.props.population.help"
-          />
-        </label>
-      }
-      name="population"
-      onChange={[Function]}
-      placeholder="ruleImplementationRawForm.props.population.placeholder"
-      rows={4}
-      size="small"
       value=""
     />
-    <FormTextArea
-      as={[Function]}
-      className="raw"
-      control={[Function]}
-      error={false}
-      label={
-        <label>
-          <Memo(MemoizedFormattedMessage)
-            id="ruleImplementationRawForm.props.validations"
-          />
-          <Help
-            message="ruleImplementationRawForm.props.validations.help"
-          />
-        </label>
+  </FormField>
+  <LimitsForm
+    onChange={[MockFunction]}
+    ruleImplementation={
+      Object {
+        "executable": true,
+        "goal": "10",
+        "id": 1,
+        "minimum": "1",
+        "result_type": "percentage",
       }
-      name="validations"
-      onChange={[Function]}
-      placeholder="ruleImplementationRawForm.props.validations.placeholder"
-      required={true}
-      rows={4}
-      size="small"
-      value=""
-    />
-    <FormButton
-      as={[Function]}
-      content="actions.submit"
-      control={[Function]}
-      disabled={true}
-      floated="right"
-      loading={false}
-      onClick={[Function]}
-      primary={true}
-      type="submit"
-    />
-    <Button
-      as="button"
-      content="actions.cancel"
-      floated="right"
-      onClick={[Function]}
-      secondary={true}
-    />
-  </Form>
-</Fragment>
+    }
+  />
+  <FormDropdown
+    as={[Function]}
+    control={[Function]}
+    label={
+      <label>
+        <Memo(MemoizedFormattedMessage)
+          id="ruleImplementationRawForm.props.source"
+        />
+      </label>
+    }
+    name="source_id"
+    onChange={[Function]}
+    options={
+      Array [
+        Object {
+          "key": "1",
+          "text": undefined,
+          "value": "1",
+        },
+        Object {
+          "key": "2",
+          "text": undefined,
+          "value": "2",
+        },
+        Object {
+          "key": "3",
+          "text": undefined,
+          "value": "3",
+        },
+      ]
+    }
+    placeholder="ruleImplementationRawForm.props.source.placeholder"
+    required={true}
+    search={true}
+    selection={true}
+    value="1"
+  />
+  <FormTextArea
+    as={[Function]}
+    className="raw"
+    control={[Function]}
+    error={false}
+    label={
+      <label>
+        <Memo(MemoizedFormattedMessage)
+          id="ruleImplementationRawForm.props.dataset"
+        />
+        <Help
+          message="ruleImplementationRawForm.props.dataset.help"
+        />
+      </label>
+    }
+    name="dataset"
+    onChange={[Function]}
+    placeholder="ruleImplementationRawForm.props.dataset.placeholder"
+    required={true}
+    rows={4}
+    size="small"
+    value=""
+  />
+  <FormTextArea
+    as={[Function]}
+    className="raw"
+    control={[Function]}
+    error={false}
+    label={
+      <label>
+        <Memo(MemoizedFormattedMessage)
+          id="ruleImplementationRawForm.props.population"
+        />
+        <Help
+          message="ruleImplementationRawForm.props.population.help"
+        />
+      </label>
+    }
+    name="population"
+    onChange={[Function]}
+    placeholder="ruleImplementationRawForm.props.population.placeholder"
+    rows={4}
+    size="small"
+    value=""
+  />
+  <FormTextArea
+    as={[Function]}
+    className="raw"
+    control={[Function]}
+    error={false}
+    label={
+      <label>
+        <Memo(MemoizedFormattedMessage)
+          id="ruleImplementationRawForm.props.validations"
+        />
+        <Help
+          message="ruleImplementationRawForm.props.validations.help"
+        />
+      </label>
+    }
+    name="validations"
+    onChange={[Function]}
+    placeholder="ruleImplementationRawForm.props.validations.placeholder"
+    required={true}
+    rows={4}
+    size="small"
+    value=""
+  />
+  <FormButton
+    as={[Function]}
+    content="actions.submit"
+    control={[Function]}
+    disabled={true}
+    floated="right"
+    loading={false}
+    onClick={[Function]}
+    primary={true}
+    type="submit"
+  />
+  <Button
+    as="button"
+    content="actions.cancel"
+    floated="right"
+    onClick={[Function]}
+    secondary={true}
+  />
+</Form>
 `;

package/src/messages/en.js

@@ -138,7 +138,7 @@ export default {
     "All rule implementations should be removed",
   "rule.error.rule_name_bc_id.unique_constraint":
     "Duplicated rule name. Edit name or associated business concept.",
-  
+
   "rule.form.accordion.select": "Select",
   "rule.form.concept.label": "Concept",
   "ruleImplementation.form.tooltip.deviation.goal":
@@ -441,9 +441,10 @@ export default {
   "ruleImplementation.system.placeholder": "Select a system",
   "ruleImplementation.table": "Table",
   "ruleImplementation.table.placeholder": "Select a table",
+  "ruleImplementationForm.populations.add": "Add population",
   "ruleImplementationForm.step.information": "Information",
   "ruleImplementationForm.step.dataset": "Data Set",
-  "ruleImplementationForm.step.population": "Population",
+  "ruleImplementationForm.step.populations": "Populations",
   "ruleImplementationForm.step.validations": "Validations",
   "ruleImplementationRawForm.props.database": "Database",
   "ruleImplementationRawForm.props.database.placeholder": "Select database",
@@ -515,6 +516,7 @@ export default {
   "ruleImplementations.summary.headers.filters": "Filters",
   "ruleImplementations.summary.headers.implementation": "Rule Implementation",
   "ruleImplementations.summary.headers.population": "Population",
+  "ruleImplementations.summary.headers.populations": "Populations",
   "ruleImplementations.summary.headers.validations": "Validation",
   "ruleImplementations.upload.success.errors":
     "Error in {implementation_key} attribute: {key} message: {message} ",

package/src/messages/es.js

@@ -455,9 +455,10 @@ export default {
   "ruleImplementation.system": "Sistema",
   "ruleImplementation.table.placeholder": "Seleccionar tabla",
   "ruleImplementation.table": "Tabla",
+  "ruleImplementationForm.populations.add": "Añadir población",
   "ruleImplementationForm.step.dataset": "Datos",
   "ruleImplementationForm.step.information": "Información",
-  "ruleImplementationForm.step.population": "Población",
+  "ruleImplementationForm.step.populations": "Poblaciones",
   "ruleImplementationForm.step.validations": "Validaciones",
   "ruleImplementationRawForm.props.database.placeholder":
     "Seleccionar base de datos",
@@ -537,6 +538,7 @@ export default {
   "ruleImplementations.summary.headers.implementation":
     "Implementación de una Regla",
   "ruleImplementations.summary.headers.population": "Población",
+  "ruleImplementations.summary.headers.populations": "Poblaciones",
   "ruleImplementations.summary.headers.validations": "Validaciones",
   "ruleImplementations.upload.success.errors":
     "Error en {name} atributo: {key} mensaje: {message} ",

package/src/reducers/ruleImplementation.js

@@ -15,7 +15,7 @@ const pickFields = _.pick([
   "id",
   "implementation_key",
   "implementation_type",
-  "population",
+  "populations",
   "raw_content",
   "results",
   "rule_id",

package/src/sagas/__tests__/createRuleImplementation.spec.js

@@ -2,7 +2,7 @@ import { testSaga } from "redux-saga-test-plan";
 import { apiJsonPost, JSON_OPTS } from "@truedat/core/services/api";
 import {
   createRuleImplementationRequestSaga,
-  createRuleImplementationSaga
+  createRuleImplementationSaga,
 } from "../createRuleImplementation";
 import { API_RULE_IMPLEMENTATIONS } from "../../api";
 import { createRuleImplementation, clearStructure } from "../../routines";
@@ -35,21 +35,23 @@ describe("sagas: createRuleImplementationSaga", () => {
   const rule_implementation = {
     implementation_key: "Awesome Impl Key",
     dataset: [{ structure: { id: 1 } }],
-    population: [
-      {
-        operator: { name: "eq", value_type: "number" },
-        structure: { id: 2 },
-        value: [{ raw: 3 }]
-      }
+    populations: [
+      [
+        {
+          operator: { name: "eq", value_type: "number" },
+          structure: { id: 2 },
+          value: [{ raw: 3 }],
+        },
+      ],
     ],
     validations: [
       {
         operator: { name: "between", value_type: "field" },
         structure: { id: 3 },
-        value: [{ id: 4 }, { id: 5 }]
-      }
+        value: [{ id: 4 }, { id: 5 }],
+      },
     ],
-    rule_id: 1
+    rule_id: 1,
   };
   const data = { rule_implementation };
   const url = API_RULE_IMPLEMENTATIONS;

package/src/sagas/__tests__/updateRuleImplementation.spec.js

@@ -39,12 +39,14 @@ describe("sagas: updateRuleImplementationSaga", () => {
     id: 1,
     implementation_key: "impl_key",
     dataset: [{ structure: { id: 1 } }],
-    population: [
-      {
-        operator: { name: "eq", value_type: "number" },
-        structure: { id: 2 },
-        value: [{ raw: 3 }],
-      },
+    populations: [
+      [
+        {
+          operator: { name: "eq", value_type: "number" },
+          structure: { id: 2 },
+          value: [{ raw: 3 }],
+        },
+      ],
     ],
     validations: [
       {