@truedat/dq 4.40.9 → 4.40.12

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,11 @@
1
1
  # Changelog
2
2
 
3
+ ## [4.40.11] 2022-03-21
4
+
5
+ ### Fixed
6
+
7
+ - [TD-3233] UI visibility condition
8
+
3
9
  ## [4.40.9] 2022-03-20
4
10
 
5
11
  ### Fixed
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@truedat/dq",
3
- "version": "4.40.9",
3
+ "version": "4.40.12",
4
4
  "description": "Truedat Web Data Quality Module",
5
5
  "sideEffects": false,
6
6
  "jsnext:main": "src/index.js",
@@ -31,7 +31,7 @@
31
31
  "@babel/plugin-transform-modules-commonjs": "^7.15.0",
32
32
  "@babel/preset-env": "^7.15.0",
33
33
  "@babel/preset-react": "^7.14.5",
34
- "@truedat/test": "4.40.9",
34
+ "@truedat/test": "4.40.12",
35
35
  "babel-jest": "^27.0.6",
36
36
  "babel-plugin-dynamic-import-node": "^2.3.3",
37
37
  "babel-plugin-lodash": "^3.3.4",
@@ -82,8 +82,8 @@
82
82
  },
83
83
  "dependencies": {
84
84
  "@apollo/client": "^3.4.10",
85
- "@truedat/core": "4.40.9",
86
- "@truedat/df": "4.40.9",
85
+ "@truedat/core": "4.40.12",
86
+ "@truedat/df": "4.40.12",
87
87
  "axios": "^0.19.2",
88
88
  "graphql": "^15.5.3",
89
89
  "path-to-regexp": "^1.7.0",
@@ -103,5 +103,5 @@
103
103
  "react-dom": ">= 16.8.6 < 17",
104
104
  "semantic-ui-react": ">= 0.88.2 < 2.1"
105
105
  },
106
- "gitHead": "618928c0c77ccea1e95b9a6d3255ecf8cbed0c90"
106
+ "gitHead": "f8f89f659e97ba1eeb39d9f86c9b8c2c8934518a"
107
107
  }
@@ -155,13 +155,8 @@ ExecutionDetails.propTypes = {
155
155
  ruleResultId: PropTypes.number,
156
156
  };
157
157
 
158
- const mapStateToProps = ({
158
+ const mapStateToProps = ({ ruleImplementation }) => ({
159
159
  ruleImplementation,
160
- templatesLoading,
161
- templates,
162
- }) => ({
163
- templatesLoaded: !templatesLoading && !_.isEmpty(templates),
164
- ruleImplementation: ruleImplementation,
165
160
  });
166
161
 
167
162
  export default connect(mapStateToProps)(ExecutionDetails);
@@ -68,67 +68,71 @@ export const RemediationPlan = ({
68
68
  />
69
69
  ) : (
70
70
  <>
71
- <Header as="h2">
72
- <Icon circular name="rain" />
73
- <Header.Content>
74
- <FormattedMessage
75
- id={!isEdit ? "remediation" : "remediation.actions.edit"}
76
- />
77
- </Header.Content>
78
- </Header>
71
+ {!_.isEmpty(remediation) ? (
72
+ <>
73
+ <Header as="h2">
74
+ <Icon circular name="rain" />
75
+ <Header.Content>
76
+ <FormattedMessage
77
+ id={!isEdit ? "remediation" : "remediation.actions.edit"}
78
+ />
79
+ </Header.Content>
80
+ </Header>
79
81
 
80
- <Segment className={className}>
81
- {!_.isEmpty(remediation) && manageRemediations ? (
82
- <div className="ui actions remediation">
83
- <ConfirmModal
84
- icon="trash"
85
- trigger={<Button secondary icon="trash" basic color="red" />}
86
- header={
87
- <FormattedMessage id="remediation.actions.delete.confirmation.header" />
88
- }
89
- content={
90
- <FormattedMessage
91
- id="remediation.actions.delete.confirmation.content"
92
- values={{ ruleResultId: <b>{ruleResultId}</b> }}
82
+ <Segment className={className}>
83
+ {manageRemediations ? (
84
+ <div className="ui actions remediation">
85
+ <ConfirmModal
86
+ icon="trash"
87
+ trigger={<Button secondary icon="trash" basic color="red" />}
88
+ header={
89
+ <FormattedMessage id="remediation.actions.delete.confirmation.header" />
90
+ }
91
+ content={
92
+ <FormattedMessage
93
+ id="remediation.actions.delete.confirmation.content"
94
+ values={{ ruleResultId: <b>{ruleResultId}</b> }}
95
+ />
96
+ }
97
+ onConfirm={() =>
98
+ deleteRemediation({
99
+ implementation_id: implementationId,
100
+ rule_result_id: ruleResultId,
101
+ })
102
+ }
103
+ />
104
+ <Button
105
+ className="button-edit-remediation"
106
+ primary
107
+ onClick={() => setIsEdit(!isEdit)}
108
+ content={formatMessage({
109
+ id: !isEdit ? "actions.edit" : "actions.cancel",
110
+ })}
93
111
  />
94
- }
95
- onConfirm={() =>
96
- deleteRemediation({
97
- implementation_id: implementationId,
98
- rule_result_id: ruleResultId,
99
- })
100
- }
101
- />
102
- <Button
103
- className="button-edit-remediation"
104
- primary
105
- onClick={() => setIsEdit(!isEdit)}
106
- content={formatMessage({
107
- id: !isEdit ? "actions.edit" : "actions.cancel",
108
- })}
109
- />
110
- </div>
111
- ) : null}
112
+ </div>
113
+ ) : null}
112
114
 
113
- <Grid>
114
- <Grid.Column width={8}>
115
- {!isEdit && remediation?.df_name ? (
116
- <DynamicFormViewer
117
- template={_.find(_.propEq("name", remediation.df_name))(
118
- templates
115
+ <Grid>
116
+ <Grid.Column width={8}>
117
+ {!isEdit && remediation?.df_name ? (
118
+ <DynamicFormViewer
119
+ template={_.find(_.propEq("name", remediation.df_name))(
120
+ templates
121
+ )}
122
+ content={remediation.df_content}
123
+ />
124
+ ) : (
125
+ <RemediationForm
126
+ onSave={onSave}
127
+ remediation={remediation}
128
+ latestResultId={latestResultId}
129
+ />
119
130
  )}
120
- content={remediation.df_content}
121
- />
122
- ) : (
123
- <RemediationForm
124
- onSave={onSave}
125
- remediation={remediation}
126
- latestResultId={latestResultId}
127
- />
128
- )}
129
- </Grid.Column>
130
- </Grid>
131
- </Segment>
131
+ </Grid.Column>
132
+ </Grid>
133
+ </Segment>
134
+ </>
135
+ ) : null}
132
136
  </>
133
137
  );
134
138
  };
@@ -125,45 +125,6 @@ exports[`<ExecutionDetails> matches the latest snapshot 1`] = `
125
125
  </tr>
126
126
  </tbody>
127
127
  </table>
128
- <h2
129
- class="ui header"
130
- style="display: none;"
131
- >
132
- <i
133
- aria-hidden="true"
134
- class="rain circular icon"
135
- />
136
- <div
137
- class="content"
138
- >
139
- Remediation plan
140
- </div>
141
- </h2>
142
- <div
143
- class="ui segment execution-details-remediation"
144
- style="display: none;"
145
- >
146
- <div
147
- class="ui grid"
148
- >
149
- <div
150
- class="eight wide column"
151
- >
152
- <form
153
- aria-label="remediation-form"
154
- class="ui form"
155
- >
156
- <button
157
- class="ui primary disabled button"
158
- disabled=""
159
- tabindex="-1"
160
- >
161
- create
162
- </button>
163
- </form>
164
- </div>
165
- </div>
166
- </div>
167
128
  </div>
168
129
  `;
169
130
 
@@ -258,42 +219,5 @@ exports[`<ExecutionDetails> without details 1`] = `
258
219
  </tr>
259
220
  </tbody>
260
221
  </table>
261
- <h2
262
- class="ui header"
263
- >
264
- <i
265
- aria-hidden="true"
266
- class="rain circular icon"
267
- />
268
- <div
269
- class="content"
270
- >
271
- Remediation plan
272
- </div>
273
- </h2>
274
- <div
275
- class="ui segment execution-details-remediation"
276
- >
277
- <div
278
- class="ui grid"
279
- >
280
- <div
281
- class="eight wide column"
282
- >
283
- <form
284
- aria-label="remediation-form"
285
- class="ui form"
286
- >
287
- <button
288
- class="ui primary disabled button"
289
- disabled=""
290
- tabindex="-1"
291
- >
292
- create
293
- </button>
294
- </form>
295
- </div>
296
- </div>
297
- </div>
298
222
  </div>
299
223
  `;