@truedat/dq 4.40.6 → 4.40.9

package/src/components/__tests__/ExecutionDetails.spec.js

@@ -1,5 +1,4 @@
-import _ from "lodash/fp";
-import React from "react";
+import React, { Suspense } from "react";
 import { render } from "@truedat/test/render";
 import messages from "@truedat/dq/messages";
 import { ExecutionDetails } from "../ExecutionDetails";
@@ -14,6 +13,7 @@ const renderOpts = {
     en: {
       ...messages.en,
       "ruleResult.details.props.test": "TestMessage",
+      "actions.create": "create",
     },
   },
 };
@@ -25,7 +25,12 @@ describe("<ExecutionDetails>", () => {
         results: [{ foo: "bar", id: 100, details: { Query: "ImZvbyI=" } }],
       },
     };
-    const { container } = render(<ExecutionDetails {...props} />, renderOpts);
+    const { container } = render(
+      <Suspense fallback={null}>
+        <ExecutionDetails {...props} />
+      </Suspense>,
+      renderOpts
+    );
     expect(container).toMatchSnapshot();
   });
 
@@ -44,7 +49,12 @@ describe("<ExecutionDetails>", () => {
         ],
       },
     };
-    const { getByText } = render(<ExecutionDetails {...props} />, renderOpts);
+    const { getByText } = render(
+      <Suspense fallback={null}>
+        <ExecutionDetails {...props} />
+      </Suspense>,
+      renderOpts
+    );
     expect(getByText("TestMessage")).toBeInTheDocument();
     expect(getByText("Base64_value")).toBeInTheDocument();
   });
@@ -56,7 +66,9 @@ describe("<ExecutionDetails>", () => {
       },
     };
     const { container } = render(
-      <ExecutionDetails {...propsWithoutDetails} />,
+      <Suspense fallback={null}>
+        <ExecutionDetails {...propsWithoutDetails} />
+      </Suspense>,
       renderOpts
     );
     expect(container).toMatchSnapshot();

package/src/components/__tests__/RemediationForm.spec.js

@@ -0,0 +1,68 @@
+import React, { Suspense } from "react";
+import { shallowWithIntl, intl } from "@truedat/test/intl-stub";
+import { render } from "@truedat/test/render";
+import { RemediationForm } from "../RemediationForm";
+
+// workaround for enzyme issue with React.useContext
+// see https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526
+jest.spyOn(React, "useContext").mockImplementation(() => intl);
+
+jest.mock("react-router-dom", () => ({
+  ...jest.requireActual("react-router-dom"), // use actual for all non-hook parts
+  useParams: () => ({
+    id: 777,
+    implementation_id: 862,
+    rule_result_id: 66322,
+  }),
+  useRouteMatch: () => ({
+    url: "/rules/777/implementations/862/results/66322",
+  }),
+}));
+
+describe("<RemediationForm />", () => {
+  const createRemediation = jest.fn();
+  const updateRemediation = jest.fn();
+  const template1 = { id: 1, name: "template1" };
+  const template2 = { id: 2, name: "template2" };
+  const templates = [template1, template2];
+  const remediation = {};
+  const onSave = jest.fn();
+
+  const props = {
+    createRemediation,
+    updateRemediation,
+    templates,
+    remediation,
+    onSave,
+  };
+  const renderOpts = {
+    messages: {
+      en: {
+        "actions.save": "save",
+        "actions.cancel": "create",
+      },
+    },
+  };
+
+  describe("with multiple templates", () => {
+    it("matches the latest snapshot", () => {
+      const { container } = render(
+        <Suspense fallback={null}>
+          <RemediationForm {...props} />
+        </Suspense>,
+        renderOpts
+      );
+      expect(container).toMatchSnapshot();
+    });
+
+    it("selecting a template shows a dynamic form passing that template as a property", () => {
+      const e = { preventDefault: jest.fn() };
+      const wrapper = shallowWithIntl(
+        <RemediationForm templates={templates} {...props} />
+      );
+
+      wrapper.find({ name: "template" }).simulate("change", e, { value: 2 });
+      expect(wrapper.find({ template: { id: 2 } }).exists()).toBeTruthy;
+    });
+  });
+});

package/src/components/__tests__/RemediationPlan.spec.js

@@ -0,0 +1,106 @@
+import React, { Suspense } from "react";
+import { render } from "@truedat/test/render";
+import userEvent from "@testing-library/user-event";
+import { RemediationPlan } from "../RemediationPlan";
+
+// workaround for enzyme issue with React.useContext
+// see https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526
+//jest.spyOn(React, "useContext").mockImplementation(() => intl);
+
+jest.mock("react-router-dom", () => ({
+  ...jest.requireActual("react-router-dom"), // use actual for all non-hook parts
+  useParams: () => ({
+    id: 777,
+    implementation_id: 862,
+    rule_result_id: 66322,
+  }),
+  useRouteMatch: () => ({
+    url: "/rules/777/implementations/862/results/66322",
+  }),
+}));
+
+describe("<RemediationPlan />", () => {
+  const template1 = { id: 1, name: "remediation_template1" };
+  const template2 = { id: 2, name: "remediation_template2" };
+  const props = {
+    remediationLoading: false,
+    clearRemediation: jest.fn(),
+    fetchRemediation: jest.fn(),
+    templates: [template1, template2],
+    lastResultId: undefined,
+    manageRemediations: true,
+  };
+  const remediation = {
+    df_content: {
+      texto: "66322_cambiado",
+    },
+    df_name: "remediation_template",
+    id: 60,
+  };
+
+  const renderOpts = {
+    messages: {
+      en: {
+        "actions.cancel": "Cancel",
+        "actions.edit": "Edit",
+        "actions.save": "Save",
+        remediation: "Remediation plan",
+        "remediation.actions.create": "Create Remediation Plan",
+        "remediation.actions.edit": "Edit Remediation Plan",
+        "template.not_found.message": "Error: Invalid template",
+      },
+    },
+  };
+
+  it("matches the latest snapshot", () => {
+    const { container } = render(
+      <Suspense fallback={null}>
+        <RemediationPlan {...props} />
+      </Suspense>,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+  });
+
+  it("New remediation component is shown if there is no existing remediation", () => {
+    const state = {
+      remediationActions: {
+        create: { href: "something" },
+      },
+      templates: props.templates,
+    };
+
+    const { queryByText } = render(<RemediationPlan {...props} />, {
+      ...renderOpts,
+      state,
+    });
+
+    expect(queryByText(/Create Remediation Plan/)).toBeInTheDocument();
+  });
+
+  it("Remediation view is shown if there is an existing remediation", () => {
+    const { queryByText } = render(
+      <Suspense fallback={null}>
+        <RemediationPlan {...props} remediation={remediation} />
+      </Suspense>,
+      renderOpts
+    );
+
+    expect(queryByText(/Edit/)).toBeInTheDocument();
+  });
+
+  it("Remediation form is shown if edit button is clicked", async () => {
+    const { queryByText, findByRole } = await render(
+      <Suspense fallback={null}>
+        <RemediationPlan {...props} remediation={remediation} />
+      </Suspense>,
+      renderOpts
+    );
+
+    userEvent.click(await queryByText(/Edit/));
+
+    expect(
+      await findByRole("form", { name: "remediation-form" })
+    ).toBeInTheDocument();
+  });
+});

package/src/components/__tests__/__snapshots__/ExecutionDetails.spec.js.snap

@@ -2,8 +2,23 @@
 
 exports[`<ExecutionDetails> matches the latest snapshot 1`] = `
 <div>
+  <h2
+    class="ui header"
+    style="display: none;"
+  >
+    <i
+      aria-hidden="true"
+      class="chart pie circular icon"
+    />
+    <div
+      class="content"
+    >
+      Rule execution result
+    </div>
+  </h2>
   <table
     class="ui table implementation-results medium"
+    style="display: none;"
   >
     <thead
       class=""
@@ -110,11 +125,63 @@ exports[`<ExecutionDetails> matches the latest snapshot 1`] = `
       </tr>
     </tbody>
   </table>
+  <h2
+    class="ui header"
+    style="display: none;"
+  >
+    <i
+      aria-hidden="true"
+      class="rain circular icon"
+    />
+    <div
+      class="content"
+    >
+      Remediation plan
+    </div>
+  </h2>
+  <div
+    class="ui segment execution-details-remediation"
+    style="display: none;"
+  >
+    <div
+      class="ui grid"
+    >
+      <div
+        class="eight wide column"
+      >
+        <form
+          aria-label="remediation-form"
+          class="ui form"
+        >
+          <button
+            class="ui primary disabled button"
+            disabled=""
+            tabindex="-1"
+          >
+            create
+          </button>
+        </form>
+      </div>
+    </div>
+  </div>
 </div>
 `;
 
 exports[`<ExecutionDetails> without details 1`] = `
 <div>
+  <h2
+    class="ui header"
+  >
+    <i
+      aria-hidden="true"
+      class="chart pie circular icon"
+    />
+    <div
+      class="content"
+    >
+      Rule execution result
+    </div>
+  </h2>
   <table
     class="ui table implementation-results medium"
   >
@@ -191,5 +258,42 @@ exports[`<ExecutionDetails> without details 1`] = `
       </tr>
     </tbody>
   </table>
+  <h2
+    class="ui header"
+  >
+    <i
+      aria-hidden="true"
+      class="rain circular icon"
+    />
+    <div
+      class="content"
+    >
+      Remediation plan
+    </div>
+  </h2>
+  <div
+    class="ui segment execution-details-remediation"
+  >
+    <div
+      class="ui grid"
+    >
+      <div
+        class="eight wide column"
+      >
+        <form
+          aria-label="remediation-form"
+          class="ui form"
+        >
+          <button
+            class="ui primary disabled button"
+            disabled=""
+            tabindex="-1"
+          >
+            create
+          </button>
+        </form>
+      </div>
+    </div>
+  </div>
 </div>
 `;

package/src/components/__tests__/__snapshots__/RemediationForm.spec.js.snap

@@ -0,0 +1,19 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RemediationForm /> with multiple templates matches the latest snapshot 1`] = `
+<div>
+  <form
+    aria-label="remediation-form"
+    class="ui form"
+    style="display: none;"
+  >
+    <button
+      class="ui primary disabled button"
+      disabled=""
+      tabindex="-1"
+    >
+      actions.create
+    </button>
+  </form>
+</div>
+`;

package/src/components/__tests__/__snapshots__/RemediationPlan.spec.js.snap

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RemediationPlan /> matches the latest snapshot 1`] = `<div />`;

package/src/messages/en.js

@@ -1,6 +1,7 @@
 /* eslint-disable prettier/prettier */
 export default {
   "actions.cancel": "Cancel",
+  "actions.edit": "Edit",
   "actions.next": "Next",
   "actions.prev": "Previous",
   "actions.save": "Save",
@@ -124,6 +125,11 @@ export default {
   "quality_result.under_minimum": "Under threshold",
   "quality_result.under_minumum": "Under threshold",
   "quality_result.failed": "Failed",
+  "remediation": "Remediation plan",
+  "remediation.actions.create": "Create Remediation Plan",
+  "remediation.actions.delete.confirmation.content": "Remediation plan will be deleted. Are you sure?",
+  "remediation.actions.delete.confirmation.header": "Delete remediation plan",
+  "remediation.actions.edit": "Edit Remediation Plan",
   rule: "Quality Rule",
   "rule.date.placeholder": "YYYY-MM-DD",
   "rule.error.goal.required": "Goal required",
@@ -518,6 +524,7 @@ export default {
     "Error uploading file. No rules have been created.",
   "ruleImplementations.upload.failed.misssing_required_columns":
     "Faltan columnas obligatorias en el fichero. Esperado [{expected}]. Recibido [{found}].",
+  "ruleResult": "Rule execution result",
   "ruleResults.actions.upload.tooltip": "Upload rule results",
   "ruleResults.actions.upload.confirmation.header": "Upload rule results",
   "ruleResults.upload.success.header": "Upload successful!",

package/src/messages/es.js

@@ -1,6 +1,7 @@
 /* eslint-disable prettier/prettier */
 export default {
   "actions.cancel": "Cancelar",
+  "actions.edit": "Editar",
   "actions.next": "Siguiente",
   "actions.prev": "Anterior",
   "actions.save": "Guardar",
@@ -126,6 +127,11 @@ export default {
   "quality.thresholds": "Umbrales",
   "quality.type_params": "Parámetros",
   "quality.type": "Tipo",
+  "remediation": "Plan de remediación",
+  "remediation.actions.create": "Crear plan de remediación",
+  "remediation.actions.delete.confirmation.content": "Se va a eliminar el plan de remediación. ¿Está seguro?",
+  "remediation.actions.delete.confirmation.header": "Eliminar plan de remediación",
+  "remediation.actions.edit": "Editar plan de remediación",
   "rule_result.actions.delete.confirmation.content":
     "¿Desea eliminar el resultado de la implementación?",
   "rule_result.actions.delete.confirmation.header": "Eliminar resultado",
@@ -540,6 +546,7 @@ export default {
     "Error al subir el fichero. No se ha realizado ninguna inserción.",
   "ruleImplementations.upload.failed.misssing_required_columns":
     "Faltan columnas obligatorias en el fichero. Esperado [{expected}]. Recibido [{found}].",
+  "ruleResult": "Resultado de ejecución de regla",
   "ruleResults.actions.upload.tooltip": "Subir resultados",
   "ruleResults.actions.upload.confirmation.header":
     "Subir resultados de implementaciones",

package/src/reducers/__tests__/remediation.spec.js

@@ -0,0 +1,83 @@
+import {
+  clearRemediation,
+  createRemediation,
+  fetchRemediation,
+  updateRemediation,
+} from "../../routines";
+import { remediation } from "..";
+
+const state = { foo: "bar" };
+
+describe("reducers: remediation", () => {
+  const initialState = {};
+
+  const data = {
+    df_content: {
+      texto: "66256_____aeaeae",
+    },
+    df_name: "remediation_template",
+    id: 58,
+  };
+
+  it("should provide the initial state", () => {
+    expect(remediation(undefined, {})).toEqual(initialState);
+  });
+
+  it("should handle the fetchRemediation.TRIGGER action", () => {
+    expect(remediation(state, { type: fetchRemediation.TRIGGER })).toEqual(
+      initialState
+    );
+  });
+
+  it("should handle the clearRemediation.TRIGGER action", () => {
+    expect(remediation(state, { type: clearRemediation.TRIGGER })).toEqual(
+      initialState
+    );
+  });
+
+  it("should handle the fetchRemediation.SUCCESS action", () => {
+    expect(
+      remediation(state, {
+        type: fetchRemediation.SUCCESS,
+        payload: { data },
+      })
+    ).toEqual(data);
+  });
+
+  it("should handle the fetchRemediation.SUCCESS action", () => {
+    expect(
+      remediation(state, {
+        type: createRemediation.SUCCESS,
+        payload: { data },
+      })
+    ).toEqual(data);
+  });
+
+  it("should handle the updateRemediation.SUCCESS action", () => {
+    expect(
+      remediation(state, {
+        type: updateRemediation.SUCCESS,
+        payload: { data },
+      })
+    ).toEqual(data);
+  });
+
+  it("should handle the 404 status fetchRemediation.FAILURE action", () => {
+    expect(
+      remediation(state, {
+        type: fetchRemediation.FAILURE,
+        payload: { data, status: 404 },
+      })
+    ).toEqual(state);
+  });
+
+  it("should handle the non 404 status fetchRemediation.FAILURE action", () => {
+    const errorData = { error: "some error" };
+    expect(
+      remediation(state, {
+        type: fetchRemediation.FAILURE,
+        payload: { data: errorData, status: 500 },
+      })
+    ).toEqual(errorData);
+  });
+});

package/src/reducers/__tests__/remediationActions.spec.js

@@ -0,0 +1,46 @@
+import { clearRemediation, fetchRemediation } from "../../routines";
+import { remediationActions } from "../remediationActions";
+
+const fooState = { foo: "bar" };
+const payload = {};
+
+describe("reducers: remediationActions", () => {
+  const initialState = {};
+
+  it("should provide the initial state", () => {
+    expect(remediationActions(undefined, {})).toEqual(initialState);
+  });
+
+  it("should be the initial state after receiving the clearRemediation.TRIGGER action", () => {
+    expect(
+      remediationActions(fooState, {
+        type: clearRemediation.TRIGGER,
+        payload,
+      })
+    ).toEqual(initialState);
+  });
+
+  it("should be the initial state after receiving the fetchRemediation.TRIGGER action", () => {
+    expect(
+      remediationActions(fooState, {
+        type: fetchRemediation.TRIGGER,
+        payload,
+      })
+    ).toEqual(initialState);
+  });
+
+  it("should extract _actions from the fetchRemediation.SUCCESS action", () => {
+    const _actions = { delete: { foo: "bar" } };
+    const payload = { _actions };
+    expect(
+      remediationActions(fooState, {
+        type: fetchRemediation.SUCCESS,
+        payload,
+      })
+    ).toMatchObject(_actions);
+  });
+
+  it("should ignore unhandled actions", () => {
+    expect(remediationActions(fooState, { type: "FOO" })).toBe(fooState);
+  });
+});

package/src/reducers/__tests__/remediationLoading.spec.js

@@ -0,0 +1,50 @@
+import {
+  createRemediation,
+  fetchRemediation,
+  updateRemediation,
+} from "../../routines";
+import { remediationLoading } from "..";
+
+const state = { foo: "bar" };
+
+describe("reducers: remediationLoading", () => {
+  it("should provide the initial state", () => {
+    expect(remediationLoading(undefined, {})).toBe(true);
+  });
+
+  it("should be true after receiving the fetchRemediation.TRIGGER action", () => {
+    expect(remediationLoading(state, { type: fetchRemediation.TRIGGER })).toBe(
+      true
+    );
+  });
+
+  it("should be false after receiving the fetchRemediation.FULFILL action", () => {
+    expect(remediationLoading(state, { type: fetchRemediation.FULFILL })).toBe(
+      false
+    );
+  });
+
+  it("should be true after receiving the updateRemediation.TRIGGER action", () => {
+    expect(remediationLoading(state, { type: updateRemediation.TRIGGER })).toBe(
+      true
+    );
+  });
+
+  it("should be false after receiving the updateRemediation.FULFILL action", () => {
+    expect(remediationLoading(state, { type: updateRemediation.FULFILL })).toBe(
+      false
+    );
+  });
+
+  it("should be true after receiving the createRemediation.TRIGGER action", () => {
+    expect(remediationLoading(state, { type: createRemediation.TRIGGER })).toBe(
+      true
+    );
+  });
+
+  it("should be false after receiving the createRemediation.FULFILL action", () => {
+    expect(remediationLoading(state, { type: createRemediation.FULFILL })).toBe(
+      false
+    );
+  });
+});

package/src/reducers/dqMessage.js

@@ -1,6 +1,11 @@
 import _ from "lodash/fp";
 import { dismissAlert } from "@truedat/core/routines";
-import { uploadRules, uploadImplementations, uploadResults } from "../routines";
+import {
+  uploadRules,
+  uploadImplementations,
+  uploadResults,
+  fetchRemediation,
+} from "../routines";
 
 const initialState = {};
 
@@ -126,7 +131,8 @@ const dqMessage = (state = initialState, { type, payload }) => {
       } else {
         return null;
       }
-
+    case fetchRemediation.FAILURE:
+      return { error: false };
     default:
       return state;
   }

package/src/reducers/index.js

@@ -9,6 +9,9 @@ import { implementationActions } from "./implementationActions";
 import { executionGroupLoading } from "./executionGroupLoading";
 import { implementationsActions } from "./implementationsActions";
 import { previousRuleImplementationQuery } from "./previousRuleImplementationQuery";
+import { remediation } from "./remediation";
+import { remediationActions } from "./remediationActions";
+import { remediationLoading } from "./remediationLoading";
 import { resultsUploading } from "./resultsUploading";
 import { rule } from "./rule";
 import { ruleActions } from "./ruleActions";
@@ -59,6 +62,9 @@ export {
   executionGroupLoading,
   implementationsActions,
   previousRuleImplementationQuery,
+  remediation,
+  remediationActions,
+  remediationLoading,
   resultsUploading,
   rule,
   ruleActions,