@truedat/dq 4.40.2 → 4.40.5

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.40.3] 2022-03-14
+
+### Added
+
+- [TD-4271] Support for linking implementations with business_concepts
+
 ## [4.40.1] 2022-03-08
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.40.2",
+  "version": "4.40.5",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -31,7 +31,7 @@
     "@babel/plugin-transform-modules-commonjs": "^7.15.0",
     "@babel/preset-env": "^7.15.0",
     "@babel/preset-react": "^7.14.5",
-    "@truedat/test": "4.39.0",
+    "@truedat/test": "4.40.5",
     "babel-jest": "^27.0.6",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -82,8 +82,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.4.10",
-    "@truedat/core": "4.40.2",
-    "@truedat/df": "4.40.2",
+    "@truedat/core": "4.40.5",
+    "@truedat/df": "4.40.5",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -103,5 +103,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "86aa7e6c6e49c8e3a975f8f4f744c44035324c7f"
+  "gitHead": "0fbea5da0db04c2d79c6237e7bd450091988bf19"
 }

package/src/components/RuleImplementationTabs.js

@@ -8,14 +8,21 @@ import { connect } from "react-redux";
 import { FormattedMessage } from "react-intl";
 import {
   RULE_IMPLEMENTATION_EVENTS,
-  RULE_IMPLEMENTATION_RESULTS_DETAILS,
+  IMPLEMENTATION_CONCEPT_LINKS,
+  IMPLEMENTATION_CONCEPT_LINKS_NEW,
   RULE_IMPLEMENTATION_MOVE,
+  RULE_IMPLEMENTATION_RESULTS_DETAILS,
   RULE_IMPLEMENTATION_RESULTS,
   RULE_IMPLEMENTATION,
   linkTo,
 } from "@truedat/core/routes";
 
-export const RuleImplementationTabs = ({ rule, ruleImplementation, match }) => {
+export const RuleImplementationTabs = ({
+  rule,
+  ruleImplementation,
+  match,
+  canCreateLink,
+}) => {
   const latest_rule_id = _.flow(
     _.pathOr([], "results"),
     _.head,
@@ -37,6 +44,22 @@ export const RuleImplementationTabs = ({ rule, ruleImplementation, match }) => {
       >
         <FormattedMessage id="tabs.dq.ruleImplementation" />
       </Menu.Item>
+
+      {canCreateLink && (
+        <Menu.Item
+          active={
+            match.path === IMPLEMENTATION_CONCEPT_LINKS ||
+            match.path === IMPLEMENTATION_CONCEPT_LINKS_NEW
+          }
+          as={Link}
+          to={linkTo.IMPLEMENTATION_CONCEPT_LINKS({
+            id: rule.id,
+            implementation_id: ruleImplementation.id,
+          })}
+        >
+          <FormattedMessage id="tabs.dq.implementation.links" />
+        </Menu.Item>
+      )}
       <Menu.Item
         active={match.path === RULE_IMPLEMENTATION_RESULTS}
         as={Link}
@@ -78,11 +101,17 @@ RuleImplementationTabs.propTypes = {
   rule: PropTypes.object,
   ruleImplementation: PropTypes.object,
   match: PropTypes.object,
+  canCreateLink: PropTypes.bool,
 };
 
-const mapStateToProps = ({ rule, ruleImplementation }) => ({
+const mapStateToProps = ({
+  rule,
+  ruleImplementation,
+  implementationActions,
+}) => ({
   rule,
   ruleImplementation,
+  canCreateLink: _.propOr(false, "link_concept")(implementationActions),
 });
 
 export default compose(

package/src/components/RuleImplementationsTable.js

@@ -132,9 +132,12 @@ RuleImplementationsTable.propTypes = {
   withoutColumns: PropTypes.array,
 };
 
-const mapStateToProps = (state) => ({
+const mapStateToProps = (state, props) => ({
   columns: getRuleImplementationColumns(state),
-  ruleImplementations: state.ruleImplementations,
+  ruleImplementations: _.getOr(
+    state.ruleImplementations,
+    "ruleImplementations"
+  )(props),
   ruleImplementationsLoading: state.ruleImplementationsLoading,
   implementationsSort: _.path("ruleImplementationQuery.sort")(state),
 });

package/src/components/RuleRoutes.js

@@ -10,14 +10,16 @@ import {
   RULE,
   RULE_EDIT,
   RULE_EVENTS,
-  RULE_IMPLEMENTATION_RESULT_DETAILS,
-  RULE_IMPLEMENTATION_RESULTS_DETAILS,
-  RULE_IMPLEMENTATION,
-  RULE_IMPLEMENTATION_EVENTS,
-  RULE_IMPLEMENTATION_NEW,
   RULE_IMPLEMENTATION_CLONE,
   RULE_IMPLEMENTATION_EDIT,
+  RULE_IMPLEMENTATION_EVENTS,
+  IMPLEMENTATION_CONCEPT_LINKS,
+  IMPLEMENTATION_CONCEPT_LINKS_NEW,
   RULE_IMPLEMENTATION_MOVE,
+  RULE_IMPLEMENTATION_NEW,
+  RULE_IMPLEMENTATION_RESULT_DETAILS,
+  RULE_IMPLEMENTATION_RESULTS_DETAILS,
+  RULE_IMPLEMENTATION,
   RULE_NEW,
   RULE_IMPLEMENTATION_RESULTS,
   RULE_IMPLEMENTATIONS,
@@ -60,6 +62,13 @@ const TemplatesLoader = React.lazy(() =>
 const ImplementationStructuresLoader = React.lazy(() =>
   import("@truedat/dd/components/ImplementationStructuresLoader")
 );
+const ImplementationLinks = React.lazy(() =>
+  import("@truedat/lm/components/ImplementationLinks")
+);
+const ImplementationRelationForm = React.lazy(() =>
+  import("@truedat/lm/components/ImplementationRelationForm")
+);
+
 const QualityTemplatesLoader = () => <TemplatesLoader scope="dq" />;
 const ImplementationTemplatesLoader = () => <TemplatesLoader scope="ri" />;
 
@@ -285,6 +294,40 @@ export const RuleRoutes = ({
                     </>
                   )}
                 />
+                <Route
+                  exact
+                  path={IMPLEMENTATION_CONCEPT_LINKS}
+                  render={() => (
+                    <>
+                      <RuleCrumbs />
+                      <Segment>
+                        <RuleImplementationLoader />
+                        {ruleLoaded && ruleImplementationLoaded && (
+                          <RuleImplementation>
+                            <ImplementationLinks />
+                          </RuleImplementation>
+                        )}
+                      </Segment>
+                    </>
+                  )}
+                />
+                <Route
+                  exact
+                  path={IMPLEMENTATION_CONCEPT_LINKS_NEW}
+                  render={() => (
+                    <>
+                      <RuleCrumbs />
+                      <Segment>
+                        <RuleImplementationLoader />
+                        {ruleLoaded && ruleImplementationLoaded && (
+                          <RuleImplementation>
+                            <ImplementationRelationForm />
+                          </RuleImplementation>
+                        )}
+                      </Segment>
+                    </>
+                  )}
+                />
                 <Route
                   exact
                   path={RULE_IMPLEMENTATION_RESULTS}

package/src/components/__tests__/RuleImplementation.spec.js

@@ -14,21 +14,23 @@ const state = {
     manage_quality_rule_implementations: true,
     manage_quality_rules: true,
   },
+  implementationActions: { link_concept: true },
 };
 
 const renderOpts = {
   messages: {
     en: {
-      "tabs.dq.ruleImplementation.results": "results",
-      "tabs.dq.ruleImplementation": "implementation",
-      "tabs.dq.ruleImplementation.audit": "events",
+      "quality.result.no.data": "No information about quality",
       "ruleImplementation.actions.clone": "clone",
-      "ruleImplementation.actions.move": "move",
-      "ruleImplementation.actions.edit": "edit",
-      "ruleImplementation.actions.deprecate": "archive",
-      "ruleImplementation.actions.delete.confirmation.header": "header",
       "ruleImplementation.actions.delete.confirmation.content": "confirm",
-      "quality.result.no.data": "No information about quality",
+      "ruleImplementation.actions.delete.confirmation.header": "header",
+      "ruleImplementation.actions.deprecate": "archive",
+      "ruleImplementation.actions.edit": "edit",
+      "ruleImplementation.actions.move": "move",
+      "tabs.dq.implementation.links": "Related concepts",
+      "tabs.dq.ruleImplementation.audit": "events",
+      "tabs.dq.ruleImplementation.results": "results",
+      "tabs.dq.ruleImplementation": "implementation",
     },
   },
   state,

package/src/components/__tests__/RuleImplementationTabs.spec.js

@@ -0,0 +1,31 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { RuleImplementationTabs } from "../RuleImplementationTabs";
+
+describe("<RuleImplementationTabs />", () => {
+  const renderOpts = {
+    messages: {
+      en: {
+        "tabs.dq.ruleImplementation": "ruleImplementation",
+        "tabs.dq.implementation.links": "links",
+        "tabs.dq.ruleImplementation.results": "results",
+        "tabs.dq.ruleImplementation.details": "details",
+        "tabs.dq.ruleImplementation.audit": "audit",
+      },
+    },
+  };
+
+  const props = {
+    rule: { id: 8 },
+    ruleImplementation: { id: 1 },
+    match: { path: "" },
+    canCreateLink: true,
+  };
+  it("matches the latest snapshot", () => {
+    const { container } = render(
+      <RuleImplementationTabs {...props} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/__snapshots__/RuleImplementation.spec.js.snap

@@ -134,6 +134,12 @@ exports[`<RuleImplementation /> matches the latest snapshot 1`] = `
     >
       implementation
     </a>
+    <a
+      class="item"
+      href="/rules/1/implementations/1/links"
+    >
+      Related concepts
+    </a>
     <a
       class="item"
       href="/rules/1/implementations/1/results"

package/src/components/__tests__/__snapshots__/RuleImplementationTabs.spec.js.snap

@@ -0,0 +1,34 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleImplementationTabs /> matches the latest snapshot 1`] = `
+<div>
+  <div
+    class="ui pointing secondary top attached tabular menu"
+  >
+    <a
+      class="item"
+      href="/rules/8/implementations/1"
+    >
+      ruleImplementation
+    </a>
+    <a
+      class="item"
+      href="/rules/8/implementations/1/links"
+    >
+      links
+    </a>
+    <a
+      class="item"
+      href="/rules/8/implementations/1/results"
+    >
+      results
+    </a>
+    <a
+      class="item"
+      href="/rules/8/implementations/1/events"
+    >
+      audit
+    </a>
+  </div>
+</div>
+`;

package/src/messages/en.js

@@ -419,6 +419,7 @@ export default {
   "ruleImplementation.props.system.placeholder": "System",
   "ruleImplementation.props.type": "Type",
   "ruleImplementation.props.type.placeholder": "Type",
+  "ruleImplementations.relation.new.header": "Link to Concept",
   "ruleImplementation.summary.database": "Database",
   "ruleImplementation.summary.dataset": "Dataset",
   "ruleImplementation.summary.field": "Field",
@@ -561,6 +562,7 @@ export default {
   "structureFields.dropdown.label": "Select Field",
   "structureFields.dropdown.placeholder": "Fields",
   "summary.link.and": "and",
+  "tabs.dq.implementation.links": "Link to concepts",
   "tabs.dq.rule": "Rule",
   "tabs.dq.rule.audit": "Audit",
   "tabs.dq.ruleImplementation": "Implementation",

package/src/messages/es.js

@@ -5,7 +5,8 @@ export default {
   "actions.prev": "Anterior",
   "actions.save": "Guardar",
   "actions.submit": "Guardar",
-  "alert.deleteRuleImplementation.failed.header": "Error al archivar implementación",
+  "alert.deleteRuleImplementation.failed.header":
+    "Error al archivar implementación",
   "alert.createExecutionGroup.success.content":
     "Se ha solicitado la ejecución de {count} implementaciones",
   "alert.createExecutionGroup.success.header": "Ejecuciones programadas",
@@ -27,7 +28,7 @@ export default {
   "dataset.form.button.add_structure": "Añadir Estructura",
   "datasetForm.implementation_key.tooltip":
     "En caso de no introducir clave de implementación, se autogenerará al guardar la implementación",
-  "executionGroup": "Ejecuciones",
+  executionGroup: "Ejecuciones",
   "executions.completed.content": "Se han ejecutado {count} implementaciones.",
   "executions.completed.header": "Ejecuciones finalizadas",
   "executions.pending.content":
@@ -189,8 +190,10 @@ export default {
   "rule.props.name": "Nombre",
   "rule.props.type_params.placeholder": "Parametros a cumplimentar",
   "rule.props.type_params": "Parametros",
-  "rule.props.type.placeholder": "Rango de valores",
   "rule.props.type": "Tipo de regla",
+  "rule.props.type.placeholder": "Rango de valores",
+  "ruleImplementations.relation.new.header":
+    "Vas a vincular esta implementación a un término de glosario",
   "rule.ruleImplementation.results.details.empty":
     "No existen detalles para este resultado",
   "rule.ruleImplementation.results.empty":
@@ -477,10 +480,12 @@ export default {
   "ruleImplementations.actions.create": "Crear nueva implementación",
   "ruleImplementations.actions.edit": "Editar implementación",
   "ruleImplementations.actions.popup.deprecated": "Implementaciones Archivadas",
-  "ruleImplementations.events.action_created": "Implementación creada en regla: {0}",
+  "ruleImplementations.events.action_created":
+    "Implementación creada en regla: {0}",
   "ruleImplementations.events.action_changed": "Campo {0} actualizado a {1}",
   "ruleImplementations.events.action_deprecated": "Implementación archivada",
-  "ruleImplementations.events.action_moved": "Implementación movida a la regla: {0}",
+  "ruleImplementations.events.action_moved":
+    "Implementación movida a la regla: {0}",
   "ruleImplementations.events.action_restored": "Implementación restaurada",
   "ruleImplementations.events.action_updated": "Implementación actualizada",
   "ruleImplementations.header": "Implementaciones de calidad",
@@ -512,7 +517,8 @@ export default {
   "ruleImplementations.props.status": "Estado",
   "ruleImplementations.props.template": "Plantilla",
   "ruleImplementations.props.rule_template": "Plantilla de regla",
-  "ruleImplementations.props.implementation_template": "Plantilla de implementación",
+  "ruleImplementations.props.implementation_template":
+    "Plantilla de implementación",
   "ruleImplementations.retrieved.results":
     "{count} implementaciones encontradas",
   "ruleImplementations.search.results.empty":
@@ -560,10 +566,12 @@ export default {
   "rules.events.action_changed": "Campo {0} actualizado: {1}",
   "rules.events.action_changed_to": "Campo {0} actualizado a {1}",
   "rules.events.action_updated": "Regla actualizada",
-  "ruleImplementations.events.action_created": "Implementación creada en regla: {0}",
+  "ruleImplementations.events.action_created":
+    "Implementación creada en regla: {0}",
   "ruleImplementations.events.action_changed": "Campo {0} actualizado a {1}",
   "ruleImplementations.events.action_deprecated": "Implementación archivada",
-  "ruleImplementations.events.action_moved": "Implementación movida a la regla: {0}",
+  "ruleImplementations.events.action_moved":
+    "Implementación movida a la regla: {0}",
   "rules.retrieved.results": "{count} reglas encontradas",
   "rules.search.placeholder": "Buscar reglas...",
   "rules.searching": "Buscando...",
@@ -580,6 +588,7 @@ export default {
   "structureFields.dropdown.label": "Seleccionar Campo",
   "structureFields.dropdown.placeholder": "Campos",
   "summary.link.and": "y",
+  "tabs.dq.implementation.links": "Conceptos relacionados",
   "tabs.dq.rule": "Regla",
   "tabs.dq.rule.audit": "Auditoría",
   "tabs.dq.ruleImplementation.audit": "Auditoría",

package/src/reducers/__tests__/implementationActions.spec.js

@@ -0,0 +1,44 @@
+import {
+  clearRuleImplementations,
+  fetchRuleImplementation,
+} from "../../routines";
+import { implementationActions } from "..";
+
+const fooState = { foo: "bar" };
+
+describe("reducers: implementationActions", () => {
+  const initialState = {};
+
+  it("should provide the initial state", () => {
+    expect(implementationActions(undefined, {})).toEqual(initialState);
+  });
+
+  it("should handle the clearRuleImplementations.TRIGGER action", () => {
+    expect(
+      implementationActions(fooState, {
+        type: clearRuleImplementations.TRIGGER,
+      })
+    ).toEqual(initialState);
+  });
+
+  it("should handle the fetchRuleImplementation.SUCCESS action", () => {
+    const actions = { action1: { href: "1" } };
+    const payload = {
+      id: 2,
+      implementation_key: "xxx",
+      results: [],
+      _actions: actions,
+    };
+
+    expect(
+      implementationActions(fooState, {
+        type: fetchRuleImplementation.SUCCESS,
+        payload,
+      })
+    ).toMatchObject(actions);
+  });
+
+  it("should ignore unknown actions", () => {
+    expect(implementationActions(fooState, { type: "FOO" })).toBe(fooState);
+  });
+});

package/src/reducers/__tests__/implementationLinks.spec.js

@@ -0,0 +1,62 @@
+import { deleteRelation } from "@truedat/lm/routines";
+import {
+  clearRuleImplementation,
+  fetchRuleImplementation,
+} from "../../routines";
+import { implementationLinks } from "..";
+
+const fooState = { foo: "bar" };
+
+describe("reducers: implementationLinks", () => {
+  const initialState = [];
+
+  it("should provide the initial state", () => {
+    expect(implementationLinks(undefined, {})).toEqual(initialState);
+  });
+
+  it("should handle the clearRuleImplementation.TRIGGER action", () => {
+    expect(
+      implementationLinks(fooState, { type: clearRuleImplementation.TRIGGER })
+    ).toEqual(initialState);
+  });
+
+  it("should handle the fetchRuleImplementation.TRIGGER action", () => {
+    expect(
+      implementationLinks(fooState, { type: fetchRuleImplementation.TRIGGER })
+    ).toEqual(initialState);
+  });
+
+  it("should handle the fetchRuleImplementation.SUCCESS action", () => {
+    const links = [{ name: "link1" }, { name: "link2" }];
+    const data = {
+      id: 2,
+      implementation_key: "xxx",
+      results: [],
+      links,
+    };
+    const payload = { data };
+
+    expect(
+      implementationLinks(fooState, {
+        type: fetchRuleImplementation.SUCCESS,
+        payload,
+      })
+    ).toMatchObject(links);
+  });
+
+  it("should filter deleted id on deleteRelation.SUCCESS action", () => {
+    const links = [{ id: "1" }, { id: "2" }];
+    const payload = { id: "1" };
+
+    expect(
+      implementationLinks(links, {
+        type: deleteRelation.SUCCESS,
+        payload,
+      })
+    ).toMatchObject([{ id: "2" }]);
+  });
+
+  it("should ignore unknown actions", () => {
+    expect(implementationLinks(fooState, { type: "FOO" })).toBe(fooState);
+  });
+});

package/src/reducers/implementationActions.js

@@ -0,0 +1,17 @@
+import _ from "lodash/fp";
+import { clearRuleImplementations, fetchRuleImplementation } from "../routines";
+
+const initialState = {};
+
+const implementationActions = (state = initialState, { type, payload }) => {
+  switch (type) {
+    case fetchRuleImplementation.SUCCESS:
+      return _.pathOr(initialState, "_actions")(payload);
+    case clearRuleImplementations.TRIGGER:
+      return initialState;
+    default:
+      return state;
+  }
+};
+
+export { implementationActions };

package/src/reducers/implementationLinks.js

@@ -0,0 +1,22 @@
+import _ from "lodash/fp";
+import { deleteRelation } from "@truedat/lm/routines";
+import { clearRuleImplementation, fetchRuleImplementation } from "../routines";
+
+const initialState = [];
+
+const implementationLinks = (state = initialState, { type, payload }) => {
+  switch (type) {
+    case clearRuleImplementation.TRIGGER:
+      return initialState;
+    case fetchRuleImplementation.TRIGGER:
+      return initialState;
+    case fetchRuleImplementation.SUCCESS:
+      return _.pathOr([], "data.links")(payload);
+    case deleteRelation.SUCCESS:
+      return _.reject(payload)(state);
+    default:
+      return state;
+  }
+};
+
+export { implementationLinks };

package/src/reducers/index.js

@@ -4,6 +4,8 @@ import { conceptRulesLoading } from "./conceptRulesLoading";
 import { deletionQuery } from "./deletionQuery";
 import { dqMessage } from "./dqMessage";
 import { executionGroup } from "./executionGroup";
+import { implementationLinks } from "./implementationLinks";
+import { implementationActions } from "./implementationActions";
 import { executionGroupLoading } from "./executionGroupLoading";
 import { implementationsActions } from "./implementationsActions";
 import { previousRuleImplementationQuery } from "./previousRuleImplementationQuery";
@@ -52,6 +54,8 @@ export {
   deletionQuery,
   dqMessage,
   executionGroup,
+  implementationLinks,
+  implementationActions,
   executionGroupLoading,
   implementationsActions,
   previousRuleImplementationQuery,