@truedat/dq 4.38.8 → 4.40.1

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [4.40.1] 2022-03-08
+
+### Changed
+
+- [TD-4604] Use actions from `POST /api/implementations/search` instead of
+  fetching permissions
+
+## [4.39.0] 2022-03-01
+
+### Changed
+
+- [TD-4528] Restyle quality results table
+
 ## [4.38.7] 2022-02-22
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.38.8",
+  "version": "4.40.1",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -31,7 +31,7 @@
     "@babel/plugin-transform-modules-commonjs": "^7.15.0",
     "@babel/preset-env": "^7.15.0",
     "@babel/preset-react": "^7.14.5",
-    "@truedat/test": "4.38.8",
+    "@truedat/test": "4.39.0",
     "babel-jest": "^27.0.6",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -82,8 +82,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.4.10",
-    "@truedat/core": "4.38.8",
-    "@truedat/df": "4.38.8",
+    "@truedat/core": "4.40.1",
+    "@truedat/df": "4.40.1",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -103,5 +103,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "66f56f3fe3e1b5eb0b18379f2d141b1433bf82c1"
+  "gitHead": "58b35b48833fbed1602d1070853e6c805bcc48f1"
 }

package/src/components/ExecutionDetails.js

@@ -91,14 +91,7 @@ export const ExecutionDetails = ({ ruleImplementation, ruleResultId }) => {
     ruleImplementation.results
   );
 
-  return _.isEmpty(ruleResult.details) ? (
-    <Message
-      style={{ marginTop: "14px" }}
-      header={formatMessage({
-        id: "rule.ruleImplementation.results.details.empty",
-      })}
-    />
-  ) : (
+  return (
     <Table className="implementation-results medium">
       <Table.Header>
         <Table.Row>
@@ -116,20 +109,23 @@ export const ExecutionDetails = ({ ruleImplementation, ruleResultId }) => {
           ruleResult={ruleResult}
         />
       </Table.Body>
-
-      <Table.Header>
-        <Table.Row>
-          <Table.HeaderCell
-            colSpan={2}
-            content={formatMessage({
-              id: "ruleResult.props.header.details",
-            })}
-          />
-        </Table.Row>
-      </Table.Header>
-      <Table.Body>
-        <DetailRow details={ruleResult.details} />
-      </Table.Body>
+      {!_.isEmpty(ruleResult.details) ? (
+        <>
+          <Table.Header>
+            <Table.Row>
+              <Table.HeaderCell
+                colSpan={2}
+                content={formatMessage({
+                  id: "ruleResult.props.header.details",
+                })}
+              />
+            </Table.Row>
+          </Table.Header>
+          <Table.Body>
+            <DetailRow details={ruleResult?.details} />
+          </Table.Body>
+        </>
+      ) : null}
     </Table>
   );
 };

package/src/components/ImplementationsRoutes.js

@@ -8,9 +8,6 @@ import RuleImplementationsLoader from "./RuleImplementationsLoader";
 const TemplatesLoader = React.lazy(() =>
   import("@truedat/df/templates/components/TemplatesLoader")
 );
-const UserDomainsLoader = React.lazy(() =>
-  import("@truedat/auth/users/components/UserDomainsLoader")
-);
 const UserSearchFiltersLoader = React.lazy(() =>
   import("@truedat/dd/components/UserSearchFiltersLoader")
 );
@@ -24,7 +21,6 @@ const ImplementationsRoutes = () => (
         <ImplementationFiltersLoader />
         <TemplatesLoader scope="qe" />
         <UserSearchFiltersLoader scope="rule_implementation" />
-        <UserDomainsLoader permissions={["manage_rule_results"]} />
         <RuleImplementations exact />
       </>
     )}

package/src/components/RuleImplementationResults.js

@@ -35,7 +35,7 @@ export const RuleImplementationResults = ({
 
   return (
     <>
-      {ruleImplementation.event_type === "FAILED" && (
+      {ruleImplementation.event_type === "FAILED" ? (
         <Message negative style={{ marginTop: "14px" }}>
           <Message.Header>
             {formatMessage({
@@ -61,7 +61,7 @@ export const RuleImplementationResults = ({
             {ruleImplementation.event_message}
           </p>
         </Message>
-      )}
+      ) : null}
       {_.isEmpty(ruleResults) ? (
         <Message
           style={{ marginTop: "14px" }}
@@ -70,25 +70,25 @@ export const RuleImplementationResults = ({
           })}
         />
       ) : (
-        <Table className="implementation-results small" selectable>
+        <Table className="implementation-results small">
           <Table.Header>
             <Table.Row>
               <Table.HeaderCell
-                content={formatMessage({ id: "ruleResult.props.quality" })}
+                content={formatMessage({ id: "ruleResult.props.date" })}
               />
               <Table.HeaderCell
-                content={formatMessage({ id: "ruleResult.props.date" })}
+                content={formatMessage({ id: "ruleResult.props.quality" })}
               />
-              {_.includes("records")(optionalColumns) && (
+              {_.includes("records")(optionalColumns) ? (
                 <Table.HeaderCell
                   content={formatMessage({ id: "ruleResult.props.records" })}
                 />
-              )}
-              {_.includes("errors")(optionalColumns) && (
+              ) : null}
+              {_.includes("errors")(optionalColumns) ? (
                 <Table.HeaderCell
                   content={formatMessage({ id: "ruleResult.props.errors" })}
                 />
-              )}
+              ) : null}
               {customColumns.map((column, index) => (
                 <Table.HeaderCell
                   key={index}
@@ -99,7 +99,7 @@ export const RuleImplementationResults = ({
                 />
               ))}
               {<Table.HeaderCell />}
-              {isAdmin && <Table.HeaderCell />}
+              {isAdmin ? <Table.HeaderCell /> : null}
             </Table.Row>
           </Table.Header>
           <Table.Body>

package/src/components/RuleImplementationsActions.js

@@ -14,18 +14,19 @@ import ExecutionPopup from "./ExecutionPopup";
 import RuleImplementationsOptions from "./RuleImplementationsOptions";
 
 export const RuleImplementationsActions = ({
+  actions,
   addImplementationFilter,
   canExecute,
-  executeImplementationsOn,
-  toggleImplementationFilterValue,
-  removeImplementationFilter,
   createExecutionGroup,
-  selectedImplementations,
+  executeImplementationsOn,
   implementationQuery,
-  setMode,
   implementationsExecution,
+  removeImplementationFilter,
   ruleImplementationCount,
   ruleImplementationsLoading,
+  selectedImplementations,
+  setMode,
+  toggleImplementationFilterValue,
 }) => {
   const showExecutableInfo = () => {
     addImplementationFilter({ filter: "executable" });
@@ -50,6 +51,8 @@ export const RuleImplementationsActions = ({
       : { filters: { id: selectedImplementations } };
     createExecutionGroup({ ...query, df_content });
   };
+
+  const canUploadResults = !!actions?.uploadResults;
   return (
     <div style={{ float: "right" }}>
       {implementationsExecution && canExecute && (
@@ -73,24 +76,28 @@ export const RuleImplementationsActions = ({
           />
         </>
       )}
-      <RuleImplementationsOptions loading={ruleImplementationsLoading} />
+      <RuleImplementationsOptions
+        loading={ruleImplementationsLoading}
+        canUploadResults={canUploadResults}
+      />
     </div>
   );
 };
 
 RuleImplementationsActions.propTypes = {
+  actions: PropTypes.object,
   addImplementationFilter: PropTypes.func,
   canExecute: PropTypes.bool,
   createExecutionGroup: PropTypes.func,
   executeImplementationsOn: PropTypes.bool,
-  implementationsExecution: PropTypes.bool,
   implementationQuery: PropTypes.object,
+  implementationsExecution: PropTypes.bool,
   removeImplementationFilter: PropTypes.func,
   ruleImplementationCount: PropTypes.number,
+  ruleImplementationsLoading: PropTypes.bool,
   selectedImplementations: PropTypes.array,
   setMode: PropTypes.func,
   toggleImplementationFilterValue: PropTypes.func,
-  ruleImplementationsLoading: PropTypes.bool,
 };
 
 const mapStateToProps = (state) => ({
@@ -98,6 +105,7 @@ const mapStateToProps = (state) => ({
   ruleImplementationCount: state.ruleImplementationCount,
   implementationsExecution: getImplementationsExecution(state),
   ruleImplementationsLoading: state.ruleImplementationsLoading,
+  actions: state.implementationsActions,
 });
 
 export default connect(mapStateToProps, {

package/src/components/RuleImplementationsOptions.js

@@ -5,7 +5,7 @@ import RuleImplementationsDownload from "./RuleImplementationsDownload";
 import RuleResultsUpload from "./RuleResultsUpload";
 import ImplementationsUploadButton from "./ImplementationsUploadButton";
 
-export const RuleImplementationsOptions = ({ loading }) => (
+export const RuleImplementationsOptions = ({ loading, canUploadResults }) => (
   <Dropdown
     icon="ellipsis vertical"
     className="button icon group-actions button-update"
@@ -16,13 +16,14 @@ export const RuleImplementationsOptions = ({ loading }) => (
     <Dropdown.Menu>
       <RuleImplementationsDownload />
       <ImplementationsUploadButton />
-      <RuleResultsUpload />
+      {canUploadResults ? <RuleResultsUpload /> : null}
     </Dropdown.Menu>
   </Dropdown>
 );
 
 RuleImplementationsOptions.propTypes = {
   loading: PropTypes.bool,
+  canUploadResults: PropTypes.bool,
 };
 
 export default RuleImplementationsOptions;

package/src/components/RuleResultRow.js

@@ -3,13 +3,14 @@ import React from "react";
 import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { useIntl } from "react-intl";
-import { useHistory } from "react-router-dom";
+import { Link } from "react-router-dom";
 import { Table, Icon } from "semantic-ui-react";
 import { ConfirmModal, DateTime } from "@truedat/core/components";
 import { columnDecorator } from "@truedat/core/services";
 import { linkTo } from "@truedat/core/routes";
 import { selectColor } from "../functions/selectors";
 import { deleteRuleResult } from "../routines";
+import "../styles/ruleResultRow.less";
 
 export const RuleResultRow = ({
   deleteRuleResult,
@@ -22,24 +23,25 @@ export const RuleResultRow = ({
 }) => {
   const { formatMessage, formatNumber: _formatNumber } = useIntl();
   const formatNumber = (num) => (_.isNil(num) ? num : _formatNumber(num));
-  const history = useHistory();
 
   return (
-    <Table.Row
-      onClick={() =>
-        !_.isEmpty(ruleResult.details)
-          ? history.push(
-              linkTo.RULE_IMPLEMENTATION_RESULT_DETAILS({
-                id: rule.id,
-                implementation_id: ruleImplementation.id,
-                rule,
-                ruleImplementation,
-                rule_result_id: ruleResult.id,
-              })
-            )
-          : null
-      }
-    >
+    <Table.Row>
+      <Table.Cell>
+        <Link
+          to={linkTo.RULE_IMPLEMENTATION_RESULT_DETAILS({
+            id: rule.id,
+            implementation_id: ruleImplementation.id,
+            rule,
+            ruleImplementation,
+            rule_result_id: ruleResult.id,
+          })}
+        >
+          <DateTime className="rule-result-date" value={ruleResult.date} />
+          {!_.isEmpty(ruleResult.details) ? (
+            <Icon name="info circle" color="blue" />
+          ) : null}
+        </Link>
+      </Table.Cell>
       <Table.Cell>
         <Icon
           name="circle"
@@ -47,28 +49,18 @@ export const RuleResultRow = ({
         />
         {`${parseFloat(ruleResult.result)} %`}
       </Table.Cell>
-      <Table.Cell>
-        <DateTime value={ruleResult.date} />
-      </Table.Cell>
-      {_.includes("records")(optionalColumns) && (
+      {_.includes("records")(optionalColumns) ? (
         <Table.Cell>{formatNumber(ruleResult.records)}</Table.Cell>
-      )}
-      {_.includes("errors")(optionalColumns) && (
+      ) : null}
+      {_.includes("errors")(optionalColumns) ? (
         <Table.Cell>{formatNumber(ruleResult.errors)}</Table.Cell>
-      )}
-      {_.includes("details")(optionalColumns) && (
-        <Table.Cell>
-          {!_.isEmpty(ruleResult.details) && (
-            <Icon name="info circle" color="blue" />
-          )}
-        </Table.Cell>
-      )}
+      ) : null}
       {customColumns?.map((column, index) => (
         <Table.Cell key={index}>
           {columnDecorator(column)(ruleResult)}
         </Table.Cell>
       ))}
-      {isAdmin && (
+      {isAdmin ? (
         <Table.Cell onClick={(e) => e.stopPropagation()}>
           <ConfirmModal
             icon="trash"
@@ -88,7 +80,7 @@ export const RuleResultRow = ({
             }
           />
         </Table.Cell>
-      )}
+      ) : null}
     </Table.Row>
   );
 };

package/src/components/RuleResultsUpload.js

@@ -1,5 +1,4 @@
-import _ from "lodash/fp";
-import React, { useEffect, useState } from "react";
+import React from "react";
 import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { Dropdown } from "semantic-ui-react";
@@ -7,31 +6,18 @@ import { useIntl } from "react-intl";
 import { UploadModal } from "@truedat/core/components";
 import { uploadResults } from "../routines";
 
-export const RuleResultsUpload = ({ uploadResults, loading, userDomains }) => {
+export const RuleResultsUpload = ({ uploadResults, loading }) => {
   const { formatMessage } = useIntl();
-  const [permissionFound, setPermissionFound] = useState(false);
-
-  useEffect(() => {
-    setPermissionFound(
-      !_.flow(
-        _.find({ permission: "manage_rule_results" }),
-        _.path("domains"),
-        _.isEmpty
-      )(userDomains)
-    );
-  }, [userDomains]);
 
   return (
     <UploadModal
       icon="upload"
       trigger={
-        permissionFound ? (
-          <Dropdown.Item
-            icon="upload"
-            text={formatMessage({ id: "ruleResults.actions.upload.tooltip" })}
-            disabled={loading}
-          />
-        ) : null
+        <Dropdown.Item
+          icon="upload"
+          text={formatMessage({ id: "ruleResults.actions.upload.tooltip" })}
+          disabled={loading}
+        />
       }
       header={formatMessage({
         id: "ruleResults.actions.upload.confirmation.header",
@@ -52,14 +38,10 @@ export const RuleResultsUpload = ({ uploadResults, loading, userDomains }) => {
 RuleResultsUpload.propTypes = {
   uploadResults: PropTypes.func,
   loading: PropTypes.bool,
-  userDomains: PropTypes.array,
 };
 
-const mapStateToProps = (state) => {
-  return {
-    loading: state.uploadingResults,
-    userDomains: state.userDomains,
-  };
-};
+const mapStateToProps = ({ resultsUploading: loading }) => ({
+  loading,
+});
 
 export default connect(mapStateToProps, { uploadResults })(RuleResultsUpload);

package/src/components/__tests__/RuleImplementationsActions.spec.js

@@ -12,6 +12,7 @@ describe("<RuleImplementationsActions />", () => {
   const setMode = jest.fn();
   const removeImplementationFilter = jest.fn();
   const props = {
+    actions: { uploadResults: {} },
     canExecute: true,
     executionGroupLoading: false,
     ruleImplementationCount: 12,
@@ -23,6 +24,7 @@ describe("<RuleImplementationsActions />", () => {
     setMode,
     removeImplementationFilter,
   };
+
   it("matches the latest snapshot", () => {
     const wrapper = shallow(<RuleImplementationsActions {...props} />);
     expect(wrapper).toMatchSnapshot();

package/src/components/__tests__/RuleImplementationsOptions.spec.js

@@ -1,18 +1,22 @@
-import _ from "lodash/fp";
 import React from "react";
-import { shallow } from "enzyme";
-import { intl } from "@truedat/test/intl-stub";
-import { RuleImplementationsOptions } from "../RuleImplementationsOptions";
+import { waitFor } from "@testing-library/react";
+import { render } from "@truedat/test/render";
+import coreEn from "@truedat/core/messages/en";
+import RuleImplementationsOptions from "../RuleImplementationsOptions";
+import en from "../../messages/en";
 
-jest.spyOn(React, "useContext").mockImplementation(() => intl);
+const renderOpts = {
+  messages: { en: { ...coreEn, ...en } },
+};
+
+const props = { canUploadResults: true };
 
 describe("<RuleImplementationsOptions />", () => {
-  it("matches the latest snapshot", () => {
-    const wrapper = shallow(<RuleImplementationsOptions />);
-    expect(wrapper).toMatchSnapshot();
-  });
-  it("matches the latest loading snapshot", () => {
-    const wrapper = shallow(<RuleImplementationsOptions loading />);
-    expect(wrapper).toMatchSnapshot();
+  it("matches the latest snapshot", async () => {
+    const { container } = render(
+      <RuleImplementationsOptions {...props} />,
+      renderOpts
+    );
+    await waitFor(() => expect(container).toMatchSnapshot());
   });
 });

package/src/components/__tests__/RuleResultRow.spec.js

@@ -11,8 +11,12 @@ jest.spyOn(React, "useContext").mockImplementation(() => intl);
 describe("<RuleResultRow />", () => {
   it("renders customColumns values when passed", () => {
     const ruleResultRowProps = {
-      id: 10,
-      ruleResult: { result: 80, params: { p1: "1", p2: "2", p3: "no" } },
+      rule: { id: 10 },
+      ruleResult: {
+        id: 54,
+        result: 80,
+        params: { p1: "1", p2: "2", p3: "no" },
+      },
       customColumns: [
         {
           name: "m_parm1",
@@ -24,7 +28,12 @@ describe("<RuleResultRow />", () => {
         },
       ],
       date: "2019-08-12T02:00:00Z",
-      ruleImplementation: { minimum: 1, goal: 10, result_type: "percentage" },
+      ruleImplementation: {
+        id: 23,
+        minimum: 1,
+        goal: 10,
+        result_type: "percentage",
+      },
     };
 
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
@@ -50,10 +59,11 @@ describe("<RuleResultRow />", () => {
 
   it("green icon when result is over goal", () => {
     const ruleResultRowProps = {
-      id: 10,
-      ruleResult: { result: 80 },
+      rule: { id: 10 },
+      ruleResult: { id: 54, result: 80 },
       date: "2019-08-12T02:00:00Z",
       ruleImplementation: {
+        id: 23,
         minimum: 1,
         goal: 10,
         result_type: "percentage",
@@ -61,7 +71,7 @@ describe("<RuleResultRow />", () => {
     };
 
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const cell = wrapper.find("TableRow").find("TableCell").at(0).dive();
+    const cell = wrapper.find("TableRow").find("TableCell").at(1).dive();
 
     expect(cell.find("td").find("Icon")).toHaveLength(1);
 
@@ -72,10 +82,11 @@ describe("<RuleResultRow />", () => {
 
   it("red icon when result is under minimum", () => {
     const ruleResultRowProps = {
-      id: 10,
-      ruleResult: { result: 80 },
+      rule: { id: 10 },
+      ruleResult: { id: 54, result: 80 },
       date: "2019-08-12T02:00:00Z",
       ruleImplementation: {
+        id: 23,
         minimum: 81,
         goal: 90,
         result_type: "percentage",
@@ -83,7 +94,7 @@ describe("<RuleResultRow />", () => {
     };
 
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const cell = wrapper.find("TableRow").find("TableCell").at(0).dive();
+    const cell = wrapper.find("TableRow").find("TableCell").at(1).dive();
 
     expect(cell.find("td").find("Icon")).toHaveLength(1);
 
@@ -94,18 +105,19 @@ describe("<RuleResultRow />", () => {
 
   it("yellow icon when result is between minimum and goal", () => {
     const ruleResultRowProps = {
-      id: 10,
+      rule: { id: 10 },
       ruleImplementation: {
+        id: 23,
         minimum: 81,
         goal: 90,
         result_type: "percentage",
       },
-      ruleResult: { result: 82 },
+      ruleResult: { id: 54, result: 82 },
       date: "2019-08-12T02:00:00Z",
     };
 
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const cell = wrapper.find("TableRow").find("TableCell").at(0).dive();
+    const cell = wrapper.find("TableRow").find("TableCell").at(1).dive();
 
     expect(cell.find("td").find("Icon")).toHaveLength(1);
 
@@ -116,13 +128,14 @@ describe("<RuleResultRow />", () => {
 
   it("renders delete cell in RuleResultRow when user isAdmin is true", () => {
     const ruleResultRowProps = {
-      id: 10,
+      rule: { id: 10 },
       ruleImplementation: {
+        id: 23,
         minimum: 81,
         goal: 90,
         result_type: "percentage",
       },
-      ruleResult: { result: 82 },
+      ruleResult: { id: 54, result: 82 },
       date: "2019-08-12T02:00:00Z",
       isAdmin: true,
       deleteRuleResult: jest.fn(),
@@ -138,13 +151,14 @@ describe("<RuleResultRow />", () => {
 
   it("does not render delete cell in RuleResultRow when user isAdmin is false", () => {
     const ruleResultRowProps = {
-      id: 10,
+      rule: { id: 10 },
       ruleImplementation: {
+        id: 23,
         minimum: 81,
         goal: 90,
         result_type: "percentage",
       },
-      ruleResult: { result: 82 },
+      ruleResult: { id: 54, result: 82 },
       date: "2019-08-12T02:00:00Z",
       isAdmin: false,
       deleteRuleResult: jest.fn(),

package/src/components/__tests__/RuleResultsUpload.spec.js

@@ -1,73 +1,15 @@
 import React from "react";
-import { intl } from "@truedat/test/intl-stub";
-import { IntlProvider } from "react-intl";
+import { waitFor } from "@testing-library/react";
 import { render } from "@truedat/test/render";
-import { shallow } from "enzyme";
-import { RuleResultsUpload } from "../RuleResultsUpload";
+import coreEn from "@truedat/core/messages/en";
+import RuleResultsUpload from "../RuleResultsUpload";
+import en from "../../messages/en";
 
-afterEach(() => {    
-  jest.clearAllMocks();
-});
+const renderOpts = { messages: { en: { ...coreEn, ...en } } };
 
 describe("<RuleResultsUpload />", () => {
-  const renderOpts = {
-    messages: {
-      en: {
-        "ruleResults.actions.upload.tooltip": "Upload rule results",
-        "ruleResults.actions.upload.confirmation.header": "Upload rule results",
-        "uploadModal.actions.upload.confirmation.content": "Drag an drop file or click to select file",
-        "ruleResults.actions.upload.confirmation.header": "Upload rule results",
-      },
-    },
-  };
-
-  it("matches the latest snapshot", () => {
-    const spy = jest.spyOn(React, "useContext").mockImplementation(() => intl);
-    const props = {
-      uploadResults: jest.fn(),
-      loading: false,
-    };
-    const wrapper = shallow(<RuleResultsUpload {...props} />);
-    expect(wrapper).toMatchSnapshot();
-    spy.mockRestore();
-  });
-
-  it("Renders upload rule results menu item if there is a domain with manage_rule_results permission", () => {
-    const props = {
-      uploadResults: jest.fn(),
-      loading: false,
-      userDomains: [
-        {
-          domains: [
-            {
-              external_id: "Truedat",
-              id: 2,
-              name: "Truedat",
-            },
-          ],
-          permission: "manage_rule_results",
-        },
-      ],
-    };
-    const { getByText } = render(<RuleResultsUpload {...props} />, renderOpts);
-
-    const element = getByText("Upload rule results");
-    expect(element).toBeInTheDocument()
-  });
-
-  it("Does not render upload rule results menu item if there is no domain with manage_rule_results permission", () => {
-    const props = {
-      uploadResults: jest.fn(),
-      loading: false,
-      userDomains: [],
-    };
-
-    const { queryByText } = render(
-      <RuleResultsUpload {...props} />,
-      renderOpts
-    );
-
-    const element = queryByText("Upload rule results");
-    expect(element).toBeNull();
+  it("matches the latest snapshot", async () => {
+    const { container } = render(<RuleResultsUpload />, renderOpts);
+    await waitFor(() => expect(container).toMatchSnapshot());
   });
 });

package/src/components/__tests__/__snapshots__/ExecutionDetails.spec.js.snap

@@ -115,19 +115,81 @@ exports[`<ExecutionDetails> matches the lastest snapshot 1`] = `
 
 exports[`<ExecutionDetails> without details 1`] = `
 <div>
-  <div
-    class="ui message"
-    style="margin-top: 14px;"
+  <table
+    class="ui table implementation-results medium"
   >
-    <div
-      class="content"
+    <thead
+      class=""
     >
-      <div
-        class="header"
+      <tr
+        class=""
       >
-        No details found for current result
-      </div>
-    </div>
-  </div>
+        <th
+          class=""
+          colspan="2"
+        >
+          Information
+        </th>
+      </tr>
+    </thead>
+    <tbody
+      class=""
+    >
+      <tr
+        class=""
+      >
+        <td
+          class=""
+        >
+          Quality
+        </td>
+        <td
+          class=""
+        >
+          <i
+            aria-hidden="true"
+            class="grey circle icon"
+          />
+          NaN %
+        </td>
+      </tr>
+      <tr
+        class=""
+      >
+        <td
+          class=""
+        >
+          Date
+        </td>
+        <td
+          class=""
+        />
+      </tr>
+      <tr
+        class=""
+      >
+        <td
+          class=""
+        >
+          Records
+        </td>
+        <td
+          class=""
+        />
+      </tr>
+      <tr
+        class=""
+      >
+        <td
+          class=""
+        >
+          Errors
+        </td>
+        <td
+          class=""
+        />
+      </tr>
+    </tbody>
+  </table>
 </div>
 `;

package/src/components/__tests__/__snapshots__/RuleImplementationResults.spec.js.snap

@@ -5,7 +5,6 @@ exports[`<RuleImplementationResults /> matches the latest snapshot 1`] = `
   <Table
     as="table"
     className="implementation-results small"
-    selectable={true}
   >
     <TableHeader
       as="thead"
@@ -16,11 +15,11 @@ exports[`<RuleImplementationResults /> matches the latest snapshot 1`] = `
       >
         <TableHeaderCell
           as="th"
-          content="ruleResult.props.quality"
+          content="ruleResult.props.date"
         />
         <TableHeaderCell
           as="th"
-          content="ruleResult.props.date"
+          content="ruleResult.props.quality"
         />
         <TableHeaderCell
           as="th"

package/src/components/__tests__/__snapshots__/RuleImplementationsActions.spec.js.snap

@@ -28,6 +28,7 @@ exports[`<RuleImplementationsActions /> matches the latest snapshot 1`] = `
     handleSubmit={[Function]}
   />
   <RuleImplementationsOptions
+    canUploadResults={true}
     loading={false}
   />
 </div>

package/src/components/__tests__/__snapshots__/RuleImplementationsOptions.spec.js.snap

@@ -1,58 +1,67 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<RuleImplementationsOptions /> matches the latest loading snapshot 1`] = `
-<Dropdown
-  additionLabel="Add "
-  additionPosition="top"
-  className="button icon group-actions button-update"
-  closeOnBlur={true}
-  closeOnEscape={true}
-  deburr={false}
-  direction="left"
-  disabled={true}
-  floating={true}
-  icon="ellipsis vertical"
-  minCharacters={1}
-  noResultsMessage="No results found."
-  openOnFocus={true}
-  renderLabel={[Function]}
-  searchInput="text"
-  selectOnBlur={true}
-  selectOnNavigation={true}
-  wrapSelection={true}
->
-  <DropdownMenu>
-    <Connect(RuleImplementationsDownload) />
-    <Connect(ImplementationsUploadButton) />
-    <Connect(RuleResultsUpload) />
-  </DropdownMenu>
-</Dropdown>
-`;
-
 exports[`<RuleImplementationsOptions /> matches the latest snapshot 1`] = `
-<Dropdown
-  additionLabel="Add "
-  additionPosition="top"
-  className="button icon group-actions button-update"
-  closeOnBlur={true}
-  closeOnEscape={true}
-  deburr={false}
-  direction="left"
-  floating={true}
-  icon="ellipsis vertical"
-  minCharacters={1}
-  noResultsMessage="No results found."
-  openOnFocus={true}
-  renderLabel={[Function]}
-  searchInput="text"
-  selectOnBlur={true}
-  selectOnNavigation={true}
-  wrapSelection={true}
->
-  <DropdownMenu>
-    <Connect(RuleImplementationsDownload) />
-    <Connect(ImplementationsUploadButton) />
-    <Connect(RuleResultsUpload) />
-  </DropdownMenu>
-</Dropdown>
+<div>
+  <div
+    aria-expanded="false"
+    class="ui floating dropdown button icon group-actions button-update"
+    role="listbox"
+    tabindex="0"
+  >
+    <i
+      aria-hidden="true"
+      class="ellipsis vertical icon"
+    />
+    <div
+      class="menu transition left"
+    >
+      <div
+        aria-disabled="true"
+        class="disabled item"
+        role="option"
+      >
+        <i
+          aria-hidden="true"
+          class="download icon"
+        />
+        <span>
+          Download with csv format
+        </span>
+        <p
+          class="menu-item-description"
+        >
+          There are no Implementations to be downloaded
+        </p>
+      </div>
+      <div
+        class="item"
+        role="option"
+      >
+        <i
+          aria-hidden="true"
+          class="upload icon"
+        />
+        <span
+          class="text"
+        >
+          Upload Implementations
+        </span>
+      </div>
+      <div
+        class="item"
+        role="option"
+      >
+        <i
+          aria-hidden="true"
+          class="upload icon"
+        />
+        <span
+          class="text"
+        >
+          Upload rule results
+        </span>
+      </div>
+    </div>
+  </div>
+</div>
 `;

package/src/components/__tests__/__snapshots__/RuleResultsUpload.spec.js.snap

@@ -1,12 +1,20 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`<RuleResultsUpload /> matches the latest snapshot 1`] = `
-<UploadModal
-  content="uploadModal.actions.upload.confirmation.content"
-  handleSubmit={[Function]}
-  header="ruleResults.actions.upload.confirmation.header"
-  icon="upload"
-  param="rule_results"
-  trigger={null}
-/>
+<div>
+  <div
+    class="item"
+    role="option"
+  >
+    <i
+      aria-hidden="true"
+      class="upload icon"
+    />
+    <span
+      class="text"
+    >
+      Upload rule results
+    </span>
+  </div>
+</div>
 `;

package/src/reducers/__tests__/implementationsActions.spec.js

@@ -0,0 +1,50 @@
+import {
+  clearRuleImplementations,
+  searchRuleImplementations,
+} from "../../routines";
+import {
+  implementationsActions,
+  initialState,
+} from "../implementationsActions";
+
+const fooState = { foo: "bar" };
+const payload = {};
+
+describe("reducers: implementationsActions", () => {
+  it("should provide the initial state", () => {
+    expect(implementationsActions(undefined, {})).toBe(initialState);
+  });
+
+  it("should be the initial state after receiving the clearRuleImplementations.TRIGGER action", () => {
+    expect(
+      implementationsActions(fooState, {
+        type: clearRuleImplementations.TRIGGER,
+        payload,
+      })
+    ).toBe(initialState);
+  });
+
+  it("should be the initial state after receiving the searchRuleImplementations.TRIGGER action", () => {
+    expect(
+      implementationsActions(fooState, {
+        type: searchRuleImplementations.TRIGGER,
+        payload,
+      })
+    ).toBe(initialState);
+  });
+
+  it("should extract _actions from the searchRuleImplementations.SUCCESS action", () => {
+    const _actions = { uploadResults: { foo: "bar" } };
+    const payload = { data: { _actions } };
+    expect(
+      implementationsActions(fooState, {
+        type: searchRuleImplementations.SUCCESS,
+        payload,
+      })
+    ).toMatchObject(_actions);
+  });
+
+  it("should ignore unhandled actions", () => {
+    expect(implementationsActions(fooState, { type: "FOO" })).toBe(fooState);
+  });
+});

package/src/reducers/__tests__/{uploadingResults.spec.js → resultsUploading.spec.js}

@@ -1,18 +1,18 @@
 import { uploadResults } from "../../routines";
-import { uploadingResults } from "..";
+import { resultsUploading } from "../resultsUploading";
 
 const fooState = { foo: "bar" };
 
 const initialState = false;
 
-describe("reducers: uploadingResults", () => {
+describe("reducers: resultsUploading", () => {
   it("should provide the initial state", () => {
-    expect(uploadingResults(undefined, {})).toEqual(initialState);
+    expect(resultsUploading(undefined, {})).toEqual(initialState);
   });
 
   it("should handle the uploadResults.TRIGGER action", () => {
     expect(
-      uploadingResults(fooState, {
+      resultsUploading(fooState, {
         type: uploadResults.TRIGGER,
       })
     ).toBeTruthy();
@@ -20,7 +20,7 @@ describe("reducers: uploadingResults", () => {
 
   it("should handle the uploadResults.FULFILL action", () => {
     expect(
-      uploadingResults(fooState, {
+      resultsUploading(fooState, {
         type: uploadResults.FULFILL,
       })
     ).toBeFalsy();

package/src/reducers/implementationsActions.js

@@ -0,0 +1,24 @@
+import {
+  clearRuleImplementations,
+  searchRuleImplementations,
+} from "../routines";
+
+export const initialState = null;
+
+export const implementationsActions = (
+  state = initialState,
+  { type, payload }
+) => {
+  switch (type) {
+    case clearRuleImplementations.TRIGGER:
+      return initialState;
+    case searchRuleImplementations.TRIGGER:
+      return initialState;
+    case searchRuleImplementations.SUCCESS:
+      return payload?.data?._actions || initialState;
+    default:
+      return state;
+  }
+};
+
+export default implementationsActions;

package/src/reducers/index.js

@@ -3,9 +3,11 @@ import { conceptRulesActions } from "./conceptRulesActions";
 import { conceptRulesLoading } from "./conceptRulesLoading";
 import { deletionQuery } from "./deletionQuery";
 import { dqMessage } from "./dqMessage";
-import { previousRuleImplementationQuery } from "./previousRuleImplementationQuery";
-import { executionGroupLoading } from "./executionGroupLoading";
 import { executionGroup } from "./executionGroup";
+import { executionGroupLoading } from "./executionGroupLoading";
+import { implementationsActions } from "./implementationsActions";
+import { previousRuleImplementationQuery } from "./previousRuleImplementationQuery";
+import { resultsUploading } from "./resultsUploading";
 import { rule } from "./rule";
 import { ruleActions } from "./ruleActions";
 import { ruleActiveFilters } from "./ruleActiveFilters";
@@ -14,6 +16,7 @@ import { ruleCreating } from "./ruleCreating";
 import { ruleFilters } from "./ruleFilters";
 import { ruleFiltersLoading } from "./ruleFiltersLoading";
 import { ruleImplementation } from "./ruleImplementation";
+import { ruleImplementationActiveFilters } from "./ruleImplementationActiveFilters";
 import { ruleImplementationCount } from "./ruleImplementationCount";
 import { ruleImplementationCreating } from "./ruleImplementationCreating";
 import { ruleImplementationFilters } from "./ruleImplementationFilters";
@@ -26,7 +29,6 @@ import { ruleImplementationSaving } from "./ruleImplementationSaving";
 import { ruleImplementationSelectedFilter } from "./ruleImplementationSelectedFilter";
 import { ruleImplementations } from "./ruleImplementations";
 import { ruleImplementationsDownloading } from "./ruleImplementationsDownloading";
-import { ruleImplementationActiveFilters } from "./ruleImplementationActiveFilters";
 import { ruleImplementationsLoading } from "./ruleImplementationsLoading";
 import { ruleImplementationsPageSize } from "./ruleImplementationsPageSize";
 import { ruleLoading } from "./ruleLoading";
@@ -39,10 +41,9 @@ import { rulesLoading } from "./rulesLoading";
 import { rulesPageSize } from "./rulesPageSize";
 import { uploadingImplementationsFile } from "./uploadingImplementationsFile";
 import { uploadingRulesFile } from "./uploadingRulesFile";
+import { userImplementationsPermissions } from "./userImplementationsPermissions";
 import { userRulePermissions } from "./userRulePermissions";
 import { userRulesPermissions } from "./userRulesPermissions";
-import { userImplementationsPermissions } from "./userImplementationsPermissions";
-import { uploadingResults } from "./uploadingResults";
 
 export {
   conceptRules,
@@ -50,9 +51,11 @@ export {
   conceptRulesLoading,
   deletionQuery,
   dqMessage,
-  previousRuleImplementationQuery,
-  executionGroupLoading,
   executionGroup,
+  executionGroupLoading,
+  implementationsActions,
+  previousRuleImplementationQuery,
+  resultsUploading,
   rule,
   ruleActions,
   ruleActiveFilters,
@@ -84,10 +87,9 @@ export {
   rules,
   rulesLoading,
   rulesPageSize,
-  uploadingRulesFile,
   uploadingImplementationsFile,
+  uploadingRulesFile,
+  userImplementationsPermissions,
   userRulePermissions,
   userRulesPermissions,
-  userImplementationsPermissions,
-  uploadingResults,
 };

package/src/reducers/{uploadingResults.js → resultsUploading.js}

@@ -2,7 +2,7 @@ import { uploadResults } from "../routines";
 
 const initialState = false;
 
-export const uploadingResults = (state = initialState, { type }) => {
+export const resultsUploading = (state = initialState, { type }) => {
   switch (type) {
     case uploadResults.TRIGGER:
       return true;
@@ -13,4 +13,4 @@ export const uploadingResults = (state = initialState, { type }) => {
   }
 };
 
-export default uploadingResults;
+export default resultsUploading;

package/src/styles/ruleResultRow.less

@@ -0,0 +1,3 @@
+.rule-result-date {
+  margin-right: 5px;
+}