@truedat/dq 4.37.4 → 4.37.5

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [4.37.5] 2022-02-06
+
+### Changed
+
+- [TD-4426]
+  - On `ExecutionDetails` decode detail fields with prefix `base64_`
+  - Option to create messages with `ruleResult.details.props.<field_name>` to replace detail key
+
 ## [4.37.4] 2022-02-04
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.37.4",
+  "version": "4.37.5",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -82,8 +82,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.4.10",
-    "@truedat/core": "4.37.4",
-    "@truedat/df": "4.37.4",
+    "@truedat/core": "4.37.5",
+    "@truedat/df": "4.37.5",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -103,5 +103,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "d6a390c1a843d164c28cf7ae174126b6c0e24618"
+  "gitHead": "98ff8669e99824ef1bdbd3d12035e6371029e4ca"
 }

package/src/components/ExecutionDetails.js

@@ -28,7 +28,7 @@ const GeneralInformation = ({ ruleImplementation, ruleResult }) => {
 
       <Table.Row>
         <Table.Cell>
-          {formatMessage({ id: "ruleResult.props.date" })}{" "}
+          {formatMessage({ id: "ruleResult.props.date" })}
         </Table.Cell>
         <Table.Cell>
           <DateTime value={ruleResult.date} />
@@ -37,14 +37,14 @@ const GeneralInformation = ({ ruleImplementation, ruleResult }) => {
 
       <Table.Row>
         <Table.Cell>
-          {formatMessage({ id: "ruleResult.props.records" })}{" "}
+          {formatMessage({ id: "ruleResult.props.records" })}
         </Table.Cell>
         <Table.Cell>{formatNumber(ruleResult.records)}</Table.Cell>
       </Table.Row>
 
       <Table.Row>
         <Table.Cell>
-          {formatMessage({ id: "ruleResult.props.errors" })}{" "}
+          {formatMessage({ id: "ruleResult.props.errors" })}
         </Table.Cell>
         <Table.Cell>{formatNumber(ruleResult.errors)}</Table.Cell>
       </Table.Row>
@@ -58,13 +58,19 @@ GeneralInformation.propTypes = {
 };
 
 const DetailRow = ({ details }) => {
+  const { formatMessage } = useIntl();
   return _.flow(
     _.keys,
     _.map((key) => (
       <Table.Row key={key}>
-        <Table.Cell>{key}</Table.Cell>
         <Table.Cell>
-          {key === "Query"
+          {formatMessage({
+            id: `ruleResult.details.props.${key.replace(/^(base64_)/, "")}`,
+            defaultMessage: key.replace(/^(base64_)/, ""),
+          })}
+        </Table.Cell>
+        <Table.Cell>
+          {key === "Query" || key.startsWith("base64_")
             ? Buffer.from(details[key], "base64").toString()
             : JSON.stringify(details[key], null, 2)}
         </Table.Cell>
@@ -73,11 +79,13 @@ const DetailRow = ({ details }) => {
   )(details);
 };
 
-export const ExecutionDetails = ({ ruleImplementation, rule_result_id }) => {
+DetailRow.propTypes = { details: PropTypes.object };
+
+export const ExecutionDetails = ({ ruleImplementation, ruleResultId }) => {
   const { formatMessage } = useIntl();
-  const { rule_result_id: id } = useParams();
+  const { rule_result_id: paramsId } = useParams();
 
-  const result_id = _.defaultTo(_.toNumber(id))(rule_result_id);
+  const result_id = _.defaultTo(_.toNumber(paramsId))(ruleResultId);
 
   const ruleResult = _.find(_.propEq("id", result_id))(
     ruleImplementation.results
@@ -128,7 +136,7 @@ export const ExecutionDetails = ({ ruleImplementation, rule_result_id }) => {
 
 ExecutionDetails.propTypes = {
   ruleImplementation: PropTypes.object,
-  rule_result_id: PropTypes.number,
+  ruleResultId: PropTypes.number,
 };
 
 const mapStateToProps = (state) => ({

package/src/components/RuleRoutes.js

@@ -75,7 +75,7 @@ const ImplementationEventsLoader = () => {
   return <EventsLoader resource_id={id} resource_type="implementation" />;
 };
 
-const RuleRoutes = ({
+export const RuleRoutes = ({
   ruleLoaded,
   ruleImplementationLoaded,
   implementationStructures,
@@ -312,7 +312,7 @@ const RuleRoutes = ({
                         <RuleImplementationLoader />
                         {ruleLoaded && ruleImplementationLoaded && (
                           <RuleImplementation>
-                            <ExecutionDetails rule_result_id={latest.id} />
+                            <ExecutionDetails ruleResultId={latest.id} />
                           </RuleImplementation>
                         )}
                       </Segment>

package/src/components/__tests__/ExecutionDetails.spec.js

@@ -11,41 +11,48 @@ jest.mock("react-router-dom", () => ({
 
 const renderOpts = {
   messages: {
-    en: messages.en,
+    en: {
+      ...messages.en,
+      "ruleResult.details.props.test": "TestMessage",
+    },
   },
 };
 
-describe("<ExecutionDetetails>", () => {
-  const rule = {
-    result_type: "percentage",
-    minimum: 50,
-    goal: 100,
-  };
-  const ruleImplementation = {
-    results: [{ foo: "bar", id: 100, details: { Query: "ImZvbyI=" } }],
-  };
-  const customColumns = [{ foo: "bar", name: "foo" }];
-  const props = {
-    rule,
-    ruleImplementation,
-    customColumns,
-  };
-
+describe("<ExecutionDetails>", () => {
   it("matches the lastest snapshot", () => {
+    const props = {
+      ruleImplementation: {
+        results: [{ foo: "bar", id: 100, details: { Query: "ImZvbyI=" } }],
+      },
+    };
     const { container } = render(<ExecutionDetails {...props} />, renderOpts);
     expect(container).toMatchSnapshot();
   });
 
+  it("decodes details with base64 prefix", () => {
+    const props = {
+      ruleImplementation: {
+        results: [
+          {
+            foo: "bar",
+            id: 100,
+            details: {
+              value: "valor",
+              base64_test: "QmFzZTY0X3ZhbHVl", //base64 for Base64_value
+            },
+          },
+        ],
+      },
+    };
+    const { getByText } = render(<ExecutionDetails {...props} />, renderOpts);
+    expect(getByText("TestMessage")).toBeInTheDocument();
+    expect(getByText("Base64_value")).toBeInTheDocument();
+  });
+
   it("without details", () => {
     const propsWithoutDetails = {
-      ...props,
       ruleImplementation: {
-        ...props.ruleImplementation,
-        results: {
-          ..._.map((result) => _.omit(["details"])(result))(
-            props.ruleImplementation.results
-          ),
-        },
+        results: [{ foo: "bar", id: 100 }],
       },
     };
     const { container } = render(

package/src/components/__tests__/RuleRoutes.spec.js

@@ -0,0 +1,23 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { RuleRoutes } from "../RuleRoutes";
+
+describe("<RuleRoutes>", () => {
+  const props = {
+    rule: {},
+    implementationStructures: [],
+    ruleLoaded: true,
+    template: {},
+    ruleImplementation: {},
+    ruleImplementationLoaded: true,
+    implementationStructuresLoaded: true,
+    systemsLoading: true,
+    templatesLoaded: true,
+    structuresAliasesLoading: true,
+  };
+
+  it("matches the lastest snapshot", () => {
+    const { container } = render(<RuleRoutes {...props} />, {});
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/__snapshots__/ExecutionDetails.spec.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
+exports[`<ExecutionDetails> matches the lastest snapshot 1`] = `
 <div>
   <table
     class="ui table implementation-results medium"
@@ -47,7 +47,6 @@ exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
           class=""
         >
           Date
-           
         </td>
         <td
           class=""
@@ -60,7 +59,6 @@ exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
           class=""
         >
           Records
-           
         </td>
         <td
           class=""
@@ -73,7 +71,6 @@ exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
           class=""
         >
           Errors
-           
         </td>
         <td
           class=""
@@ -116,7 +113,7 @@ exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
 </div>
 `;
 
-exports[`<ExecutionDetetails> without details 1`] = `
+exports[`<ExecutionDetails> without details 1`] = `
 <div>
   <div
     class="ui message"

package/src/components/__tests__/__snapshots__/RuleRoutes.spec.js.snap

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleRoutes> matches the lastest snapshot 1`] = `<div />`;