@truedat/dq 4.37.1 → 4.37.5

package/src/components/__tests__/__snapshots__/ExecutionDetails.spec.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
+exports[`<ExecutionDetails> matches the lastest snapshot 1`] = `
 <div>
   <table
     class="ui table implementation-results medium"
@@ -47,7 +47,6 @@ exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
           class=""
         >
           Date
-           
         </td>
         <td
           class=""
@@ -60,7 +59,6 @@ exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
           class=""
         >
           Records
-           
         </td>
         <td
           class=""
@@ -73,7 +71,6 @@ exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
           class=""
         >
           Errors
-           
         </td>
         <td
           class=""
@@ -116,7 +113,7 @@ exports[`<ExecutionDetetails> matches the lastest snapshot 1`] = `
 </div>
 `;
 
-exports[`<ExecutionDetetails> without details 1`] = `
+exports[`<ExecutionDetails> without details 1`] = `
 <div>
   <div
     class="ui message"

package/src/components/__tests__/__snapshots__/RuleEventRow.spec.js.snap

@@ -0,0 +1,38 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleEventsRow /> matches the latest snapshot 1`] = `
+<div>
+  <div
+    class="event"
+  >
+    <div
+      class="content"
+    >
+      <div
+        class="summary"
+      >
+        <a
+          class="user"
+        >
+          some.user@domain.tld
+        </a>
+         
+        <div
+          class="date"
+        >
+          <time
+            datetime="1631777792848"
+          >
+            2021-09-16 07:36
+          </time>
+        </div>
+      </div>
+      <div
+        class="text extra"
+      >
+        Field field1 changed to: "new value"
+      </div>
+    </div>
+  </div>
+</div>
+`;

package/src/components/__tests__/__snapshots__/RuleEvents.spec.js.snap

@@ -0,0 +1,78 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleEvents /> matches the latest snapshot 1`] = `
+<div>
+  <div
+    class="ui bottom attached segment"
+  >
+    <div
+      class="ui small feed"
+    >
+      <div
+        class="event"
+      >
+        <div
+          class="content"
+        >
+          <div
+            class="summary"
+          >
+            <a
+              class="user"
+            >
+              some.user@domain.tld
+            </a>
+             
+            <div
+              class="date"
+            >
+              <time
+                datetime="1631777792848"
+              >
+                2021-09-16 07:36
+              </time>
+            </div>
+          </div>
+          <div
+            class="text extra"
+          >
+            Field domain_id changed to: 140
+          </div>
+        </div>
+      </div>
+      <div
+        class="event"
+      >
+        <div
+          class="content"
+        >
+          <div
+            class="summary"
+          >
+            <a
+              class="user"
+            >
+              some.user
+            </a>
+             
+            <div
+              class="date"
+            >
+              <time
+                datetime="1631784663061"
+              >
+                2021-09-16 09:31
+              </time>
+            </div>
+          </div>
+          <div
+            class="text extra"
+          >
+            Field domain_id changed to: 168
+          </div>
+        </div>
+      </div>
+    </div>
+  </div>
+</div>
+`;

package/src/components/__tests__/__snapshots__/RuleRoutes.spec.js.snap

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleRoutes> matches the lastest snapshot 1`] = `<div />`;

package/src/messages/en.js

@@ -132,6 +132,7 @@ export default {
     "All rule implementations should be removed",
   "rule.error.rule_name_bc_id.unique_constraint":
     "Duplicated rule name. Edit name or associated business concept.",
+  
   "rule.form.accordion.select": "Select",
   "rule.form.concept.label": "Concept",
   "ruleImplementation.form.tooltip.deviation.goal":
@@ -541,6 +542,10 @@ export default {
   "rules.actions.upload.confirmation.header": "Confirm bulk upload",
   "rules.actions.upload.tooltip": "Upload Rules",
   "rules.crumbs.top": "Rules",
+  "rules.events.action_created": "Rule created",
+  "rules.events.action_changed": "Field {0} changed: {1}",
+  "rules.events.action_changed_to": "Field {0} changed to: {1}",
+  "rules.events.action_updated": "Rule updated",
   "rules.retrieved.results": "{count} rules found",
   "rules.search.placeholder": "Search rules...",
   "rules.searching": "Searching...",
@@ -557,6 +562,7 @@ export default {
   "structureFields.dropdown.placeholder": "Fields",
   "summary.link.and": "and",
   "tabs.dq.rule": "Rule",
+  "tabs.dq.rule.audit": "Audit",
   "tabs.dq.ruleImplementation": "Implementation",
   "tabs.dq.ruleImplementation.audit": "Audit",
   "tabs.dq.ruleImplementation.details": "Details",

package/src/messages/es.js

@@ -556,6 +556,14 @@ export default {
   "rules.actions.upload.confirmation.header": "Subir ficheros de reglas",
   "rules.actions.upload.tooltip": "Subir reglas",
   "rules.crumbs.top": "Reglas",
+  "rules.events.action_created": "Regla creada",
+  "rules.events.action_changed": "Campo {0} actualizado: {1}",
+  "rules.events.action_changed_to": "Campo {0} actualizado a {1}",
+  "rules.events.action_updated": "Regla actualizada",
+  "ruleImplementations.events.action_created": "Implementación creada en regla: {0}",
+  "ruleImplementations.events.action_changed": "Campo {0} actualizado a {1}",
+  "ruleImplementations.events.action_deprecated": "Implementación archivada",
+  "ruleImplementations.events.action_moved": "Implementación movida a la regla: {0}",
   "rules.retrieved.results": "{count} reglas encontradas",
   "rules.search.placeholder": "Buscar reglas...",
   "rules.searching": "Buscando...",
@@ -573,6 +581,7 @@ export default {
   "structureFields.dropdown.placeholder": "Campos",
   "summary.link.and": "y",
   "tabs.dq.rule": "Regla",
+  "tabs.dq.rule.audit": "Auditoría",
   "tabs.dq.ruleImplementation.audit": "Auditoría",
   "tabs.dq.ruleImplementation.details": "Detalles",
   "tabs.dq.ruleImplementation.results": "Resultados",

package/src/reducers/__tests__/ruleActiveFilters.spec.js

@@ -1,10 +1,11 @@
+import { applyUserSearchFilter } from "@truedat/dd/routines";
 import { initialState } from "../ruleActiveFilters";
 import {
   addRuleFilter,
   closeRuleFilter,
   removeRuleFilter,
   resetRuleFilters,
-  toggleRuleFilterValue
+  toggleRuleFilterValue,
 } from "../../routines";
 import { ruleActiveFilters } from "..";
 
@@ -21,11 +22,22 @@ describe("reducers: ruleActiveFilters", () => {
     expect(
       ruleActiveFilters(fooState, {
         type: addRuleFilter.TRIGGER,
-        payload
+        payload,
       })
     ).toEqual({ ...fooState, baz: [] });
   });
 
+  it("should handle the applyUserSearchFilter.TRIGGER action", () => {
+    const filters = { country: ["Sp"] };
+    const payload = { userFilter: { filters }, scope: "rule" };
+    expect(
+      ruleActiveFilters(fooState, {
+        type: applyUserSearchFilter.TRIGGER,
+        payload,
+      })
+    ).toEqual({ ...filters });
+  });
+
   it("should handle the closeRuleFilter.TRIGGER action", () => {
     const foo = ["foo1"];
     const bar = [];
@@ -34,7 +46,7 @@ describe("reducers: ruleActiveFilters", () => {
     expect(
       ruleActiveFilters(state, {
         type: closeRuleFilter.TRIGGER,
-        payload
+        payload,
       })
     ).toEqual({ foo });
   });
@@ -47,7 +59,7 @@ describe("reducers: ruleActiveFilters", () => {
     expect(
       ruleActiveFilters(state, {
         type: removeRuleFilter.TRIGGER,
-        payload
+        payload,
       })
     ).toEqual({ bar });
   });
@@ -55,7 +67,7 @@ describe("reducers: ruleActiveFilters", () => {
   it("should handle the resetRuleFilters.TRIGGER action", () => {
     expect(
       ruleActiveFilters(fooState, {
-        type: resetRuleFilters.TRIGGER
+        type: resetRuleFilters.TRIGGER,
       })
     ).toEqual(initialState);
   });
@@ -63,7 +75,7 @@ describe("reducers: ruleActiveFilters", () => {
   it("should handle the resetRuleFilters.TRIGGER action when execution filter exists", () => {
     expect(
       ruleActiveFilters(fooState, {
-        type: resetRuleFilters.TRIGGER
+        type: resetRuleFilters.TRIGGER,
       })
     ).toEqual(initialState);
   });
@@ -76,7 +88,7 @@ describe("reducers: ruleActiveFilters", () => {
     expect(
       ruleActiveFilters(state, {
         type: toggleRuleFilterValue.TRIGGER,
-        payload
+        payload,
       })
     ).toEqual({ foo: ["foo1", "foo3"], bar });
   });

package/src/reducers/__tests__/ruleImplementationActiveFilters.spec.js

@@ -1,10 +1,11 @@
+import { applyUserSearchFilter } from "@truedat/dd/routines";
 import { initialState } from "../ruleImplementationActiveFilters";
 import {
   addImplementationFilter,
   closeImplementationFilter,
   removeImplementationFilter,
   resetImplementationFilters,
-  toggleImplementationFilterValue
+  toggleImplementationFilterValue,
 } from "../../routines";
 import { ruleImplementationActiveFilters } from "..";
 
@@ -17,13 +18,24 @@ describe("reducers: ruleImplementationActiveFilters", () => {
     );
   });
 
+  it("should handle the applyUserSearchFilter.TRIGGER action", () => {
+    const filters = { country: ["Sp"] };
+    const payload = { userFilter: { filters }, scope: "rule_implementation" };
+    expect(
+      ruleImplementationActiveFilters(fooState, {
+        type: applyUserSearchFilter.TRIGGER,
+        payload,
+      })
+    ).toEqual({ ...filters });
+  });
+
   it("should handle the addImplementationFilter.TRIGGER action", () => {
     const filter = "baz";
     const payload = { filter };
     expect(
       ruleImplementationActiveFilters(fooState, {
         type: addImplementationFilter.TRIGGER,
-        payload
+        payload,
       })
     ).toEqual({ ...fooState, baz: [] });
   });
@@ -36,7 +48,7 @@ describe("reducers: ruleImplementationActiveFilters", () => {
     expect(
       ruleImplementationActiveFilters(state, {
         type: closeImplementationFilter.TRIGGER,
-        payload
+        payload,
       })
     ).toEqual({ foo });
   });
@@ -49,7 +61,7 @@ describe("reducers: ruleImplementationActiveFilters", () => {
     expect(
       ruleImplementationActiveFilters(state, {
         type: removeImplementationFilter.TRIGGER,
-        payload
+        payload,
       })
     ).toEqual({ bar });
   });
@@ -57,7 +69,7 @@ describe("reducers: ruleImplementationActiveFilters", () => {
   it("should handle the resetImplementationFilters.TRIGGER action", () => {
     expect(
       ruleImplementationActiveFilters(fooState, {
-        type: resetImplementationFilters.TRIGGER
+        type: resetImplementationFilters.TRIGGER,
       })
     ).toEqual(initialState);
   });
@@ -67,7 +79,7 @@ describe("reducers: ruleImplementationActiveFilters", () => {
       ruleImplementationActiveFilters(
         { ...fooState, executable: [true] },
         {
-          type: resetImplementationFilters.TRIGGER
+          type: resetImplementationFilters.TRIGGER,
         }
       )
     ).toEqual({ executable: [true] });
@@ -81,7 +93,7 @@ describe("reducers: ruleImplementationActiveFilters", () => {
     expect(
       ruleImplementationActiveFilters(state, {
         type: toggleImplementationFilterValue.TRIGGER,
-        payload
+        payload,
       })
     ).toEqual({ foo: ["foo1", "foo3"], bar });
   });

package/src/reducers/index.js

@@ -17,6 +17,7 @@ import { ruleImplementation } from "./ruleImplementation";
 import { ruleImplementationCount } from "./ruleImplementationCount";
 import { ruleImplementationCreating } from "./ruleImplementationCreating";
 import { ruleImplementationFilters } from "./ruleImplementationFilters";
+import { ruleImplementationFiltersLoading } from "./ruleImplementationFiltersLoading";
 import { ruleImplementationLoading } from "./ruleImplementationLoading";
 import { ruleImplementationQuery } from "./ruleImplementationQuery";
 import { ruleImplementationRaw } from "./ruleImplementationRaw";
@@ -64,6 +65,7 @@ export {
   ruleImplementationCount,
   ruleImplementationCreating,
   ruleImplementationFilters,
+  ruleImplementationFiltersLoading,
   ruleImplementationLoading,
   ruleImplementationQuery,
   ruleImplementationRaw,

package/src/reducers/ruleActiveFilters.js

@@ -1,4 +1,5 @@
 import _ from "lodash/fp";
+import { applyUserSearchFilter } from "@truedat/dd/routines";
 import {
   addRuleFilter,
   closeRuleFilter,
@@ -15,6 +16,10 @@ export const ruleActiveFilters = (state = initialState, { type, payload }) => {
       const { filter } = payload;
       return { ...state, [filter]: [] };
     }
+    case applyUserSearchFilter.TRIGGER: {
+      const { userFilter, scope } = payload;
+      return scope === "rule" ? _.prop("filters")(userFilter) : state;
+    }
     case closeRuleFilter.TRIGGER: {
       const { filter } = payload;
       const values = _.propOr([], filter)(state);

package/src/reducers/ruleImplementationActiveFilters.js

@@ -1,4 +1,5 @@
 import _ from "lodash/fp";
+import { applyUserSearchFilter } from "@truedat/dd/routines";
 import {
   addImplementationFilter,
   closeImplementationFilter,
@@ -18,6 +19,12 @@ export const ruleImplementationActiveFilters = (
       const { filter } = payload;
       return { ...state, [filter]: [] };
     }
+    case applyUserSearchFilter.TRIGGER: {
+      const { userFilter, scope } = payload;
+      return scope === "rule_implementation"
+        ? _.prop("filters")(userFilter)
+        : state;
+    }
     case closeImplementationFilter.TRIGGER: {
       const { filter } = payload;
       const values = _.propOr([], filter)(state);

package/src/reducers/ruleImplementationFilters.js

@@ -1,7 +1,7 @@
 import _ from "lodash/fp";
 import {
   clearImplementationFilters,
-  fetchImplementationFilters
+  fetchImplementationFilters,
 } from "../routines";
 
 const initialState = {};

package/src/reducers/ruleImplementationFiltersLoading.js

@@ -0,0 +1,14 @@
+import { fetchImplementationFilters } from "../routines";
+
+const ruleImplementationFiltersLoading = (state = false, { type }) => {
+  switch (type) {
+    case fetchImplementationFilters.REQUEST:
+      return true;
+    case fetchImplementationFilters.FULFILL:
+      return false;
+    default:
+      return state;
+  }
+};
+
+export { ruleImplementationFiltersLoading };

package/src/selectors/__tests__/getParsedEvents.spec.js

@@ -0,0 +1,173 @@
+import { getParsedEvents } from "..";
+
+describe("selectors: getParsedEvents", () => {
+  const events = [
+    {
+      id: 52351,
+      service: "td_dd",
+      resource_id: 777,
+      resource_type: "rule",
+      event: "rule_created",
+      payload: {
+        active: true,
+        content: {
+          added: {
+            data_owner: null,
+            proyecto: ["P1"],
+          },
+        },
+        description: {},
+        df_name: "dq_default_template",
+        domain_id: 2,
+        goal: 20,
+        minimum: 80,
+        name: "des01",
+        result_type: "deviation",
+        updated_by: 398,
+      },
+      user_id: 398,
+      user_name: null,
+      user: {
+        email: "some.user@domain.tld",
+        full_name: "Some User",
+        id: 398,
+        user_name: "some.user@domain.tld",
+      },
+      ts: "2021-08-12T12:11:26.908147Z",
+    },
+
+    {
+      id: 100217,
+      service: "td_dd",
+      resource_id: 777,
+      resource_type: "rule",
+      event: "rule_updated",
+      payload: {
+        domain_id: 140,
+      },
+      user_id: 142,
+      user_name: null,
+      user: {
+        email: "some.user@domain.tld",
+        full_name: "Some User",
+        id: 142,
+        user_name: "some.user@domain.tld",
+      },
+      ts: "2021-09-16T07:36:32.848603Z",
+    },
+    {
+      id: 100435,
+      service: "td_dd",
+      resource_id: 777,
+      resource_type: "rule",
+      event: "rule_updated",
+      payload: {
+        description: {
+          document: {
+            data: {},
+            nodes: [
+              {
+                data: {},
+                nodes: [
+                  {
+                    marks: [],
+                    object: "text",
+                    text: "Añadimos descripción a la regla",
+                  },
+                ],
+                object: "block",
+                type: "paragraph",
+              },
+            ],
+            object: "document",
+          },
+          object: "value",
+        },
+        updated_by: 171,
+      },
+      user_id: 171,
+      user_name: null,
+      user: {
+        email: "some.user@domain.tld",
+        full_name: "Some User",
+        id: 171,
+        user_name: "some.user",
+      },
+      ts: "2021-09-16T09:30:52.317357Z",
+    },
+    {
+      id: 177692,
+      service: "td_dd",
+      resource_id: 777,
+      resource_type: "rule",
+      event: "rule_updated",
+      payload: {
+        content: {
+          changed: {
+            data_stew: null,
+            principle: "Validez",
+            scheduler: "",
+            tags: "et",
+          },
+          removed: {
+            data_owner: null,
+            proyecto: ["P1"],
+          },
+        },
+        df_name: "quality_template",
+        updated_by: 426,
+      },
+      user_id: 426,
+      user_name: null,
+      user: {
+        email: "some.user@domain.tld",
+        full_name: "Some User",
+        id: 426,
+        user_name: "some.user",
+      },
+      ts: "2021-10-20T07:56:45.891087Z",
+    },
+  ];
+
+  const parsed = [
+    {
+      ...events[0],
+      payload: [{ field: "des01", action: "created" }],
+    },
+    {
+      ...events[1],
+      payload: [{ field: "domain_id", action: "changed", value: 140 }],
+    },
+    {
+      ...events[2],
+      payload: [
+        {
+          field: "description",
+          action: "changed",
+          value: "Añadimos descripción a la regla",
+        },
+      ],
+    },
+    {
+      ...events[3],
+      payload: [
+        { field: "df_name", action: "changed", value: "quality_template" },
+        { action: "changed", field: "data_stew", value: null },
+        { action: "changed", field: "principle", value: "Validez" },
+        { action: "changed", field: "scheduler", value: "" },
+        { action: "changed", field: "tags", value: "et" },
+      ],
+    },
+  ];
+
+  it("should return all the events with the new payload", () => {
+    const res = getParsedEvents({ events });
+    expect(res).toEqual(parsed);
+  });
+
+  it("should return empty array when we have no elements", () => {
+    const res = getParsedEvents({ events: [] });
+    expect(res).toHaveLength(0);
+    expect(res).toEqual(expect.arrayContaining([]));
+  });
+});

package/src/selectors/getParsedEvents.js

@@ -8,6 +8,24 @@ const getEvents = ({ events }) => {
 const transformFieldFormat = (field) =>
   _.isBoolean(field) ? _.toString(field) : field;
 
+const findDeep = (obj, key) =>
+  _.has(key, obj)
+    ? obj[key]
+    : _.flatten(
+        _.map((v) => (typeof v == "object" ? findDeep(v, key) : []), obj)
+      );
+
+const transformRulePayloadFormat = (payload, field) => {
+  switch (field) {
+    case "content":
+      return payload.content;
+    case "description":
+      return _.first(findDeep(payload.description, "text"));
+    default:
+      return payload[field];
+  }
+};
+
 const getParsedEvents = createSelector([getEvents], (events) => {
   return _.map((d) => {
     switch (d.event) {
@@ -68,6 +86,43 @@ const getParsedEvents = createSelector([getEvents], (events) => {
             }))
           )(d),
         };
+      case "rule_created":
+        return {
+          ...d,
+          payload: [
+            {
+              field: _.path("payload.name")(d),
+              action: "created",
+            },
+          ],
+        };
+
+      case "rule_updated":
+        const content = _.flow(
+          _.getOr({}, "payload.content.changed"),
+          _.toPairs,
+          _.map(([field, value]) => ({
+            field,
+            value,
+            action: "changed",
+          }))
+        )(d);
+        return {
+          ...d,
+          payload: [
+            ..._.flow(
+              _.path("payload"),
+              _.omit(["updated_by", "content"]),
+              _.keys,
+              _.map((field) => ({
+                field: field,
+                action: "changed",
+                value: transformRulePayloadFormat(d.payload, field),
+              }))
+            )(d),
+            ...content,
+          ],
+        };
 
       default:
         return {