@truedat/dq 4.34.2 → 4.35.4

package/CHANGELOG.md

@@ -1,6 +1,20 @@
 # Changelog
 
-## [Unreleased]
+## [4.35.2] 2021-12-20
+
+### Fixed
+
+- [TD-4380] Allow modifier in operator filter
+
+## [4.34.3] 2021-12-15
+
+### Added
+
+- [TD-4273] Upload `RuleResults`
+
+## [4.34.2] 2021-12-14
+
+### Added
 
 - [TD-4314] Add BulkLoad for `rules`
 - [TD-4301] Add BulkLoad for `implementations`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "4.34.2",
+  "version": "4.35.4",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -82,8 +82,8 @@
   },
   "dependencies": {
     "@apollo/client": "^3.4.10",
-    "@truedat/core": "4.34.2",
-    "@truedat/df": "4.34.2",
+    "@truedat/core": "4.35.4",
+    "@truedat/df": "4.35.4",
     "axios": "^0.19.2",
     "graphql": "^15.5.3",
     "path-to-regexp": "^1.7.0",
@@ -103,5 +103,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "8b28a5faca902e9cab3e8b5ab2bc1f8626e3ec7b"
+  "gitHead": "b03fba26635e365bbab64a6de1dd9a155925b5d1"
 }

package/src/api.js

@@ -16,6 +16,7 @@ const API_RULE_IMPLEMENTATION_FILTERS_SEARCH =
   "/api/rule_implementation_filters/search";
 const API_RULE_IMPLEMENTATIONS_UPLOAD = "/api/rule_implementations/upload";
 const API_RULE_RESULT = "/api/rule_results/:id";
+const API_RULE_RESULTS = "/api/rule_results";
 const API_SUBSCRIPTIONS_SEARCH = "/api/subscriptions/user/me/search";
 const API_SUBSCRIPTION = "/api/subscriptions/:id";
 const API_SUBSCRIPTIONS = "/api/subscriptions";
@@ -37,6 +38,7 @@ export {
   API_RULE_IMPLEMENTATION_FILTERS_SEARCH,
   API_RULE_IMPLEMENTATIONS_UPLOAD,
   API_RULE_RESULT,
+  API_RULE_RESULTS,
   API_SUBSCRIPTIONS_SEARCH,
   API_SUBSCRIPTION,
   API_SUBSCRIPTIONS,

package/src/components/ImplementationsUploadButton.js

@@ -1,7 +1,7 @@
 import React from "react";
 import PropTypes from "prop-types";
 import { connect } from "react-redux";
-import { Button } from "semantic-ui-react";
+import { Dropdown } from "semantic-ui-react";
 import { FormattedMessage, useIntl } from "react-intl";
 import { UploadModal } from "@truedat/core/components";
 import { API_RULE_IMPLEMENTATIONS_UPLOAD } from "../api";
@@ -21,14 +21,12 @@ export const ImplementationsUploadButton = ({
     <UploadModal
       icon="upload"
       trigger={
-        <Button
-          secondary
-          floated="right"
+        <Dropdown.Item
           icon="upload"
-          loading={loading}
-          data-tooltip={formatMessage({
+          text={formatMessage({
             id: "ruleImplementations.actions.upload.tooltip",
           })}
+          disabled={loading}
         />
       }
       header={

package/src/components/RuleImplementationsActions.js

@@ -2,9 +2,7 @@ import _ from "lodash/fp";
 import React from "react";
 import PropTypes from "prop-types";
 import { connect } from "react-redux";
-import { Button, Checkbox } from "semantic-ui-react";
-import { useIntl } from "react-intl";
-import { downloadImplementations, uploadImplementations } from "../routines";
+import { Checkbox } from "semantic-ui-react";
 import { getImplementationsExecution } from "../selectors";
 import {
   addImplementationFilter,
@@ -12,38 +10,12 @@ import {
   removeImplementationFilter,
   createExecutionGroup,
 } from "../routines";
-import ImplementationsUploadButton from "./ImplementationsUploadButton";
-
 import ExecutionPopup from "./ExecutionPopup";
-
-const staticHeaderLabels = [
-  "implementation_key",
-  "implementation_type",
-  "rule",
-  "template",
-  "goal",
-  "minimum",
-  "business_concept",
-  "last_execution_at",
-  "result",
-  "execution",
-  "inserted_at",
-  "executable",
-];
-
-const staticContentLabels = [
-  "quality_result.under_minimum",
-  "quality_result.under_goal",
-  "quality_result.over_goal",
-  "quality_result.no_execution",
-  "executable.true",
-  "executable.false",
-];
+import RuleImplementationsOptions from "./RuleImplementationsOptions";
 
 export const RuleImplementationsActions = ({
   addImplementationFilter,
   canExecute,
-  downloadImplementations,
   executeImplementationsOn,
   toggleImplementationFilterValue,
   removeImplementationFilter,
@@ -53,22 +25,8 @@ export const RuleImplementationsActions = ({
   setMode,
   implementationsExecution,
   ruleImplementationCount,
-  ruleImplementationsDownloading,
   ruleImplementationsLoading,
-  upload,
 }) => {
-  const { formatMessage } = useIntl();
-
-  const headerLabels = _.flow(
-    _.map((l) => [l, formatMessage({ id: `ruleImplementations.props.${l}` })]),
-    _.fromPairs
-  )(staticHeaderLabels);
-
-  const contentLabels = _.flow(
-    _.map((l) => [l, formatMessage({ id: `ruleImplementations.props.${l}` })]),
-    _.fromPairs
-  )(staticContentLabels);
-
   const showExecutableInfo = () => {
     addImplementationFilter({ filter: "executable" });
     toggleImplementationFilterValue({
@@ -115,29 +73,13 @@ export const RuleImplementationsActions = ({
           />
         </>
       )}
-      {!ruleImplementationsLoading && (
-        <Button
-          floated="right"
-          secondary
-          icon="download"
-          data-tooltip={formatMessage({
-            id: "implementations.actions.download.tooltip",
-          })}
-          onClick={() =>
-            downloadImplementations({ contentLabels, headerLabels })
-          }
-          loading={ruleImplementationsDownloading}
-        />
-      )}
-      {upload && <ImplementationsUploadButton />}
-      <ImplementationsUploadButton />
+      <RuleImplementationsOptions loading={ruleImplementationsLoading} />
     </div>
   );
 };
 
 RuleImplementationsActions.propTypes = {
   addImplementationFilter: PropTypes.func,
-  downloadImplementations: PropTypes.func,
   canExecute: PropTypes.bool,
   createExecutionGroup: PropTypes.func,
   executeImplementationsOn: PropTypes.bool,
@@ -148,23 +90,19 @@ RuleImplementationsActions.propTypes = {
   selectedImplementations: PropTypes.array,
   setMode: PropTypes.func,
   toggleImplementationFilterValue: PropTypes.func,
-  ruleImplementationsDownloading: PropTypes.bool,
   ruleImplementationsLoading: PropTypes.bool,
-  upload: PropTypes.bool,
 };
 
 const mapStateToProps = (state) => ({
   canExecute: _.propOr(false, "userImplementationsPermissions.execute")(state),
   ruleImplementationCount: state.ruleImplementationCount,
   implementationsExecution: getImplementationsExecution(state),
-  ruleImplementationsDownloading: state.ruleImplementationsDownloading,
   ruleImplementationsLoading: state.ruleImplementationsLoading,
 });
 
 export default connect(mapStateToProps, {
   addImplementationFilter,
-  downloadImplementations,
   toggleImplementationFilterValue,
   removeImplementationFilter,
   createExecutionGroup,
-})(RuleImplementationsActions, uploadImplementations);
+})(RuleImplementationsActions);

package/src/components/RuleImplementationsDownload.js

@@ -0,0 +1,86 @@
+import _ from "lodash/fp";
+import React from "react";
+import PropTypes from "prop-types";
+import { connect } from "react-redux";
+import { Dropdown } from "semantic-ui-react";
+import { useIntl } from "react-intl";
+import { downloadImplementations } from "../routines";
+
+const staticHeaderLabels = [
+  "implementation_key",
+  "implementation_type",
+  "rule",
+  "template",
+  "goal",
+  "minimum",
+  "business_concept",
+  "last_execution_at",
+  "result",
+  "execution",
+  "inserted_at",
+  "executable",
+];
+
+const staticContentLabels = [
+  "quality_result.under_minimum",
+  "quality_result.under_goal",
+  "quality_result.over_goal",
+  "quality_result.no_execution",
+  "executable.true",
+  "executable.false",
+];
+
+export const RuleImplementationsDownload = ({
+  downloadImplementations,
+  ruleImplementationsDownloading,
+  ruleImplementations,
+}) => {
+  const { formatMessage } = useIntl();
+
+  const headerLabels = _.flow(
+    _.map((l) => [l, formatMessage({ id: `ruleImplementations.props.${l}` })]),
+    _.fromPairs
+  )(staticHeaderLabels);
+
+  const contentLabels = _.flow(
+    _.map((l) => [l, formatMessage({ id: `ruleImplementations.props.${l}` })]),
+    _.fromPairs
+  )(staticContentLabels);
+
+  const isDisabled = _.isEmpty(ruleImplementations);
+
+  return (
+    <Dropdown.Item
+      icon="download"
+      content={
+        <>
+          <span>
+            {formatMessage({ id: "implementations.actions.download.tooltip" })}
+          </span>
+          {isDisabled && (
+            <p className="menu-item-description">
+              {formatMessage({ id: "implementations.actions.download.empty" })}
+            </p>
+          )}
+        </>
+      }
+      onClick={() => downloadImplementations({ contentLabels, headerLabels })}
+      disabled={isDisabled || ruleImplementationsDownloading}
+    />
+  );
+};
+
+RuleImplementationsDownload.propTypes = {
+  downloadImplementations: PropTypes.func,
+  ruleImplementationsDownloading: PropTypes.bool,
+  ruleImplementations: PropTypes.array,
+};
+
+const mapStateToProps = _.pick([
+  "ruleImplementationsDownloading",
+  "ruleImplementations",
+]);
+
+export default connect(mapStateToProps, {
+  downloadImplementations,
+})(RuleImplementationsDownload);

package/src/components/RuleImplementationsOptions.js

@@ -0,0 +1,28 @@
+import React from "react";
+import PropTypes from "prop-types";
+import { Dropdown } from "semantic-ui-react";
+import RuleImplementationsDownload from "./RuleImplementationsDownload";
+import RuleResultsUpload from "./RuleResultsUpload";
+import ImplementationsUploadButton from "./ImplementationsUploadButton";
+
+export const RuleImplementationsOptions = ({ loading }) => (
+  <Dropdown
+    icon="ellipsis vertical"
+    className="button icon group-actions button-update"
+    direction="left"
+    floating
+    disabled={loading}
+  >
+    <Dropdown.Menu>
+      <RuleImplementationsDownload />
+      <ImplementationsUploadButton />
+      <RuleResultsUpload />
+    </Dropdown.Menu>
+  </Dropdown>
+);
+
+RuleImplementationsOptions.propTypes = {
+  loading: PropTypes.bool,
+};
+
+export default RuleImplementationsOptions;

package/src/components/RuleResultsUpload.js

@@ -0,0 +1,47 @@
+import React from "react";
+import PropTypes from "prop-types";
+import { connect } from "react-redux";
+import { Dropdown } from "semantic-ui-react";
+import { useIntl } from "react-intl";
+import { UploadModal } from "@truedat/core/components";
+import { uploadResults } from "../routines";
+
+export const RuleResultsUpload = ({ uploadResults, loading }) => {
+  const { formatMessage } = useIntl();
+
+  return (
+    <UploadModal
+      icon="upload"
+      trigger={
+        <Dropdown.Item
+          icon="upload"
+          text={formatMessage({ id: "ruleResults.actions.upload.tooltip" })}
+          disabled={loading}
+        />
+      }
+      header={formatMessage({
+        id: "ruleResults.actions.upload.confirmation.header",
+      })}
+      content={formatMessage({
+        id: "uploadModal.actions.upload.confirmation.content",
+      })}
+      param={"rule_results"}
+      handleSubmit={(data) =>
+        uploadResults({
+          data,
+        })
+      }
+    />
+  );
+};
+
+RuleResultsUpload.propTypes = {
+  uploadResults: PropTypes.func,
+  loading: PropTypes.bool,
+};
+
+const mapStateToProps = ({ uploadingResults }) => ({
+  loading: uploadingResults,
+});
+
+export default connect(mapStateToProps, { uploadResults })(RuleResultsUpload);

package/src/components/__tests__/RuleImplementationsActions.spec.js

@@ -8,7 +8,6 @@ jest.spyOn(React, "useContext").mockImplementation(() => intl);
 
 describe("<RuleImplementationsActions />", () => {
   const addImplementationFilter = jest.fn();
-  const downloadImplementations = jest.fn();
   const toggleImplementationFilterValue = jest.fn();
   const setMode = jest.fn();
   const removeImplementationFilter = jest.fn();
@@ -17,9 +16,7 @@ describe("<RuleImplementationsActions />", () => {
     executionGroupLoading: false,
     ruleImplementationCount: 12,
     implementationsExecution: true,
-    ruleImplementationsDownloading: false,
     ruleImplementationsLoading: false,
-    downloadImplementations,
     toggleImplementationFilterValue,
     addImplementationFilter,
     executeImplementationsOn: false,
@@ -31,12 +28,6 @@ describe("<RuleImplementationsActions />", () => {
     expect(wrapper).toMatchSnapshot();
   });
 
-  it("calls downloadImplementations on button click", () => {
-    const wrapper = shallow(<RuleImplementationsActions {...props} />);
-    wrapper.find("Button").simulate("click");
-    expect(downloadImplementations.mock.calls.length).toBe(1);
-  });
-
   it("as user with permissions I see execute implementations button and checkbox", () => {
     const props = {
       canExecute: true,

package/src/components/__tests__/RuleImplementationsOptions.spec.js

@@ -0,0 +1,18 @@
+import _ from "lodash/fp";
+import React from "react";
+import { shallow } from "enzyme";
+import { intl } from "@truedat/test/intl-stub";
+import { RuleImplementationsOptions } from "../RuleImplementationsOptions";
+
+jest.spyOn(React, "useContext").mockImplementation(() => intl);
+
+describe("<RuleImplementationsOptions />", () => {
+  it("matches the latest snapshot", () => {
+    const wrapper = shallow(<RuleImplementationsOptions />);
+    expect(wrapper).toMatchSnapshot();
+  });
+  it("matches the latest loading snapshot", () => {
+    const wrapper = shallow(<RuleImplementationsOptions loading />);
+    expect(wrapper).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/RuleResultsUpload.spec.js

@@ -0,0 +1,18 @@
+import _ from "lodash/fp";
+import React from "react";
+import { shallow } from "enzyme";
+import { intl } from "@truedat/test/intl-stub";
+import { RuleResultsUpload } from "../RuleResultsUpload";
+
+jest.spyOn(React, "useContext").mockImplementation(() => intl);
+
+describe("<RuleResultsUpload />", () => {
+  it("matches the latest snapshot", () => {
+    const props = {
+      uploadResults: jest.fn(),
+      loading: false,
+    };
+    const wrapper = shallow(<RuleResultsUpload {...props} />);
+    expect(wrapper).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/__snapshots__/RuleImplementationsActions.spec.js.snap

@@ -27,15 +27,8 @@ exports[`<RuleImplementationsActions /> matches the latest snapshot 1`] = `
     disabled={true}
     handleSubmit={[Function]}
   />
-  <Button
-    as="button"
-    data-tooltip="implementations.actions.download.tooltip"
-    floated="right"
-    icon="download"
+  <RuleImplementationsOptions
     loading={false}
-    onClick={[Function]}
-    secondary={true}
   />
-  <Connect(ImplementationsUploadButton) />
 </div>
 `;

package/src/components/__tests__/__snapshots__/RuleImplementationsOptions.spec.js.snap

@@ -0,0 +1,58 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleImplementationsOptions /> matches the latest loading snapshot 1`] = `
+<Dropdown
+  additionLabel="Add "
+  additionPosition="top"
+  className="button icon group-actions button-update"
+  closeOnBlur={true}
+  closeOnEscape={true}
+  deburr={false}
+  direction="left"
+  disabled={true}
+  floating={true}
+  icon="ellipsis vertical"
+  minCharacters={1}
+  noResultsMessage="No results found."
+  openOnFocus={true}
+  renderLabel={[Function]}
+  searchInput="text"
+  selectOnBlur={true}
+  selectOnNavigation={true}
+  wrapSelection={true}
+>
+  <DropdownMenu>
+    <Connect(RuleImplementationsDownload) />
+    <Connect(ImplementationsUploadButton) />
+    <Connect(RuleResultsUpload) />
+  </DropdownMenu>
+</Dropdown>
+`;
+
+exports[`<RuleImplementationsOptions /> matches the latest snapshot 1`] = `
+<Dropdown
+  additionLabel="Add "
+  additionPosition="top"
+  className="button icon group-actions button-update"
+  closeOnBlur={true}
+  closeOnEscape={true}
+  deburr={false}
+  direction="left"
+  floating={true}
+  icon="ellipsis vertical"
+  minCharacters={1}
+  noResultsMessage="No results found."
+  openOnFocus={true}
+  renderLabel={[Function]}
+  searchInput="text"
+  selectOnBlur={true}
+  selectOnNavigation={true}
+  wrapSelection={true}
+>
+  <DropdownMenu>
+    <Connect(RuleImplementationsDownload) />
+    <Connect(ImplementationsUploadButton) />
+    <Connect(RuleResultsUpload) />
+  </DropdownMenu>
+</Dropdown>
+`;

package/src/components/__tests__/__snapshots__/RuleResultsUpload.spec.js.snap

@@ -0,0 +1,18 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RuleResultsUpload /> matches the latest snapshot 1`] = `
+<UploadModal
+  content="uploadModal.actions.upload.confirmation.content"
+  handleSubmit={[Function]}
+  header="ruleResults.actions.upload.confirmation.header"
+  icon="upload"
+  param="rule_results"
+  trigger={
+    <DropdownItem
+      disabled={false}
+      icon="upload"
+      text="ruleResults.actions.upload.tooltip"
+    />
+  }
+/>
+`;

package/src/components/ruleImplementationForm/FiltersGroup.js

@@ -110,6 +110,7 @@ const Filter = ({
                 composeValue={composeValue}
                 population={clause?.population || [{}]}
                 onChange={onValueConditionChange}
+                onModifierChange={onModifierChange}
                 parentStructures={parentStructures}
                 siblings={findSiblings(clause)}
                 scope="population"

package/src/components/ruleImplementationForm/ValueConditions.js

@@ -64,6 +64,16 @@ export const ValueConditions = ({
 
   const onRowAddition = () => onChange(_.concat(population)([{}]));
 
+  const onModifierChange = (index, modifier) => {
+    const clause = _.nth(index)(population);
+    const updatedCondition = {
+      ...clause,
+      modifier,
+    };
+    const modifiedPopulation = replaceAt(index, updatedCondition)(population);
+    onChange && onChange(modifiedPopulation);
+  };
+
   return population.map((clause, index) => (
     <React.Fragment key={index}>
       <Grid.Row>
@@ -74,6 +84,7 @@ export const ValueConditions = ({
             onOperatorChange={onOperatorChange}
             onStructureChange={onStructureChange}
             onValueChange={onValueChange}
+            onModifierChange={onModifierChange}
             parentStructures={parentStructures}
             scope={scope}
             siblings={siblings}

package/src/messages/en.js

@@ -19,13 +19,14 @@ export default {
   "createRule.error.domain_id.required": "Domain is required",
   "createRuleImplementation.error.implementation_key.duplicated":
     "Duplicated implementation key",
-  "createRule.error.rule_name_bc_id.unique_constraint": "Duplicated rule name. Edit name or associated business concept.",
+  "createRule.error.rule_name_bc_id.unique_constraint":
+    "Duplicated rule name. Edit name or associated business concept.",
   "dataset.form.button.add_join.popup":
     "Select both fields to add a new clause",
   "dataset.form.button.add_structure": "Add Structure",
   "datasetForm.implementation_key.tooltip":
     "Leave empty for autogeneration of implementation key after saving implementation",
-  "executionGroup": "Executions",
+  executionGroup: "Executions",
   "executions.completed.content": "{count} executions completed.",
   "executions.completed.header": "Executions completed",
   "executions.pending.content":
@@ -53,9 +54,13 @@ export default {
   "filtersGrid.field.operator": "Operator",
   "filtersGrid.field.value": "Value",
   "implementations.actions.do_execution": "Execute implementations",
-  "implementations.actions.download.tooltip": "Download to csv",
-  "implementations.actions.execution.confirmation.content": "{implementations_count} implementations will be executed. Are you sure?",
-  "implementations.actions.execution.confirmation.header": "Implementations execution",
+  "implementations.actions.download.tooltip": "Download with csv format",
+  "implementations.actions.download.empty":
+    "There are no Implementations to be downloaded",
+  "implementations.actions.execution.confirmation.content":
+    "{implementations_count} implementations will be executed. Are you sure?",
+  "implementations.actions.execution.confirmation.header":
+    "Implementations execution",
   "implementations.actions.execution.confirmation.legend": "Template fields",
   "implementations.execute.filtered": "{count} implementations to execute",
   "implementations.search.placeholder": "Search implementations...",
@@ -118,7 +123,7 @@ export default {
   "quality_result.under_minimum": "Under threshold",
   "quality_result.under_minumum": "Under threshold",
   "quality_result.failed": "Failed",
-  "rule": "Quality Rule",
+  rule: "Quality Rule",
   "rule.date.placeholder": "YYYY-MM-DD",
   "rule.error.goal.required": "Goal required",
   "rule.error.minimum.required": "Minimun threshold required",
@@ -456,7 +461,8 @@ export default {
   "ruleImplementations.actions.edit": "Edit Implementation",
   "ruleImplementations.actions.popup.deprecated": "Deprecated Implementations",
   "ruleImplementations.actions.upload.tooltip": "Upload Implementations",
-  "ruleImplementations.actions.upload.confirmation.header": "Confirm bulk upload",
+  "ruleImplementations.actions.upload.confirmation.header":
+    "Confirm bulk upload",
   "ruleImplementations.header": "Quality Implementations",
   "ruleImplementations.props.business_concept": "Concept",
   "ruleImplementations.props.status": "Status",
@@ -492,11 +498,20 @@ export default {
   "ruleImplementations.summary.headers.implementation": "Rule Implementation",
   "ruleImplementations.summary.headers.population": "Population",
   "ruleImplementations.summary.headers.validations": "Validation",
-  "ruleImplementations.upload.success.errors": "Error in {implementation_key} attribute: {key} message: {message} ",
-  "ruleImplementations.upload.success.header": "Upload success! Loaded {count_ids} omitted {count_errors}:",
-  "ruleImplementations.upload.failed.header": "Error uploading file. No rules have been created.",
+  "ruleImplementations.upload.success.errors":
+    "Error in {implementation_key} attribute: {key} message: {message} ",
+  "ruleImplementations.upload.success.header":
+    "Upload success! Loaded {count_ids} omitted {count_errors}:",
+  "ruleImplementations.upload.failed.header":
+    "Error uploading file. No rules have been created.",
   "ruleImplementations.upload.failed.misssing_required_columns":
     "Faltan columnas obligatorias en el fichero. Esperado [{expected}]. Recibido [{found}].",
+  "ruleResults.actions.upload.tooltip": "Upload rule results",
+  "ruleResults.actions.upload.confirmation.header": "Upload rule results",
+  "ruleResults.upload.success.header": "Upload successful!",
+  "ruleResults.upload.failed.header":
+    "Error uploading file. No results have been created.",
+  "ruleResults.upload.failed.content": "Error in line {row}.",
   "ruleResult.props.header.information": "Information",
   "ruleResult.props.header.details": "Details",
   "ruleResult.props.date": "Date",
@@ -519,9 +534,12 @@ export default {
   "rules.retrieved.results": "{count} rules found",
   "rules.search.placeholder": "Search rules...",
   "rules.searching": "Searching...",
-  "rules.upload.success.errors": "Error in {rule_name} attribute: {key} message: {message} ",
-  "rules.upload.success.header": "Upload success! Loaded {count_ids} omitted {count_errors}:",
-  "rules.upload.failed.header": "Error uploading file. No rules have been created.",
+  "rules.upload.success.errors":
+    "Error in {rule_name} attribute: {key} message: {message} ",
+  "rules.upload.success.header":
+    "Upload successful! Loaded {count_ids} omitted {count_errors}:",
+  "rules.upload.failed.header":
+    "Error uploading file. No rules have been created.",
   "rules.upload.failed.misssing_required_columns":
     "Missing required columns. Expected [{expected}]. Found [{found}].",
   "structureFields.dropdown.label": "Select Field",

package/src/messages/es.js

@@ -19,13 +19,14 @@ export default {
   "createRule.error.domain_id.required": "Dominio es requerido",
   "createRuleImplementation.error.implementation_key.duplicated":
     "Identificador duplicado",
-  "createRule.error.rule_name_bc_id.unique_constraint": "La regla ya existe con ese nombre o concepto asociado",
+  "createRule.error.rule_name_bc_id.unique_constraint":
+    "La regla ya existe con ese nombre o concepto asociado",
   "dataset.form.button.add_join.popup":
     "Seleccionar ambos campos para añadir una nueva cláusula",
   "dataset.form.button.add_structure": "Añadir Estructura",
   "datasetForm.implementation_key.tooltip":
     "En caso de no introducir clave de implementación, se autogenerará al guardar la implementación",
-  "executionGroup": "Ejecuciones",
+  executionGroup: "Ejecuciones",
   "executions.completed.content": "Se han ejecutado {count} implementaciones.",
   "executions.completed.header": "Ejecuciones finalizadas",
   "executions.pending.content":
@@ -53,10 +54,15 @@ export default {
   "filtersGrid.field.operator": "Operador",
   "filtersGrid.field.value": "Valor",
   "implementations.actions.do_execution": "Ejecutar implementaciones",
-  "implementations.actions.download.tooltip": "Descargar en csv",
-  "implementations.actions.execution.confirmation.content": "Se va a solicitar la ejecución de {implementations_count} implementaciones. ¿Estás seguro?",
-  "implementations.actions.execution.confirmation.header": "Solicitar ejecución de implementaciones",
-  "implementations.actions.execution.confirmation.legend": "Campos de la plantilla",
+  "implementations.actions.download.tooltip": "Descargar en formato csv",
+  "implementations.actions.download.empty":
+    "No hay implementaciones para descargar",
+  "implementations.actions.execution.confirmation.content":
+    "Se va a solicitar la ejecución de {implementations_count} implementaciones. ¿Estás seguro?",
+  "implementations.actions.execution.confirmation.header":
+    "Solicitar ejecución de implementaciones",
+  "implementations.actions.execution.confirmation.legend":
+    "Campos de la plantilla",
   "implementations.execute.filtered": "{count} implementaciones a ejecutar",
   "implementations.search.placeholder": "Buscar implementaciones...",
   "navigation.quality.rules": "Reglas",
@@ -214,7 +220,7 @@ export default {
   "rule.type.numeric_format": "Tiene formato numérico",
   "rule.type.unique_values": "Tiene valores únicos",
   "rule.values_list": "Valores de la lista",
-  "rule": "Regla de Calidad",
+  rule: "Regla de Calidad",
   "ruleImplementation.action.deprecate": "archivada",
   "ruleImplementation.actions.clone": "Clonar implementación",
   "ruleImplementation.actions.delete.confirmation.content":
@@ -235,7 +241,8 @@ export default {
     "Restaurar Implementación",
   "ruleImplementation.actions.restore": "Restaurar Implementación",
   "ruleImplementations.actions.upload.tooltip": "Subir Implementaciones",
-  "ruleImplementations.actions.upload.confirmation.header": "Subir ficheros de implementaciones",
+  "ruleImplementations.actions.upload.confirmation.header":
+    "Subir ficheros de implementaciones",
   "ruleImplementation.column.placeholder": "Seleccionar columna",
   "ruleImplementation.column": "Columna",
   "ruleImplementation.delete.folder": '"Eliminado"',
@@ -509,13 +516,21 @@ export default {
     "Implementación de una Regla",
   "ruleImplementations.summary.headers.population": "Población",
   "ruleImplementations.summary.headers.validations": "Validaciones",
-  "ruleImplementations.upload.success.errors": "Error en {name} atributo: {key} mensaje: {message} ",
-  "ruleImplementations.upload.success.header": "¡Fichero subido correctamente! subidos {count_ids} errores {count_errors}:",
-  "ruleImplementations.upload.failed.header": "Error al subir el fichero. No se ha realizado ninguna inserción.",
+  "ruleImplementations.upload.success.errors":
+    "Error en {name} atributo: {key} mensaje: {message} ",
+  "ruleImplementations.upload.success.header":
+    "¡Fichero subido correctamente! subidos {count_ids} errores {count_errors}:",
+  "ruleImplementations.upload.failed.header":
+    "Error al subir el fichero. No se ha realizado ninguna inserción.",
   "ruleImplementations.upload.failed.misssing_required_columns":
     "Faltan columnas obligatorias en el fichero. Esperado [{expected}]. Recibido [{found}].",
-
-
+  "ruleResults.actions.upload.tooltip": "Subir resultados",
+  "ruleResults.actions.upload.confirmation.header":
+    "Subir resultados de implementaciones",
+  "ruleResults.upload.success.header": "¡Fichero subido correctamente!",
+  "ruleResults.upload.failed.header":
+    "Error al subir fichero. No se ha realizado ninguna inserción.",
+  "ruleResults.upload.failed.content": "Error en la línea {row}.",
   "ruleResult.props.date": "Fecha",
   "ruleResult.props.details": "Detalles",
   "ruleResult.props.errors": "Errores",
@@ -534,9 +549,12 @@ export default {
   "rules.retrieved.results": "{count} reglas encontradas",
   "rules.search.placeholder": "Buscar reglas...",
   "rules.searching": "Buscando...",
-  "rules.upload.success.errors": "Error en {rule_name} atributo: {key} mensaje: {message} ",
-  "rules.upload.success.header": "¡Fichero subido correctamente! subidos {count_ids} errores {count_errors}:",
-  "rules.upload.failed.header": "Error al subir el fichero. No se ha realizado ninguna inserción.",
+  "rules.upload.success.errors":
+    "Error en {rule_name} atributo: {key} mensaje: {message} ",
+  "rules.upload.success.header":
+    "¡Fichero subido correctamente! subidos {count_ids} errores {count_errors}:",
+  "rules.upload.failed.header":
+    "Error al subir el fichero. No se ha realizado ninguna inserción.",
   "rules.upload.failed.misssing_required_columns":
     "Faltan columnas obligatorias en el fichero. Esperado [{expected}]. Recibido [{found}].",
   "ruleSubscription.actions.remove": "Eliminar",

package/src/reducers/__tests__/uploadingResults.spec.js

@@ -0,0 +1,28 @@
+import { uploadResults } from "../../routines";
+import { uploadingResults } from "..";
+
+const fooState = { foo: "bar" };
+
+const initialState = false;
+
+describe("reducers: previousRuleImplementationQuery", () => {
+  it("should provide the initial state", () => {
+    expect(uploadingResults(undefined, {})).toEqual(initialState);
+  });
+
+  it("should handle the uploadResults.TRIGGER action", () => {
+    expect(
+      uploadingResults(fooState, {
+        type: uploadResults.TRIGGER,
+      })
+    ).toBeTruthy();
+  });
+
+  it("should handle the uploadResults.FULFILL action", () => {
+    expect(
+      uploadingResults(fooState, {
+        type: uploadResults.FULFILL,
+      })
+    ).toBeFalsy();
+  });
+});

package/src/reducers/dqMessage.js

@@ -1,6 +1,6 @@
 import _ from "lodash/fp";
 import { dismissAlert } from "@truedat/core/routines";
-import { uploadRules, uploadImplementations } from "../routines";
+import { uploadRules, uploadImplementations, uploadResults } from "../routines";
 
 const initialState = {};
 
@@ -95,6 +95,27 @@ const dqMessage = (state = initialState, { type, payload }) => {
       } else {
         return null;
       }
+    case uploadResults.SUCCESS:
+      return {
+        error: false,
+        header: "ruleResults.upload.success.header",
+        icon: "check",
+        color: "green",
+        text: "",
+      };
+    case uploadResults.FAILURE:
+      if (payload.status != 500) {
+        return {
+          error: true,
+          header: "ruleResults.upload.failed.header",
+          content: `ruleResults.upload.failed.content`,
+          icon: "attention",
+          text: "",
+          fields: { row: _.path("data.row")(payload) },
+        };
+      } else {
+        return null;
+      }
 
     default:
       return state;

package/src/reducers/index.js

@@ -42,6 +42,7 @@ import { uploadRulesFile } from "./uploadRulesFile";
 import { userRulePermissions } from "./userRulePermissions";
 import { userRulesPermissions } from "./userRulesPermissions";
 import { userImplementationsPermissions } from "./userImplementationsPermissions";
+import { uploadingResults } from "./uploadingResults";
 
 export {
   conceptRules,
@@ -88,4 +89,5 @@ export {
   userRulePermissions,
   userRulesPermissions,
   userImplementationsPermissions,
+  uploadingResults,
 };

package/src/reducers/uploadingResults.js

@@ -0,0 +1,16 @@
+import { uploadResults } from "../routines";
+
+const initialState = false;
+
+export const uploadingResults = (state = initialState, { type }) => {
+  switch (type) {
+    case uploadResults.TRIGGER:
+      return true;
+    case uploadResults.FULFILL:
+      return false;
+    default:
+      return state;
+  }
+};
+
+export default uploadingResults;

package/src/routines.js

@@ -89,6 +89,7 @@ export const openImplementationFilter = createRoutine(
 export const downloadImplementations = createRoutine(
   "DOWNLOAD_IMPLEMENTATIONS"
 );
+export const uploadResults = createRoutine("UPLOAD_RESULTS");
 export const createExecutionGroup = createRoutine("CREATE_EXECUTION_GROUP");
 export const fetchExecutionGroup = createRoutine("FETCH_EXECUTION_GROUP");
 export const clearExecutionGroup = createRoutine("CLEAR_EXECUTION_GROUP");

package/src/sagas/__tests__/uploadResults.spec.js

@@ -0,0 +1,65 @@
+import { testSaga } from "redux-saga-test-plan";
+import { apiJsonPost, UPLOAD_JSON_OPTS } from "@truedat/core/services/api";
+import { uploadResultsRequestSaga, uploadResultsSaga } from "../uploadResults";
+import { uploadResults } from "../../routines";
+import { API_RULE_RESULTS } from "../../api";
+
+describe("sagas: uploadResultsRequestSaga", () => {
+  it("should invoke uploadResultsSaga on trigger", () => {
+    expect(() => {
+      testSaga(uploadResultsRequestSaga)
+        .next()
+        .takeLatest(uploadResults.TRIGGER, uploadResultsSaga)
+        .finish()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should throw exception if an unhandled action is received", () => {
+    expect(() => {
+      testSaga(uploadResultsRequestSaga)
+        .next()
+        .takeLatest("FOO", uploadResultsSaga);
+    }).toThrow();
+  });
+});
+
+describe("sagas: uploadResultsSaga", () => {
+  const body = { rule_results: "content" };
+  const payload = { data: body };
+  const data = { message: [1, 2] };
+  it("should put a success action when a response is returned", () => {
+    expect(() => {
+      testSaga(uploadResultsSaga, { payload })
+        .next()
+        .put(uploadResults.request())
+        .next()
+        .call(apiJsonPost, API_RULE_RESULTS, body, UPLOAD_JSON_OPTS)
+        .next({ data })
+        .put(uploadResults.success(data))
+        .next()
+        .put(uploadResults.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should put a failure action when the call returns an error", () => {
+    const message = "Request failed";
+    const error = { message };
+
+    expect(() => {
+      testSaga(uploadResultsSaga, { payload })
+        .next()
+        .put(uploadResults.request())
+        .next()
+        .call(apiJsonPost, API_RULE_RESULTS, body, UPLOAD_JSON_OPTS)
+        .throw(error)
+        .put(uploadResults.failure(message))
+        .next()
+        .put(uploadResults.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+});

package/src/sagas/index.js

@@ -18,6 +18,7 @@ import { uploadImplementationsRequestsSaga } from "./uploadImplementations";
 import { uploadRulesRequestsSaga } from "./uploadRules";
 import { updateRuleImplementationRequestSaga } from "./updateRuleImplementation";
 import { updateRuleRequestSaga } from "./updateRule";
+import { uploadResultsRequestSaga } from "./uploadResults";
 
 export {
   createExecutionGroupRequestSaga,
@@ -40,6 +41,7 @@ export {
   uploadImplementationsRequestsSaga,
   updateRuleImplementationRequestSaga,
   updateRuleRequestSaga,
+  uploadResultsRequestSaga,
 };
 
 export default [
@@ -63,4 +65,5 @@ export default [
   uploadImplementationsRequestsSaga(),
   updateRuleImplementationRequestSaga(),
   updateRuleRequestSaga(),
+  uploadResultsRequestSaga(),
 ];

package/src/sagas/uploadResults.js

@@ -0,0 +1,32 @@
+import { call, put, takeLatest } from "redux-saga/effects";
+import { apiJsonPost, UPLOAD_JSON_OPTS } from "@truedat/core/services/api";
+import { uploadResults } from "../routines";
+import { API_RULE_RESULTS } from "../api";
+
+export function* uploadResultsSaga({ payload }) {
+  try {
+    const { data: body } = payload;
+    yield put(uploadResults.request());
+    const { data } = yield call(
+      apiJsonPost,
+      API_RULE_RESULTS,
+      body,
+      UPLOAD_JSON_OPTS
+    );
+
+    yield put(uploadResults.success(data));
+  } catch (error) {
+    if (error.response) {
+      const { status, data } = error.response;
+      yield put(uploadResults.failure({ status, data }));
+    } else {
+      yield put(uploadResults.failure(error.message));
+    }
+  } finally {
+    yield put(uploadResults.fulfill());
+  }
+}
+
+export function* uploadResultsRequestSaga() {
+  yield takeLatest(uploadResults.TRIGGER, uploadResultsSaga);
+}