@truedat/df 8.12.1 → 8.12.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/df",
-  "version": "8.12.1",
+  "version": "8.12.4",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "module": "src/index.js",
@@ -54,14 +54,14 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.12.1",
+    "@truedat/test": "8.12.4",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
   },
   "dependencies": {
     "@apollo/client": "^3.13.8",
-    "@truedat/core": "8.12.1",
+    "@truedat/core": "8.12.4",
     "axios": "^1.15.0",
     "graphql": "^16.11.0",
     "is-hotkey": "^0.2.0",
@@ -90,5 +90,5 @@
     "semantic-ui-react": "^3.0.0-beta.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "db02aab92701c55a73d5a5b469a7114f9c3a596e"
+  "gitHead": "d5bc1af84c4d828bdec676b0da58385cf0d6015f"
 }

package/src/components/__tests__/SelectableDynamicForm.spec.js

@@ -119,6 +119,23 @@ describe("<SelectableDynamicForm />", () => {
       await waitForLoad(rendered);
       expect(rendered.container).toMatchSnapshot();
     });
+
+    it("does not auto-select a template when none is default", async () => {
+      const onNameChange = jest.fn();
+      const thisProps = {
+        ...props,
+        onNameChange,
+      };
+      const rendered = render(
+        <SelectableDynamicForm {...thisProps} />,
+        renderOpts,
+      );
+      await waitForLoad(rendered);
+      expect(onNameChange).not.toHaveBeenCalled();
+      expect(rendered.getByRole("alert")).toHaveTextContent(
+        /template\.selector\.placeholder/i,
+      );
+    });
   });
 
   describe("with single template", () => {
@@ -201,6 +218,7 @@ describe("<SelectableDynamicForm />", () => {
           disableSelector
           selectedTemplate={selectedTemplate}
         />,
+        { mocks: [multipleTemplatesMock(variables)] },
       );
       await waitForLoad(rendered);
       expect(
@@ -218,6 +236,7 @@ describe("<SelectableDynamicForm />", () => {
           disableSelector
           selectedTemplate={selectedTemplate}
         />,
+        { mocks: [multipleTemplatesMock(variables)] },
       );
       await waitForLoad(rendered);
       expect(rendered.container).toMatchSnapshot();

package/src/components/widgets/TextField.js

@@ -2,7 +2,7 @@ import PropTypes from "prop-types";
 import { Form } from "semantic-ui-react";
 
 export const TextField = ({ field: { name, value }, onChange }) => (
-  <Form.TextArea value={value} name={name} onChange={onChange} />
+  <Form.TextArea value={value ?? ""} name={name} onChange={onChange} />
 );
 
 TextField.propTypes = {

package/src/selectors/getOptions.js

@@ -12,9 +12,13 @@ const transformValues = (systems) =>
   )(systems);
 
 export const getDropdownOptions = createSelector(
-  ({ systems }, { field }) =>
-    field?.type === "system" ? transformValues(systems) : field?.parsedValues,
-  _.sortBy("text"),
+  ({ systems }) => systems,
+  (_, { field }) => field?.type,
+  (_, { field }) => field?.parsedValues,
+  (systems, type, parsedValues) =>
+    _.sortBy("text")(
+      type === "system" ? transformValues(systems) : parsedValues,
+    ),
 );
 
 export const makeGetDropdownOptions = () => getDropdownOptions;

package/src/templates/components/TemplatesContext.js

@@ -14,9 +14,8 @@ export default function TemplatesContextProvider(props) {
   const initialSortColumn = _.prop("initialSortColumn")(props);
   const initialSortDirection = _.prop("initialSortDirection")(props);
 
-  const { templates, templatesLoading: loading } = useSelector(
-    _.pick(["templates", "templatesLoading"]),
-  );
+  const templates = useSelector((state) => state.templates);
+  const loading = useSelector((state) => state.templatesLoading);
 
   const [query, setQuery] = useState("");
   const [scope, setScope] = useState();

package/src/templates/components/templateForm/DefaultValue.js

@@ -7,12 +7,8 @@ import DateField from "../../../components/widgets/DateField";
 
 const defaultValueFormat = (d) => (_.isArray(d) ? _.first(d) : d);
 const multipleDefaultValueFormat = (d) => {
-  switch (d) {
-    case "":
-      return [];
-    default:
-      return !_.isArray(d) ? [d] : d;
-  }
+  if (d === "" || _.isNil(d)) return [];
+  return !_.isArray(d) ? [d] : d;
 };
 
 export const DefaultValue = ({

package/src/templates/components/templateForm/TableValuesForm.js

@@ -116,7 +116,7 @@ export const TableValuesForm = ({
 }) => {
   const fieldCount = _.size(values);
   const [activeField, setActiveField] = useState();
-  const [fieldValue, setFieldValue] = useState();
+  const [fieldValue, setFieldValue] = useState("");
   const { formatMessage } = useIntl();
 
   const swap = (targetKey, sourceKey) => {