@truedat/dd 8.7.5 → 8.8.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "8.7.5",
+  "version": "8.8.0",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "module": "src/index.js",
@@ -51,7 +51,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.7.5",
+    "@truedat/test": "8.8.0",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -86,5 +86,5 @@
     "svg-pan-zoom": "^3.6.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "c6330f05c6d7eb7b601ff861385deedb257efc3d"
+  "gitHead": "006b9cd6486cd37976d4dc06ede1a48e37175f30"
 }

package/src/components/StructureTabPane.js

@@ -106,8 +106,10 @@ export const StructureTabPane = ({ path }) => {
       {activeTab === "metadata" && tabVisibility.metadata && (
         <StructureMetadata />
       )}
-      {activeTab === "lineage" && <StructureLineage />}
-      {activeTab === "impact" && <StructureImpact />}
+      {activeTab === "lineage" && tabVisibility?.lineage && (
+        <StructureLineage />
+      )}
+      {activeTab === "impact" && tabVisibility?.impact && <StructureImpact />}
       {<CustomTab tabs={customTabs} activeTab={activeTab} />}
     </ErrorBoundary>
   );

package/src/components/__tests__/__snapshots__/StructureTabPane.spec.js.snap

@@ -40,21 +40,9 @@ exports[`<StructureTabPane /> renders correctly with grants tab 1`] = `
 </div>
 `;
 
-exports[`<StructureTabPane /> renders correctly with impact tab 1`] = `
-<div>
-  <div>
-    StructureImpact
-  </div>
-</div>
-`;
+exports[`<StructureTabPane /> renders correctly with impact tab 1`] = `<div />`;
 
-exports[`<StructureTabPane /> renders correctly with lineage tab 1`] = `
-<div>
-  <div>
-    StructureLineage
-  </div>
-</div>
-`;
+exports[`<StructureTabPane /> renders correctly with lineage tab 1`] = `<div />`;
 
 exports[`<StructureTabPane /> renders correctly with links tab 1`] = `
 <div>

package/src/selectors/__tests__/getTabVisibility.spec.js

@@ -14,21 +14,45 @@ describe("selectors: getTabVisibility", () => {
     });
   });
 
-  it("should include lineage iff structure has in degree", () => {
+  it("should include lineage iff structure has in degree and user has view_lineage permission", () => {
     expect(
-      getTabVisibility({ structure: { degree: { in: 1 } } }),
+      getTabVisibility({
+        structure: { degree: { in: 1 } },
+        userPermissions: { view_lineage: true },
+      }),
     ).toMatchObject({ lineage: true });
     expect(
-      getTabVisibility({ structure: { degree: { in: 0 } } }),
+      getTabVisibility({
+        structure: { degree: { in: 0 } },
+        userPermissions: { view_lineage: true },
+      }),
+    ).toMatchObject({ lineage: false });
+    expect(
+      getTabVisibility({
+        structure: { degree: { in: 1 } },
+        userPermissions: { view_lineage: false },
+      }),
     ).toMatchObject({ lineage: false });
   });
 
-  it("should include impact iff structure has out degree", () => {
+  it("should include impact iff structure has out degree and user has view_lineage permission", () => {
     expect(
-      getTabVisibility({ structure: { degree: { out: 1 } } }),
+      getTabVisibility({
+        structure: { degree: { out: 1 } },
+        userPermissions: { view_lineage: true },
+      }),
     ).toMatchObject({ impact: true });
     expect(
-      getTabVisibility({ structure: { degree: { out: 0 } } }),
+      getTabVisibility({
+        structure: { degree: { out: 0 } },
+        userPermissions: { view_lineage: true },
+      }),
+    ).toMatchObject({ impact: false });
+    expect(
+      getTabVisibility({
+        structure: { degree: { out: 1 } },
+        userPermissions: { view_lineage: false },
+      }),
     ).toMatchObject({ impact: false });
   });
 
@@ -249,4 +273,60 @@ describe("selectors: getTabVisibility", () => {
       }),
     ).toMatchObject({ roles: true });
   });
+
+  describe("acceptance criteria: lineage and impact tab visibility", () => {
+    it("1a: without permission + with data -> tabs hidden", () => {
+      expect(
+        getTabVisibility({
+          structure: { degree: { in: 1, out: 1 } },
+          userPermissions: { view_lineage: false },
+        }),
+      ).toMatchObject({ lineage: false, impact: false });
+    });
+
+    it("1b: without permission + without data -> tabs hidden", () => {
+      expect(
+        getTabVisibility({
+          structure: { degree: { in: 0, out: 0 } },
+          userPermissions: { view_lineage: false },
+        }),
+      ).toMatchObject({ lineage: false, impact: false });
+    });
+
+    it("2a: with permission in dom A + data in dom A -> tabs visible", () => {
+      expect(
+        getTabVisibility({
+          structure: { degree: { in: 1, out: 1 } },
+          userPermissions: { view_lineage: true },
+        }),
+      ).toMatchObject({ lineage: true, impact: true });
+    });
+
+    it("2c: with permission in dom A + without data in dom A -> tabs hidden", () => {
+      expect(
+        getTabVisibility({
+          structure: { degree: { in: 0, out: 0 } },
+          userPermissions: { view_lineage: true },
+        }),
+      ).toMatchObject({ lineage: false, impact: false });
+    });
+
+    it("2e: with permission in dom A and B + data -> tabs visible", () => {
+      expect(
+        getTabVisibility({
+          structure: { degree: { in: 1, out: 1 } },
+          userPermissions: { view_lineage: true },
+        }),
+      ).toMatchObject({ lineage: true, impact: true });
+    });
+
+    it("2f: with permission in dom A and B + without data -> tabs hidden", () => {
+      expect(
+        getTabVisibility({
+          structure: { degree: { in: 0, out: 0 } },
+          userPermissions: { view_lineage: true },
+        }),
+      ).toMatchObject({ lineage: false, impact: false });
+    });
+  });
 });

package/src/selectors/getTabVisibility.js

@@ -50,9 +50,13 @@ const rulesTabVisible = (state) =>
   state?.structure?.implementation_count > 0 &&
   state?.userPermissions?.view_quality;
 
-const lineageTabVisible = _.anyPass([_.path("structure.degree.in")]);
+const lineageTabVisible = (state) =>
+  state?.userPermissions?.view_lineage &&
+  _.anyPass([_.path("structure.degree.in")])(state);
 
-const impactTabVisible = _.anyPass([_.path("structure.degree.out")]);
+const impactTabVisible = (state) =>
+  state?.userPermissions?.view_lineage &&
+  _.anyPass([_.path("structure.degree.out")])(state);
 
 const parentsTabVisible = _.conformsTo({ parentRelations: notEmpty });