@truedat/dd 8.7.1 → 8.7.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "8.7.1",
+  "version": "8.7.2",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "module": "src/index.js",
@@ -51,7 +51,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.7.1",
+    "@truedat/test": "8.7.2",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -86,5 +86,5 @@
     "svg-pan-zoom": "^3.6.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "f7605a6ea3f78839b42bb7d8339eec125ba49acb"
+  "gitHead": "e971cd8773dc15ad949f260abbfe4d3236473af7"
 }

package/src/api/queries.js

@@ -515,6 +515,7 @@ export const buildDSVQuery = (loadStructureMetadata) => gql`
         }
         external_id
         id
+        links_count
         inserted_at
         latest_note
         roles

package/src/reducers/structure.js

@@ -13,6 +13,7 @@ const structureFields = (fn) =>
       "domains",
       "external_id",
       "id",
+      "links_count",
       "roles",
       "inserted_at",
       "updated_at",

package/src/selectors/__tests__/getTabVisibility.spec.js

@@ -68,27 +68,28 @@ describe("selectors: getTabVisibility", () => {
     ).toMatchObject({ profile: true });
   });
 
-  it("should include links iff structure has links", () => {
+  it("should include links tab if user has create_link permission", () => {
     expect(
-      getTabVisibility({ structureLinks: [{ resource_type: "concept" }] }),
+      getTabVisibility({ structureActions: { create_link: {} } }),
     ).toMatchObject({
       links: true,
     });
-    expect(
-      getTabVisibility({ structureLinks: [{ resource_type: "foo" }] }),
-    ).toMatchObject({
-      links: false,
-    });
-    expect(
-      getTabVisibility({
-        structureLinks: [{ resource_type: "foo" }],
-        structureActions: { create_link: {} },
-      }),
-    ).toMatchObject({
+  });
+
+  it("should include links tab if structure has links_count > 0", () => {
+    expect(getTabVisibility({ structure: { links_count: 2 } })).toMatchObject({
       links: true,
     });
   });
 
+  it("should not include links tab if no permission and no links", () => {
+    expect(getTabVisibility({})).toMatchObject({ links: false });
+    expect(getTabVisibility({ structure: {} })).toMatchObject({ links: false });
+    expect(getTabVisibility({ structure: { links_count: 0 } })).toMatchObject({
+      links: false,
+    });
+  });
+
   it("should include notes if template_id is in structure_note", () => {
     const structure = { type: "foo", structure_type: { template_id: 1 } };
     const templates = [{ name: "foo", id: 1 }];

package/src/selectors/getTabVisibility.js

@@ -19,10 +19,9 @@ const profileTabVisible = ({
     notEmpty(structureProfile?.patterns));
 
 const linksTabVisible = (state) => {
-  const structureLinks = getStructureToConceptLinks(state);
-  return (
-    _.has("create_link", state?.structureActions) || !_.isEmpty(structureLinks)
-  );
+  const hasPermission = _.has("create_link", state?.structureActions);
+  const hasLinks = (state?.structure?.links_count || 0) > 0;
+  return hasPermission || hasLinks;
 };
 
 const notesTabVisible = ({ templatesLoading, templates, structure }) =>