@truedat/dd 8.4.8 → 8.4.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "8.4.8",
+  "version": "8.4.9",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "module": "src/index.js",
@@ -51,7 +51,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.4.8",
+    "@truedat/test": "8.4.9",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -86,5 +86,5 @@
     "svg-pan-zoom": "^3.6.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "7829e377f78c3cfc66e449f5dc31a8b03c0f5f00"
+  "gitHead": "9fd4bd2126a33342009194c8ae1829cd3c617a48"
 }

package/src/messages/en.js

@@ -397,7 +397,11 @@ export default {
   "structure.rule.props.name": "Name",
   "structure.rule_implementation.props.key": "Implementation",
   "structure.rule_implementation.props.result": "Quality",
+  "structure.reason": "Reason",
   "structure.search.placeholder": "Enter a search...",
+  "structure.similarity": "Similarity",
+  "suggestions.similarity.cosine.popup":
+    "Similarity score (cosine). Higher values indicate a closer match.",
   "structure.share.title": "Share structure",
   "structure.system": "System",
   "structure.system.create": "Create system",

package/src/messages/es.js

@@ -407,7 +407,11 @@ export default {
   "structure.rule.props.name": "Nombre",
   "structure.rule_implementation.props.key": "Implementación",
   "structure.rule_implementation.props.result": "Calidad",
+  "structure.reason": "Motivo",
   "structure.search.placeholder": "Introduce una busqueda...",
+  "structure.similarity": "Similitud",
+  "suggestions.similarity.cosine.popup":
+    "Puntuación de similitud (coseno). Valores más altos indican mayor coincidencia.",
   "structure.share.title": "Compartir estructura",
   "structure.system": "Sistema",
   "structure.system.create": "Crear sistema",

package/src/components/StructureSuggestions.js

@@ -1,88 +0,0 @@
-import _ from "lodash/fp";
-import React, { useEffect } from "react";
-import { Popup } from "semantic-ui-react";
-import { useIntl } from "react-intl";
-import { useParams } from "react-router";
-import { useSelector } from "react-redux";
-import PropTypes from "prop-types";
-import { useDataStructureSuggestions } from "../hooks/useStructures";
-import { defaultColumnsForStructureSelector } from "../selectors";
-import StructuresSearchResults from "./StructuresSearchResults";
-
-const SimilarityColumn = (similarity) => {
-  const { formatMessage } = useIntl();
-  return (
-    <Popup
-      content={formatMessage({ id: "suggestions.similarity.cosine.popup" })}
-      trigger={<span>{similarity.toFixed(3)}</span>}
-    />
-  );
-};
-
-const similarityColumnDefinition = {
-  name: "similarity",
-  fieldSelector: _.prop("similarity"),
-  fieldDecorator: SimilarityColumn,
-  width: 1,
-};
-const suggestionColumns = (state) =>
-  _.concat(defaultColumnsForStructureSelector(state))([
-    similarityColumnDefinition,
-  ]);
-
-export const StructureSuggestions = ({
-  selectedStructure,
-  handleSelectedStructure,
-  selectable,
-}) => {
-  const { business_concept_id: id, id: version } = useParams();
-  const { conceptLinks, columns } = useSelector((state) => ({
-    conceptLinks: state.conceptLinks,
-    columns: suggestionColumns(state),
-  }));
-
-  const {
-    trigger: fetchSuggestions,
-    data,
-    isMutating,
-  } = useDataStructureSuggestions();
-
-  useEffect(() => {
-    if (id && version && conceptLinks) {
-      fetchSuggestions({
-        resource: {
-          id,
-          version,
-          type: "concepts",
-          links: _.filter(
-            ({ resource_type }) => resource_type == "data_structure"
-          )(conceptLinks),
-        },
-      });
-    }
-  }, [id, version, conceptLinks]);
-
-  const structures = data?.data?.data || [];
-
-  return (
-    <StructuresSearchResults
-      loading={isMutating}
-      columns={columns}
-      size="small"
-      structures={structures}
-      selectedStructure={selectedStructure}
-      onSelect={handleSelectedStructure}
-      labelResults={false}
-      pagination={false}
-      selectable={selectable}
-    />
-  );
-};
-
-StructureSuggestions.propTypes = {
-  handleSelectedStructure: PropTypes.func,
-  selectedStructure: PropTypes.object,
-  selectable: PropTypes.bool,
-};
-
-export default StructureSuggestions;

package/src/components/__tests__/StructureSuggestions.spec.js

@@ -1,93 +0,0 @@
-import React from "react";
-import { render, screen } from "@testing-library/react";
-import { useSelector } from "react-redux";
-import { useParams } from "react-router";
-import { useDataStructureSuggestions } from "../../hooks/useStructures";
-import StructureSuggestions from "../StructureSuggestions";
-import StructuresSearchResults from "../StructuresSearchResults";
-import * as selectors from "../../selectors";
-
-jest.mock("react-router", () => ({
-    useParams: jest.fn(),
-}));
-
-jest.mock("react-redux", () => ({
-    useSelector: jest.fn(),
-}));
-
-jest.mock("../../hooks/useStructures", () => ({
-    useDataStructureSuggestions: jest.fn(),
-}));
-
-jest.mock("../StructuresSearchResults", () => jest.fn(() => <div>MockSearchResults</div>));
-
-jest.mock("../../selectors", () => ({
-    defaultColumnsForStructureSelector: jest.fn(),
-}));
-
-describe("StructureSuggestions", () => {
-    const mockFetchSuggestions = jest.fn();
-
-    beforeEach(() => {
-        jest.clearAllMocks();
-
-        selectors.defaultColumnsForStructureSelector.mockReturnValue([
-            { name: "name", fieldSelector: (x) => x.name },
-        ]);
-
-        useParams.mockReturnValue({ business_concept_id: "123", id: "456" });
-
-        useSelector.mockImplementation((selectorFn) =>
-            selectorFn({
-                conceptLinks: [
-                    { resource_type: "data_structure", id: "ds1" },
-                    { resource_type: "other", id: "not-ds" },
-                ],
-                // mock of defaultColumnsForStructureSelector + similarity column
-                columns: [
-                    { name: "name", fieldSelector: (x) => x.name },
-                    { name: "similarity", fieldSelector: (x) => x.similarity },
-                ],
-            })
-        );
-
-        useDataStructureSuggestions.mockReturnValue({
-            trigger: mockFetchSuggestions,
-            data: {
-                data: {
-                    data: [
-                        { id: "structure1", similarity: 0.89 },
-                        { id: "structure2", similarity: 0.77 },
-                    ],
-                },
-            },
-            isMutating: false,
-        });
-    });
-
-    it("calls fetchSuggestions on mount with correct parameters", () => {
-        render(<StructureSuggestions selectedStructure={null} handleSelectedStructure={jest.fn()} selectable={true} />);
-
-        expect(mockFetchSuggestions).toHaveBeenCalledWith({
-            resource: {
-                id: "123",
-                version: "456",
-                type: "concepts",
-                links: [{ resource_type: "data_structure", id: "ds1" }],
-            },
-        });
-    });
-
-    it("renders StructuresSearchResults with props", () => {
-        render(<StructureSuggestions selectedStructure={{}} handleSelectedStructure={jest.fn()} selectable={false} />);
-
-        expect(screen.getByText("MockSearchResults")).toBeInTheDocument();
-        const props = StructuresSearchResults.mock.calls[0][0];
-        expect(props.structures).toEqual([
-            { id: "structure1", similarity: 0.89 },
-            { id: "structure2", similarity: 0.77 },
-        ]);
-        expect(props.loading).toBe(false);
-        expect(props.selectable).toBe(false);
-    });
-});