@truedat/dd 8.3.0 → 8.3.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "8.3.0",
+  "version": "8.3.1",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "module": "src/index.js",
@@ -48,7 +48,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.3.0",
+    "@truedat/test": "8.3.1",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -83,5 +83,5 @@
     "svg-pan-zoom": "^3.6.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "d1abe685a3ae0cd2999e7bb62d3c0fd56522095f"
+  "gitHead": "59c8197b9eab936607c7d205ac25a378e6dd073e"
 }

package/src/messages/en.js

@@ -514,6 +514,14 @@ export default {
     "External id: {externalId} The field <{field}> does not have a permitted value",
   "structures.bulkUpdateStructures.failed.note.df_content.required":
     "External id: {externalId} The field <{field}> is required",
+  "structures.bulkUpdateStructures.failed.note.content_unchanged":
+    "Content unchanged for external id {externalId}",
+  "structures.bulkUpdateStructures.failed.note.invalid_transition":
+    "Invalid note transition for external id {externalId}",
+  "structures.bulkUpdateStructures.failed.note.conflict":
+    "Note conflict for external id {externalId}",
+  "structures.bulkUpdateStructures.failed.note.only_draft_are_editable":
+    "The note for external id {externalId} must be in draft status to be edited",
   "structures.bulkUpdateStructures.no.structures.body":
     "No structures selected",
   "structures.bulkUpdateStructures.no.structures.header": "Empty Search",
@@ -635,6 +643,12 @@ export default {
     "Insufficient permissions to edit the structure in row {row}",
   "structures.uploadStructures.failed.note.only_draft_are_editable":
     "The note in row {row} need to be on draft status",
+  "structures.uploadStructures.failed.note.content_unchanged":
+    "Content unchanged",
+  "structures.uploadStructures.failed.note.invalid_transition":
+    "Invalid note transition",
+  "structures.uploadStructures.failed.note.conflict":
+    "Note conflict",
   "structures.uploadStructures.success.content":
     "Updated extra info of {count} structures",
   "structures.uploadStructures.success.content.any":

package/src/messages/es.js

@@ -528,6 +528,14 @@ export default {
     "External id: {externalId} El campo <{field}> no tiene un valor permitido",
   "structures.bulkUpdateStructures.failed.note.df_content.required":
     "External id: {externalId} El campo <{field}> es necesario",
+  "structures.bulkUpdateStructures.failed.note.content_unchanged":
+    "Contenido sin cambios para external id {externalId}",
+  "structures.bulkUpdateStructures.failed.note.invalid_transition":
+    "Transición de nota no válida para external id {externalId}",
+  "structures.bulkUpdateStructures.failed.note.conflict":
+    "Conflicto de nota para external id {externalId}",
+  "structures.bulkUpdateStructures.failed.note.only_draft_are_editable":
+    "La nota del external id {externalId} debe estar en borrador para poder editar",
   "structures.bulkUpdateStructures.no.structures.header": "Búsqueda vacía",
   "structures.bulkUpdateStructures.success.header":
     "¡Actualización finalizada! subidos {count_ids} errores {count_errors}",
@@ -655,6 +663,12 @@ export default {
     "No tiene los permisos suficientes para editar la estructura de la fila {row}",
   "structures.uploadStructures.failed.note.only_draft_are_editable":
     "La nota de la fila {row} debe estar en estado borrador para poder ser editada",
+  "structures.uploadStructures.failed.note.content_unchanged":
+    "Contenido sin cambios",
+  "structures.uploadStructures.failed.note.invalid_transition":
+    "Transición de nota no válida",
+  "structures.uploadStructures.failed.note.conflict":
+    "Conflicto de nota",
   "structures.uploadStructures.success.content":
     "Se ha actualizado la información adicional de {count} estructuras",
   "structures.uploadStructures.success.content.any":

package/src/reducers/ddMessage.js

@@ -8,6 +8,7 @@ import {
   updateReferenceDataset,
   updateStructureType,
   uploadStructuresDomains,
+  doStructureNoteAction,
 } from "../routines";
 
 export const initialState = null;
@@ -21,23 +22,23 @@ const ddMessage = (state = initialState, { type, payload }) => {
     case uploadStructuresDomains.SUCCESS: {
       const messagesImp = _.has("errors")(payload.data)
         ? _.flow(
-          _.propOr([], "errors"),
-          _.map((error) => {
-            const errorMessage = Object.entries(error.message)
-              .map(([field, messages]) => `${field}: ${messages.join(", ")}`)
-              .join(" | ");
-            return {
-              id: `structures.bulkUploadStructuresDomains.success.errors.${errorMessage}`,
-              fields: {
-                row: error.row,
-                id: error.id,
-                field: error.field,
-                externalId: error.external_id,
-                message: errorMessage,
-              },
-            };
-          })
-        )(payload.data)
+            _.propOr([], "errors"),
+            _.map((error) => {
+              const errorMessage = Object.entries(error.message)
+                .map(([field, messages]) => `${field}: ${messages.join(", ")}`)
+                .join(" | ");
+              return {
+                id: `structures.bulkUploadStructuresDomains.success.errors.${errorMessage}`,
+                fields: {
+                  row: error.row,
+                  id: error.id,
+                  field: error.field,
+                  externalId: error.external_id,
+                  message: errorMessage,
+                },
+              };
+            })
+          )(payload.data)
         : "";
       return {
         error: false,
@@ -59,12 +60,12 @@ const ddMessage = (state = initialState, { type, payload }) => {
       return payload.status !== 422
         ? state
         : {
-          error: true,
-          header: "structures.uploadStructuresDomains.failed.header",
-          icon: "attention",
-          content: payload?.data?.error?.message,
-          initialMaxListItems: 5,
-        };
+            error: true,
+            header: "structures.uploadStructuresDomains.failed.header",
+            icon: "attention",
+            content: payload?.data?.error?.message,
+            initialMaxListItems: 5,
+          };
 
     case updateStructureType.SUCCESS:
       return {
@@ -94,6 +95,13 @@ const ddMessage = (state = initialState, { type, payload }) => {
         icon: "check",
         color: "green",
       };
+    case doStructureNoteAction.FAILURE:
+      return {
+        error: true,
+        header: "alert.doStructureNoteAction.failed.header",
+        icon: "attention",
+        content: payload?.data?.error,
+      };
     default:
       return state;
   }

package/src/selectors/__tests__/messages.spec.js

@@ -0,0 +1,56 @@
+import { getUploadAlertMessage } from "../messages";
+
+describe("selectors: getUploadAlertMessage", () => {
+  it("returns uploadAccepted when status is 202", () => {
+    const result = getUploadAlertMessage({ status: 202, data: {} });
+    expect(result.anchor).toBeDefined();
+    expect(result.anchor.reference).toBeDefined();
+    expect(result.header).toBe(
+      "structures.bulkUpdateStructures.success.accepted.header"
+    );
+  });
+
+  it("returns uploadWithErrors when status is 200 and data has errors with workflow message ids", () => {
+    const data = {
+      ids: [1],
+      errors: [
+        {
+          message: "content_unchanged",
+          row: 2,
+          external_id: "EXT-001",
+        },
+        {
+          message: "invalid_transition",
+          row: 3,
+          external_id: "EXT-002",
+        },
+      ],
+    };
+    const result = getUploadAlertMessage({ status: 200, data });
+    expect(result.messages).toHaveLength(2);
+    expect(result.messages[0].id).toBe(
+      "structures.bulkUpdateStructures.failed.note.content_unchanged"
+    );
+    expect(result.messages[1].id).toBe(
+      "structures.bulkUpdateStructures.failed.note.invalid_transition"
+    );
+    expect(result.fields.count_errors).toBe(2);
+  });
+
+  it("returns uploadWithErrors when status is 200 and data has errors with only_draft_are_editable", () => {
+    const data = {
+      ids: [],
+      errors: [
+        {
+          message: "only_draft_are_editable",
+          row: 1,
+          external_id: "EXT-001",
+        },
+      ],
+    };
+    const result = getUploadAlertMessage({ status: 200, data });
+    expect(result.messages[0].id).toBe(
+      "structures.bulkUpdateStructures.failed.note.only_draft_are_editable"
+    );
+  });
+});

package/src/selectors/getParsedEvents.js

@@ -16,7 +16,9 @@ const transformNotesPayloadFormat = (payload) => {
 
   const addedFields = payload.content.added
     ? payload.content.added
-    : payload.content.changed;
+    : payload.content.removed
+      ? payload.content.removed
+      : payload.content.changed;
 
   const fieldsArray = Object.keys(addedFields).reduce((acc, field) => {
     if (!_.isEmpty(addedFields[field])) acc.push(field);

package/src/selectors/messages.js

@@ -1,58 +1,58 @@
-
+import _ from "lodash/fp";
 import { STRUCTURE_NOTES_UPLOAD_JOBS } from "@truedat/core/routes";
 
 const uploadWithErrors = (data) => {
-    const messagesImp = _.has("errors")(data)
-        ? _.flow(
-            _.propOr([], "errors"),
-            _.map((error) => ({
-                id: `structures.bulkUpdateStructures.failed.note.${error.message}`,
-                fields: {
-                    row: error.row,
-                    id: error.id,
-                    field: error.field,
-                    externalId: error.external_id,
-                    message: error.message,
-                },
-                defaultMessage: "structures.bulkUploadStructures.success.errors",
-            }))
-        )(data)
-        : "";
-    return {
-        error: false,
-        header: "structures.bulkUpdateStructures.success.header",
-        icon: "check",
-        color: data.errors.length >= 1 ? "orange" : "green",
-        text: "",
-        messages: messagesImp,
-        fields: {
-            count_ids: data.ids.length,
-            count_errors: data.errors.length,
-        },
-        downloadable: true,
-        initialMaxListItems: 5,
-    };
+  const messagesImp = _.has("errors")(data)
+    ? _.flow(
+        _.propOr([], "errors"),
+        _.map((error) => ({
+          id: `structures.bulkUpdateStructures.failed.note.${error.message}`,
+          fields: {
+            row: error.row,
+            id: error.id,
+            field: error.field,
+            externalId: error.external_id,
+            message: error.message,
+          },
+          defaultMessage: "structures.bulkUploadStructures.success.errors",
+        }))
+      )(data)
+    : "";
+  return {
+    error: false,
+    header: "structures.bulkUpdateStructures.success.header",
+    icon: "check",
+    color: data.errors.length >= 1 ? "orange" : "green",
+    text: "",
+    messages: messagesImp,
+    fields: {
+      count_ids: data.ids.length,
+      count_errors: data.errors.length,
+    },
+    downloadable: true,
+    initialMaxListItems: 5,
+  };
 };
 
 const uploadAccepted = () => {
-    return {
-        error: false,
-        header: "structures.bulkUpdateStructures.success.accepted.header",
-        icon: "check",
-        color: "blue",
-        text: "",
-        anchor: {
-            reference: STRUCTURE_NOTES_UPLOAD_JOBS,
-            label: "sidemenu.structures_upload_events",
-        },
-    };
+  return {
+    error: false,
+    header: "structures.bulkUpdateStructures.success.accepted.header",
+    icon: "check",
+    color: "blue",
+    text: "",
+    anchor: {
+      reference: STRUCTURE_NOTES_UPLOAD_JOBS,
+      label: "sidemenu.structures_upload_events",
+    },
+  };
 };
 
 export const getUploadAlertMessage = ({ status, data }) => {
-    if (status === 202) {
-        return uploadAccepted();
-    }
-    if (status === 200) {
-        return uploadWithErrors(data);
-    }
-};
+  if (status === 202) {
+    return uploadAccepted();
+  }
+  if (status === 200) {
+    return uploadWithErrors(data);
+  }
+};