@truedat/dd 8.13.0 → 8.13.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "8.13.0",
+  "version": "8.13.1",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "module": "src/index.js",
@@ -54,7 +54,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.13.0",
+    "@truedat/test": "8.13.1",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -90,5 +90,5 @@
     "svg-pan-zoom": "^3.6.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "b9d1c2133cea6293e6a5ce5d198a4cd49133b4c1"
+  "gitHead": "09ce6d3a8693835de75577e43d99d86addb2edf7"
 }

package/src/components/StructureNoteLink.js

@@ -2,18 +2,40 @@ import PropTypes from "prop-types";
 import { Link } from "react-router";
 import { linkTo } from "@truedat/core/routes";
 
-export const StructureNoteLink = ({ data_structure_id, external_id }) =>
-  data_structure_id ? (
-    <Link to={linkTo.STRUCTURE_NOTES({ id: data_structure_id })}>
-      {external_id}
-    </Link>
-  ) : (
-    external_id
+const preferredLabel = ({ alias, name, external_id }) =>
+  typeof alias === "string" && alias.trim() !== ""
+    ? alias.trim()
+    : name || external_id;
+
+export const StructureNoteLink = ({
+  alias,
+  data_structure_id,
+  external_id,
+  name,
+}) => {
+  const label = preferredLabel({ alias, name, external_id });
+  const hasSecondaryExternalId =
+    external_id != null && external_id !== "" && external_id !== label;
+
+  return (
+    <>
+      {data_structure_id ? (
+        <Link to={linkTo.STRUCTURE_NOTES({ id: data_structure_id })}>
+          {label}
+        </Link>
+      ) : (
+        label
+      )}
+      {hasSecondaryExternalId ? <small>{external_id}</small> : null}
+    </>
   );
+};
 
 StructureNoteLink.propTypes = {
+  alias: PropTypes.string,
   data_structure_id: PropTypes.number,
   external_id: PropTypes.string,
+  name: PropTypes.string,
 };
 
 export default StructureNoteLink;

package/src/components/__tests__/StructureNoteLink.spec.js

@@ -41,4 +41,36 @@ describe("<StructureNoteLink />", () => {
     ).toBeInTheDocument();
     expect(rendered.getByText(/structure-100/i)).toBeInTheDocument();
   });
+
+  it("prefers a non-empty alias and renders external_id as secondary text", () => {
+    const rendered = render(
+      <StructureNoteLink
+        alias="Structure alias"
+        data_structure_id={42}
+        external_id="EXT-001"
+        name="Structure name"
+      />,
+    );
+
+    expect(
+      rendered.getByRole("link", { name: "Structure alias" }),
+    ).toHaveAttribute("href", "/structures/42/notes");
+    expect(rendered.getByText("EXT-001")).toBeInTheDocument();
+  });
+
+  it("falls back to name for an empty alias without duplicating external_id", () => {
+    const rendered = render(
+      <StructureNoteLink
+        alias="  "
+        data_structure_id={42}
+        external_id="EXT-001"
+        name="Structure name"
+      />,
+    );
+
+    expect(
+      rendered.getByRole("link", { name: "Structure name" }),
+    ).toBeInTheDocument();
+    expect(rendered.getByText("EXT-001")).toBeInTheDocument();
+  });
 });