@truedat/dd 5.2.9 → 5.3.1

package/src/components/__tests__/ReferenceDatasetFieldSelector.spec.js

@@ -0,0 +1,86 @@
+import React from "react";
+import { waitFor } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { render } from "@truedat/test/render";
+import { REFERENCE_DATASETS_QUERY } from "../../api/queries";
+import ReferenceDatasetFieldSelector from "../ReferenceDatasetFieldSelector";
+
+const referenceDatasets = [
+  {
+    __typename: "ReferenceDataset",
+    id: "1",
+    name: "countries",
+    headers: ["CODE", "DESC_ES", "DESC_EN"],
+    rowCount: 9,
+    updatedAt: "2023-03-04T12:10:53.245332Z",
+  },
+  {
+    __typename: "ReferenceDataset",
+    id: "2",
+    name: "currencies",
+    headers: ["ENTITY", "Currency", "Alphabetic Code", "Numeric Code"],
+    rowCount: 5,
+    updatedAt: "2023-03-05T09:57:59.765822Z",
+  },
+];
+
+const referenceDatasetsMock = {
+  request: {
+    query: REFERENCE_DATASETS_QUERY,
+  },
+  result: { data: { referenceDatasets } },
+};
+
+describe("<ReferenceDatasetFieldSelector />", () => {
+  it("selecting reference dataset fills fields dropdown; clicking a field calls onChange", async () => {
+    const onChange = jest.fn();
+    const renderOpts = {
+      mocks: [referenceDatasetsMock],
+    };
+    const { queryAllByText, getByRole } = render(
+      <ReferenceDatasetFieldSelector onChange={onChange} />,
+      renderOpts
+    );
+    const countriesOptionQuery = () =>
+      getByRole("option", { name: /countries/i });
+    await waitFor(() => {
+      // also matches "reference dataset field", get first
+      expect(queryAllByText(/Reference dataset/i)[0]).toBeInTheDocument();
+      // same text for label and dropdown, match the second one, the dropdown
+      expect(queryAllByText(/Reference dataset field/i)[1]).toBeInTheDocument();
+      expect(countriesOptionQuery()).toBeInTheDocument();
+      expect(getByRole("option", { name: /currencies/i })).toBeInTheDocument();
+    });
+
+    userEvent.click(countriesOptionQuery());
+
+    const optionQuery = () => getByRole("option", { name: /CODE/i });
+    await waitFor(() => {
+      expect(optionQuery()).toBeInTheDocument();
+    });
+    userEvent.click(optionQuery());
+    expect(onChange).toHaveBeenNthCalledWith(
+      1,
+      null,
+      {
+        name: null,
+        referenceDataset: { id: "1" },
+        type: "reference_dataset_field",
+      },
+      null
+    );
+    expect(onChange).toHaveBeenNthCalledWith(
+      2,
+      null,
+      {
+        name: "CODE",
+        referenceDataset: {
+          id: "1",
+          name: "countries",
+        },
+        type: "reference_dataset_field",
+      },
+      null
+    );
+  });
+});

package/src/components/__tests__/StructureStructureForm.spec.js

@@ -0,0 +1,138 @@
+import React from "react";
+import { waitFor } from "@testing-library/react";
+import { render } from "@truedat/test/render";
+import userEvent from "@testing-library/user-event";
+import StructureStructureForm from "../StructureStructureForm";
+import { linkStructureToStructure } from "../../routines";
+import { LINK_LABELS_QUERY } from "../../api/queries";
+
+const linkLabels = {
+  labels: [
+    {
+      id: "1",
+      name: "is_copy_from",
+    },
+    {
+      id: "2",
+      name: "reimu_ga_tsukutta",
+    },
+    {
+      id: "3",
+      name: "marisa_ga_tsukutta",
+    },
+  ],
+};
+
+const linkLabelsMock = {
+  request: { query: LINK_LABELS_QUERY },
+  result: { data: linkLabels },
+};
+
+describe("<StructureStructureForm />", () => {
+  const structure = {
+    alias: null,
+    confidential: false,
+    domain_ids: [1],
+    domains: [
+      {
+        external_id: "Acme",
+        id: 1,
+        name: "Acme",
+        parent_id: null,
+        parents: [],
+        updated_at: "2022-03-22 12:56:39.639127Z",
+      },
+    ],
+    external_id: "external_id",
+    id: 67583,
+    inserted_at: "2019-11-27T08:35:44.000000Z",
+    updated_at: "2021-06-10T12:01:17.343065Z",
+    class: null,
+    classes: null,
+    data_structure_link_count: 0,
+    data_structure_type: {
+      metadata_views: [],
+      template_id: 9,
+      translation: null,
+    },
+    degree: null,
+    deleted_at: null,
+    description: null,
+    grant: null,
+    grants: [],
+    group: "group",
+    implementation_count: 0,
+    metadata: {
+      database: "database",
+      host: "host",
+    },
+    name: "structure",
+    note: {},
+    siblings: [],
+    source: {
+      external_id: "oracle_meta_ds2",
+      id: 19,
+    },
+    system: {
+      id: 2,
+      name: "SYSTEM_1",
+    },
+    type: "Schema",
+  };
+
+  it("matches the latest snapshot", async () => {
+    const columns = ["name", "system", "group"].map((name) => ({ name }));
+    const structureActiveFilters = {};
+    const structuresRows = [{ id: 1 }, { id: 2 }];
+    const dispatch = jest.fn();
+
+    const props = {
+      linkStructureToStructure,
+      structuresRows,
+      columns,
+      onSelect: jest.fn(),
+    };
+
+    const renderOpts = {
+      mocks: [linkLabelsMock],
+      state: {
+        structure,
+        structures: [structure],
+        structureActiveFilters,
+      },
+      dispatch,
+    };
+
+    const { queryByText, findByText, getByRole } = render(
+      <StructureStructureForm {...props} />,
+      renderOpts
+    );
+    await waitFor(() =>
+      expect(queryByText(/loading/i)).not.toBeInTheDocument()
+    );
+    userEvent.click(await findByText("structure"));
+
+    const saveButton = getByRole("button", { name: "Save" });
+    await waitFor(() => {
+      expect(saveButton).toBeEnabled();
+    });
+
+    const label1 = getByRole("option", { name: "is_copy_from" });
+    const label2 = getByRole("option", { name: "reimu_ga_tsukutta" });
+
+    userEvent.click(label1);
+    userEvent.click(label2);
+
+    userEvent.click(saveButton);
+    await new Promise((r) => setTimeout(r, 200));
+
+    expect(dispatch).toHaveBeenCalledWith({
+      ...linkStructureToStructure(),
+      payload: {
+        sourceStructureId: 67583,
+        targetStructureId: 67583,
+        labelIds: ["1", "2"],
+      },
+    });
+  });
+});

package/src/components/__tests__/StructureStructureLinks.spec.js

@@ -1,22 +1,27 @@
 import React from "react";
 import { render } from "@truedat/test/render";
 import { waitFor } from "@testing-library/react";
-import { useParams } from "react-router-dom";
+import userEvent from "@testing-library/user-event";
 import { STRUCTURE_STRUCTURE_LINKS_QUERY } from "../../api/queries";
+import { deleteStructureStructureLink } from "../../routines";
 import StructureStructureLinks from "../StructureStructureLinks";
 
 jest.mock("react-router-dom", () => ({
   ...jest.requireActual("react-router-dom"),
-  useParams: jest.fn(),
+  useParams: () => ({ id: 60217 }),
 }));
 
 const dataStructureWithLinks = {
   currentVersion: {
     id: "212416",
-    name: "CMESANO",
+    name: "STRUCTURE_1",
   },
   dataStructureLinks: [
     {
+      _actions: {
+        delete_struct_to_struct_link: true,
+      },
+      id: "1",
       labels: [
         {
           name: "copy",
@@ -24,54 +29,58 @@ const dataStructureWithLinks = {
       ],
       source: {
         currentVersion: {
-          name: "CMESANO",
+          name: "STRUCTURE_1",
           pathWithIds: [
             {
               data_structure_id: "114207",
-              name: "SRV_DS2P.PRO.SANTALUCIA.ES",
+              name: "UNO",
             },
             {
               data_structure_id: "58050",
-              name: "SIISDS2",
+              name: "DOS",
             },
             {
               data_structure_id: "58045",
-              name: "INPAHEM_SINIEPAGO",
+              name: "TRES",
             },
           ],
         },
         id: "60217",
         system: {
           id: "2",
-          name: "Oracle producción solvencia",
+          name: "SYSTEM_1",
         },
       },
       target: {
         currentVersion: {
-          name: "NIDSINIE",
+          name: "STRUCTURE_2",
           pathWithIds: [
             {
               data_structure_id: "114207",
-              name: "SRV_DS2P.PRO.SANTALUCIA.ES",
+              name: "UNO",
             },
             {
               data_structure_id: "58050",
-              name: "SIISDS2",
+              name: "DOS",
             },
             {
               data_structure_id: "58045",
-              name: "INPAHEM_SINIEPAGO",
+              name: "TRES",
             },
           ],
         },
         id: "60218",
         system: {
           id: "2",
-          name: "Oracle producción solvencia",
+          name: "SYSTEM_1",
         },
       },
     },
     {
+      _actions: {
+        delete_struct_to_struct_link: true,
+      },
+      id: "2",
       labels: [
         {
           name: "label_1_1",
@@ -82,46 +91,46 @@ const dataStructureWithLinks = {
       ],
       source: {
         currentVersion: {
-          name: "ivalindm",
+          name: "STRUCTURE_3",
           pathWithIds: [
             {
               data_structure_id: "147587",
-              name: "bdrs",
+              name: "UNO",
             },
             {
               data_structure_id: "151648",
-              name: "inpahem_siniepago",
+              name: "DOS",
             },
           ],
         },
         id: "151674",
         system: {
           id: "11",
-          name: "Azure Databricks",
+          name: "SYSTEM_2",
         },
       },
       target: {
         currentVersion: {
-          name: "CMESANO",
+          name: "STRUCTURE_1",
           pathWithIds: [
             {
               data_structure_id: "114207",
-              name: "SRV_DS2P.PRO.SANTALUCIA.ES",
+              name: "UNO",
             },
             {
               data_structure_id: "58050",
-              name: "SIISDS2",
+              name: "DOS",
             },
             {
               data_structure_id: "58045",
-              name: "INPAHEM_SINIEPAGO",
+              name: "TRES",
             },
           ],
         },
         id: "60217",
         system: {
           id: "2",
-          name: "Oracle producción solvencia",
+          name: "SYSTEM_1",
         },
       },
     },
@@ -138,24 +147,89 @@ const linksMock = {
 };
 
 describe("<StructureStructureLinks />", () => {
-  const props = { dataStructureWithLinks };
+  const props = {
+    dataStructureWithLinks,
+  };
+
+  const structureActions = {
+    create_struct_to_struct_link: {
+      href: "/some/url",
+      method: "POST",
+    },
+  };
+
+  const renderOpts = {
+    routes: ["/structures/60217/structureLinks"],
+    mocks: [linksMock],
+  };
+
+  it("shows structure to structure links", async () => {
+    const { getByRole } = render(<StructureStructureLinks {...props} />, {
+      ...renderOpts,
+      state: { structureActions },
+    });
+    await waitFor(() => {
+      expect(getByRole("link", { name: /STRUCTURE_2/i })).toBeInTheDocument();
+      expect(getByRole("link", { name: /STRUCTURE_3/i })).toBeInTheDocument();
+    });
+    await waitFor(() => {
+      expect(getByRole("button", { name: /Add link/i })).toBeInTheDocument();
+    });
+    expect(
+      document.getElementById("delete-link-60217-60218")
+    ).toBeInTheDocument();
+    expect(
+      document.getElementById("delete-link-151674-60217")
+    ).toBeInTheDocument();
+  });
 
-  it("matches the latest snapshot", async () => {
-    const renderOpts = {
-      routes: ["/structures/60217/structureLinks"],
-      mocks: [linksMock],
-    };
-    useParams.mockImplementation(() => ({
-      id: 60217,
-    }));
-    const { container, findByText, getByRole, queryByText, debug } = render(
+  it("hides the 'add link' and delete link buttons if there are no permissions", async () => {
+    const { getByRole, queryByRole } = render(
       <StructureStructureLinks {...props} />,
       renderOpts
     );
     await waitFor(() => {
-      expect(getByRole("link", { name: /NIDSINIE/i })).toBeInTheDocument();
-      expect(getByRole("link", { name: /ivalindm/i })).toBeInTheDocument();
+      expect(getByRole("link", { name: /STRUCTURE_2/i })).toBeInTheDocument();
+      expect(getByRole("link", { name: /STRUCTURE_3/i })).toBeInTheDocument();
+    });
+    expect(
+      queryByRole("button", { name: /Add link/i })
+    ).not.toBeInTheDocument();
+    expect(document.getElementById("delete-link-60217-60218")).toBeNull();
+    expect(document.getElementById("delete-link-151674-60217")).toBeNull();
+  });
+
+  it("deletes link", async () => {
+    const dispatch = jest.fn();
+    const { getByText, getByRole } = render(
+      <StructureStructureLinks {...props} />,
+      {
+        ...renderOpts,
+        state: { structureActions },
+        dispatch,
+      }
+    );
+    await waitFor(() => {
+      expect(getByRole("link", { name: /STRUCTURE_2/i })).toBeInTheDocument();
+      expect(getByRole("link", { name: /STRUCTURE_3/i })).toBeInTheDocument();
+    });
+    await waitFor(() => {
+      expect(getByRole("button", { name: /Add link/i })).toBeInTheDocument();
+    });
+
+    const deleteButton = document.getElementById("delete-link-60217-60218");
+    userEvent.click(deleteButton);
+    expect(getByText("Delete link")).toBeInTheDocument();
+    const yesButton = getByRole("button", { name: /Yes/i });
+    userEvent.click(yesButton);
+
+    expect(dispatch).toHaveBeenCalledWith({
+      ...deleteStructureStructureLink(),
+      payload: {
+        dataStructureLinkId: "1",
+        sourceStructureId: "60217",
+        targetStructureId: "60218",
+      },
     });
-    expect(container).toMatchSnapshot();
   });
 });

package/src/messages/en.js

@@ -424,6 +424,8 @@ export default {
   "structureLink.currentStructure": "Current structure",
   "structureLink.label": "Relation label",
   "structureLink.relatedStructure": "Related structure",
+  "structureLink.selector.label": "Relation label",
+  "structureLink.selector.placeholder": "Select a relation label...",
   "structureSelector.union.criteria": "Union criteria",
   "structureSelector.union.type": "Union type",
   "structureTag.comment": "Comments",

package/src/messages/es.js

@@ -433,6 +433,9 @@ export default {
   "structureLink.currentStructure": "Estructura actual",
   "structureLink.label": "Etiqueta de relación",
   "structureLink.relatedStructure": "Estructura relacionada",
+  "structureLink.selector.label": "Etiqueta de relación",
+  "structureLink.selector.placeholder":
+    "Seleccione una etiqueta de relación...",
   "structureSelector.union.criteria": "Criterio de unión",
   "structureSelector.union.type": "Tipo de unión",
   "structureTag.comment": "Comentario",

package/src/reducers/structureRedirect.js

@@ -8,6 +8,7 @@ import {
   STRUCTURE_TAGS,
   STRUCTURE_TYPES,
   STRUCTURES,
+  STRUCTURE_STRUCTURE_LINKS,
   linkTo,
 } from "@truedat/core/routes";
 import {
@@ -24,6 +25,7 @@ import {
   deleteStructure,
   deleteTag,
   doStructureNoteAction,
+  linkStructureToStructure,
   updateGrantApprovalRule,
   updateReferenceDataset,
   updateStructure,
@@ -50,6 +52,10 @@ export const structureRedirect = (
       const id = _.path("data.id")(payload);
       return linkTo.SYSTEM_STRUCTURES({ id });
     }
+    case linkStructureToStructure.SUCCESS:
+      return linkTo.STRUCTURE_STRUCTURE_LINKS({
+        id: payload.sourceStructureId,
+      });
     case updateSystem.SUCCESS: {
       const id = _.path("data.id")(payload);
       return linkTo.SYSTEM_STRUCTURES({ id });

package/src/routines.js

@@ -51,6 +51,7 @@ export const deleteGrantApprovalRule = createRoutine("DELETE_GRANT_APPROVAL_RULE
 export const deleteReferenceDataset = createRoutine("DELETE_REFERENCE_DATASET");
 export const deleteStructureTag = createRoutine("DELETE_STRUCTURE_TAG");
 export const deleteStructure = createRoutine("DELETE_STRUCTURE");
+export const deleteStructureStructureLink = createRoutine("DELETE_STRUCTURE_STRUCTURE_LINK");
 export const deleteTag = createRoutine("DELETE_TAG");
 export const deleteUserSearchFilter = createRoutine("DELETE_USER_SEARCH_FILTER");
 export const doStructureNoteAction = createRoutine("DO_STRUCTURE_NOTE_ACTION");
@@ -86,7 +87,7 @@ export const fetchUserSearchFilters = createRoutine("FETCH_USER_SEARCH_FILTERS")
 export const filterStructures = createRoutine("FILTER_STRUCTURES");
 export const hoverNode = createRoutine("HOVER_NODE");
 export const initSvg = createRoutine("INIT_SVG");
-export const tagStructure = createRoutine("TAG_STRUCTURE");
+export const linkStructureToStructure = createRoutine("LINK_STRUCTURE_TO_STRUCTURE");
 export const loadLineageEvents = createRoutine("LOAD_LINEAGE_EVENTS");
 export const openGrantFilter = createRoutine("OPEN_GRANT_FILTER");
 export const openStructureFilter = createRoutine("OPEN_STRUCTURE_FILTER");
@@ -113,6 +114,7 @@ export const setGrantChangeRequestCart = createRoutine("SET_GRANT_CHANGE_REQUEST
 export const setGrantRequestsQuery = createRoutine("SET_GRANT_REQUESTS_QUERY");
 export const sortGrants = createRoutine("SORT_GRANTS");
 export const sortStructures = createRoutine("SORT_STRUCTURES");
+export const tagStructure = createRoutine("TAG_STRUCTURE");
 export const toggleGrantDateFilter = createRoutine("TOGGLE_GRANT_DATE_FILTER");
 export const toggleGrantFilterValue = createRoutine("TOGGLE_GRANT_FILTER_VALUE");
 export const toggleStructureDateFilter = createRoutine("TOGGLE_STRUCTURE_DATE_FILTER");

package/src/sagas/__tests__/deleteStructureStructureLink.spec.js

@@ -0,0 +1,101 @@
+import _ from "lodash/fp";
+import { compile } from "path-to-regexp";
+import { testSaga } from "redux-saga-test-plan";
+import { apiJsonDelete, JSON_OPTS } from "@truedat/core/services/api";
+import {
+  deleteStructureStructureLinkSaga,
+  deleteStructureStructureLinkRequestSaga,
+} from "../deleteStructureStructureLink";
+import { deleteStructureStructureLink } from "../../routines";
+import { API_STRUCTURE_TO_STRUCTURE_LINK } from "../../api";
+
+describe("sagas: deleteStructureStructureRequestSaga", () => {
+  it("should invoke deleteStructureStructureSaga on deleteStructureStructureLink.TRIGGER", () => {
+    expect(() => {
+      testSaga(deleteStructureStructureLinkRequestSaga)
+        .next()
+        .takeLatest(
+          deleteStructureStructureLink.TRIGGER,
+          deleteStructureStructureLinkSaga
+        )
+        .finish()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should throw exception if an unhandled action is received", () => {
+    expect(() => {
+      testSaga(deleteStructureStructureLinkRequestSaga)
+        .next()
+        .takeLatest("FOO", deleteStructureStructureLinkSaga);
+    }).toThrow();
+  });
+});
+
+describe("sagas: deleteStructureStructureLinkSaga", () => {
+  const sourceStructureId = 1;
+  const targetStructureId = 2;
+  const dataStructureLinkId = 1;
+  const receivedPayload = {
+    sourceStructureId,
+    targetStructureId,
+    dataStructureLinkId,
+  };
+
+  const deletePayload = {
+    sourceStructureId,
+    targetStructureId,
+  };
+
+  const url = compile(API_STRUCTURE_TO_STRUCTURE_LINK)({
+    sourceStructureId,
+    targetStructureId,
+  });
+
+  const client = {
+    cache: {
+      identify: jest.fn(),
+      evict: jest.fn(),
+      gc: jest.fn(),
+    },
+  };
+
+  it("should put a success action when a response is returned", () => {
+    expect(() => {
+      testSaga(deleteStructureStructureLinkSaga, { payload: receivedPayload })
+        .next()
+        .getContext("client")
+        .next(client)
+        .put(deleteStructureStructureLink.request(deletePayload))
+        .next(client)
+        .call(apiJsonDelete, url, JSON_OPTS)
+        .next({ data: deletePayload })
+        .put(deleteStructureStructureLink.success(deletePayload))
+        .next()
+        .put(deleteStructureStructureLink.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should put a failure action when a call returns an error", () => {
+    const message = "Request failed";
+    const error = { message };
+
+    expect(() => {
+      testSaga(deleteStructureStructureLinkSaga, { payload: receivedPayload })
+        .next()
+        .getContext("client")
+        .next(client)
+        .put(deleteStructureStructureLink.request(deletePayload))
+        .next(client)
+        .call(apiJsonDelete, url, JSON_OPTS)
+        .throw(error)
+        .put(deleteStructureStructureLink.failure(message))
+        .next()
+        .put(deleteStructureStructureLink.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+});