@truedat/dd 5.18.3 → 5.20.0

package/src/components/__tests__/GrantRemovalWorkflow.spec.js

@@ -0,0 +1,157 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { LATEST_GRANT_REQUEST_BY_GRANT_QUERY } from "@truedat/dd/api/queries";
+import GrantRemovalWorkflow from "../GrantRemovalWorkflow";
+
+describe("<GrantRemovalWorkflow />", () => {
+  const latestGrantRequestByGrantMock = (variables, grantRequestStatus) => {
+    const latestGrantRequest = !grantRequestStatus
+      ? null
+      : {
+          __typename: "GrantRequest",
+          id: 17,
+          group: {
+            __typename: "GrantRequestGroup",
+            grant: null,
+          },
+          requestType: "GRANT_REMOVAL",
+          status: {
+            __typename: "GrantRequestStatus",
+            status: grantRequestStatus,
+          },
+        };
+
+    return {
+      request: {
+        query: LATEST_GRANT_REQUEST_BY_GRANT_QUERY,
+        variables,
+      },
+      result: {
+        data: {
+          latestGrantRequest,
+        },
+      },
+    };
+  };
+
+  const grant = {
+    id: 17,
+  };
+
+  const latestRequestVars = { id: grant.id, requestType: "GRANT_REMOVAL" };
+
+  it("Shows workflow button at start state", async () => {
+    const renderOpts = {
+      mocks: [latestGrantRequestByGrantMock(latestRequestVars, null)],
+    };
+    const { findByRole } = render(
+      <GrantRemovalWorkflow
+        grant={{ ...grant, pending_removal: false }}
+        actions={{}}
+      />,
+      renderOpts
+    );
+    expect(await findByRole("button")).toHaveClass("orange");
+  });
+
+  it("Shows workflow button at pending state", async () => {
+    const renderOpts = {
+      mocks: [latestGrantRequestByGrantMock(latestRequestVars, "pending")],
+    };
+    const { findByRole, queryByText } = render(
+      <GrantRemovalWorkflow
+        grant={{ ...grant, pending_removal: false }}
+        actions={{}}
+      />,
+      renderOpts
+    );
+    const button = await findByRole("button");
+    expect(button).toHaveClass("yellow");
+    const cancelRequestOption = queryByText(/Cancel request/);
+    expect(cancelRequestOption).toBeInTheDocument();
+  });
+
+  it("Shows workflow button at rejected state", async () => {
+    const renderOpts = {
+      mocks: [latestGrantRequestByGrantMock(latestRequestVars, "rejected")],
+    };
+    const { findByRole } = render(
+      <GrantRemovalWorkflow
+        grant={{ ...grant, pending_removal: false }}
+        actions={{}}
+      />,
+      renderOpts
+    );
+    expect(await findByRole("button")).toHaveClass("red");
+  });
+
+  it("Shows workflow button at approved state", async () => {
+    const renderOpts = {
+      mocks: [latestGrantRequestByGrantMock(latestRequestVars, "approved")],
+    };
+    const { findByRole } = render(
+      <GrantRemovalWorkflow
+        grant={{ ...grant, pending_removal: true }}
+        actions={{}}
+      />,
+      renderOpts
+    );
+    expect(await findByRole("button")).toHaveClass("brown");
+  });
+
+  it("Workflow bypass: request approved, initially pending_removal true but someone with permissions set pending_removal to false", async () => {
+    const renderOpts = {
+      mocks: [latestGrantRequestByGrantMock(latestRequestVars, "approved")],
+    };
+    const { findByRole } = render(
+      <GrantRemovalWorkflow
+        grant={{ ...grant, pending_removal: false }}
+        actions={{}}
+      />,
+      renderOpts
+    );
+    expect(await findByRole("button")).toHaveClass("grey");
+  });
+
+  it("Workflow bypass: request pending, initially pending_removal to false but someone with permissions set pending_removal to true", async () => {
+    const renderOpts = {
+      mocks: [latestGrantRequestByGrantMock(latestRequestVars, "pending")],
+    };
+    const { findByRole } = render(
+      <GrantRemovalWorkflow
+        grant={{ ...grant, pending_removal: true }}
+        actions={{}}
+      />,
+      renderOpts
+    );
+    expect(await findByRole("button")).toHaveClass("grey");
+  });
+
+  it("Workflow bypass: request rejected, initially pending_removal to false but someone with permissions set pending_removal to true", async () => {
+    const renderOpts = {
+      mocks: [latestGrantRequestByGrantMock(latestRequestVars, "rejected")],
+    };
+    const { findByRole } = render(
+      <GrantRemovalWorkflow
+        grant={{ ...grant, pending_removal: true }}
+        actions={{}}
+      />,
+      renderOpts
+    );
+    expect(await findByRole("button")).toHaveClass("grey");
+  });
+
+  it("Workflow bypass: request processing, initially pending_removal to false but someone with permissions set pending_removal to true", async () => {
+    const renderOpts = {
+      mocks: [latestGrantRequestByGrantMock(latestRequestVars, "processing")],
+    };
+    const { findByRole } = render(
+      <GrantRemovalWorkflow
+        grant={{ ...grant, pending_removal: true }}
+        actions={{}}
+      />,
+      renderOpts
+    );
+    expect(await findByRole("button")).toHaveClass("grey");
+  });
+});

package/src/components/__tests__/GrantRequest.spec.js

@@ -1,6 +1,7 @@
 import React, { Suspense } from "react";
 import { render } from "@truedat/test/render";
 import { GrantRequest } from "../GrantRequest";
+import en from "../../messages/en";
 
 describe("<GrantRequest />", () => {
   const grantRequest = {
@@ -67,6 +68,7 @@ describe("<GrantRequest />", () => {
         "grantRequest.summary.emptyApprovals": "empty",
         "grantRequestApproval.header": "approval header",
         "grantRequests.header": "grant requests",
+        "request.grantAccess": "Structure access",
         "ruleImplementation.summary.field": "field",
         "ruleImplementation.summary.operator": "operator",
         "ruleImplementation.summary.values": "values",

package/src/components/__tests__/GrantRequestHeader.spec.js

@@ -1,15 +1,12 @@
 import React, { Suspense } from "react";
 import { render } from "@truedat/test/render";
 import { GrantRequestHeader } from "../GrantRequestHeader";
+import en from "../../messages/en";
 
 describe("<GrantRequestHeader />", () => {
   const renderOpts = {
     messages: {
-      en: {
-        "grantRequest.header": "header",
-        "grantRequest.actions.approve": "approve",
-        "grantRequest.actions.reject": "reject",
-      },
+      en,
     },
   };
 

package/src/components/__tests__/StructureGrantDropdown.spec.js

@@ -98,21 +98,6 @@ describe("<StructureGrantDropdown />", () => {
     expect(container).toMatchSnapshot();
   });
 
-  it("matches the latest snapshot for pendingRemovalGrant state", () => {
-    const grantRequest = null;
-    const props = {
-      ...propsBuilder({ pending_removal: true }),
-      grantRequest,
-      grantRequestStatus: null,
-    };
-    const { container } = render(
-      <StructureGrantDropdown {...props} />,
-      renderOpts
-    );
-
-    expect(container).toMatchSnapshot();
-  });
-
   it("matches the latest snapshot for activeGrant state", () => {
     const grantRequest = null;
     const props = {
@@ -177,7 +162,7 @@ describe("<StructureGrantDropdown />", () => {
     );
 
     userEvent.click(
-      await findByText(en["grant.actions.view_request.confirmation.header"])
+      await findByText(en["grant.actions.viewRequest.confirmation.header"])
     );
 
     expect(mockHistory.push).toHaveBeenCalledWith("/grantRequests/8");

package/src/components/__tests__/StructureGrantSummaryButton.spec.js

@@ -1,17 +1,18 @@
 import React from "react";
 import { waitFor } from "@testing-library/react";
 import { render } from "@truedat/test/render";
-import { LATEST_GRANT_REQUEST_QUERY } from "../../api/queries";
+import { LATEST_GRANT_REQUEST_BY_DS_QUERY } from "../../api/queries";
 import StructureGrantSummaryButton from "../StructureGrantSummaryButton";
 import en from "../../messages/en";
 
 const latestGrantMockBuilder = (status) => ({
-  request: { query: LATEST_GRANT_REQUEST_QUERY },
+  request: { query: LATEST_GRANT_REQUEST_BY_DS_QUERY },
   result: {
     data: {
       latestGrantRequest: status
         ? {
             id: 1,
+            requestType: "ACCESS",
             group: {
               grant: {
                 id: 1,

package/src/components/__tests__/StructureGrants.spec.js

@@ -47,18 +47,22 @@ describe("<StructureGrants />", () => {
       user: { id: 1, full_name: "foo user" },
       data_structure: structure,
       end_date: "2021/08/02",
+      pending_removal: false,
     },
     {
       id: 2,
       user: { id: 2, full_name: "bar user" },
       data_structure: { name: "bar structure" },
       end_date: "2021/09/02",
+      pending_removal: false,
     },
   ];
 
   const userPermissions = { update_grant_removal: {} };
 
-  const props = { grants, columns, structure, userPermissions };
+  const grantsActions = { manage_grant_removal: {} };
+
+  const props = { grants, columns, structure, userPermissions, grantsActions };
 
   it("matches the latest snapshot", () => {
     const { container } = render(<StructureGrants {...props} />);

package/src/components/__tests__/StructureNoteSuggestions.spec.js

@@ -0,0 +1,151 @@
+import React, { Suspense } from "react";
+import { waitFor } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { render } from "@truedat/test/render";
+import StructureNoteSuggestions from "../StructureNoteSuggestions";
+
+const mockSuggestions = {
+  editable_field: "editable_field_value",
+  non_editable_field: "non_editable_field_value",
+  unselect_field: "unselect_field_value",
+};
+jest.mock("@truedat/core/services/api", () => ({
+  apiJson: (url) => ({
+    then: (callback) =>
+      callback({
+        data: {
+          data: url.startsWith("suggestions")
+            ? mockSuggestions
+            : url.startsWith("error_message")
+            ? ["error", { error: { message: "ERROR MESSAGE" } }]
+            : ["error", "ERROR TEXT"],
+        },
+      }),
+  }),
+}));
+
+const messages = {
+  en: {
+    "actions.cancel": "cancel",
+    "actions.save": "save",
+    "structure_note.ai_suggestion.header": "header",
+    "actions.apply_ai_suggestion": "actions.apply_ai_suggestion",
+    "actions.ai_suggestion": "actions.ai_suggestion",
+    "structure_note.ai_suggestion.error": "error",
+  },
+};
+
+describe("<StructureNoteSuggestions />", () => {
+  it("matches the latest snapshot", () => {
+    const props = {
+      template: {},
+    };
+    const { container } = render(
+      <Suspense fallback={null}>
+        <StructureNoteSuggestions {...props} />
+      </Suspense>,
+      { messages }
+    );
+    expect(container).toMatchSnapshot();
+  });
+
+  it("component lifecycle", async () => {
+    const applySuggestions = jest.fn();
+    const props = {
+      aiSuggestionsAction: { href: "suggestions" },
+      applySuggestions,
+      template: {
+        content: [
+          {
+            fields: [
+              {
+                name: "editable_field",
+                label: "EditableField",
+                editable: true,
+              },
+            ],
+          },
+          {
+            name: "Group2",
+            fields: [
+              {
+                name: "non_editable_field",
+                label: "NonEditableField",
+                editable: false,
+              },
+              {
+                name: "unselect_field",
+                label: "UnselectedField",
+                editable: true,
+              },
+            ],
+          },
+        ],
+      },
+      isModification: true,
+    };
+    const { container, findByText, queryByText } = render(
+      <Suspense fallback={null}>
+        <StructureNoteSuggestions {...props} />
+      </Suspense>,
+      { messages }
+    );
+
+    userEvent.click(await findByText(/actions.ai_suggestion/i));
+    await waitFor(() =>
+      expect(queryByText(/actions.ai_suggestion/i)).not.toBeInTheDocument()
+    );
+
+    expect(container).toMatchSnapshot();
+
+    userEvent.click(await findByText(/UnselectedField/i));
+    userEvent.click(await findByText(/UnselectedField/i));
+    userEvent.click(await findByText(/UnselectedField/i));
+
+    userEvent.click(await findByText(/actions.apply_ai_suggestion/i));
+    await waitFor(() =>
+      expect(
+        queryByText(/actions.apply_ai_suggestion/i)
+      ).not.toBeInTheDocument()
+    );
+    expect(applySuggestions).toHaveBeenCalledWith(
+      expect.objectContaining({ editable_field: "editable_field_value" })
+    );
+
+    expect(container).toMatchSnapshot();
+  });
+
+  it("renders error with message", async () => {
+    const props = {
+      aiSuggestionsAction: { href: "error_message" },
+    };
+    const { container, findByText, queryByText } = render(
+      <Suspense fallback={null}>
+        <StructureNoteSuggestions {...props} />
+      </Suspense>,
+      { messages }
+    );
+
+    userEvent.click(await findByText(/actions.ai_suggestion/i));
+    await waitFor(() =>
+      expect(queryByText(/error message/i)).toBeInTheDocument()
+    );
+    expect(container).toMatchSnapshot();
+  });
+
+  it("renders error with message", async () => {
+    const props = {
+      aiSuggestionsAction: { href: "error_text" },
+    };
+    const { container, findByText, queryByText } = render(
+      <Suspense fallback={null}>
+        <StructureNoteSuggestions {...props} />
+      </Suspense>,
+      { messages }
+    );
+
+    userEvent.click(await findByText(/actions.ai_suggestion/i));
+    await waitFor(() => expect(queryByText(/error text/i)).toBeInTheDocument());
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/StructureNotesEdit.spec.js

@@ -28,6 +28,40 @@ describe("<StructureNotesEdit />", () => {
     expect(container).toMatchSnapshot();
   });
 
+  it("matches the latest snapshot with ai suggestion action", () => {
+    const props = {
+      structure: { id: 1 },
+      template: { id: 2 },
+      doStructureNoteAction: () => {},
+      selectTemplate: () => {},
+      selectDomain: () => {},
+      structureNotes: {
+        _actions: {
+          ai_suggestions: { href: "suggestion" },
+        },
+        structureNotes: [],
+      },
+      latestDfContent: { foo: "bar" },
+      applyTemplate: applyTemplate({ id: 2 }),
+      selectDomains: jest.fn(),
+    };
+    const { container } = render(
+      <Suspense fallback={null}>
+        <StructureNotesEdit {...props} />
+      </Suspense>,
+      {
+        messages: {
+          en: {
+            "actions.cancel": "cancel",
+            "actions.save": "save",
+            "structure_note.ai_suggestion.header": "header",
+            "actions.ai_suggestion": "ai_suggestion",
+          },
+        },
+      }
+    );
+    expect(container).toMatchSnapshot();
+  });
   it("calls doStructureNoteAction when submit is clicked", async () => {
     const doStructureNoteAction = jest.fn();
     const template = {

package/src/components/__tests__/__snapshots__/Grant.spec.js.snap

@@ -223,7 +223,7 @@ exports[`<Grant /> matches the latest snapshot 1`] = `
 </div>
 `;
 
-exports[`<Grant /> matches the latest snapshot with cancel_removal action 1`] = `
+exports[`<Grant /> matches the latest snapshot with manage_grant_removal action 1`] = `
 <div>
   <div
     class="ui breadcrumb"
@@ -552,15 +552,16 @@ exports[`<Grant /> matches the latest snapshot with update action 1`] = `
                     Grants  -&gt; foo
                   </div>
                 </h2>
+              </div>
+              <div
+                class="right aligned four wide column"
+              >
                 <button
                   class="ui button button icon group-actions"
                 >
                   Request grant change
                 </button>
               </div>
-              <div
-                class="right aligned four wide column"
-              />
             </div>
           </div>
           <div

package/src/components/__tests__/__snapshots__/GrantRequest.spec.js.snap

@@ -47,7 +47,7 @@ exports[`<GrantRequest /> matches the latest snapshot 1`] = `
               <div
                 class="content"
               >
-                header
+                Structure access
               </div>
             </h2>
           </div>
@@ -198,7 +198,7 @@ exports[`<GrantRequest /> matches the latest snapshot with approve actions 1`] =
               <div
                 class="content"
               >
-                header
+                Structure access
               </div>
             </h2>
           </div>
@@ -465,7 +465,7 @@ exports[`<GrantRequest /> matches the latest snapshot with failed status 1`] = `
               <div
                 class="content"
               >
-                header
+                Structure access
               </div>
             </h2>
           </div>

package/src/components/__tests__/__snapshots__/GrantRequestHeader.spec.js.snap

@@ -18,7 +18,7 @@ exports[`<GrantRequestHeader /> matches the latest snapshot (pending) 1`] = `
         <div
           class="content"
         >
-          header
+          Structure access request
         </div>
       </h2>
     </div>
@@ -28,12 +28,12 @@ exports[`<GrantRequestHeader /> matches the latest snapshot (pending) 1`] = `
       <button
         class="ui primary button button icon group-actions"
       >
-        approve
+        Approve
       </button>
       <button
         class="ui secondary button button icon group-actions"
       >
-        reject
+        Reject
       </button>
     </div>
   </div>
@@ -58,7 +58,7 @@ exports[`<GrantRequestHeader /> matches the latest snapshot 1`] = `
         <div
           class="content"
         >
-          header
+          Structure access request
         </div>
       </h2>
     </div>

package/src/components/__tests__/__snapshots__/GrantRequestsSearchResults.spec.js.snap

@@ -165,7 +165,7 @@ exports[`<GrantRequestsSearchResults /> matches the latest snapshot 1`] = `
           results
         </div>
         <table
-          class="ui sortable table"
+          class="ui selectable sortable table"
         >
           <thead
             class=""

package/src/components/__tests__/__snapshots__/StructureGrantDropdown.spec.js.snap

@@ -33,58 +33,6 @@ exports[`<StructureGrantDropdown /> matches the latest snapshot for activeGrant
           Request grant change
         </span>
       </div>
-      <div
-        class="item"
-        role="option"
-      >
-        <i
-          aria-hidden="true"
-          class="delete icon"
-        />
-        <span
-          class="text"
-        >
-          Request grant removal
-        </span>
-      </div>
-    </div>
-  </div>
-</div>
-`;
-
-exports[`<StructureGrantDropdown /> matches the latest snapshot for pendingRemovalGrant state 1`] = `
-<div>
-  <div
-    aria-expanded="false"
-    class="ui floating dropdown"
-    role="listbox"
-    tabindex="0"
-  >
-    <button
-      class="ui red icon button button basic icon group-actions"
-    >
-      <i
-        aria-hidden="true"
-        class="shield icon"
-      />
-    </button>
-    <div
-      class="menu transition left"
-    >
-      <div
-        class="item"
-        role="option"
-      >
-        <i
-          aria-hidden="true"
-          class="delete icon"
-        />
-        <span
-          class="text"
-        >
-          Cancel grant removal
-        </span>
-      </div>
     </div>
   </div>
 </div>

package/src/components/__tests__/__snapshots__/StructureGrantListButton.spec.js.snap

@@ -73,20 +73,6 @@ exports[`<StructureGrantListButton /> matches the latest snapshot with grant 1`]
           Request grant change
         </span>
       </div>
-      <div
-        class="item"
-        role="option"
-      >
-        <i
-          aria-hidden="true"
-          class="delete icon"
-        />
-        <span
-          class="text"
-        >
-          Request grant removal
-        </span>
-      </div>
     </div>
   </div>
 </div>

package/src/components/__tests__/__snapshots__/StructureGrantSummaryButton.spec.js.snap

@@ -85,20 +85,6 @@ exports[`<StructureGrantSummaryButton /> matches snapshot for active grant and i
           Request grant change
         </span>
       </div>
-      <div
-        class="item"
-        role="option"
-      >
-        <i
-          aria-hidden="true"
-          class="delete icon"
-        />
-        <span
-          class="text"
-        >
-          Request grant removal
-        </span>
-      </div>
     </div>
   </div>
 </div>