@truedat/dd 4.54.12 → 4.56.0

package/src/components/__tests__/GrantApprovalRuleDeleteButton.spec.js

@@ -0,0 +1,56 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import userEvent from "@testing-library/user-event";
+import GrantApprovalRuleDeleteButton from "../GrantApprovalRuleDeleteButton";
+import { deleteGrantApprovalRule } from "../../routines";
+import en from "../../messages/en";
+
+const renderOpts = {
+  messages: {
+    en: { ...en, "confirmation.yes": "yes", "confirmation.no": "no" },
+  },
+};
+
+describe("<GrantApprovalRuleDeleteButton />", () => {
+  const approvalRule = {
+    __typename: "ApprovalRule",
+    id: "123",
+  };
+  it("matches the last snapshot", () => {
+    const props = { deleteGrantApprovalRule, approvalRule };
+    const { container } = render(
+      <GrantApprovalRuleDeleteButton {...props} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+  });
+
+  it("call deleteGrantApprovalRule routine on confirm", () => {
+    const dispatch = jest.fn();
+    const props = { deleteGrantApprovalRule, approvalRule };
+    const { getByRole } = render(<GrantApprovalRuleDeleteButton {...props} />, {
+      ...renderOpts,
+      dispatch,
+    });
+    userEvent.click(getByRole("button", { name: /delete/i }));
+    userEvent.click(getByRole("button", { name: /yes/i }));
+
+    expect(dispatch).toHaveBeenLastCalledWith({
+      ...deleteGrantApprovalRule(),
+      payload: { id: approvalRule.id },
+    });
+  });
+
+  it("do not call deleteGrantApprovalRule routine on cancel", () => {
+    const dispatch = jest.fn();
+    const props = { deleteGrantApprovalRule, approvalRule };
+    const { getByRole } = render(<GrantApprovalRuleDeleteButton {...props} />, {
+      ...renderOpts,
+      dispatch,
+    });
+    userEvent.click(getByRole("button", { name: /delete/i }));
+    userEvent.click(getByRole("button", { name: /no/i }));
+
+    expect(dispatch).toHaveBeenCalledTimes(0);
+  });
+});

package/src/components/__tests__/GrantApprovalRuleEdit.spec.js

@@ -0,0 +1,76 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { waitFor } from "@testing-library/react";
+import { domainsMock, rolesMock } from "@truedat/test/mocks";
+import { GrantApprovalRuleEdit } from "../GrantApprovalRuleEdit";
+import { GRANT_APPROVAL_RULE_QUERY } from "../../api/queries";
+import en from "../../messages/en";
+
+jest.mock("react-router-dom", () => ({
+  ...jest.requireActual("react-router-dom"),
+  useParams: () => ({ id: 123 }),
+}));
+
+const grantApprovalRule = {
+  grantApprovalRule: {
+    __typename: "ApprovalRule",
+    id: "123",
+    name: "rule_name",
+    action: "approve",
+    role: "grants",
+    domainIds: ["1"],
+    userId: "1",
+    domains: [
+      {
+        __typename: "Domain",
+        name: "domain_test",
+      },
+    ],
+    conditions: [
+      {
+        __typename: "Condition",
+        field: "request.foo",
+        operator: "neq",
+        value: "bar",
+      },
+    ],
+    comment: "comment",
+  },
+};
+
+const approvalRuleMock = {
+  request: { query: GRANT_APPROVAL_RULE_QUERY, variables: { id: 123 } },
+  result: { data: grantApprovalRule },
+};
+
+const renderOpts = {
+  mocks: [
+    approvalRuleMock,
+    domainsMock({ action: "approveGrantRequests" }),
+    rolesMock({ domainId: "1", permission: "approve_grant_request" }),
+  ],
+  messages: {
+    en: {
+      ...en,
+      "domain.selector.label": "Domain",
+      "domain.selector.placeholder": "Domain",
+      "actions.save": "Save",
+      "actions.cancel": "Cancel",
+    },
+  },
+  fallback: "lazy",
+};
+
+describe("<GrantApprovalRuleEdit />", () => {
+  it("matches the last snapshot", async () => {
+    const { container, queryByText } = render(
+      <GrantApprovalRuleEdit />,
+      renderOpts
+    );
+    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
+    await waitFor(() =>
+      expect(queryByText(/loading/i)).not.toBeInTheDocument()
+    );
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/GrantApprovalRuleForm.spec.js

@@ -0,0 +1,135 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { waitFor } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { domainsMock, rolesMock } from "@truedat/test/mocks";
+import GrantApprovalRuleForm from "../GrantApprovalRuleForm";
+import en from "../../messages/en";
+
+const renderOpts = {
+  mocks: [
+    domainsMock({ action: "approveGrantRequests" }),
+    rolesMock({ domainId: "1", permission: "approve_grant_request" }),
+  ],
+  messages: {
+    en: {
+      ...en,
+      "domain.selector.label": "Domain",
+      "domain.selector.placeholder": "Domain",
+      "actions.save": "Save",
+      "actions.cancel": "Cancel",
+    },
+  },
+  fallback: "lazy",
+};
+const approvalRule = {
+  __typename: "ApprovalRule",
+  id: "123",
+  name: "rule_name",
+  action: "approve",
+  role: "grants",
+  domainIds: ["1"],
+  userId: "1",
+  domains: [
+    {
+      __typename: "Domain",
+      name: "domain_test",
+    },
+  ],
+  conditions: [
+    {
+      __typename: "Condition",
+      field: "request.foo",
+      operator: "neq",
+      value: "bar",
+    },
+    {
+      __typename: "Condition",
+      field: "invalid_condition",
+      operator: "neq",
+      value: "bar",
+    },
+  ],
+  comment: "comment",
+};
+
+describe("<GrantApprovalRuleForm />", () => {
+  it("matches the last snapshot", async () => {
+    const props = {
+      onSubmit: jest.fn(),
+      approvalRule,
+    };
+    const { container, findByRole } = render(
+      <GrantApprovalRuleForm {...props} />,
+      renderOpts
+    );
+    await findByRole("button", { name: /save/i });
+    expect(container).toMatchSnapshot();
+  });
+
+  it("matches the last snapshot for new rule", async () => {
+    const props = { onSubmit: jest.fn() };
+    const { container, findByRole } = render(
+      <GrantApprovalRuleForm {...props} />,
+      renderOpts
+    );
+    await findByRole("button", { name: /save/i });
+    expect(container).toMatchSnapshot();
+  });
+
+  it("call onSubmit with data", async () => {
+    const onSubmit = jest.fn();
+    const props = { onSubmit };
+    const { getByRole, findByText, debug } = render(
+      <GrantApprovalRuleForm {...props} />,
+      renderOpts
+    );
+    await waitFor(() =>
+      expect(getByRole("button", { name: /save/i })).toBeDisabled()
+    );
+
+    userEvent.type(getByRole("textbox", { name: /name/i }), "rule_name");
+
+    userEvent.click(await findByText(/fooDomain/));
+
+    await waitFor(() =>
+      expect(getByRole("textbox", { name: /comment/i })).not.toBeDisabled()
+    );
+
+    userEvent.click(await findByText(/role1/i));
+    userEvent.click(await findByText(/reject/i));
+
+    userEvent.type(getByRole("textbox", { name: /comment/i }), "rule_comment");
+
+    userEvent.click(await findByText(/request metadata/i));
+    userEvent.type(getByRole("textbox", { name: /field/i }), "field");
+    userEvent.click(await findByText(/is equal/i));
+    userEvent.type(getByRole("textbox", { name: /value/i }), "value");
+
+    await waitFor(() =>
+      expect(getByRole("button", { name: /save/i })).not.toBeDisabled()
+    );
+
+    userEvent.click(getByRole("button", { name: /save/i }));
+
+    await waitFor(() => {
+      expect(onSubmit.mock.calls.length).toBe(1);
+    });
+    expect(onSubmit.mock.calls[0][0]).toMatchObject({
+      approvalRule: {
+        action: "reject",
+        comment: "rule_comment",
+        conditions: [
+          {
+            field: "request.field",
+            operator: "eq",
+            value: "value",
+          },
+        ],
+        domainIds: ["1"],
+        name: "rule_name",
+        role: "role1",
+      },
+    });
+  });
+});

package/src/components/__tests__/GrantApprovalRuleNew.spec.js

@@ -0,0 +1,40 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { waitFor } from "@testing-library/react";
+import { domainsMock, rolesMock } from "@truedat/test/mocks";
+import { GrantApprovalRuleNew } from "../GrantApprovalRuleNew";
+import en from "../../messages/en";
+
+const createGrantApprovalRule = jest.fn();
+
+const renderOpts = {
+  mocks: [
+    domainsMock({ action: "approveGrantRequests" }),
+    rolesMock({ domainId: "1", permission: "approve_grant_request" }),
+  ],
+  messages: {
+    en: {
+      ...en,
+      "domain.selector.label": "Domain",
+      "domain.selector.placeholder": "Domain",
+      "actions.save": "Save",
+      "actions.cancel": "Cancel",
+    },
+  },
+  fallback: "lazy",
+};
+
+describe("<GrantApprovalRuleNew />", () => {
+  it("matches the last snapshot", async () => {
+    const props = { createGrantApprovalRule };
+    const { container, queryByText } = render(
+      <GrantApprovalRuleNew {...props} />,
+      renderOpts
+    );
+    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
+    await waitFor(() =>
+      expect(queryByText(/loading/i)).not.toBeInTheDocument()
+    );
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/GrantApprovalRules.spec.js

@@ -0,0 +1,107 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import userEvent from "@testing-library/user-event";
+import { waitFor } from "@testing-library/react";
+import { linkTo } from "@truedat/core/routes";
+import GrantApprovalRules from "../GrantApprovalRules";
+import { GRANT_APPROVAL_RULES_QUERY } from "../../api/queries";
+import en from "../../messages/en";
+
+const mockHistory = {
+  push: jest.fn(),
+};
+
+jest.mock("react-router-dom", () => ({
+  ...jest.requireActual("react-router-dom"),
+  useHistory: () => mockHistory,
+}));
+
+const grantApprovalRules = {
+  grantApprovalRules: [
+    {
+      __typename: "ApprovalRule",
+      id: "123",
+      name: "rule_name",
+      action: "approve",
+      role: "grants",
+      domains: [
+        {
+          __typename: "Domain",
+          name: "domain_test",
+        },
+      ],
+    },
+    {
+      __typename: "ApprovalRule",
+      id: "456",
+      name: "reject rule",
+      action: "reject",
+      role: "grants",
+      domains: [
+        {
+          __typename: "Domain",
+          name: "domain_test",
+        },
+      ],
+    },
+  ],
+};
+
+const emptyGrantApprovalRules = {
+  grantApprovalRules: [],
+};
+
+const approvalRulesMock = (data) => ({
+  request: { query: GRANT_APPROVAL_RULES_QUERY },
+  result: { data },
+});
+
+const renderOpts = (data) => ({
+  mocks: [approvalRulesMock(data)],
+  messages: { en },
+  fallback: "lazy",
+});
+
+describe("<GrantApprovalRules />", () => {
+  it("matches the last snapshot", async () => {
+    const { container, queryByText } = render(
+      <GrantApprovalRules />,
+      renderOpts(grantApprovalRules)
+    );
+    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
+    expect(container).toMatchSnapshot();
+    await waitFor(() =>
+      expect(queryByText(/loading/i)).not.toBeInTheDocument()
+    );
+    expect(container).toMatchSnapshot();
+  });
+
+  it("matches snapshot for empty data", async () => {
+    const { container, queryByText } = render(
+      <GrantApprovalRules />,
+      renderOpts(emptyGrantApprovalRules)
+    );
+    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
+    expect(container).toMatchSnapshot();
+    await waitFor(() =>
+      expect(queryByText(/loading/i)).not.toBeInTheDocument()
+    );
+    expect(container).toMatchSnapshot();
+  });
+
+  it("navigates to ApprovalRule detail on click", async () => {
+    const { queryByText } = render(
+      <GrantApprovalRules />,
+      renderOpts(grantApprovalRules)
+    );
+    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
+    await waitFor(() =>
+      expect(queryByText(/loading/i)).not.toBeInTheDocument()
+    );
+
+    userEvent.click(queryByText(/rule_name/i));
+    expect(mockHistory.push).toHaveBeenCalledWith(
+      linkTo.GRANT_APPROVAL_RULE({ id: 123 })
+    );
+  });
+});

package/src/components/__tests__/StructureGrantDropdown.spec.js

@@ -143,6 +143,6 @@ describe("<StructureGrantDropdown />", () => {
       await findByText(en["grant.actions.view_request.confirmation.header"])
     );
 
-    expect(mockHistory.push).toHaveBeenCalledWith("/grant_requests/8");
+    expect(mockHistory.push).toHaveBeenCalledWith("/grantRequests/8");
   });
 });

package/src/components/__tests__/__snapshots__/GrantApprovalRule.spec.js.snap

@@ -0,0 +1,239 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<GrantApprovalRule /> matches the last snapshot 1`] = `
+<div>
+  <div
+    class="ui breadcrumb"
+  >
+    <a
+      class="section"
+    >
+      Approval rules
+    </a>
+    <i
+      aria-hidden="true"
+      class="right angle icon divider"
+    />
+    <div
+      class="active section"
+    >
+      rule_name
+    </div>
+  </div>
+  <div
+    class="ui segment"
+  >
+    <div
+      class="ui grid"
+    >
+      <div
+        class="eight wide column"
+      >
+        <h2
+          class="ui header"
+        >
+          <i
+            aria-hidden="true"
+            class="key circular icon"
+          />
+          <div
+            class="content"
+          >
+            Grant approval rule
+          </div>
+        </h2>
+      </div>
+      <div
+        class="right aligned eight wide column"
+      >
+        <a
+          class="ui primary button"
+          href="/grantApproveRules/123/edit"
+          role="button"
+        >
+          Edit
+        </a>
+        <button
+          class="ui button"
+        >
+          Delete
+        </button>
+      </div>
+    </div>
+    <div
+      class="ui big relaxed list"
+      role="list"
+    >
+      <div
+        class="item"
+        role="listitem"
+      >
+        <div
+          class="header"
+        >
+          Name
+        </div>
+        <div
+          class="content"
+        >
+          rule_name
+        </div>
+      </div>
+      <div
+        class="item"
+        role="listitem"
+      >
+        <div
+          class="header"
+        >
+          Domain
+        </div>
+        <div
+          class="content"
+        >
+          domain_test
+        </div>
+      </div>
+      <div
+        class="item"
+        role="listitem"
+      >
+        <div
+          class="header"
+        >
+          Role
+        </div>
+        <div
+          class="content"
+        >
+          grants
+        </div>
+      </div>
+      <div
+        class="item"
+        role="listitem"
+      >
+        <div
+          class="header"
+        >
+          Action
+        </div>
+        <div
+          class="content"
+        >
+          Approve
+        </div>
+      </div>
+      <div
+        class="item"
+        role="listitem"
+      >
+        <div
+          class="header"
+        >
+          Comment
+        </div>
+        <div
+          class="content"
+        >
+          comment invalid
+        </div>
+      </div>
+      <div
+        class="item"
+        role="listitem"
+      >
+        <div
+          class="header"
+        >
+          Conditions
+        </div>
+        <table
+          class="ui celled collapsing compact table"
+        >
+          <thead
+            class=""
+          >
+            <tr
+              class="center aligned"
+            >
+              <th
+                class=""
+              >
+                Context
+              </th>
+              <th
+                class=""
+              >
+                Field
+              </th>
+              <th
+                class=""
+              >
+                Operator
+              </th>
+              <th
+                class=""
+              >
+                Value
+              </th>
+            </tr>
+          </thead>
+          <tbody
+            class=""
+          >
+            <tr
+              class="center aligned"
+            >
+              <td
+                class=""
+              >
+                Request metadata
+              </td>
+              <td
+                class=""
+              >
+                foo
+              </td>
+              <td
+                class=""
+              >
+                Is not equal
+              </td>
+              <td
+                class=""
+              >
+                bar
+              </td>
+            </tr>
+            <tr
+              class="center aligned"
+            >
+              <td
+                class=""
+              >
+                -
+              </td>
+              <td
+                class=""
+              >
+                invalid_field
+              </td>
+              <td
+                class=""
+              >
+                Is equal
+              </td>
+              <td
+                class=""
+              >
+                baz
+              </td>
+            </tr>
+          </tbody>
+        </table>
+      </div>
+    </div>
+  </div>
+</div>
+`;