@truedat/dd 4.40.14 → 4.41.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.41.0] 2022-03-25
+
+### Added
+
+- [TD-4535] Structures domains CSV upload bulk update
+
 ## [4.40.14] 2022-03-22
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "4.40.14",
+  "version": "4.41.0",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.14.1",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.40.14",
+    "@truedat/test": "4.41.0",
     "babel-jest": "^27.0.6",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -84,9 +84,9 @@
     ]
   },
   "dependencies": {
-    "@truedat/auth": "4.40.14",
-    "@truedat/core": "4.40.14",
-    "@truedat/df": "4.40.14",
+    "@truedat/auth": "4.41.0",
+    "@truedat/core": "4.41.0",
+    "@truedat/df": "4.41.0",
     "lodash": "^4.17.21",
     "path-to-regexp": "^1.7.0",
     "prop-types": "^15.7.2",
@@ -107,5 +107,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "11d6d5749f624fd3db6005f79f0df6ce05bc7793"
+  "gitHead": "f4d8bc5e536b847c7b562a84bfa70955a93166ea"
 }

package/src/api.js

@@ -31,6 +31,8 @@ const API_STRUCTURE_TAG = "/api/data_structure_tags/:id";
 const API_STRUCTURE_TAGS = "/api/data_structure_tags";
 const API_STRUCTURE_TYPE = "/api/data_structure_types/:id";
 const API_STRUCTURE_TYPES = "/api/data_structure_types";
+const API_STRUCTURES_DOMAINS_UPLOAD =
+  "/api/data_structures/bulk_upload_domains";
 const API_STRUCTURES_TAG = "/api/data_structures/:data_structure_id/tags/:id";
 const API_STRUCTURES_TAGS = "/api/data_structures/:data_structure_id/tags";
 const API_USER_SEARCH_FILTERS = "/api/user_search_filters";
@@ -79,6 +81,7 @@ export {
   API_USER_SEARCH_FILTERS,
   API_USER_SEARCH_FILTER,
   API_GET_USER_SEARCH_FILTERS,
+  API_STRUCTURES_DOMAINS_UPLOAD,
   API_STRUCTURES_TAG,
   API_STRUCTURES_TAGS,
   API_STRUCTURES_UPLOAD,

package/src/components/StructuresDomainsUploadOption.js

@@ -0,0 +1,52 @@
+import React from "react";
+import PropTypes from "prop-types";
+import { connect } from "react-redux";
+import { Dropdown } from "semantic-ui-react";
+import { useIntl } from "react-intl";
+import { UploadModal } from "@truedat/core/components";
+import { uploadStructuresDomains } from "../routines";
+
+export const StructuresDomainsUploadOption = ({
+  uploadStructuresDomains,
+  loading,
+}) => {
+  const { formatMessage } = useIntl();
+
+  return (
+    <UploadModal
+      icon="upload"
+      trigger={
+        <Dropdown.Item
+          icon="upload"
+          text={formatMessage({ id: "structures.actions.uploadDomains.tooltip" })}
+          disabled={loading}
+        />
+      }
+      header={formatMessage({
+        id: "structures.actions.uploadDomains.confirmation.header",
+      })}
+      content={formatMessage({
+        id: "structures.actions.uploadDomains.confirmation.content",
+      })}
+      param={"structures_domains"}
+      handleSubmit={(data) =>
+        uploadStructuresDomains({
+          data,
+        })
+      }
+    />
+  );
+};
+
+StructuresDomainsUploadOption.propTypes = {
+  uploadStructuresDomains: PropTypes.func,
+  loading: PropTypes.bool,
+};
+
+const mapStateToProps = ({ uploadingStructuresDomainsFile }) => ({
+  loading: uploadingStructuresDomainsFile,
+});
+
+export default connect(mapStateToProps, { uploadStructuresDomains })(
+  StructuresDomainsUploadOption
+);

package/src/components/StructuresOptions.js

@@ -6,10 +6,12 @@ import StructuresDownloadOption from "./StructuresDownloadOption";
 import StructuresEditableDownloadOption from "./StructuresEditableDownloadOption";
 import StructuresUpdateOption from "./StructuresUpdateOption";
 import StructuresUploadOption from "./StructuresUploadOption";
+import StructuresDomainsUploadOption from "./StructuresDomainsUploadOption";
 
 export const StructuresOptions = ({
   autoPublish,
   bulkUpload,
+  bulkUploadDomains,
   hasFilterApplied,
 }) => (
   <Dropdown
@@ -26,6 +28,7 @@ export const StructuresOptions = ({
       {bulkUpload ? (
         <StructuresUploadOption canAutoPublish={!!autoPublish} />
       ) : null}
+      {bulkUploadDomains ? <StructuresDomainsUploadOption /> : null}
       <Dropdown.Divider />
       <StructuresUpdateOption />
     </Dropdown.Menu>
@@ -35,6 +38,7 @@ export const StructuresOptions = ({
 StructuresOptions.propTypes = {
   autoPublish: PropTypes.object,
   bulkUpload: PropTypes.object,
+  bulkUploadDomains: PropTypes.object,
   hasFilterApplied: PropTypes.bool,
 };
 

package/src/components/__tests__/PendingStructureNotesTable.spec.js

@@ -13,6 +13,7 @@ const renderOpts = {
       "pendingStructureNotes.props.domains": "Domains",
       "structure.notes.status.draft": "Draft",
       "structure.notes.status.rejected": "Rejected",
+      "pendingStructureNotes.props.path": "Path",
     },
   },
 };

package/src/components/__tests__/StructuresOptions.spec.js

@@ -10,7 +10,12 @@ const renderOpts = {
 };
 
 describe("<StructuresOptions />", () => {
-  const props = { bulkUpload: {}, bulkUpdate: {}, autoPublish: {} };
+  const props = {
+    bulkUpload: {},
+    bulkUpdate: {},
+    bulkUploadDomains: {},
+    autoPublish: {},
+  };
 
   it("matches the latest snapshot", async () => {
     const { container } = render(<StructuresOptions {...props} />, renderOpts);

package/src/components/__tests__/__snapshots__/PendingStructureNotesTable.spec.js.snap

@@ -34,7 +34,7 @@ exports[`<PendingStructureNotesTable /> matches the latest snapshot 1`] = `
         <th
           class=""
         >
-          pendingStructureNotes.props.path
+          Path
         </th>
       </tr>
     </thead>

package/src/components/__tests__/__snapshots__/StructuresOptions.spec.js.snap

@@ -68,6 +68,20 @@ exports[`<StructuresOptions /> matches the latest snapshot 1`] = `
           Upload structure notes
         </span>
       </div>
+      <div
+        class="item"
+        role="option"
+      >
+        <i
+          aria-hidden="true"
+          class="upload icon"
+        />
+        <span
+          class="text"
+        >
+          Update structure domains
+        </span>
+      </div>
       <div
         class="divider"
       />

package/src/messages/en.js

@@ -371,9 +371,13 @@ export default {
   "structures.actions.new_system": "New system",
   "structures.actions.upload": "Upload file",
   "structures.actions.upload.confirmation.content": "Notes",
+  "structures.actions.uploadDomains.confirmation.content": "Structure domains",
   "structures.actions.upload.confirmation.header":
     "Upload notes file of structures",
+  "structures.actions.uploadDomains.confirmation.header":
+    "Upload structures domains file",
   "structures.actions.upload.tooltip": "Upload structure notes",
+  "structures.actions.uploadDomains.tooltip": "Update structure domains",
   "structures.bulkUpdate.crumbs.top": "Bulk update",
   "structures.bulkUpdate.success.content":
     "Updated {count} structures successfully",
@@ -391,12 +395,25 @@ export default {
     "Bulk update completed. Loaded {count_ids} errors {count_errors}",
   "structures.bulkUpdateStructures.success.errors":
     "Error in external id {externalId}, message: {message}",
+  "structures.bulkUploadStructuresDomains.success.errors.domain: not_exist":
+    "Error in line {row}, in external id {externalId}, domain does not exist",
+  "structures.bulkUploadStructuresDomains.success.errors.update_domain: forbbiden":
+    "Error in line {row}, in external id {externalId}, update forbbiden",
+  "structures.bulkUploadStructuresDomains.success.errors.domain_ids: must be a non-empty list":
+    "Error in line {row}, in external id {externalId}, domain_ids must be a non-empty list",
+  "structures.bulkUploadStructuresDomains.success.errors.structure: not_exist":
+    "Error in line {row}, in external id {externalId}, data structure does not exist",
   "structures.bulkUploadStructures.success.errors":
     "Error in line {row}, in external id {externalId}, message: {message}",
+  "structures.bulkUploadStructuresDomains.success.errors":
+    "Error in line {row}, in external id {externalId}, message: {message}",
   "structures.bulkUpdateStructures.success.unchanged":
     "{unchanged} structures remained unchanged.",
   "structures.bulkUpdateStructures.success.updated":
     "Updated {changed} structures successfully.",
+  "structures.bulkUploadStructuresDomains.success.header":
+    "Bulk update completed. Loaded {count_ids} errors {count_errors}",
+
   "structures.crumbs.top": "Structures",
   "structures.edit.bulk.confirmation.content":
     "{structures_count} structures will be updated. Are you sure?",
@@ -445,6 +462,7 @@ export default {
   "structures.uploadStructures.failed.external_id_not_exist":
     "Invalid External Id",
   "structures.uploadStructures.failed.header": "Upload Failed!",
+  "structures.uploadStructuresDomains.failed.header": "Upload Failed!",
   "structures.uploadStructures.failed.invalid_file_format":
     "Invalid file format",
   "structures.uploadStructures.failed.note.df_content.default":

package/src/messages/es.js

@@ -375,9 +375,15 @@ export default {
   "structures.actions.new_system": "Nuevo sistema",
   "structures.actions.upload": "Subir fichero",
   "structures.actions.upload.confirmation.content": "Notas",
+  "structures.actions.uploadDomains.confirmation.content":
+    "Dominios de estructuras",
   "structures.actions.upload.confirmation.header":
     "Subir fichero de notas de estructuras",
+  "structures.actions.uploadDomains.confirmation.header":
+    "Subir fichero de dominios de estructuras",
   "structures.actions.upload.tooltip": "Subir notas de estructuras",
+  "structures.actions.uploadDomains.tooltip":
+    "Actualizar dominios de estructuras",
   "structures.bulkUpdate.crumbs.top": "Actualización masiva",
   "structures.bulkUpdate.success.content":
     "Se han actualizado {count} estructuras",
@@ -395,12 +401,24 @@ export default {
     "¡Actualización finalizada! subidos {count_ids} errores {count_errors}",
   "structures.bulkUpdateStructures.success.errors":
     "Error en external id {externalId}, mensaje: {message}",
+  "structures.bulkUploadStructuresDomains.success.errors.domain: not_exist":
+    "Error en linea {row}, en external id {externalId}, el dominio no existe",
+  "structures.bulkUploadStructuresDomains.success.errors.structure: not_exist":
+    "Error en linea {row}, en external id {externalId}, la estructura no existe",
+  "structures.bulkUploadStructuresDomains.success.errors.update_domain: forbbiden":
+    "Error en linea {row}, en external id {externalId}, no tiene permisos para actualizar",
+  "structures.bulkUploadStructuresDomains.success.errors.domain_ids: must be a non-empty list":
+    "Error en linea {row}, en external id {externalId}, domain_ids no puede ser una lista vacia",
   "structures.bulkUploadStructures.success.errors":
     "Error en linea {row}, en external id {externalId} mensaje: {message}",
+  "structures.bulkUploadStructuresDomains.success.errors":
+    "Error en linea {row}, en external id {externalId} mensaje: {message}",
   "structures.bulkUpdateStructures.success.unchanged":
     "{unchanged} se han mantenido sin cambios.",
   "structures.bulkUpdateStructures.success.updated":
     "Se han actualizado {changed} estructuras.",
+  "structures.bulkUploadStructuresDomains.success.header":
+    "¡Actualización finalizada! subidos {count_ids} errores {count_errors}",
   "structures.crumbs.top": "Estructuras",
   "structures.edit.bulk.confirmation.content":
     "Se van a actualizar {structures_count} estructuras. ¿Estás seguro?",
@@ -453,6 +471,8 @@ export default {
     "External Id Inválido",
   "structures.uploadStructures.failed.header":
     "Error al subir el fichero. El contenido no se ha actualizado",
+  "structures.uploadStructuresDomains.failed.header":
+    "Error al subir el fichero. El contenido no se ha actualizado",
   "structures.uploadStructures.failed.invalid_file_format":
     "Formato de fichero inválido",
   "structures.uploadStructures.failed.note.df_content.default":

package/src/reducers/__tests__/ddMessage.spec.js

@@ -0,0 +1,76 @@
+import { uploadStructuresDomains } from "../../routines";
+import { ddMessage } from "..";
+
+const fooState = { foo: "bar" };
+
+describe("reducers: ddMessage", () => {
+  const initialState = null;
+
+  it("should provide the initial state", () => {
+    expect(ddMessage(undefined, {})).toEqual(initialState);
+  });
+
+  it("should handle the uploadStructuresDomains.SUCCESS action returning some errored rows", () => {
+    const ddMsg = ddMessage(fooState, {
+      type: uploadStructuresDomains.SUCCESS,
+      payload: {
+        data: {
+          errors: [
+            {
+              external_id: "postgres://Postgres-Test/postgres/public/city/city_id",
+              message: {
+                external_domain_ids: ["must exist: UEUEUEU"],
+              },
+              row: 3,
+            },
+            {
+              external_id:
+                "postgres://Postgres-Test/postgres/public/city/city_name",
+              message: {
+                external_domain_ids: ["must exist: NANDAKA, JAJAJA"],
+              },
+              row: 4,
+            },
+          ],
+          ids: [5375339],
+        },
+      },
+    });
+
+    expect(ddMsg).toMatchObject({
+      error: false,
+      header: "structures.bulkUploadStructuresDomains.success.header",
+      icon: "check",
+      color: "orange",
+      fields: { count_errors: 2, count_ids: 1}
+    });
+    const { messages: errors } = ddMsg;
+    expect(errors.length).toEqual(2);
+  });
+
+  it("should handle the uploadStructuresDomains.FAILURE action", () => {
+    const ddMsg = ddMessage(fooState, {
+      type: uploadStructuresDomains.FAILURE,
+      payload: {
+        status: 422,
+        data: {
+          error: {
+            message:
+              "invalid_headers, must be: external_id, domain_external_ids",
+          },
+        },
+      },
+    });
+
+    expect(ddMsg).toMatchObject({
+      error: true,
+      header: "structures.uploadStructuresDomains.failed.header",
+      icon: "attention",
+      content: "invalid_headers, must be: external_id, domain_external_ids",
+    });
+  });
+
+
+
+
+});

package/src/reducers/ddMessage.js

@@ -4,6 +4,7 @@ import {
   bulkUpdateStructures,
   uploadStructures,
   updateStructureType,
+  uploadStructuresDomains,
 } from "../routines";
 
 const initialState = null;
@@ -18,10 +19,7 @@ const ddMessage = (state = initialState, { type, payload }) => {
         ? _.flow(
             _.propOr([], "errors"),
             _.map((error) => ({
-              id:
-                type == bulkUpdateStructures.SUCCESS
-                  ? `structures.bulkUpdateStructures.failed.note.${error.message}`
-                  : `structures.uploadStructures.failed.note.${error.message}`,
+              id: `structures.bulkUpdateStructures.failed.note.${error.message}`,
               fields: {
                 row: error.row,
                 id: error.id,
@@ -29,10 +27,7 @@ const ddMessage = (state = initialState, { type, payload }) => {
                 externalId: error.external_id,
                 message: error.message,
               },
-              defaultMessage:
-                type == bulkUpdateStructures.SUCCESS
-                  ? "structures.bulkUpdateStructures.success.errors"
-                  : "structures.bulkUploadStructures.success.errors",
+              defaultMessage: "structures.bulkUploadStructures.success.errors",
             }))
           )(payload.data)
         : "";
@@ -51,6 +46,54 @@ const ddMessage = (state = initialState, { type, payload }) => {
         initialMaxListItems: 5,
       };
     }
+
+    case uploadStructuresDomains.SUCCESS: {
+      const messagesImp = _.has("errors")(payload.data)
+        ? _.flow(
+            _.propOr([], "errors"),
+            _.map((error) => {
+              const errorMessage = Object.entries(error.message)
+                .map(([field, messages]) => `${field}: ${messages.join(", ")}`)
+                .join(" | ");
+              return {
+                id: `structures.bulkUploadStructuresDomains.success.errors.${errorMessage}`,
+                fields: {
+                  row: error.row,
+                  id: error.id,
+                  field: error.field,
+                  externalId: error.external_id,
+                  message: errorMessage,
+                },
+              };
+            })
+          )(payload.data)
+        : "";
+      return {
+        error: false,
+        header: "structures.bulkUploadStructuresDomains.success.header",
+        icon: "check",
+        color: payload.data.errors.length >= 1 ? "orange" : "green",
+        text: "",
+        messages: messagesImp,
+        fields: {
+          count_ids: payload.data.ids.length,
+          count_errors: payload.data.errors.length,
+        },
+        downloadable: true,
+        initialMaxListItems: 5,
+      };
+    }
+
+    case uploadStructuresDomains.FAILURE:
+      return payload.status !== 422
+        ? state
+        : {
+            error: true,
+            header: "structures.uploadStructuresDomains.failed.header",
+            icon: "attention",
+            content: payload?.data?.error?.message,
+          };
+
     case updateStructureType.SUCCESS:
       return {
         error: false,

package/src/routines.js

@@ -132,6 +132,7 @@ export const updateStructureTag = createRoutine("UPDATE_STRUCTURE_TAG");
 export const updateStructureType = createRoutine("UPDATE_STRUCTURE_TYPE");
 export const updateSystem = createRoutine("UPDATE_SYSTEM");
 export const uploadStructures = createRoutine("UPLOAD_STRUCTURES");
+export const uploadStructuresDomains = createRoutine("UPLOAD_STRUCTURES_DOMAINS");
 export const addGrantRequestToCart = createRoutine("ADD_GRANT_REQUEST_TO_CART");
 export const removeGrantRequestFromCart = createRoutine(
   "REMOVE_GRANT_REQUEST_FROM_CART"

package/src/sagas/__tests__/uploadStructuresDomains.spec.js

@@ -0,0 +1,81 @@
+import { testSaga } from "redux-saga-test-plan";
+import { apiJsonPost, UPLOAD_JSON_OPTS } from "@truedat/core/services/api";
+import {
+  uploadStructuresDomainsRequestSaga,
+  uploadStructuresDomainsSaga,
+} from "../uploadStructuresDomains";
+import { uploadStructuresDomains } from "../../routines";
+import { API_STRUCTURES_DOMAINS_UPLOAD } from "../../api";
+
+describe("sagas: uploadStructuresDomainsRequestSaga", () => {
+  it("should invoke uploadStructuresDomainsSaga on trigger", () => {
+    expect(() => {
+      testSaga(uploadStructuresDomainsRequestSaga)
+        .next()
+        .takeLatest(
+          uploadStructuresDomains.TRIGGER,
+          uploadStructuresDomainsSaga
+        )
+        .finish()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should throw exception if an unhandled action is received", () => {
+    expect(() => {
+      testSaga(uploadStructuresDomainsRequestSaga)
+        .next()
+        .takeLatest("FOO", uploadStructuresDomainsSaga);
+    }).toThrow();
+  });
+});
+
+describe("sagas: uploadStructuresDomainsSaga", () => {
+  const body = { structures_domains: "content" };
+  const payload = { data: body };
+  const data = { message: [1, 2] };
+  it("should put a success action when a response is returned", () => {
+    expect(() => {
+      testSaga(uploadStructuresDomainsSaga, { payload })
+        .next()
+        .put(uploadStructuresDomains.request())
+        .next()
+        .call(
+          apiJsonPost,
+          API_STRUCTURES_DOMAINS_UPLOAD,
+          body,
+          UPLOAD_JSON_OPTS
+        )
+        .next({ data })
+        .put(uploadStructuresDomains.success({ data }))
+        .next()
+        .put(uploadStructuresDomains.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should put a failure action when the call returns an error", () => {
+    const message = "Request failed";
+    const error = { message };
+
+    expect(() => {
+      testSaga(uploadStructuresDomainsSaga, { payload })
+        .next()
+        .put(uploadStructuresDomains.request())
+        .next()
+        .call(
+          apiJsonPost,
+          API_STRUCTURES_DOMAINS_UPLOAD,
+          body,
+          UPLOAD_JSON_OPTS
+        )
+        .throw(error)
+        .put(uploadStructuresDomains.failure(message))
+        .next()
+        .put(uploadStructuresDomains.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+});

package/src/sagas/index.js

@@ -46,6 +46,7 @@ import { updateStructureTagRequestSaga } from "./updateStructureTag";
 import { updateStructureTypeRequestSaga } from "./updateStructureType";
 import { updateSystemRequestSaga } from "./updateSystem";
 import { uploadStructuresRequestSaga } from "./uploadStructures";
+import { uploadStructuresDomainsRequestSaga } from "./uploadStructuresDomains";
 import { operateGrantRequestToCartRequestSaga } from "./operateGrantRequestCart";
 
 export {
@@ -97,6 +98,7 @@ export {
   updateStructureTypeRequestSaga,
   updateSystemRequestSaga,
   uploadStructuresRequestSaga,
+  uploadStructuresDomainsRequestSaga,
   operateGrantRequestToCartRequestSaga,
 };
 
@@ -149,5 +151,6 @@ export default [
   updateStructureTypeRequestSaga(),
   updateSystemRequestSaga(),
   uploadStructuresRequestSaga(),
+  uploadStructuresDomainsRequestSaga(),
   operateGrantRequestToCartRequestSaga(),
 ];

package/src/sagas/uploadStructuresDomains.js

@@ -0,0 +1,35 @@
+import { call, put, takeLatest } from "redux-saga/effects";
+import { apiJsonPost, UPLOAD_JSON_OPTS } from "@truedat/core/services/api";
+import { uploadStructuresDomains } from "../routines";
+import { API_STRUCTURES_DOMAINS_UPLOAD } from "../api";
+
+export function* uploadStructuresDomainsSaga({ payload }) {
+  try {
+    const { data: body } = payload;
+    yield put(uploadStructuresDomains.request());
+    const { data } = yield call(
+      apiJsonPost,
+      API_STRUCTURES_DOMAINS_UPLOAD,
+      body,
+      UPLOAD_JSON_OPTS
+    );
+
+    yield put(uploadStructuresDomains.success({ data }));
+  } catch (error) {
+    if (error.response) {
+      const { status, data } = error.response;
+      yield put(uploadStructuresDomains.failure({ status, data }));
+    } else {
+      yield put(uploadStructuresDomains.failure(error.message));
+    }
+  } finally {
+    yield put(uploadStructuresDomains.fulfill());
+  }
+}
+
+export function* uploadStructuresDomainsRequestSaga() {
+  yield takeLatest(
+    uploadStructuresDomains.TRIGGER,
+    uploadStructuresDomainsSaga
+  );
+}