@truedat/dd 4.40.13 → 4.41.1

package/src/messages/en.js

@@ -150,6 +150,15 @@ export default {
   "navigation.lineage.view": "View in Data Catalog",
   "navigation.profile.executions": "Executions",
   "navigation.profile.executions.detail": "Detail",
+  "pendingStructureNotes.header": "Pending Notes",
+  "pendingStructureNotes.subheader": "Structure notes pending some action",
+  "pendingStructureNotes.props.structure": "Data Structure",
+  "pendingStructureNotes.props.status": "Status",
+  "pendingStructureNotes.props.system": "System",
+  "pendingStructureNotes.props.domains": "Domains",
+  "pendingStructureNotes.props.path": "Path",
+  "pendingStructureNotes.search.results.empty": "No structure notes found",
+  "pendingStructureNotes.filters": "Filters",
   "profile.completed.content": "{count} profiles completed.",
   "profile.completed.header": "Profiles completed.",
   "profile.pending.content":
@@ -362,9 +371,13 @@ export default {
   "structures.actions.new_system": "New system",
   "structures.actions.upload": "Upload file",
   "structures.actions.upload.confirmation.content": "Notes",
+  "structures.actions.uploadDomains.confirmation.content": "Structure domains",
   "structures.actions.upload.confirmation.header":
     "Upload notes file of structures",
+  "structures.actions.uploadDomains.confirmation.header":
+    "Upload structures domains file",
   "structures.actions.upload.tooltip": "Upload structure notes",
+  "structures.actions.uploadDomains.tooltip": "Update structure domains",
   "structures.bulkUpdate.crumbs.top": "Bulk update",
   "structures.bulkUpdate.success.content":
     "Updated {count} structures successfully",
@@ -382,12 +395,25 @@ export default {
     "Bulk update completed. Loaded {count_ids} errors {count_errors}",
   "structures.bulkUpdateStructures.success.errors":
     "Error in external id {externalId}, message: {message}",
+  "structures.bulkUploadStructuresDomains.success.errors.domain: not_exist":
+    "Error in line {row}, in external id {externalId}, domain does not exist",
+  "structures.bulkUploadStructuresDomains.success.errors.update_domain: forbbiden":
+    "Error in line {row}, in external id {externalId}, update forbbiden",
+  "structures.bulkUploadStructuresDomains.success.errors.domain_ids: must be a non-empty list":
+    "Error in line {row}, in external id {externalId}, domain_ids must be a non-empty list",
+  "structures.bulkUploadStructuresDomains.success.errors.structure: not_exist":
+    "Error in line {row}, in external id {externalId}, data structure does not exist",
   "structures.bulkUploadStructures.success.errors":
     "Error in line {row}, in external id {externalId}, message: {message}",
+  "structures.bulkUploadStructuresDomains.success.errors":
+    "Error in line {row}, in external id {externalId}, message: {message}",
   "structures.bulkUpdateStructures.success.unchanged":
     "{unchanged} structures remained unchanged.",
   "structures.bulkUpdateStructures.success.updated":
     "Updated {changed} structures successfully.",
+  "structures.bulkUploadStructuresDomains.success.header":
+    "Bulk update completed. Loaded {count_ids} errors {count_errors}",
+
   "structures.crumbs.top": "Structures",
   "structures.edit.bulk.confirmation.content":
     "{structures_count} structures will be updated. Are you sure?",
@@ -436,6 +462,7 @@ export default {
   "structures.uploadStructures.failed.external_id_not_exist":
     "Invalid External Id",
   "structures.uploadStructures.failed.header": "Upload Failed!",
+  "structures.uploadStructuresDomains.failed.header": "Upload Failed!",
   "structures.uploadStructures.failed.invalid_file_format":
     "Invalid file format",
   "structures.uploadStructures.failed.note.df_content.default":

package/src/messages/es.js

@@ -153,6 +153,16 @@ export default {
   "navigation.lineage.view": "Ver detalle",
   "navigation.profile.executions": "Ejecuciones",
   "navigation.profile.executions.detail": "Detalle",
+  "pendingStructureNotes.header": "Notas pendientes",
+  "pendingStructureNotes.subheader":
+    "Notas de estructuras pendientes de acción",
+  "pendingStructureNotes.props.structure": "Estructura",
+  "pendingStructureNotes.props.status": "Estado",
+  "pendingStructureNotes.props.system": "Sistema",
+  "pendingStructureNotes.props.domains": "Dominios",
+  "pendingStructureNotes.props.path": "Ruta",
+  "pendingStructureNotes.search.results.empty": "Ninguna nota encontrada",
+  "pendingStructureNotes.filters": "Filtros",
   "profile.completed.content": "Se han ejecutado {count} perfilados.",
   "profile.completed.header": "Ejecuciones finalizadas",
   "profile.pending.content":
@@ -365,9 +375,15 @@ export default {
   "structures.actions.new_system": "Nuevo sistema",
   "structures.actions.upload": "Subir fichero",
   "structures.actions.upload.confirmation.content": "Notas",
+  "structures.actions.uploadDomains.confirmation.content":
+    "Dominios de estructuras",
   "structures.actions.upload.confirmation.header":
     "Subir fichero de notas de estructuras",
+  "structures.actions.uploadDomains.confirmation.header":
+    "Subir fichero de dominios de estructuras",
   "structures.actions.upload.tooltip": "Subir notas de estructuras",
+  "structures.actions.uploadDomains.tooltip":
+    "Actualizar dominios de estructuras",
   "structures.bulkUpdate.crumbs.top": "Actualización masiva",
   "structures.bulkUpdate.success.content":
     "Se han actualizado {count} estructuras",
@@ -385,12 +401,24 @@ export default {
     "¡Actualización finalizada! subidos {count_ids} errores {count_errors}",
   "structures.bulkUpdateStructures.success.errors":
     "Error en external id {externalId}, mensaje: {message}",
+  "structures.bulkUploadStructuresDomains.success.errors.domain: not_exist":
+    "Error en linea {row}, en external id {externalId}, el dominio no existe",
+  "structures.bulkUploadStructuresDomains.success.errors.structure: not_exist":
+    "Error en linea {row}, en external id {externalId}, la estructura no existe",
+  "structures.bulkUploadStructuresDomains.success.errors.update_domain: forbbiden":
+    "Error en linea {row}, en external id {externalId}, no tiene permisos para actualizar",
+  "structures.bulkUploadStructuresDomains.success.errors.domain_ids: must be a non-empty list":
+    "Error en linea {row}, en external id {externalId}, domain_ids no puede ser una lista vacia",
   "structures.bulkUploadStructures.success.errors":
     "Error en linea {row}, en external id {externalId} mensaje: {message}",
+  "structures.bulkUploadStructuresDomains.success.errors":
+    "Error en linea {row}, en external id {externalId} mensaje: {message}",
   "structures.bulkUpdateStructures.success.unchanged":
     "{unchanged} se han mantenido sin cambios.",
   "structures.bulkUpdateStructures.success.updated":
     "Se han actualizado {changed} estructuras.",
+  "structures.bulkUploadStructuresDomains.success.header":
+    "¡Actualización finalizada! subidos {count_ids} errores {count_errors}",
   "structures.crumbs.top": "Estructuras",
   "structures.edit.bulk.confirmation.content":
     "Se van a actualizar {structures_count} estructuras. ¿Estás seguro?",
@@ -443,6 +471,8 @@ export default {
     "External Id Inválido",
   "structures.uploadStructures.failed.header":
     "Error al subir el fichero. El contenido no se ha actualizado",
+  "structures.uploadStructuresDomains.failed.header":
+    "Error al subir el fichero. El contenido no se ha actualizado",
   "structures.uploadStructures.failed.invalid_file_format":
     "Formato de fichero inválido",
   "structures.uploadStructures.failed.note.df_content.default":

package/src/reducers/__tests__/ddMessage.spec.js

@@ -0,0 +1,73 @@
+import { uploadStructuresDomains } from "../../routines";
+import { ddMessage } from "..";
+
+const fooState = { foo: "bar" };
+
+describe("reducers: ddMessage", () => {
+  const initialState = null;
+
+  it("should provide the initial state", () => {
+    expect(ddMessage(undefined, {})).toEqual(initialState);
+  });
+
+  it("should handle the uploadStructuresDomains.SUCCESS action returning some errored rows", () => {
+    const ddMsg = ddMessage(fooState, {
+      type: uploadStructuresDomains.SUCCESS,
+      payload: {
+        data: {
+          errors: [
+            {
+              external_id:
+                "postgres://Postgres-Test/postgres/public/city/city_id",
+              message: {
+                external_domain_ids: ["must exist: UEUEUEU"],
+              },
+              row: 3,
+            },
+            {
+              external_id:
+                "postgres://Postgres-Test/postgres/public/city/city_name",
+              message: {
+                external_domain_ids: ["must exist: NANDAKA, JAJAJA"],
+              },
+              row: 4,
+            },
+          ],
+          ids: [5375339],
+        },
+      },
+    });
+
+    expect(ddMsg).toMatchObject({
+      error: false,
+      header: "structures.bulkUploadStructuresDomains.success.header",
+      icon: "check",
+      color: "orange",
+      fields: { count_errors: 2, count_ids: 1 },
+    });
+    const { messages: errors } = ddMsg;
+    expect(errors.length).toEqual(2);
+  });
+
+  it("should handle the uploadStructuresDomains.FAILURE action", () => {
+    const ddMsg = ddMessage(fooState, {
+      type: uploadStructuresDomains.FAILURE,
+      payload: {
+        status: 422,
+        data: {
+          error: {
+            message:
+              "invalid_headers, must be: external_id, domain_external_ids",
+          },
+        },
+      },
+    });
+
+    expect(ddMsg).toMatchObject({
+      error: true,
+      header: "structures.uploadStructuresDomains.failed.header",
+      icon: "attention",
+      content: "invalid_headers, must be: external_id, domain_external_ids",
+    });
+  });
+});

package/src/reducers/ddMessage.js

@@ -4,6 +4,7 @@ import {
   bulkUpdateStructures,
   uploadStructures,
   updateStructureType,
+  uploadStructuresDomains,
 } from "../routines";
 
 const initialState = null;
@@ -18,10 +19,7 @@ const ddMessage = (state = initialState, { type, payload }) => {
         ? _.flow(
             _.propOr([], "errors"),
             _.map((error) => ({
-              id:
-                type == bulkUpdateStructures.SUCCESS
-                  ? `structures.bulkUpdateStructures.failed.note.${error.message}`
-                  : `structures.uploadStructures.failed.note.${error.message}`,
+              id: `structures.bulkUpdateStructures.failed.note.${error.message}`,
               fields: {
                 row: error.row,
                 id: error.id,
@@ -29,10 +27,7 @@ const ddMessage = (state = initialState, { type, payload }) => {
                 externalId: error.external_id,
                 message: error.message,
               },
-              defaultMessage:
-                type == bulkUpdateStructures.SUCCESS
-                  ? "structures.bulkUpdateStructures.success.errors"
-                  : "structures.bulkUploadStructures.success.errors",
+              defaultMessage: "structures.bulkUploadStructures.success.errors",
             }))
           )(payload.data)
         : "";
@@ -51,6 +46,54 @@ const ddMessage = (state = initialState, { type, payload }) => {
         initialMaxListItems: 5,
       };
     }
+
+    case uploadStructuresDomains.SUCCESS: {
+      const messagesImp = _.has("errors")(payload.data)
+        ? _.flow(
+            _.propOr([], "errors"),
+            _.map((error) => {
+              const errorMessage = Object.entries(error.message)
+                .map(([field, messages]) => `${field}: ${messages.join(", ")}`)
+                .join(" | ");
+              return {
+                id: `structures.bulkUploadStructuresDomains.success.errors.${errorMessage}`,
+                fields: {
+                  row: error.row,
+                  id: error.id,
+                  field: error.field,
+                  externalId: error.external_id,
+                  message: errorMessage,
+                },
+              };
+            })
+          )(payload.data)
+        : "";
+      return {
+        error: false,
+        header: "structures.bulkUploadStructuresDomains.success.header",
+        icon: "check",
+        color: payload.data.errors.length >= 1 ? "orange" : "green",
+        text: "",
+        messages: messagesImp,
+        fields: {
+          count_ids: payload.data.ids.length,
+          count_errors: payload.data.errors.length,
+        },
+        downloadable: true,
+        initialMaxListItems: 5,
+      };
+    }
+
+    case uploadStructuresDomains.FAILURE:
+      return payload.status !== 422
+        ? state
+        : {
+            error: true,
+            header: "structures.uploadStructuresDomains.failed.header",
+            icon: "attention",
+            content: payload?.data?.error?.message,
+          };
+
     case updateStructureType.SUCCESS:
       return {
         error: false,

package/src/routines.js

@@ -132,6 +132,9 @@ export const updateStructureTag = createRoutine("UPDATE_STRUCTURE_TAG");
 export const updateStructureType = createRoutine("UPDATE_STRUCTURE_TYPE");
 export const updateSystem = createRoutine("UPDATE_SYSTEM");
 export const uploadStructures = createRoutine("UPLOAD_STRUCTURES");
+export const uploadStructuresDomains = createRoutine(
+  "UPLOAD_STRUCTURES_DOMAINS"
+);
 export const addGrantRequestToCart = createRoutine("ADD_GRANT_REQUEST_TO_CART");
 export const removeGrantRequestFromCart = createRoutine(
   "REMOVE_GRANT_REQUEST_FROM_CART"

package/src/sagas/__tests__/uploadStructuresDomains.spec.js

@@ -0,0 +1,81 @@
+import { testSaga } from "redux-saga-test-plan";
+import { apiJsonPost, UPLOAD_JSON_OPTS } from "@truedat/core/services/api";
+import {
+  uploadStructuresDomainsRequestSaga,
+  uploadStructuresDomainsSaga,
+} from "../uploadStructuresDomains";
+import { uploadStructuresDomains } from "../../routines";
+import { API_STRUCTURES_DOMAINS_UPLOAD } from "../../api";
+
+describe("sagas: uploadStructuresDomainsRequestSaga", () => {
+  it("should invoke uploadStructuresDomainsSaga on trigger", () => {
+    expect(() => {
+      testSaga(uploadStructuresDomainsRequestSaga)
+        .next()
+        .takeLatest(
+          uploadStructuresDomains.TRIGGER,
+          uploadStructuresDomainsSaga
+        )
+        .finish()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should throw exception if an unhandled action is received", () => {
+    expect(() => {
+      testSaga(uploadStructuresDomainsRequestSaga)
+        .next()
+        .takeLatest("FOO", uploadStructuresDomainsSaga);
+    }).toThrow();
+  });
+});
+
+describe("sagas: uploadStructuresDomainsSaga", () => {
+  const body = { structures_domains: "content" };
+  const payload = { data: body };
+  const data = { message: [1, 2] };
+  it("should put a success action when a response is returned", () => {
+    expect(() => {
+      testSaga(uploadStructuresDomainsSaga, { payload })
+        .next()
+        .put(uploadStructuresDomains.request())
+        .next()
+        .call(
+          apiJsonPost,
+          API_STRUCTURES_DOMAINS_UPLOAD,
+          body,
+          UPLOAD_JSON_OPTS
+        )
+        .next({ data })
+        .put(uploadStructuresDomains.success({ data }))
+        .next()
+        .put(uploadStructuresDomains.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should put a failure action when the call returns an error", () => {
+    const message = "Request failed";
+    const error = { message };
+
+    expect(() => {
+      testSaga(uploadStructuresDomainsSaga, { payload })
+        .next()
+        .put(uploadStructuresDomains.request())
+        .next()
+        .call(
+          apiJsonPost,
+          API_STRUCTURES_DOMAINS_UPLOAD,
+          body,
+          UPLOAD_JSON_OPTS
+        )
+        .throw(error)
+        .put(uploadStructuresDomains.failure(message))
+        .next()
+        .put(uploadStructuresDomains.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+});

package/src/sagas/index.js

@@ -46,6 +46,7 @@ import { updateStructureTagRequestSaga } from "./updateStructureTag";
 import { updateStructureTypeRequestSaga } from "./updateStructureType";
 import { updateSystemRequestSaga } from "./updateSystem";
 import { uploadStructuresRequestSaga } from "./uploadStructures";
+import { uploadStructuresDomainsRequestSaga } from "./uploadStructuresDomains";
 import { operateGrantRequestToCartRequestSaga } from "./operateGrantRequestCart";
 
 export {
@@ -97,6 +98,7 @@ export {
   updateStructureTypeRequestSaga,
   updateSystemRequestSaga,
   uploadStructuresRequestSaga,
+  uploadStructuresDomainsRequestSaga,
   operateGrantRequestToCartRequestSaga,
 };
 
@@ -149,5 +151,6 @@ export default [
   updateStructureTypeRequestSaga(),
   updateSystemRequestSaga(),
   uploadStructuresRequestSaga(),
+  uploadStructuresDomainsRequestSaga(),
   operateGrantRequestToCartRequestSaga(),
 ];

package/src/sagas/uploadStructuresDomains.js

@@ -0,0 +1,35 @@
+import { call, put, takeLatest } from "redux-saga/effects";
+import { apiJsonPost, UPLOAD_JSON_OPTS } from "@truedat/core/services/api";
+import { uploadStructuresDomains } from "../routines";
+import { API_STRUCTURES_DOMAINS_UPLOAD } from "../api";
+
+export function* uploadStructuresDomainsSaga({ payload }) {
+  try {
+    const { data: body } = payload;
+    yield put(uploadStructuresDomains.request());
+    const { data } = yield call(
+      apiJsonPost,
+      API_STRUCTURES_DOMAINS_UPLOAD,
+      body,
+      UPLOAD_JSON_OPTS
+    );
+
+    yield put(uploadStructuresDomains.success({ data }));
+  } catch (error) {
+    if (error.response) {
+      const { status, data } = error.response;
+      yield put(uploadStructuresDomains.failure({ status, data }));
+    } else {
+      yield put(uploadStructuresDomains.failure(error.message));
+    }
+  } finally {
+    yield put(uploadStructuresDomains.fulfill());
+  }
+}
+
+export function* uploadStructuresDomainsRequestSaga() {
+  yield takeLatest(
+    uploadStructuresDomains.TRIGGER,
+    uploadStructuresDomainsSaga
+  );
+}