@truedat/dd 4.39.0 → 4.39.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.39.1] 2022-03-04
+
+### Added
+
+- [TD-4534] With inheritance option on structrue domain update
+
 ## [4.38.6] 2022-02-21
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "4.39.0",
+  "version": "4.39.1",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -107,5 +107,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "f3d2fe3fcdec546afc22d0a79c4f4f3dfb91ea48"
+  "gitHead": "834628cb0737cb7c874fce2bce891d23fe80e1d7"
 }

package/src/components/EditDomainForm.js

@@ -1,6 +1,6 @@
 import _ from "lodash/fp";
 import React, { useState } from "react";
-import { Button, Container, Form, Header } from "semantic-ui-react";
+import { Button, Checkbox, Container, Form, Header } from "semantic-ui-react";
 import { DomainDropdownSelector } from "@truedat/bg/components";
 import { linkTo } from "@truedat/core/routes";
 import PropTypes from "prop-types";
@@ -11,9 +11,14 @@ import { updateStructure } from "../routines";
 export const EditDomainForm = ({ title, updateStructure, structure }) => {
   const { formatMessage } = useIntl();
   const [domainId, setDomainId] = useState(null);
+  const [with_inheritance, set_with_inheritance] = useState(true);
 
   const onSubmit = () => {
-    const data_structure = { id: structure.id, domain_id: domainId };
+    const data_structure = {
+      id: structure.id,
+      domain_id: domainId,
+      with_inheritance,
+    };
     const redirect = linkTo.STRUCTURE_NOTES(data_structure);
 
     updateStructure({ data_structure, redirect });
@@ -33,11 +38,22 @@ export const EditDomainForm = ({ title, updateStructure, structure }) => {
         value={domainId || structure?.domain_id}
       />
 
+      <Checkbox
+        label={formatMessage({
+          id: "structureDomain.actions.update.with_inheritance",
+        })}
+        checked={with_inheritance}
+        onChange={(e) => {
+          set_with_inheritance(!with_inheritance);
+          e.preventDefault();
+        }}
+      />
+
       <Form onSubmit={onSubmit}>
         <div className="actions">
           <Button
             type="submit"
-            disabled={!Boolean(domainId)}
+            disabled={!Boolean(domainId) || domainId == structure?.domain_id}
             primary
             content={formatMessage({ id: "structureDomain.actions.update" })}
           />

package/src/components/__tests__/EditDomainForm.spec.js

@@ -26,11 +26,16 @@ describe("<EditDomainForm />", () => {
     en: {
       "structure.edit_domain.title": "Edit domain",
       "structureDomain.actions.update": "Update",
+      "structureDomain.actions.update.with_inheritance": "Apply on children",
       "domain.selector.label": "Domain",
       "domain.selector.placeholder": "Select a domain...",
     },
   };
 
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
   it("matches the latest snapshot", () => {
     const { container } = render(<EditDomainForm {...props} />, {
       state: { domains },
@@ -62,10 +67,41 @@ describe("<EditDomainForm />", () => {
     });
 
     const button = getByRole("button", { name: /update/i });
+    const checkbox = getByRole("checkbox");
+    const option = getByRole("option", { name: /Domain 1/i });
+
+    expect(button).toBeDisabled();
+    expect(checkbox).toBeChecked();
+    userEvent.click(option);
+    await waitFor(() => {
+      expect(button).not.toBeDisabled();
+    });
+    userEvent.click(button);
+    await waitFor(() => {
+      expect(updateStructure.mock.calls.length).toBe(1);
+    });
+    expect(updateStructure).toHaveBeenCalledWith(
+      expect.objectContaining({
+        data_structure: { domain_id: 1, id: 42, with_inheritance: true },
+        redirect: "/structures/42/notes",
+      })
+    );
+  });
+
+  it("invokes function when send button clicked with modified inheritance", async () => {
+    const { getByRole } = render(<EditDomainForm {...props} />, {
+      state: { domains },
+      messages,
+    });
+
+    const button = getByRole("button", { name: /update/i });
+    const checkbox = getByRole("checkbox");
     const option = getByRole("option", { name: /Domain 1/i });
 
     expect(button).toBeDisabled();
+    expect(checkbox).toBeChecked();
     userEvent.click(option);
+    userEvent.click(checkbox);
     await waitFor(() => {
       expect(button).not.toBeDisabled();
     });
@@ -75,7 +111,7 @@ describe("<EditDomainForm />", () => {
     });
     expect(updateStructure).toHaveBeenCalledWith(
       expect.objectContaining({
-        data_structure: { domain_id: 1, id: 42 },
+        data_structure: { domain_id: 1, id: 42, with_inheritance: false },
         redirect: "/structures/42/notes",
       })
     );

package/src/components/__tests__/__snapshots__/EditDomainForm.spec.js.snap

@@ -90,6 +90,21 @@ exports[`<EditDomainForm /> matches the latest snapshot 1`] = `
         </div>
       </div>
     </div>
+    <div
+      class="ui checked checkbox"
+    >
+      <input
+        checked=""
+        class="hidden"
+        readonly=""
+        tabindex="0"
+        type="checkbox"
+        value=""
+      />
+      <label>
+        Apply on children
+      </label>
+    </div>
     <form
       class="ui form"
     >

package/src/messages/en.js

@@ -314,6 +314,7 @@ export default {
   "structure.version.inserted_at": "Imported {when}",
   "structure.version.version": "Version {version}",
   "structureDomain.actions.update": "Update",
+  "structureDomain.actions.update.with_inheritance": "Apply on children",
   "structureSelector.union.criteria": "Union criteria",
   "structureTagForm.props.name": "Name",
   "structureTags.actions.create": "Create Structure Tag",

package/src/messages/es.js

@@ -318,6 +318,7 @@ export default {
   "structure.version.inserted_at": "Importada {when}",
   "structure.version.version": "Versión {version}",
   "structureDomain.actions.update": "Actualizar",
+  "structureDomain.actions.update.with_inheritance": "Aplicar en hijos",
   "structureSelector.union.criteria": "Criterio de unión",
   "structureTagForm.props.name": "Nombre",
   "structureTags.actions.create": "Crear Etiqueta de Estructura",