@truedat/dd 4.36.4 → 4.36.8

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.36.5] 2022-01-20
+
+### Added
+
+- [TD-4100] Long Alert error message CSV download link
+
 ## [4.36.3] 2022-01-18
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "4.36.4",
+  "version": "4.36.8",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -47,7 +47,7 @@
     "jest": "^27.0.6",
     "react": "^16.14.0",
     "react-dom": "^16.14.0",
-    "redux-saga-test-plan": "^4.0.1",
+    "redux-saga-test-plan": "^4.0.4",
     "rimraf": "^3.0.2",
     "semantic-ui-react": "^2.0.3"
   },
@@ -84,9 +84,9 @@
     ]
   },
   "dependencies": {
-    "@truedat/auth": "4.36.4",
-    "@truedat/core": "4.36.4",
-    "@truedat/df": "4.36.4",
+    "@truedat/auth": "4.36.8",
+    "@truedat/core": "4.36.8",
+    "@truedat/df": "4.36.8",
     "lodash": "^4.17.21",
     "path-to-regexp": "^1.7.0",
     "prop-types": "^15.7.2",
@@ -107,5 +107,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "4dbf4f9e5188b82b17d053b65e76506e60aa6722"
+  "gitHead": "b9b8ee80998b230697593b5d207d187971bc0724"
 }

package/src/components/StructureDeleteButton.js

@@ -1,6 +1,5 @@
 import React from "react";
 import PropTypes from "prop-types";
-import { bindActionCreators } from "redux";
 import { connect } from "react-redux";
 import { useIntl } from "react-intl";
 import { Button, Icon } from "semantic-ui-react";
@@ -24,11 +23,7 @@ export const StructureDeleteButton = ({ structure, deleteStructure }) => {
       content={formatMessage({
         id: "structure.actions.delete.confirmation.content",
       })}
-      handleSubmit={() =>
-        deleteStructure({
-          id: structure.id,
-        })
-      }
+      onConfirm={() => deleteStructure({ id: structure.id })}
       onOpen={(e) => e.stopPropagation()}
       onClone={(e) => e.stopPropagation()}
     />
@@ -39,14 +34,11 @@ StructureDeleteButton.propTypes = {
   structure: PropTypes.object,
   deleteStructure: PropTypes.func,
 };
-const mapDispatchToProps = (dispatch) =>
-  bindActionCreators({ deleteStructure }, dispatch);
 
 const mapStateToProps = ({ structure }) => ({
   structure,
 });
 
-export default connect(
-  mapStateToProps,
-  mapDispatchToProps
-)(StructureDeleteButton);
+export default connect(mapStateToProps, { deleteStructure })(
+  StructureDeleteButton
+);

package/src/components/StructureNoteActions.js

@@ -9,7 +9,7 @@ import { ConfirmModal, GroupActions } from "@truedat/core/components";
 import { linkTo } from "@truedat/core/routes";
 import { doStructureNoteAction } from "../routines";
 
-export const ModalDelete = ({ modalOnClick, modalAction, modalIcon }) => (
+export const ModalDelete = ({ modalOnConfirm, modalAction, modalIcon }) => (
   <ConfirmModal
     icon="trash"
     trigger={
@@ -34,11 +34,12 @@ export const ModalDelete = ({ modalOnClick, modalAction, modalIcon }) => (
         id={`structure.notes.actions.${modalAction}.confirmation.content`}
       />
     }
-    handleSubmit={modalOnClick}
+    onConfirm={modalOnConfirm}
   />
 );
+
 ModalDelete.propTypes = {
-  modalOnClick: PropTypes.func,
+  modalOnConfirm: PropTypes.func,
   modalText: PropTypes.object,
   modalAction: PropTypes.string,
 };
@@ -89,7 +90,7 @@ export const StructureNoteActions = ({
       return withModal(action)
         ? {
             ...baseAction,
-            modalOnClick: () =>
+            modalOnConfirm: () =>
               doStructureNoteAction({
                 action: data,
                 dataStructureId: structure?.id,

package/src/components/StructureTagsCards.js

@@ -65,9 +65,7 @@ export const StructureTagsCards = ({
                       />
                     )
                   }
-                  handleSubmit={() =>
-                    deleteStructureTag({ id: structureTag.id })
-                  }
+                  onConfirm={() => deleteStructureTag({ id: structureTag.id })}
                 />
               </div>
             </Card.Content>

package/src/components/StructuresBulkUpdate.js

@@ -186,7 +186,7 @@ export class StructuresBulkUpdate extends React.Component {
                     values={{ structures_count: structureCount }}
                   />
                 }
-                handleSubmit={this.handleSubmit}
+                onConfirm={this.handleSubmit}
               />
               <HistoryBackButton
                 content={<FormattedMessage id="actions.cancel" />}

package/src/components/__tests__/__snapshots__/StructureTagsCards.spec.js.snap

@@ -46,13 +46,13 @@ exports[`<StructureTagsCards /> matches the latest snapshot 1`] = `
                 }
               />
             }
-            handleSubmit={[Function]}
             header={
               <Memo(MemoizedFormattedMessage)
                 id="structureTags.actions.delete.confirmation.header"
               />
             }
             icon="trash"
+            onConfirm={[Function]}
             trigger={
               <Button
                 as="button"
@@ -109,13 +109,13 @@ exports[`<StructureTagsCards /> matches the latest snapshot 1`] = `
                 }
               />
             }
-            handleSubmit={[Function]}
             header={
               <Memo(MemoizedFormattedMessage)
                 id="structureTags.actions.delete.confirmation.header"
               />
             }
             icon="trash"
+            onConfirm={[Function]}
             trigger={
               <Button
                 as="button"

package/src/components/__tests__/__snapshots__/StructuresBulkUpdate.spec.js.snap

@@ -81,12 +81,12 @@ exports[`<StructuresBulkUpdate /> matches the latest snapshot 1`] = `
           }
         />
       }
-      handleSubmit={[Function]}
       header={
         <Memo(MemoizedFormattedMessage)
           id="structures.edit.bulk.confirmation.header"
         />
       }
+      onConfirm={[Function]}
       trigger={
         <Button
           as="button"

package/src/messages/en.js

@@ -1,7 +1,9 @@
 export default {
   "alert.createStructureTag.failed.header": "Error creating structure tag",
+  "alert.export.csv": "Export to CSV",
   "alert.linkStructureTag.failed.header": "Error linking tag to structure",
   "alert.saveStructureUserFilters.failed.header": "Error saving filter",
+  "alert.show.more": "Show more",
   "alert.updateStructureTag.failed.header": "Error editing structure tag",
   "alert.updateSystem.failed.header": "Error updating system",
   "createStructureTag.error.name.has already been taken":
@@ -363,15 +365,21 @@ export default {
   "structures.bulkUpdate.success.content":
     "Updated {count} structures successfully",
   "structures.bulkUpdate.success.header": "Succeded Bulk Update",
+  "structures.bulkUpdateStructures.failed.note.df_content.default":
+    "External id: {externalId} The field <{field}> is invalid",
+  "structures.bulkUpdateStructures.failed.note.df_content.inclusion":
+    "External id: {externalId} The field <{field}> does not have a permitted value",
+  "structures.bulkUpdateStructures.failed.note.df_content.required":
+    "External id: {externalId} The field <{field}> is required",
   "structures.bulkUpdateStructures.no.structures.body":
     "No structures selected",
   "structures.bulkUpdateStructures.no.structures.header": "Empty Search",
   "structures.bulkUpdateStructures.success.header":
-    "Bulk update success! Loaded {count_ids} omitted {count_errors}",
+    "Bulk update completed. Loaded {count_ids} errors {count_errors}",
   "structures.bulkUpdateStructures.success.errors":
-    "Error in id {id}, in {name} attribute: {key} message: {message}",
+    "Error in external id {externalId}, message: {message}",
   "structures.bulkUploadStructures.success.errors":
-    "Error in line {row}, in {name} attribute: {key} message: {message}",
+    "Error in line {row}, in external id {externalId}, message: {message}",
   "structures.bulkUpdateStructures.success.unchanged":
     "{unchanged} structures remained unchanged.",
   "structures.bulkUpdateStructures.success.updated":
@@ -427,11 +435,11 @@ export default {
   "structures.uploadStructures.failed.invalid_file_format":
     "Invalid file format",
   "structures.uploadStructures.failed.note.df_content.default":
-    "The field <{field}> in row {row} is invalid",
+    "External id: {externalId} The field <{field}> in row {row} is invalid",
   "structures.uploadStructures.failed.note.df_content.inclusion":
-    "The field <{field}> in row {row} does not have a permitted value",
+    "External id: {externalId} The field <{field}> in row {row} does not have a permitted value",
   "structures.uploadStructures.failed.note.df_content.required":
-    "The field <{field}> in row {row} is required",
+    "External id: {externalId} The field <{field}> in row {row} is required",
   "structures.uploadStructures.failed.note.insufficient_permissions":
     "Insufficient permissions to edit the structure in row {row}",
   "structures.uploadStructures.failed.note.only_draft_are_editable":

package/src/messages/es.js

@@ -1,8 +1,10 @@
 export default {
   "alert.createStructureTag.failed.header": "Error al crear Etiqueta",
+  "alert.export.csv": "Exportar a CSV",
   "alert.linkStructureTag.failed.header":
     "Error asociando etiqueta a estructura",
   "alert.saveStructureUserFilters.failed.header": "Error guardando filtro",
+  "alert.show.more": "Mostrar más",
   "alert.updateStructureTag.failed.header": "Error al editar Etiqueta",
   "alert.updateSystem.failed.header": "Error actualizando sistema",
   "createStructureTag.error.name.has already been taken":
@@ -368,13 +370,19 @@ export default {
   "structures.bulkUpdate.success.header": "Actualización terminada con éxito",
   "structures.bulkUpdateStructures.no.structures.body":
     "Ninguna estructura seleccionada",
+  "structures.bulkUpdateStructures.failed.note.df_content.default":
+    "External id: {externalId} El campo <{field}> es inválido",
+  "structures.bulkUpdateStructures.failed.note.df_content.inclusion":
+    "External id: {externalId} El campo <{field}> no tiene un valor permitido",
+  "structures.bulkUpdateStructures.failed.note.df_content.required":
+    "External id: {externalId} El campo <{field}> es necesario",
   "structures.bulkUpdateStructures.no.structures.header": "Búsqueda vacía",
   "structures.bulkUpdateStructures.success.header":
-    "¡Actualización realizada correctamente! subidos {count_ids} errores {count_errors}",
+    "¡Actualización finalizada! subidos {count_ids} errores {count_errors}",
   "structures.bulkUpdateStructures.success.errors":
-    "Error en id {id}, en {name} atributo: {key} mensaje: {message}",
+    "Error en external id {externalId}, mensaje: {message}",
   "structures.bulkUploadStructures.success.errors":
-    "Error en linea {row}, en {name} atributo: {key} mensaje: {message}",
+    "Error en linea {row}, en external id {externalId} mensaje: {message}",
   "structures.bulkUpdateStructures.success.unchanged":
     "{unchanged} se han mantenido sin cambios.",
   "structures.bulkUpdateStructures.success.updated":

package/src/reducers/ddMessage.js

@@ -20,17 +20,19 @@ const ddMessage = (state = initialState, { type, payload }) => {
             _.map((error) => ({
               id:
                 type == bulkUpdateStructures.SUCCESS
-                  ? "structures.bulkUpdateStructures.success.errors"
-                  : "structures.bulkUploadStructures.success.errors",
+                  ? `structures.bulkUpdateStructures.failed.note.${error.message}`
+                  : `structures.uploadStructures.failed.note.${error.message}`,
               fields: {
-                name: error.implementation_key,
-                key: Object.keys(error.message)[0],
-                message: error.message[Object.keys(error.message)[0]][0],
                 row: error.row,
                 id: error.id,
+                field: error.field,
+                externalId: error.external_id,
+                message: error.message,
               },
               defaultMessage:
-                "structures.bulkUpdateStructures.success.errors.default",
+                type == bulkUpdateStructures.SUCCESS
+                  ? "structures.bulkUpdateStructures.success.errors"
+                  : "structures.bulkUploadStructures.success.errors",
             }))
           )(payload.data)
         : "";
@@ -45,6 +47,8 @@ const ddMessage = (state = initialState, { type, payload }) => {
           count_ids: payload.data.ids.length,
           count_errors: payload.data.errors.length,
         },
+        downloadable: true,
+        initialMaxListItems: 5,
       };
     }
     case updateStructureType.SUCCESS: