@truedat/dd 4.36.1 → 4.36.5

package/CHANGELOG.md

@@ -1,10 +1,17 @@
 # Changelog
 
-## [4.36.1] 2022-01-13
+## [4.36.5] 2022-01-20
 
-### Changed
+### Added
+
+- [TD-4100] Long Alert error message CSV download link
+
+
+## [4.36.3] 2022-01-18
+
+### Added
 
-- [TD-2564] Structure filter messages for `has_field_child`
+- [TD-4100] Allow partial loads for notes in case that there are errors on the file
 
 ## [4.36.0] 2022-01-13
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "4.36.1",
+  "version": "4.36.5",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -84,9 +84,9 @@
     ]
   },
   "dependencies": {
-    "@truedat/auth": "4.36.1",
-    "@truedat/core": "4.36.1",
-    "@truedat/df": "4.36.1",
+    "@truedat/auth": "4.36.5",
+    "@truedat/core": "4.36.5",
+    "@truedat/df": "4.36.5",
     "lodash": "^4.17.21",
     "path-to-regexp": "^1.7.0",
     "prop-types": "^15.7.2",
@@ -107,5 +107,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "236b538f0fa3671bc4f3dc3bcfb26ea6bb9bbaee"
+  "gitHead": "dec36033435443b730ea93fa482ef1ca7dbf28a6"
 }

package/src/components/StructureSelectedFilters.js

@@ -37,11 +37,6 @@ const translations = (formatMessage, structureTypes) => ({
       id: `filters.with_profiling.raw.${v}`,
       defaultMessage: v,
     }),
-  "has_field_child.raw": (v) =>
-    formatMessage({
-      id: `filters.has_field_child.raw.${v}`,
-      defaultMessage: v,
-    }),
   linked_concepts_count: (v) =>
     formatMessage({
       id: `filters.linked_concepts_count.${v}`,

package/src/components/StructureSelectorInputFieldJoin.js

@@ -124,10 +124,14 @@ export const StructureSelectorInputFieldJoin = ({
   ];
   const deleteClause = (idx) => handleSelectField(removeAt(clauses, idx));
   const handleChange = (prop, idx) => (data) => {
-    const { data_structure_id: id, parent_index: parent_index } = data;
+    const {
+      data_structure_id: id,
+      parent_index: parent_index,
+      name: name,
+    } = data;
     const newClause = _.isNil(parent_index)
-      ? { ...clauses[idx], [prop]: { id } }
-      : { ...clauses[idx], [prop]: { id, parent_index } };
+      ? { ...clauses[idx], [prop]: { id, name } }
+      : { ...clauses[idx], [prop]: { id, parent_index, name } };
     const newClauses = _.set(`[${idx}]`, newClause)(clauses);
     handleSelectField(newClauses);
   };

package/src/components/__tests__/__snapshots__/GrantRequest.spec.js.snap

@@ -294,6 +294,7 @@ exports[`<GrantRequest /> matches the latest snapshot with approve actions 1`] =
                             <span
                               class="highlighted"
                             >
+                               
                               "foo"
                             </span>
                           </a>
@@ -560,6 +561,7 @@ exports[`<GrantRequest /> matches the latest snapshot with failed status 1`] = `
                             <span
                               class="highlighted"
                             >
+                               
                               "foo"
                             </span>
                           </a>

package/src/messages/en.js

@@ -1,7 +1,9 @@
 export default {
   "alert.createStructureTag.failed.header": "Error creating structure tag",
+  "alert.export.csv": "Export to CSV",
   "alert.linkStructureTag.failed.header": "Error linking tag to structure",
   "alert.saveStructureUserFilters.failed.header": "Error saving filter",
+  "alert.show.more": "Show more",
   "alert.updateStructureTag.failed.header": "Error editing structure tag",
   "alert.updateSystem.failed.header": "Error updating system",
   "createStructureTag.error.name.has already been taken":
@@ -30,9 +32,6 @@ export default {
   "filters.with_profiling.raw": "Profile",
   "filters.with_profiling.raw.false": "Without profile",
   "filters.with_profiling.raw.true": "With profile",
-  "filters.has_field_child.raw": "Child fields",
-  "filters.has_field_child.raw.false": "Without fields",
-  "filters.has_field_child.raw.true": "With fields",
   "grant.cell.direct_access": "Direct access",
   "grant.cell.end_date.null": "No expiration set",
   "grant.cell.end_date.same_user": "It's you",
@@ -366,10 +365,21 @@ export default {
   "structures.bulkUpdate.success.content":
     "Updated {count} structures successfully",
   "structures.bulkUpdate.success.header": "Succeded Bulk Update",
+  "structures.bulkUpdateStructures.failed.note.df_content.default":
+    "External id: {externalId} The field <{field}> is invalid",
+  "structures.bulkUpdateStructures.failed.note.df_content.inclusion":
+    "External id: {externalId} The field <{field}> does not have a permitted value",
+  "structures.bulkUpdateStructures.failed.note.df_content.required":
+    "External id: {externalId} The field <{field}> is required",
   "structures.bulkUpdateStructures.no.structures.body":
     "No structures selected",
   "structures.bulkUpdateStructures.no.structures.header": "Empty Search",
-  "structures.bulkUpdateStructures.success.header": "Succeded Bulk Update",
+  "structures.bulkUpdateStructures.success.header":
+    "Bulk update success! Loaded {count_ids} errors {count_errors}",
+  "structures.bulkUpdateStructures.success.errors":
+    "Error in external id {externalId}, message: {message}",
+  "structures.bulkUploadStructures.success.errors":
+    "Error in line {row}, in external id {externalId}, message: {message}",
   "structures.bulkUpdateStructures.success.unchanged":
     "{unchanged} structures remained unchanged.",
   "structures.bulkUpdateStructures.success.updated":
@@ -425,11 +435,11 @@ export default {
   "structures.uploadStructures.failed.invalid_file_format":
     "Invalid file format",
   "structures.uploadStructures.failed.note.df_content.default":
-    "The field <{field}> in row {row} is invalid",
+    "External id: {externalId} The field <{field}> in row {row} is invalid",
   "structures.uploadStructures.failed.note.df_content.inclusion":
-    "The field <{field}> in row {row} does not have a permitted value",
+    "External id: {externalId} The field <{field}> in row {row} does not have a permitted value",
   "structures.uploadStructures.failed.note.df_content.required":
-    "The field <{field}> in row {row} is required",
+    "External id: {externalId} The field <{field}> in row {row} is required",
   "structures.uploadStructures.failed.note.insufficient_permissions":
     "Insufficient permissions to edit the structure in row {row}",
   "structures.uploadStructures.failed.note.only_draft_are_editable":

package/src/messages/es.js

@@ -1,8 +1,10 @@
 export default {
   "alert.createStructureTag.failed.header": "Error al crear Etiqueta",
+  "alert.export.csv": "Exportar a CSV",
   "alert.linkStructureTag.failed.header":
     "Error asociando etiqueta a estructura",
   "alert.saveStructureUserFilters.failed.header": "Error guardando filtro",
+  "alert.show.more": "Mostrar más",
   "alert.updateStructureTag.failed.header": "Error al editar Etiqueta",
   "alert.updateSystem.failed.header": "Error actualizando sistema",
   "createStructureTag.error.name.has already been taken":
@@ -31,9 +33,6 @@ export default {
   "filters.with_profiling.raw": "Perfilado",
   "filters.with_profiling.raw.false": "Sin perfilado",
   "filters.with_profiling.raw.true": "Contiene perfilado",
-  "filters.has_field_child.raw": "Campos hijos",
-  "filters.has_field_child.raw.false": "Sin campos",
-  "filters.has_field_child.raw.true": "Tiene campos",
   "grant.cell.direct_access": "Acceso Directo",
   "grant.cell.end_date.null": "Sin fecha de expiración",
   "grant.cell.end_date.same_user": "Eres tú",
@@ -371,9 +370,19 @@ export default {
   "structures.bulkUpdate.success.header": "Actualización terminada con éxito",
   "structures.bulkUpdateStructures.no.structures.body":
     "Ninguna estructura seleccionada",
+  "structures.bulkUpdateStructures.failed.note.df_content.default":
+    "External id: {externalId} El campo <{field}> es inválido",
+  "structures.bulkUpdateStructures.failed.note.df_content.inclusion":
+    "External id: {externalId} El campo <{field}> no tiene un valor permitido",
+  "structures.bulkUpdateStructures.failed.note.df_content.required":
+    "External id: {externalId} El campo <{field}> es necesario",
   "structures.bulkUpdateStructures.no.structures.header": "Búsqueda vacía",
   "structures.bulkUpdateStructures.success.header":
-    "Actualización terminada con éxito",
+    "¡Actualización realizada correctamente! subidos {count_ids} errores {count_errors}",
+  "structures.bulkUpdateStructures.success.errors":
+    "Error en external id {externalId}, mensaje: {message}",
+  "structures.bulkUploadStructures.success.errors":
+    "Error en linea {row}, en external id {externalId} mensaje: {message}",
   "structures.bulkUpdateStructures.success.unchanged":
     "{unchanged} se han mantenido sin cambios.",
   "structures.bulkUpdateStructures.success.updated":

package/src/reducers/__tests__/graph.spec.js

@@ -3,7 +3,7 @@ import {
   clearGraph,
   clearStructure,
   fetchGraph,
-  fetchStructure
+  fetchStructure,
 } from "../../routines";
 
 const fooState = { foo: "bar" };

package/src/reducers/__tests__/structureImpactGraph.spec.js

@@ -3,7 +3,7 @@ import {
   clearStructure,
   fetchStructure,
   fetchStructureGraph,
-  createGraph
+  createGraph,
 } from "../../routines";
 
 const fooState = { foo: "bar" };
@@ -31,7 +31,7 @@ describe("reducers: structureImpactGraph", () => {
     expect(
       structureImpactGraph(fooState, {
         type: fetchStructureGraph.SUCCESS,
-        payload
+        payload,
       })
     ).toBe(data);
   });
@@ -42,7 +42,7 @@ describe("reducers: structureImpactGraph", () => {
     expect(
       structureImpactGraph(fooState, {
         type: createGraph.SUCCESS,
-        payload
+        payload,
       })
     ).toBe(data);
   });
@@ -53,7 +53,7 @@ describe("reducers: structureImpactGraph", () => {
     expect(
       structureImpactGraph(fooState, {
         type: createGraph.SUCCESS,
-        payload
+        payload,
       })
     ).toBe(fooState);
   });
@@ -64,7 +64,7 @@ describe("reducers: structureImpactGraph", () => {
     expect(
       structureImpactGraph(fooState, {
         type: fetchStructureGraph.SUCCESS,
-        payload
+        payload,
       })
     ).toBe(fooState);
   });

package/src/reducers/__tests__/structureLineageGraph.spec.js

@@ -31,7 +31,7 @@ describe("reducers: structureLineageGraph", () => {
     expect(
       structureLineageGraph(fooState, {
         type: fetchStructureGraph.SUCCESS,
-        payload
+        payload,
       })
     ).toBe(data);
   });
@@ -42,7 +42,7 @@ describe("reducers: structureLineageGraph", () => {
     expect(
       structureLineageGraph(fooState, {
         type: createGraph.SUCCESS,
-        payload
+        payload,
       })
     ).toBe(data);
   });
@@ -53,7 +53,7 @@ describe("reducers: structureLineageGraph", () => {
     expect(
       structureLineageGraph(fooState, {
         type: fetchStructureGraph.SUCCESS,
-        payload
+        payload,
       })
     ).toBe(fooState);
   });
@@ -64,7 +64,7 @@ describe("reducers: structureLineageGraph", () => {
     expect(
       structureLineageGraph(fooState, {
         type: createGraph.SUCCESS,
-        payload
+        payload,
       })
     ).toBe(fooState);
   });
@@ -75,7 +75,7 @@ describe("reducers: structureLineageGraph", () => {
     expect(
       structureLineageGraph(fooState, {
         type: fetchStructureGraph.SUCCESS,
-        payload
+        payload,
       })
     ).toBe(fooState);
   });

package/src/reducers/ddMessage.js

@@ -12,27 +12,43 @@ const ddMessage = (state = initialState, { type, payload }) => {
   switch (type) {
     case dismissAlert.TRIGGER:
       return initialState;
+    case uploadStructures.SUCCESS:
     case bulkUpdateStructures.SUCCESS: {
-      const { data, structureCount } = payload;
-      const changedMessage = {
-        id: "structures.bulkUpdateStructures.success.updated",
-        fields: { changed: _.size(data.message) },
-      };
-      const unchangedMessage = {
-        id: "structures.bulkUpdateStructures.success.unchanged",
-        fields: { unchanged: structureCount - _.size(data.message) },
-      };
-      const messages =
-        structureCount - _.size(data.message) > 0
-          ? [changedMessage, unchangedMessage]
-          : [changedMessage];
+      const messagesImp = _.has("errors")(payload.data)
+        ? _.flow(
+            _.propOr([], "errors"),
+            _.map((error) => ({
+              id:
+                type == bulkUpdateStructures.SUCCESS
+                  ? `structures.bulkUpdateStructures.failed.note.${error.message}`
+                  : `structures.uploadStructures.failed.note.${error.message}`,
+              fields: {
+                row: error.row,
+                id: error.id,
+                field: error.field,
+                externalId: error.external_id,
+                message: error.message,
+              },
+              defaultMessage:
+                type == bulkUpdateStructures.SUCCESS
+                  ? "structures.bulkUpdateStructures.success.errors"
+                  : "structures.bulkUploadStructures.success.errors",
+            }))
+          )(payload.data)
+        : "";
       return {
         error: false,
         header: "structures.bulkUpdateStructures.success.header",
         icon: "check",
-        color: "green",
+        color: payload.data.errors.length >= 1 ? "orange" : "green",
         text: "",
-        messages: messages,
+        messages: messagesImp,
+        fields: {
+          count_ids: payload.data.ids.length,
+          count_errors: payload.data.errors.length,
+        },
+        downloadable: true,
+        initialMaxListItems: 5,
       };
     }
     case updateStructureType.SUCCESS:
@@ -42,25 +58,6 @@ const ddMessage = (state = initialState, { type, payload }) => {
         icon: "check",
         color: "green",
       };
-    case uploadStructures.SUCCESS: {
-      const { data } = payload;
-      const count = _.flow(_.prop("message"), _.size)(data);
-      const content =
-        count === 0
-          ? "structures.uploadStructures.success.content.any"
-          : count === 1
-          ? "structures.uploadStructures.success.content.single"
-          : "structures.uploadStructures.success.content";
-      return {
-        error: false,
-        header: "structures.uploadStructures.success.header",
-        content,
-        icon: "check",
-        color: "green",
-        text: "",
-        fields: { count },
-      };
-    }
     case uploadStructures.FAILURE:
       if (payload.status != 500) {
         const { data } = payload;
@@ -69,24 +66,24 @@ const ddMessage = (state = initialState, { type, payload }) => {
         const field = _.path("errors.field")(data);
         const messages = _.has("errors")(data)
           ? _.flow(
-              _.propOr([], "errors"),
-              _.toPairs,
-              _.filter(([k, _v]) => k !== "row" && k !== "field"),
-              _.map(([k, v]) =>
-                _.map((e) => ({
-                  id: `structures.uploadStructures.failed.${k}.${e}`,
-                  fields: { row, field },
-                  defaultMessage: "structures.uploadStructures.failed.default",
-                }))(v)
-              ),
-              _.flatten
-            )(data)
-          : _.flow(_.path("error.message"), (m) => [
-              {
-                id: `structures.uploadStructures.failed.${m}`,
+            _.propOr([], "errors"),
+            _.toPairs,
+            _.filter(([k, _v]) => k !== "row" && k !== "field"),
+            _.map(([k, v]) =>
+              _.map((e) => ({
+                id: `structures.uploadStructures.failed.${k}.${e}`,
+                fields: { row, field },
                 defaultMessage: "structures.uploadStructures.failed.default",
-              },
-            ])(data);
+              }))(v)
+            ),
+            _.flatten
+          )(data)
+          : _.flow(_.path("error.message"), (m) => [
+            {
+              id: `structures.uploadStructures.failed.${m}`,
+              defaultMessage: "structures.uploadStructures.failed.default",
+            },
+          ])(data);
         return {
           error: true,
           header: "structures.uploadStructures.failed.header",

package/src/sagas/__tests__/bulkUpdateStructures.spec.js

@@ -55,7 +55,7 @@ describe("sagas: bulkUpdateStructuresSaga", () => {
         .next()
         .call(apiJsonPost, API_DATA_STRUCTURES_BULK_UPDATE, body, JSON_OPTS)
         .next({ data })
-        .put(bulkUpdateStructures.success({ ...data, structureCount }))
+        .put(bulkUpdateStructures.success({ data }))
         .next()
         .put(bulkUpdateStructures.fulfill())
         .next()

package/src/sagas/__tests__/uploadStructures.spec.js

@@ -2,7 +2,7 @@ import { testSaga } from "redux-saga-test-plan";
 import { apiJsonPost, UPLOAD_JSON_OPTS } from "@truedat/core/services/api";
 import {
   uploadStructuresRequestSaga,
-  uploadStructuresSaga
+  uploadStructuresSaga,
 } from "../uploadStructures";
 import { uploadStructures } from "../../routines";
 import { API_STRUCTURES_UPLOAD } from "../../api";
@@ -39,7 +39,7 @@ describe("sagas: uploadStructuresSaga", () => {
         .next()
         .call(apiJsonPost, API_STRUCTURES_UPLOAD, body, UPLOAD_JSON_OPTS)
         .next({ data })
-        .put(uploadStructures.success(data))
+        .put(uploadStructures.success({ data }))
         .next()
         .put(uploadStructures.fulfill())
         .next()

package/src/sagas/bulkUpdateStructures.js

@@ -22,7 +22,7 @@ export function* bulkUpdateStructuresSaga({ payload }) {
       body,
       JSON_OPTS
     );
-    yield put(bulkUpdateStructures.success({ ...data, structureCount }));
+    yield put(bulkUpdateStructures.success({ data }));
   } catch (error) {
     if (error.response) {
       const { status, data } = error.response;

package/src/sagas/uploadStructures.js

@@ -14,7 +14,7 @@ export function* uploadStructuresSaga({ payload }) {
       UPLOAD_JSON_OPTS
     );
 
-    yield put(uploadStructures.success(data));
+    yield put(uploadStructures.success({ data }));
   } catch (error) {
     if (error.response) {
       const { status, data } = error.response;