@truedat/dd 4.35.0 → 4.35.4

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # Changelog
 
+## [4.35.4] 2021-12-20
+
+### Fixed
+
+- # [TD-4356] Improve structure types view performance by doing optional the metadata fields column
+
+## [4.35.3] 2021-12-20
+
+### Fixed
+
+- [TD-4369] 504 error on /api/data_structure_types call
+
+## [4.35.1] 2021-12-18
+
+### Added
+
+- [TD-4388] Display polling lineage in its data catalog tab
+
 ## [4.35.0] 2021-12-16
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dd",
-  "version": "4.35.0",
+  "version": "4.35.4",
   "description": "Truedat Web Data Dictionary",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -84,9 +84,9 @@
     ]
   },
   "dependencies": {
-    "@truedat/auth": "4.34.2",
-    "@truedat/core": "4.34.2",
-    "@truedat/df": "4.34.2",
+    "@truedat/auth": "4.35.4",
+    "@truedat/core": "4.35.4",
+    "@truedat/df": "4.35.4",
     "lodash": "^4.17.21",
     "path-to-regexp": "^1.7.0",
     "prop-types": "^15.7.2",
@@ -107,5 +107,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "334017e98230462a4f072fa697eee6f90c1b0b31"
+  "gitHead": "b03fba26635e365bbab64a6de1dd9a155925b5d1"
 }

package/src/components/DictionaryRoutes.js

@@ -77,7 +77,7 @@ export const DictionaryRoutes = () => {
         path={STRUCTURE_TYPES}
         render={() => (
           <>
-            <StructureTypesLoader />
+            <StructureTypesLoader liteRequest={true} />
             <StructureTypesRoutes />
           </>
         )}

package/src/components/StructureGraph.js

@@ -2,12 +2,11 @@ import _ from "lodash/fp";
 import React, { useEffect } from "react";
 import PropTypes from "prop-types";
 import { connect } from "react-redux";
-import { createStructureGraph, fetchStructureGraph } from "../routines";
-import GraphRedirector from "./GraphRedirector";
+import { createGraph, fetchStructureGraph } from "../routines";
 import LineageGraph from "./LineageGraph";
 
 export const StructureGraph = ({
-  createStructureGraph,
+  createGraph,
   degree,
   fetchStructureGraph,
   graph,
@@ -16,23 +15,16 @@ export const StructureGraph = ({
   type,
 }) => {
   useEffect(() => {
-    degree &&
-      _.isEmpty(graph) &&
-      createStructureGraph({ ids: [id], type: type });
+    degree && _.isEmpty(graph) && createGraph({ ids: [id], type: type });
   }, [type]);
   useEffect(() => {
     graphId && _.isEmpty(graph) && fetchStructureGraph({ id: graphId });
   }, [graphId]);
-  return degree ? (
-    <>
-      <GraphRedirector />
-      <LineageGraph height="50vh" graph={graph} />
-    </>
-  ) : null;
+  return degree ? <LineageGraph height="50vh" graph={graph} /> : null;
 };
 
 StructureGraph.propTypes = {
-  createStructureGraph: PropTypes.func,
+  createGraph: PropTypes.func,
   fetchStructureGraph: PropTypes.func,
   degree: PropTypes.object,
   graph: PropTypes.object,
@@ -47,6 +39,6 @@ const mapStateToProps = ({ structure }) => ({
 });
 
 export default connect(mapStateToProps, {
-  createStructureGraph,
+  createGraph,
   fetchStructureGraph,
 })(StructureGraph);

package/src/components/StructureLineage.js

@@ -5,7 +5,7 @@ import { Grid } from "semantic-ui-react";
 import StructureGraph from "./StructureGraph";
 import LineageDownloadButton from "./LineageDownloadButton";
 
-export const StructureLineage = props => (
+export const StructureLineage = (props) => (
   <>
     <Grid>
       <Grid.Row>
@@ -18,17 +18,14 @@ export const StructureLineage = props => (
   </>
 );
 
-const mapStateToProps = ({
-  structureLineageId: graphId,
-  structureLineageGraph: graph
-}) => ({
+const mapStateToProps = ({ structureLineageId: graphId, graph: graph }) => ({
   graph,
   graphId,
-  type: "lineage"
+  type: "lineage",
 });
 
 StructureLineage.propTypes = {
-  graph: PropTypes.object
+  graph: PropTypes.object,
 };
 
 export default connect(mapStateToProps)(StructureLineage);

package/src/components/StructureSelector.js

@@ -35,7 +35,7 @@ export const StructureSelector = ({
   return (
     <Segment>
       <StructuresLoader pageSize={pageSize} defaultFilters={defaultFilters} />
-      <StructureTypesLoader />
+      <StructureTypesLoader liteRequest={true} />
       <StructureFiltersLoader defaultFilters={defaultFilters} />
       <StructuresSearch />
       <StructureSelectedFilters />

package/src/components/StructureTypesTable.js

@@ -33,6 +33,7 @@ export const StructureTypeRow = ({
   translation,
   metadata_fields,
   metadata_views,
+  hasMetadataFields,
 }) => (
   <Table.Row>
     <Table.Cell>
@@ -49,7 +50,9 @@ export const StructureTypeRow = ({
     <Table.Cell>
       {_.flow(_.map("name"), _.join(", "))(metadata_views)}
     </Table.Cell>
-    <Table.Cell className="text-right">{metadata_fields?.length}</Table.Cell>
+    {hasMetadataFields && (
+      <Table.Cell className="text-right">{metadata_fields?.length}</Table.Cell>
+    )}
   </Table.Row>
 );
 
@@ -64,6 +67,8 @@ StructureTypeRow.propTypes = {
 
 export const StructureTypesTable = ({ structureTypes, loading }) => {
   const { formatMessage } = useIntl();
+  const hasMetadataFields =
+    _.filter("metadata_fields")(structureTypes).length > 0;
   return loading ? null : (
     <Table basic definition>
       <Table.Header>
@@ -78,15 +83,21 @@ export const StructureTypesTable = ({ structureTypes, loading }) => {
           <Table.HeaderCell
             content={formatMessage({ id: "structureType.metadataViews" })}
           />
-          <Table.HeaderCell
-            className="text-right"
-            content={formatMessage({ id: "structureType.metadataFields" })}
-          />
+          {hasMetadataFields && (
+            <Table.HeaderCell
+              className="text-right"
+              content={formatMessage({ id: "structureType.metadataFields" })}
+            />
+          )}
         </Table.Row>
       </Table.Header>
       <Table.Body>
         {structureTypes.map((props, key) => (
-          <StructureTypeRow key={key} {...props} />
+          <StructureTypeRow
+            key={key}
+            {...props}
+            hasMetadataFields={hasMetadataFields}
+          />
         ))}
       </Table.Body>
     </Table>

package/src/components/__tests__/__snapshots__/StructureSelector.spec.js.snap

@@ -5,7 +5,9 @@ exports[`<StructureSelector /> matches the latest snapshot 1`] = `
   <Connect(StructuresLoader)
     pageSize={7}
   />
-  <Connect(StructureTypesLoader) />
+  <Connect(StructureTypesLoader)
+    liteRequest={true}
+  />
   <Connect(FiltersLoader) />
   <Connect(StructuresSearch) />
   <injectIntl(Connect(SelectedFilters)) />