@truedat/core 8.3.0 → 8.3.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/core",
-  "version": "8.3.0",
+  "version": "8.3.2",
   "description": "Truedat Web Core",
   "sideEffects": false,
   "module": "src/index.js",
@@ -48,7 +48,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.3.0",
+    "@truedat/test": "8.3.2",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -85,5 +85,5 @@
     "slate-react": "^0.22.10",
     "swr": "^2.3.3"
   },
-  "gitHead": "d1abe685a3ae0cd2999e7bb62d3c0fd56522095f"
+  "gitHead": "ed0c289882710d6df3483692fab5833747130cbf"
 }

package/src/components/UploadJobParser.js

@@ -18,9 +18,7 @@ export const StatusPill = ({ status }) => (
     ])(status)}
     size="small"
   >
-    <FormattedMessage
-      id={`uploadJob.parser.event.status.${status}`}
-    />
+    <FormattedMessage id={`uploadJob.parser.event.status.${status}`} />
   </Label>
 );
 
@@ -64,9 +62,8 @@ const SheetAndLine = ({ response }) => (
     {response.row_number ? (
       <span>
         {" "}
-        -{" "}
-        <FormattedMessage id="uploadJob.parser.result.prop.row_number" />
-        : {response.row_number}
+        - <FormattedMessage id="uploadJob.parser.result.prop.row_number" />:{" "}
+        {response.row_number}
       </span>
     ) : null}
   </Label>
@@ -90,7 +87,7 @@ const externalIdDetailValue = (details) =>
       external_id={details.external_id}
     />
   ) : (
-    details?.external_id ?? ""
+    (details?.external_id ?? "")
   );
 
 const ErrorDetail = ({ response }) => {
@@ -131,18 +128,20 @@ const ErrorDetail = ({ response }) => {
       ],
     ],
     implementation_creation_error: (details) => {
-      return details?.map(detail => {
-        if (_.isArray(detail)) {
-          const [field, [error]] = detail;
-          return [field, error]
-        }
+      return (
+        details?.map((detail) => {
+          if (_.isArray(detail)) {
+            const [field, [error]] = detail;
+            return [field, error];
+          }
 
-        if (_.isObject(detail)) {
-          return [detail.field, detail.message]
-        }
+          if (_.isObject(detail)) {
+            return [detail.field, detail.message];
+          }
 
-        return detail;
-      }) || []
+          return detail;
+        }) || []
+      );
     },
     duplicate_field_names: (details) => [
       [
@@ -152,41 +151,60 @@ const ErrorDetail = ({ response }) => {
     ],
     pending_approval_conflict: (details) =>
       [
-        [formatMessage({ id: `${messagePrefix}.message` }), details?.message ?? ""],
-        [formatMessage({ id: `${messagePrefix}.externalId` }), externalIdDetailValue(details)],
+        [
+          formatMessage({ id: `${messagePrefix}.message` }),
+          details?.message ?? "",
+        ],
+        [null, externalIdDetailValue(details)],
       ].filter(([, v]) => v !== undefined && v !== ""),
     data_structure_not_found: (details) => [
-      [formatMessage({ id: `${messagePrefix}.externalId` }), externalIdDetailValue(details)],
-    ],
-    template_not_found: (details) => [
-      [formatMessage({ id: `${messagePrefix}.externalId` }), externalIdDetailValue(details)],
-    ],
-    unauthorized: (details) => [
-      [formatMessage({ id: `${messagePrefix}.externalId` }), externalIdDetailValue(details)],
+      [null, externalIdDetailValue(details)],
     ],
+    template_not_found: (details) => [[null, externalIdDetailValue(details)]],
+    unauthorized: (details) => [[null, externalIdDetailValue(details)]],
     unreject_failed: (details) =>
       [
-        [formatMessage({ id: `${messagePrefix}.reason` }), details?.reason ?? ""],
-        [formatMessage({ id: `${messagePrefix}.externalId` }), externalIdDetailValue(details)],
+        [
+          formatMessage({ id: `${messagePrefix}.reason` }),
+          details?.reason ?? "",
+        ],
+        [null, externalIdDetailValue(details)],
       ].filter(([, v]) => v !== undefined && v !== ""),
     field_validation_error: (details) =>
       details?.errors?.map((e) => [
         e?.field ?? formatMessage({ id: `${messagePrefix}.message` }),
         e?.message ?? "",
-      ]) ?? [[formatMessage({ id: `${messagePrefix}.externalId` }), externalIdDetailValue(details)]],
-    unprocessable_entity: (details) => [
-      [formatMessage({ id: `${messagePrefix}.externalId` }), externalIdDetailValue(details)],
-    ],
+      ]) ?? [[null, externalIdDetailValue(details)]],
+    unprocessable_entity: (details) => [[null, externalIdDetailValue(details)]],
     structure_note_creation_error: (details) => {
+      const reason = details?.reason ?? details?.error;
+
+      const reasonMessageId =
+        reason != null
+          ? `structures.uploadStructures.failed.note.${reason}`
+          : null;
+
       const errorPairs = details?.errors?.length
         ? details.errors.map((e) => [
-          e?.field ?? formatMessage({ id: `${messagePrefix}.message` }),
-          e?.message ?? "",
-        ])
-        : [[formatMessage({ id: `${messagePrefix}.reason` }), String(details?.reason ?? details?.error ?? "")]];
+            e?.field ?? formatMessage({ id: `${messagePrefix}.message` }),
+            e?.message ?? "",
+          ])
+        : [
+            [
+              formatMessage({ id: `${messagePrefix}.reason` }),
+              reasonMessageId
+                ? formatMessage({
+                    id: reasonMessageId,
+                    defaultMessage: String(reason),
+                  })
+                : String(reason ?? ""),
+            ],
+          ];
+
       const externalIdPair = details?.external_id
-        ? [[formatMessage({ id: `${messagePrefix}.externalId` }), externalIdDetailValue(details)]]
+        ? [[null, externalIdDetailValue(details)]]
         : [];
+
       return [...errorPairs, ...externalIdPair];
     },
   };
@@ -195,12 +213,20 @@ const ErrorDetail = ({ response }) => {
 
   const details = _.cond([
     [_.isNil, _.constant([])],
-    [_.stubTrue, (d) => {
-      const result = detailBuilder(d);
-      return _.isArray(result) ? result : [];
-    }],
+    [
+      _.stubTrue,
+      (d) => {
+        const result = detailBuilder(d);
+        return _.isArray(result) ? result : [];
+      },
+    ],
   ])(response.details);
 
+  const visibleDetails = _.filter(
+    ([, value]) => value != null && value !== "",
+    details
+  );
+
   return (
     <div>
       <CellHeader
@@ -208,25 +234,25 @@ const ErrorDetail = ({ response }) => {
         response={response}
       />
 
-      {
-        _.isEmpty(details)
-          ? null
-          : details.map(([key, value], idx) => (
-            <div key={idx} style={{ paddingLeft: "10px" }}>
-              <span
-                style={{
-                  fontSize: "1em",
-                  fontWeight: "bold",
-                  paddingRight: "5px",
-                }}
-              >
-                {key}:
-              </span>
+      {_.isEmpty(visibleDetails)
+        ? null
+        : visibleDetails.map(([key, value], idx) => (
+            <div key={idx}>
+              {key != null && key !== "" ? (
+                <span
+                  style={{
+                    fontSize: "1em",
+                    fontWeight: "bold",
+                    paddingRight: "5px",
+                  }}
+                >
+                  {key}:
+                </span>
+              ) : null}
               {value}
             </div>
-          ))
-      }
-    </div >
+          ))}
+    </div>
   );
 };
 const summaryItems = [
@@ -268,36 +294,36 @@ const CompletedDetail = ({ response }) => {
         );
       }
       return result;
-    }
+    },
   ])(summaryItems);
 
   if (items.length === 0) return null;
 
-  return (
-    <span>&nbsp;|&nbsp;{items}&nbsp;|&nbsp;</span>
-  );
+  return <span>&nbsp;|&nbsp;{items}&nbsp;|&nbsp;</span>;
 };
 
-
 const InfoDetail = ({ response }) =>
   !response || !response.type ? null : (
     <div>
       <CellHeader
-        header={`uploadJob.parser.info.${response.type}`}
+        header={
+          response.type === "unchanged" && response.details?.is_deprecated
+            ? "uploadJob.parser.info.deprecated_implementation"
+            : `uploadJob.parser.info.${response.type}`
+        }
         response={response}
       />
       {response.details ? (
         <div>
           {response.details.implementation_key != null ? (
             <RuleImplementationLink {...response.details} />
-          ) : (response.details.data_structure_id != null ||
-            response.details.external_id != null) ? (
+          ) : response.details.data_structure_id != null ||
+            response.details.external_id != null ? (
             <StructureNoteLink
               data_structure_id={response.details.data_structure_id}
               external_id={response.details.external_id}
             />
-          ) : null}
-          {" "}
+          ) : null}{" "}
         </div>
       ) : null}
       <ChangesDetail changes={response?.details?.changes} />
@@ -360,21 +386,21 @@ const ChangesDetail = ({
   );
 };
 
-
 const formatValue = (value, key) => {
   if (_.has("value")(value)) return formatValue(value.value, key);
   if (_.isArray(value)) {
-    return _.flow(_.map((v) => formatValue(v, key)), _.join(", "))(value);
+    return _.flow(
+      _.map((v) => formatValue(v, key)),
+      _.join(", ")
+    )(value);
   }
   if (_.isObject(value)) {
     if (_.has("document")(value))
       return <RichTextEditor readOnly value={value} />;
     if (_.has("url_value")(value))
       return `[${value.url_name}] (${value.url_value})`;
-    if (_.has("name")(value))
-      return value.name;
-    if (_.has("external_id")(value))
-      return value.external_id;
+    if (_.has("name")(value)) return value.name;
+    if (_.has("external_id")(value)) return value.external_id;
 
     return _.flow(_.keys, _.join(", "))(value);
   }

package/src/components/__tests__/UploadJobParser.spec.js

@@ -1,3 +1,4 @@
+import userEvent from "@testing-library/user-event";
 import { render } from "@truedat/test/render";
 import { StatusPill, ResponseCell } from "../UploadJobParser";
 
@@ -35,9 +36,7 @@ describe("<ResponseCell />", () => {
     const rendered = render(
       <ResponseCell response={response} status="FAILED" />
     );
-    expect(
-      rendered.getByText(/missing_required_headers/i)
-    ).toBeInTheDocument();
+    expect(rendered.getByText(/missing_required_headers/i)).toBeInTheDocument();
   });
 
   it("renders ERROR status with details", () => {
@@ -51,9 +50,7 @@ describe("<ResponseCell />", () => {
       <ResponseCell response={response} status="ERROR" />
     );
     expect(
-      rendered.getByText(
-        /uploadJob.parser.error.missing_required_headers/i
-      )
+      rendered.getByText(/uploadJob.parser.error.missing_required_headers/i)
     ).toBeInTheDocument();
     expect(rendered.getByText(/header1, header2/i)).toBeInTheDocument();
   });
@@ -87,12 +84,22 @@ describe("<ResponseCell />", () => {
     };
     const rendered = render(<ResponseCell response={response} status="INFO" />);
     expect(
-      rendered.getByText(
-        /uploadJob.parser.info.implementation_updated/i
-      )
+      rendered.getByText(/uploadJob.parser.info.implementation_updated/i)
     ).toBeInTheDocument();
   });
 
+  it("renders INFO status with deprecated_implementation specifically when unchanged and deprecated", () => {
+    const response = {
+      type: "unchanged",
+      details: {
+        id: 123,
+        is_deprecated: true,
+      },
+    };
+    const rendered = render(<ResponseCell response={response} status="INFO" />);
+    expect(rendered.getByText(/uploadJob.parser.info.deprecated_implementation/i)).toBeInTheDocument();
+  });
+
   it("renders default case for unknown status", () => {
     const response = "some text";
     const rendered = render(
@@ -100,4 +107,261 @@ describe("<ResponseCell />", () => {
     );
     expect(rendered.getByText(/some text/i)).toBeInTheDocument();
   });
+
+  it("renders ERROR status with structure_note_creation_error and translated workflow reason", () => {
+    const response = {
+      type: "structure_note_creation_error",
+      details: {
+        reason: "content_unchanged",
+        external_id: "EXT-001",
+        data_structure_id: 123,
+      },
+    };
+    const renderOpts = {
+      messages: {
+        en: {
+          "uploadJob.parser.error.structure_note_creation_error":
+            "Structure note error",
+          "uploadJob.parser.detail.reason": "Reason",
+          "uploadJob.parser.detail.externalId": "External id",
+          "structures.uploadStructures.failed.note.content_unchanged":
+            "Content unchanged",
+        },
+      },
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />,
+      renderOpts
+    );
+    expect(rendered.getByText(/structure note error/i)).toBeInTheDocument();
+    expect(rendered.getByText(/content unchanged/i)).toBeInTheDocument();
+  });
+
+  it("returns null when ERROR response has no type", () => {
+    const response = { details: {} };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />
+    );
+    expect(rendered.container.firstChild).toBeNull();
+  });
+
+  it("renders ERROR status with invalid_template_name details", () => {
+    const response = {
+      type: "invalid_template_name",
+      details: { template_name: "My Template" },
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />
+    );
+    expect(
+      rendered.getByText(/uploadJob.parser.error.invalid_template_name/i)
+    ).toBeInTheDocument();
+    expect(rendered.getByText(/My Template/i)).toBeInTheDocument();
+  });
+
+  it("renders ERROR status with duplicate_field_names details", () => {
+    const response = {
+      type: "duplicate_field_names",
+      details: { duplicate_fields: ["col_a", "col_b"] },
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />
+    );
+    expect(
+      rendered.getByText(/uploadJob.parser.error.duplicate_field_names/i)
+    ).toBeInTheDocument();
+    expect(rendered.getByText(/col_a, col_b/i)).toBeInTheDocument();
+  });
+
+  it("renders ERROR status with implementation_creation_error and array details", () => {
+    const response = {
+      type: "implementation_creation_error",
+      details: [
+        ["name", ["Name is required"]],
+        ["key", ["Key is invalid"]],
+      ],
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />
+    );
+    expect(
+      rendered.getByText(
+        /uploadJob.parser.error.implementation_creation_error/i
+      )
+    ).toBeInTheDocument();
+    expect(rendered.getByText(/Name is required/i)).toBeInTheDocument();
+    expect(rendered.getByText(/Key is invalid/i)).toBeInTheDocument();
+  });
+
+  it("renders ERROR status with implementation_creation_error and object details", () => {
+    const response = {
+      type: "implementation_creation_error",
+      details: [
+        { field: "name", message: "Invalid" },
+        { field: "key", message: "Duplicate" },
+      ],
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />
+    );
+    expect(rendered.getByText(/Invalid/i)).toBeInTheDocument();
+    expect(rendered.getByText(/Duplicate/i)).toBeInTheDocument();
+  });
+
+  it("renders ERROR status with field_validation_error details", () => {
+    const response = {
+      type: "field_validation_error",
+      details: {
+        errors: [
+          { field: "name", message: "Required" },
+          { field: "external_id", message: "Already exists" },
+        ],
+      },
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />
+    );
+    expect(
+      rendered.getByText(/uploadJob.parser.error.field_validation_error/i)
+    ).toBeInTheDocument();
+    expect(rendered.getByText(/Required/i)).toBeInTheDocument();
+    expect(rendered.getByText(/Already exists/i)).toBeInTheDocument();
+  });
+
+  it("renders ERROR status with deprecated_implementation details", () => {
+    const response = {
+      type: "deprecated_implementation",
+      details: { implementation_key: "old_impl_key" },
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />
+    );
+    expect(
+      rendered.getByText(/uploadJob.parser.error.deprecated_implementation/i)
+    ).toBeInTheDocument();
+    expect(rendered.getByText(/old_impl_key/i)).toBeInTheDocument();
+  });
+
+  it("renders ERROR status with unreject_failed details", () => {
+    const response = {
+      type: "unreject_failed",
+      details: { reason: "Workflow in progress" },
+    };
+    const renderOpts = {
+      messages: {
+        en: {
+          "uploadJob.parser.error.unreject_failed": "Unreject failed",
+          "uploadJob.parser.detail.reason": "Reason",
+        },
+      },
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />,
+      renderOpts
+    );
+    expect(rendered.getByText(/unreject failed/i)).toBeInTheDocument();
+    expect(rendered.getByText(/Workflow in progress/i)).toBeInTheDocument();
+  });
+
+  it("renders COMPLETED status with no summary when all counts are zero", () => {
+    const response = {
+      insert_count: 0,
+      update_count: 0,
+      unchanged_count: 0,
+      error_count: 0,
+      invalid_sheet_count: 0,
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="COMPLETED" />
+    );
+    expect(
+      rendered.queryByText(/uploadJob.parser.result.summary.created/i)
+    ).not.toBeInTheDocument();
+  });
+
+  it("renders default case with object response as JSON", () => {
+    const response = { code: "ERR_001", description: "Something failed" };
+    const rendered = render(
+      <ResponseCell response={response} status="UNKNOWN" />
+    );
+    expect(rendered.getByText(/"code":\s*"ERR_001"/i)).toBeInTheDocument();
+    expect(
+      rendered.getByText(/"description":\s*"Something failed"/i)
+    ).toBeInTheDocument();
+  });
+
+  it("renders INFO status with details.changes and expandable ChangesDetail", async () => {
+    const response = {
+      type: "implementation_updated",
+      details: {
+        changes: {
+          name: "New Name",
+          description: "Updated description",
+        },
+      },
+    };
+    const user = userEvent.setup({ delay: null });
+    const rendered = render(<ResponseCell response={response} status="INFO" />);
+    expect(
+      rendered.getByText(/uploadJob.parser.info.implementation_updated/i)
+    ).toBeInTheDocument();
+    expect(
+      rendered.getByText(/uploadJob.parser.result.prop.changes/i)
+    ).toBeInTheDocument();
+    expect(rendered.getByText(/\(2\)/)).toBeInTheDocument();
+    await user.click(
+      rendered.getByText(/uploadJob.parser.result.prop.changes/i).closest("div")
+    );
+    expect(rendered.getByText(/New Name/i)).toBeInTheDocument();
+    expect(rendered.getByText(/Updated description/i)).toBeInTheDocument();
+  });
+
+  it("renders INFO status with nested df_content in changes", async () => {
+    const response = {
+      type: "implementation_updated",
+      details: {
+        changes: {
+          df_content: {
+            inner_key: "inner_value",
+          },
+        },
+      },
+    };
+    const user = userEvent.setup({ delay: null });
+    const rendered = render(<ResponseCell response={response} status="INFO" />);
+    const changesHeader = rendered.getByText(
+      /uploadJob.parser.result.prop.changes/i
+    );
+    await user.click(changesHeader.closest("div"));
+    expect(
+      rendered.getByText(/ruleImplementations.props.df_content/i)
+    ).toBeInTheDocument();
+  });
+
+  it("renders ERROR with sheet and row_number in response", () => {
+    const response = {
+      type: "missing_required_headers",
+      sheet: "Sheet1",
+      row_number: 5,
+      details: { missing_headers: ["H1"] },
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />
+    );
+    expect(rendered.getByText(/Sheet1/i)).toBeInTheDocument();
+    expect(rendered.getByText(/5/)).toBeInTheDocument();
+  });
+
+  it("renders INFO status with null details", () => {
+    const response = { type: "some_info" };
+    const rendered = render(<ResponseCell response={response} status="INFO" />);
+    expect(
+      rendered.getByText(/uploadJob.parser.info.some_info/i)
+    ).toBeInTheDocument();
+  });
+
+  it("renders INFO status with null response as null", () => {
+    const rendered = render(<ResponseCell response={null} status="INFO" />);
+    expect(rendered.container.firstChild).toBeNull();
+  });
 });