@truedat/core 8.13.4 → 8.13.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/core",
-  "version": "8.13.4",
+  "version": "8.13.5",
   "description": "Truedat Web Core",
   "sideEffects": [
     "**/*.css",
@@ -57,7 +57,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.13.4",
+    "@truedat/test": "8.13.5",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -99,5 +99,5 @@
     "swr": "^2.3.3",
     "turndown": "^7.2.2"
   },
-  "gitHead": "4ec142f1c856aa669b232b12250c800a19ab9ace"
+  "gitHead": "9b87cbb7143f20b305b84077c1fcf004e5b27726"
 }

package/src/components/GlossaryMenu.js

@@ -15,7 +15,7 @@ import {
   CONCEPTS_DEPRECATED,
   CONCEPT_LINKS_MANAGEMENT,
   CONCEPT_LINKS_APPROVALS,
-  CONCEPTS_BULK_UPLOAD_EVENTS,
+  CONCEPTS_UPLOAD_JOBS,
   CONCEPTS_SUBSCOPE,
   CONCEPTS_SIDEMENU_SUBSCOPE,
   CONCEPTS_SIDEMENU_SUBSCOPE_DEPRECATED,
@@ -101,9 +101,9 @@ function buildMainConceptsSubmenuItems(
   };
   const manageUploads = {
     name: "concepts_upload_events",
-    routes: [CONCEPTS_BULK_UPLOAD_EVENTS],
+    routes: [CONCEPTS_UPLOAD_JOBS],
     groups: ["business_glossary_management"],
-    isActive: () => pathname === CONCEPTS_BULK_UPLOAD_EVENTS,
+    isActive: () => pathname === CONCEPTS_UPLOAD_JOBS,
   };
 
   return [
@@ -171,7 +171,7 @@ function buildManagementSubmenuItems() {
     },
     {
       name: "concepts_upload_events",
-      routes: [CONCEPTS_BULK_UPLOAD_EVENTS],
+      routes: [CONCEPTS_UPLOAD_JOBS],
       groups: ["business_glossary_management"],
     },
   ];

package/src/components/UploadJobDetails.js

@@ -168,7 +168,7 @@ export const ChangesDetail = ({ changes, changeDetails, scope }) => {
   const detailsId = useId();
   const details = changeDetails ?? changes;
 
-  if (!details) return null;
+  if (!details || _.isEmpty(details)) return null;
 
   const changesList = flattenChanges(details);
 

package/src/components/UploadJobParser.js

@@ -1,9 +1,11 @@
 import _ from "lodash/fp";
 import PropTypes from "prop-types";
+import { Link } from "react-router";
 import { FormattedMessage, useIntl } from "react-intl";
 import Label from "semantic-ui-react/dist/commonjs/elements/Label";
 import RuleImplementationLink from "@truedat/dq/components/RuleImplementationLink";
 import StructureNoteLink from "@truedat/dd/components/StructureNoteLink";
+import { linkTo } from "../routes";
 import { ChangesDetail, ErrorDetailsDisclosure } from "./UploadJobDetails";
 import { classifyUploadJobErrorMessage } from "./UploadJobSummary";
 
@@ -69,6 +71,19 @@ export const ResponseCell = ({
   }
 };
 
+const ConceptLink = ({ business_concept_id, id, name }) => (
+  <Link to={linkTo.CONCEPT_VERSION({ business_concept_id, id })}>{name}</Link>
+);
+
+ConceptLink.propTypes = {
+  business_concept_id: PropTypes.oneOfType([
+    PropTypes.number,
+    PropTypes.string,
+  ]),
+  id: PropTypes.oneOfType([PropTypes.number, PropTypes.string]),
+  name: PropTypes.string,
+};
+
 export const ResultEntityCell = ({ response, status }) => {
   if (!response?.details || !["INFO", "ERROR"].includes(status)) return null;
 
@@ -78,6 +93,8 @@ export const ResultEntityCell = ({ response, status }) => {
 
   return response.details.implementation_key != null ? (
     <RuleImplementationLink {...response.details} />
+  ) : response.details.business_concept_id != null ? (
+    <ConceptLink {...response.details} />
   ) : status === "INFO" &&
     (response.details.data_structure_id != null ||
       response.details.external_id != null) ? (
@@ -113,6 +130,11 @@ ResultEntityCell.propTypes = {
         PropTypes.number,
         PropTypes.string,
       ]),
+      business_concept_id: PropTypes.oneOfType([
+        PropTypes.number,
+        PropTypes.string,
+      ]),
+      id: PropTypes.oneOfType([PropTypes.number, PropTypes.string]),
       name: PropTypes.string,
     }),
   }),
@@ -204,6 +226,51 @@ const ErrorDetail = ({ response, showOrigin }) => {
     );
   }
 
+  if (!showOrigin && type === "name_not_available") {
+    const name = response.details?.name;
+
+    return (
+      <span className="upload-job-simple-error">
+        <FormattedMessage id="uploadJob.parser.error.name_not_available" />
+        {name != null ? `: ${name}` : null}
+      </span>
+    );
+  }
+
+  if (!showOrigin && type === "unexpected_error") {
+    const { type: errorType } = classifyUploadJobErrorMessage(
+      response.details?.message,
+    );
+
+    if (errorType === "unexpected_error") {
+      return (
+        <span className="upload-job-simple-error">
+          <FormattedMessage id="uploadJob.parser.error.unexpected_error" />
+        </span>
+      );
+    }
+  }
+
+  const validationErrorPairs = (errors) => {
+    if (_.isArray(errors)) {
+      return errors.map((e) => [
+        e?.field ?? formatMessage({ id: `${messagePrefix}.message` }),
+        e?.message ?? "",
+      ]);
+    }
+
+    if (_.isObject(errors)) {
+      return Object.entries(errors).flatMap(([field, messages]) =>
+        (_.isArray(messages) ? messages : [messages]).map((message) => [
+          field,
+          message ?? "",
+        ]),
+      );
+    }
+
+    return null;
+  };
+
   const detailBuilders = {
     missing_required_headers: (details) => [
       [
@@ -276,10 +343,9 @@ const ErrorDetail = ({ response, showOrigin }) => {
         [null, externalIdDetailValue(details)],
       ].filter(([, v]) => v !== undefined && v !== ""),
     field_validation_error: (details) =>
-      details?.errors?.map((e) => [
-        e?.field ?? formatMessage({ id: `${messagePrefix}.message` }),
-        e?.message ?? "",
-      ]) ?? [[null, externalIdDetailValue(details)]],
+      validationErrorPairs(details?.errors) ?? [
+        [null, externalIdDetailValue(details)],
+      ],
     unprocessable_entity: (details) => [[null, externalIdDetailValue(details)]],
     structure_note_creation_error: (details) => {
       const reason = details?.reason ?? details?.error;
@@ -289,12 +355,10 @@ const ErrorDetail = ({ response, showOrigin }) => {
           ? `structures.uploadStructures.failed.note.${reason}`
           : null;
 
-      const errorPairs = details?.errors?.length
-        ? details.errors.map((e) => [
-            e?.field ?? formatMessage({ id: `${messagePrefix}.message` }),
-            e?.message ?? "",
-          ])
-        : [
+      const validationPairs = validationErrorPairs(details?.errors);
+
+      const errorPairs = _.isEmpty(validationPairs)
+        ? [
             [
               formatMessage({ id: `${messagePrefix}.reason` }),
               reasonMessageId
@@ -304,7 +368,8 @@ const ErrorDetail = ({ response, showOrigin }) => {
                   })
                 : String(reason ?? ""),
             ],
-          ];
+          ]
+        : validationPairs;
 
       const externalIdPair = details?.external_id
         ? [[null, externalIdDetailValue(details)]]

package/src/components/UploadJobScope.js

@@ -1,10 +1,19 @@
 import {
+  CONCEPTS_UPLOAD_JOBS,
   IMPLEMENTATIONS_UPLOAD_JOBS,
   STRUCTURE_NOTES_UPLOAD_JOBS,
   linkTo,
 } from "@truedat/core/routes";
 
 export const uploadJobScopes = {
+  concepts: {
+    listPath: CONCEPTS_UPLOAD_JOBS,
+    detailPath: (id) => linkTo.CONCEPTS_UPLOAD_JOB({ id }),
+    listHeaderId: "uploadJobs.concepts.header",
+    detailHeaderId: "uploadJob.concepts.header",
+    entityColumnMessageId: "uploadJob.results.column.concept",
+    fieldMessagePrefix: "concepts.props",
+  },
   implementations: {
     listPath: IMPLEMENTATIONS_UPLOAD_JOBS,
     detailPath: (id) => linkTo.IMPLEMENTATIONS_UPLOAD_JOB({ id }),

package/src/components/UploadJobSummary.js

@@ -52,7 +52,8 @@ export const classifyUploadJobErrorMessage = (message) => {
   const isTechnicalError =
     /^%[A-Z][A-Za-z0-9_.]*\{/.test(normalizedMessage) ||
     /^\{:/.test(normalizedMessage) ||
-    /^\*\* \(/.test(normalizedMessage);
+    /^\*\* \(/.test(normalizedMessage) ||
+    /^protocol \S+ not implemented/.test(normalizedMessage);
 
   return isTechnicalError
     ? { type: "unexpected_error" }

package/src/components/__tests__/UploadJobBreadcrumbs.spec.js

@@ -37,4 +37,14 @@ describe("ImplementationUploadJobBreadcrumbs", () => {
     expect(rendered.getByText(filename)).toBeInTheDocument();
     expect(rendered.container).toMatchSnapshot();
   });
+
+  it("renders breadcrumbs for concepts scope", async () => {
+    const rendered = render(<UploadJobBreadcrumbs scope="concepts" />);
+    await waitForLoad(rendered);
+
+    expect(
+      rendered.getByText(/uploadJobs.concepts.header/i),
+    ).toBeInTheDocument();
+    expect(rendered.container).toMatchSnapshot();
+  });
 });

package/src/components/__tests__/UploadJobParser.spec.js

@@ -32,6 +32,10 @@ jest.mock("@truedat/dd/components/StructureNoteLink", () => ({
     );
   },
 }));
+jest.mock("react-router", () => ({
+  ...jest.requireActual("react-router"),
+  Link: ({ to, children }) => <a href={to}>{children}</a>,
+}));
 
 const changeMessages = {
   en: {
@@ -50,6 +54,8 @@ const changeMessages = {
     "uploadJob.parser.error.field_validation_error": "Field validation error",
     "uploadJob.parser.error.data_structure_not_found":
       "Data structure not found",
+    "uploadJob.parser.error.unexpected_error": "Unexpected error",
+    "uploadJob.parser.error.name_not_available": "Name not available",
     "uploadJob.parser.detail.message": "Message",
   },
 };
@@ -99,6 +105,98 @@ describe("<ResultEntityCell />", () => {
     );
   });
 
+  it("renders INFO concept links from row details", () => {
+    const rendered = render(
+      <ResultEntityCell
+        status="INFO"
+        response={{
+          details: {
+            id: 5,
+            business_concept_id: 3,
+            name: "My Concept",
+          },
+        }}
+      />,
+    );
+    expect(rendered.getByRole("link", { name: "My Concept" })).toHaveAttribute(
+      "href",
+      "/concepts/3/versions/5",
+    );
+  });
+
+  it("renders ERROR concept links from row details", () => {
+    const rendered = render(
+      <ResultEntityCell
+        status="ERROR"
+        response={{
+          type: "name_not_available",
+          details: {
+            id: 5,
+            business_concept_id: 3,
+            name: "My Concept",
+          },
+        }}
+      />,
+    );
+    expect(rendered.getByRole("link", { name: "My Concept" })).toHaveAttribute(
+      "href",
+      "/concepts/3/versions/5",
+    );
+  });
+
+  it("renders concept links for unexpected_error rows with entity data", () => {
+    const rendered = render(
+      <ResultEntityCell
+        status="ERROR"
+        response={{
+          type: "unexpected_error",
+          details: {
+            id: 5,
+            business_concept_id: 3,
+            name: "My Concept",
+          },
+        }}
+      />,
+    );
+    expect(rendered.getByRole("link", { name: "My Concept" })).toHaveAttribute(
+      "href",
+      "/concepts/3/versions/5",
+    );
+  });
+
+  it("renders concept links for unchanged rows", () => {
+    const rendered = render(
+      <ResultEntityCell
+        status="INFO"
+        response={{
+          type: "unchanged",
+          details: {
+            id: 5,
+            business_concept_id: 3,
+            name: "My Concept",
+          },
+        }}
+      />,
+    );
+    expect(rendered.getByRole("link", { name: "My Concept" })).toHaveAttribute(
+      "href",
+      "/concepts/3/versions/5",
+    );
+  });
+
+  it("renders no entity for historical unchanged rows without entity data", () => {
+    const rendered = render(
+      <ResultEntityCell
+        status="INFO"
+        response={{
+          type: "unchanged",
+          details: { row_number: 3, sheet: "date template" },
+        }}
+      />,
+    );
+    expect(rendered.container).toBeEmptyDOMElement();
+  });
+
   it("renders implementation refs and preferred structure labels with external ids", () => {
     const implementation = render(
       <ResultEntityCell
@@ -512,6 +610,43 @@ describe("<ResponseCell />", () => {
     expect(rendered.getByText(/Already exists/i)).toBeInTheDocument();
   });
 
+  it("renders ERROR status with field_validation_error details as an object", () => {
+    const response = {
+      type: "field_validation_error",
+      details: {
+        id: 693,
+        name: "prueba2",
+        sheet: "termino",
+        errors: { adjuntos: ["is invalid"] },
+        row_number: 3,
+        business_concept_id: 337,
+      },
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />,
+    );
+    expect(
+      rendered.getByText(/uploadJob.parser.error.field_validation_error/i),
+    ).toBeInTheDocument();
+    expect(rendered.getByText(/adjuntos/i)).toBeInTheDocument();
+    expect(rendered.getByText(/is invalid/i)).toBeInTheDocument();
+  });
+
+  it("renders ERROR status with field_validation_error object details with multiple messages", () => {
+    const response = {
+      type: "field_validation_error",
+      details: {
+        errors: { name: ["Required", "Too long"], type: "is invalid" },
+      },
+    };
+    const rendered = render(
+      <ResponseCell response={response} status="ERROR" />,
+    );
+    expect(rendered.getByText(/Required/i)).toBeInTheDocument();
+    expect(rendered.getByText(/Too long/i)).toBeInTheDocument();
+    expect(rendered.getByText(/is invalid/i)).toBeInTheDocument();
+  });
+
   it("renders ERROR status with deprecated_implementation details", () => {
     const response = {
       type: "deprecated_implementation",
@@ -706,6 +841,27 @@ describe("<ResponseCell />", () => {
     });
   });
 
+  it("renders no changes disclosure when change_details is empty", () => {
+    const rendered = render(
+      <ResponseCell
+        response={{
+          type: "updated",
+          details: {
+            change_details: {},
+          },
+        }}
+        status="INFO"
+      />,
+      {
+        messages: changeMessages,
+      },
+    );
+
+    expect(
+      rendered.queryByRole("button", { name: /modified fields?/i }),
+    ).not.toBeInTheDocument();
+  });
+
   it("renders boolean, null and zero change values without losing their values", async () => {
     const user = userEvent.setup({ delay: null });
     const rendered = render(
@@ -850,6 +1006,67 @@ describe("<ResultDetailCell /> errors", () => {
     expect(rendered.queryByText("unknown-note")).not.toBeInTheDocument();
   });
 
+  it("renders unexpected_error with empty details as a generic message only", () => {
+    const rendered = render(
+      <ResultDetailCell
+        response={{ type: "unexpected_error", details: {} }}
+        status="ERROR"
+      />,
+      { messages: changeMessages },
+    );
+
+    expect(rendered.getByText("Unexpected error")).toBeInTheDocument();
+    expect(rendered.queryByRole("button")).not.toBeInTheDocument();
+    expect(
+      rendered.queryByText(/protocol String\.Chars/),
+    ).not.toBeInTheDocument();
+  });
+
+  it("renders unexpected_error events with technical messages as a generic message only", () => {
+    const technicalMessage =
+      "protocol String.Chars not implemented for type Tuple. This protocol is implemented for the following type(s): Atom, BitString\n\nGot value:\n\n {:array, :map}\n";
+
+    const rendered = render(
+      <ResultDetailCell
+        response={{
+          type: "unexpected_error",
+          details: { message: technicalMessage },
+        }}
+        status="ERROR"
+      />,
+      { messages: changeMessages },
+    );
+
+    expect(rendered.getByText("Unexpected error")).toBeInTheDocument();
+    expect(rendered.queryByRole("button")).not.toBeInTheDocument();
+    expect(
+      rendered.queryByText(/protocol String\.Chars/),
+    ).not.toBeInTheDocument();
+  });
+
+  it("renders name_not_available with the conflicting name as a simple message", () => {
+    const rendered = render(
+      <ResultDetailCell
+        response={{
+          type: "name_not_available",
+          details: {
+            name: "TEST CREACION",
+            row_number: 3,
+            sheet: "date template",
+          },
+        }}
+        status="ERROR"
+      />,
+      { messages: changeMessages },
+    );
+
+    expect(
+      rendered.getByText("Name not available: TEST CREACION"),
+    ).toBeInTheDocument();
+    expect(rendered.queryByRole("button")).not.toBeInTheDocument();
+    expect(rendered.queryByText(/row_number/)).not.toBeInTheDocument();
+  });
+
   it("uses the singular error count for one field", () => {
     const rendered = render(
       <ResultDetailCell

package/src/components/__tests__/UploadJobScope.spec.js

@@ -25,6 +25,23 @@ describe("Upload job scopes", () => {
     );
   });
 
+  it("defines concepts upload routes and presentation metadata", () => {
+    expect(uploadJobScopes.concepts.listPath).toBe("/concepts/uploadJobs");
+    expect(uploadJobScopes.concepts.listHeaderId).toBe(
+      "uploadJobs.concepts.header",
+    );
+    expect(uploadJobScopes.concepts.detailHeaderId).toBe(
+      "uploadJob.concepts.header",
+    );
+    expect(uploadJobScopes.concepts.detailPath(12)).toBe(
+      "/concepts/uploadJobs/12",
+    );
+    expect(uploadJobScopes.concepts.entityColumnMessageId).toBe(
+      "uploadJob.results.column.concept",
+    );
+    expect(uploadJobScopes.concepts.fieldMessagePrefix).toBe("concepts.props");
+  });
+
   it("falls back to implementation semantics for unknown scopes", () => {
     expect(getUploadJobScope("other")).toMatchObject({
       listPath: null,

package/src/components/__tests__/UploadJobSummary.spec.js

@@ -130,6 +130,33 @@ describe("<UploadJobSummary />", () => {
     });
   });
 
+  it("classifies protocol not implemented messages as unexpected errors", () => {
+    expect(
+      classifyUploadJobErrorMessage(
+        "protocol String.Chars not implemented for type Tuple. This protocol is implemented for the following type(s): Atom, BitString\n\nGot value:\n\n {:array, :map}\n",
+      ),
+    ).toEqual({ type: "unexpected_error" });
+  });
+
+  it("replaces protocol failure details with an unexpected error", () => {
+    const technicalMessage =
+      "protocol String.Chars not implemented for type Tuple. This protocol is implemented for the following type(s): Atom, BitString\n\nGot value:\n\n {:array, :map}\n";
+    const rendered = render(
+      <UploadJobSummary
+        events={[{ status: "FAILED", response: { message: technicalMessage } }]}
+        latestStatus="FAILED"
+      />,
+      { messages: summaryMessages },
+    );
+
+    expect(rendered.getByLabelText("Summary")).toHaveTextContent(
+      "Error processing the file: Unexpected error",
+    );
+    expect(rendered.getByLabelText("Summary")).not.toHaveTextContent(
+      "protocol String.Chars not implemented",
+    );
+  });
+
   it("renders a human failure message", () => {
     const rendered = render(
       <UploadJobSummary

package/src/components/__tests__/UploadJobs.spec.js

@@ -189,4 +189,19 @@ describe("<UploadJobs />", () => {
     expect(rendered.getByText(/completed/i)).toBeInTheDocument();
     expect(rendered.getByText(/success/i)).toBeInTheDocument();
   });
+
+  it("renders concepts scope header", async () => {
+    useUploadJobs.mockReturnValue({
+      loading: false,
+      data: {
+        data: [],
+      },
+    });
+
+    const rendered = render(<UploadJobs scope="concepts" />);
+    await waitForLoad(rendered);
+
+    const elements = rendered.getAllByText(/uploadJobs.concepts.header/i);
+    expect(elements.length).toBeGreaterThan(0);
+  });
 });

package/src/components/__tests__/__snapshots__/GlossaryMenu.spec.js.snap

@@ -132,7 +132,7 @@ exports[`<GlossaryMenu /> matches the latest snapshot, finds fixed and subscopes
           aria-checked="false"
           class="item"
           data-discover="true"
-          href="/concepts/management/bulk_upload_event"
+          href="/concepts/uploadJobs"
           name="concepts_upload_events"
           role="option"
         >

package/src/components/__tests__/__snapshots__/SideMenu.spec.js.snap

@@ -125,7 +125,7 @@ exports[`<SideMenu /> matches the latest snapshot 1`] = `
               aria-checked="false"
               class="item"
               data-discover="true"
-              href="/concepts/management/bulk_upload_event"
+              href="/concepts/uploadJobs"
               name="concepts_upload_events"
               role="option"
             >

package/src/components/__tests__/__snapshots__/UploadJobBreadcrumbs.spec.js.snap

@@ -1,5 +1,21 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`ImplementationUploadJobBreadcrumbs renders breadcrumbs for concepts scope 1`] = `
+<div>
+  <div
+    class="ui breadcrumb"
+  >
+    <a
+      class="section"
+      data-discover="true"
+      href="/concepts/uploadJobs"
+    >
+      uploadJobs.concepts.header
+    </a>
+  </div>
+</div>
+`;
+
 exports[`ImplementationUploadJobBreadcrumbs renders breadcrumbs with filename 1`] = `
 <div>
   <div

package/src/routes.js

@@ -14,8 +14,8 @@ export const BUCKET_VIEW_CONFIG_EDIT = "/bucketViewConfigs/:id/edit";
 export const BUCKET_VIEW_CONFIG_NEW = "/bucketViewConfigs/new";
 export const CONCEPTS = "/concepts";
 export const CONCEPTS_BULK_UPDATE = "/concepts/bulk_update";
-export const CONCEPTS_BULK_UPLOAD_EVENTS =
-  "/concepts/management/bulk_upload_event";
+export const CONCEPTS_UPLOAD_JOBS = "/concepts/uploadJobs";
+export const CONCEPTS_UPLOAD_JOB = "/concepts/uploadJobs/:id";
 export const CONCEPTS_NEW = "/concepts/new";
 export const CONCEPTS_PENDING = "/concepts/pending";
 export const CONCEPTS_DEPRECATED = "/concepts/deprecated";
@@ -313,6 +313,8 @@ const routes = {
   BUCKET_VIEW_CONFIGS,
   CONCEPTS,
   CONCEPTS_BULK_UPDATE,
+  CONCEPTS_UPLOAD_JOBS,
+  CONCEPTS_UPLOAD_JOB,
   CONCEPT_LINKS_APPROVALS,
   CONCEPT_LINKS_APPROVALS_RESULTS,
   CONCEPTS_NEW,