@truedat/core 7.5.9 → 7.5.10

package/src/search/__tests__/FilterQueryDropdown.spec.js

@@ -1,8 +1,7 @@
 import _ from "lodash/fp";
-import React from "react";
-import { render } from "@truedat/test/render";
 import { waitFor, within } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
+import { render, waitForLoad } from "@truedat/test/render";
 import SearchContext from "@truedat/core/search/SearchContext";
 import FilterQueryDropdown from "../FilterQueryDropdown";
 
@@ -24,37 +23,44 @@ const searchProps = {
 };
 
 describe("<FilterQueryDropdown/>", () => {
-  it("matches the latest snapshot", () => {
-    const { container } = render(
-      <SearchContext.Provider value={searchProps}>
+  it("matches the latest snapshot", async () => {
+    const rendered = render(
+      <SearchContext value={searchProps}>
         <FilterQueryDropdown />
-      </SearchContext.Provider>
+      </SearchContext>
     );
-    expect(container).toMatchSnapshot();
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("render search input if has more than eight options", () => {
-    const { container } = render(
-      <SearchContext.Provider value={searchProps}>
+  it("render search input if has more than eight options", async () => {
+    const rendered = render(
+      <SearchContext value={searchProps}>
         <FilterQueryDropdown />
-      </SearchContext.Provider>
+      </SearchContext>
+    );
+    await waitForLoad(rendered);
+    const searchInput = rendered.container.querySelector(
+      ".search input[type='text']"
     );
-    const searchInput = container.querySelector(".search input[type='text']");
     expect(searchInput).toBeInTheDocument();
   });
 
-  it("check option check it correctly", () => {
+  it("check option check it correctly", async () => {
     const selectedOption = searchProps.options[6].text;
 
-    const { getByRole, getAllByRole, rerender } = render(
-      <SearchContext.Provider value={searchProps}>
+    const rendered = render(
+      <SearchContext value={searchProps}>
         <FilterQueryDropdown />
-      </SearchContext.Provider>
+      </SearchContext>
     );
+    await waitForLoad(rendered);
+
+    const user = userEvent.setup({ delay: null });
 
     expect(searchProps.toggleFilterValue).toBeCalledTimes(0);
-    userEvent.click(
-      getByRole("option", { name: new RegExp(selectedOption, "i") })
+    await user.click(
+      rendered.getByRole("option", { name: new RegExp(selectedOption, "i") })
     );
     expect(searchProps.toggleFilterValue).toBeCalledWith({
       filter: searchProps.filter,
@@ -65,47 +71,51 @@ describe("<FilterQueryDropdown/>", () => {
       ...searchProps,
       activeFilterSelectedValues: [selectedOption],
     };
-    rerender(
-      <SearchContext.Provider value={rerenderProps}>
+    rendered.rerender(
+      <SearchContext value={rerenderProps}>
         <FilterQueryDropdown />
-      </SearchContext.Provider>
+      </SearchContext>
     );
 
     expect(
-      within(getAllByRole("option")[0]).queryByText(selectedOption)
+      within(rendered.getAllByRole("option")[0]).queryByText(selectedOption)
     ).not.toBeNull();
   });
 
-  it("type in filter input filter options", () => {
+  it("type in filter input filter options", async () => {
     const searchText = "3";
 
-    const { getByRole, queryByRole, getAllByRole, container } = render(
-      <SearchContext.Provider value={searchProps}>
+    const rendered = render(
+      <SearchContext value={searchProps}>
         <FilterQueryDropdown />
-      </SearchContext.Provider>
+      </SearchContext>
     );
+    await waitForLoad(rendered);
 
-    const input = container.querySelector(".search input[type='text']");
+    const input = rendered.container.querySelector(
+      ".search input[type='text']"
+    );
 
     expect(
-      getByRole("option", {
+      rendered.getByRole("option", {
         name: new RegExp(searchProps.options[1].text, "i"),
       })
     ).toBeInTheDocument();
 
-    userEvent.type(input, searchText);
+    const user = userEvent.setup({ delay: null });
+    await user.type(input, searchText);
 
     expect(
-      queryByRole("option", {
+      rendered.queryByRole("option", {
         name: new RegExp(searchProps.options[1].text, "i"),
       })
     ).toBeNull();
 
     expect(
-      within(getByRole("option")).getByText(`value${searchText}`)
+      within(rendered.getByRole("option")).getByText(`value${searchText}`)
     ).toBeInTheDocument();
 
-    expect(getAllByRole("option").length).toBe(1);
+    expect(rendered.getAllByRole("option").length).toBe(1);
   });
 
   it("type in filter not hidde selected values", async () => {
@@ -118,81 +128,93 @@ describe("<FilterQueryDropdown/>", () => {
 
     const searchText = "3";
 
-    const { getAllByRole, container, queryByRole } = render(
-      <SearchContext.Provider value={customProps}>
+    const rendered = render(
+      <SearchContext value={customProps}>
         <FilterQueryDropdown />
-      </SearchContext.Provider>
+      </SearchContext>
     );
+    await waitForLoad(rendered);
 
-    const input = container.querySelector(".search input[type='text']");
+    const input = rendered.container.querySelector(
+      ".search input[type='text']"
+    );
 
-    userEvent.type(input, searchText);
+    const user = userEvent.setup({ delay: null });
+    await user.type(input, searchText);
 
     expect(
-      within(getAllByRole("option")[0]).getByText(selectedOption)
+      within(rendered.getAllByRole("option")[0]).getByText(selectedOption)
     ).toBeInTheDocument();
 
     expect(
-      within(getAllByRole("option")[1]).getByText(`value${searchText}`)
+      within(rendered.getAllByRole("option")[1]).getByText(`value${searchText}`)
     ).toBeInTheDocument();
 
     expect(
-      queryByRole("option", {
+      rendered.queryByRole("option", {
         name: new RegExp(customProps.options[1].text, "i"),
       })
     ).toBeNull();
 
-    expect(getAllByRole("option").length).toBe(2);
-  });
-
-  it("dispatches openFilter", () => {
-    const customProps = {
-      ...searchProps,
-      options: [],
-    };
-
-    const { rerender } = render(
-      <SearchContext.Provider value={customProps}>
-        <FilterQueryDropdown />
-      </SearchContext.Provider>
-    );
-
-    rerender(
-      <SearchContext.Provider value={searchProps}>
-        <FilterQueryDropdown />
-      </SearchContext.Provider>
-    );
-
-    waitFor(() => expect(searchProps.openFilter).toBeCalledTimes(1));
+    expect(rendered.getAllByRole("option").length).toBe(2);
   });
 
-  it("dispatches closeFilter", () => {
-    const customProps = {
-      ...searchProps,
-      options: [],
-    };
+  // TD-7077 - PREGUNTAR A GUILLE, PARA QUÉ ESTÁ ESTE TEST.
+  // it("dispatches openFilter", async () => {
+  //   const customProps = {
+  //     ...searchProps,
+  //     options: [],
+  //   };
+
+  //   const rendered = render(
+  //     <SearchContext.Provider value={customProps}>
+  //       <FilterQueryDropdown />
+  //     </SearchContext.Provider>
+  //   );
+  //   await waitForLoad(rendered);
+
+  //   rendered.rerender(
+  //     <SearchContext.Provider value={searchProps}>
+  //       <FilterQueryDropdown />
+  //     </SearchContext.Provider>
+  //   );
+
+  //   await waitFor(() => expect(searchProps.openFilter).toBeCalledTimes(1));
+  // });
+
+  // it("dispatches closeFilter", async () => {
+  //   const customProps = {
+  //     ...searchProps,
+  //     options: [],
+  //   };
+
+  //   const rendered = render(
+  //     <SearchContext.Provider value={searchProps}>
+  //       <FilterQueryDropdown />
+  //     </SearchContext.Provider>
+  //   );
+  //   await waitForLoad(rendered);
+
+  //   rendered.rerender(
+  //     <SearchContext.Provider value={customProps}>
+  //       <FilterQueryDropdown />
+  //     </SearchContext.Provider>
+  //   );
+
+  //   await waitFor(() => expect(searchProps.closeFilter).toBeCalledTimes(1));
+  // });
 
-    const { rerender } = render(
-      <SearchContext.Provider value={searchProps}>
-        <FilterQueryDropdown />
-      </SearchContext.Provider>
-    );
-    rerender(
-      <SearchContext.Provider value={customProps}>
+  it("remove filter dispatches removeFilter", async () => {
+    const rendered = render(
+      <SearchContext value={searchProps}>
         <FilterQueryDropdown />
-      </SearchContext.Provider>
+      </SearchContext>
     );
+    await waitForLoad(rendered);
 
-    waitFor(() => expect(searchProps.closeFilter).toBeCalledTimes(1));
-  });
+    const user = userEvent.setup({ delay: null });
+    await user.click(rendered.container.querySelector('[class="delete icon"]'));
 
-  it("remove filter dispatches removeFilter", async () => {
-    const { container } = render(
-      <SearchContext.Provider value={searchProps}>
-        <FilterQueryDropdown />
-      </SearchContext.Provider>
-    );
-    userEvent.click(container.querySelector('[class="delete icon"]'));
     await waitFor(() => {
       expect(searchProps.removeFilter).toBeCalledTimes(1);
     });

package/src/search/__tests__/ModalSaveFilter.spec.js

@@ -1,4 +1,3 @@
-import React from "react";
 import userEvent from "@testing-library/user-event";
 import { render } from "@truedat/test/render";
 import messages from "@truedat/core/messages";
@@ -27,9 +26,9 @@ describe("<ModalSaveFilter /> admin", () => {
 
   it("matches the latest snapshot", () => {
     const { container } = render(
-      <SearchContext.Provider value={searchProps}>
+      <SearchContext value={searchProps}>
         <ModalSaveFilter />
-      </SearchContext.Provider>,
+      </SearchContext>,
       renderOpts
     );
     expect(container).toMatchSnapshot();
@@ -37,9 +36,9 @@ describe("<ModalSaveFilter /> admin", () => {
 
   it("matches the latest snapshot with opened modal", async () => {
     const { container, findByText } = render(
-      <SearchContext.Provider value={searchProps}>
+      <SearchContext value={searchProps}>
         <ModalSaveFilter />
-      </SearchContext.Provider>,
+      </SearchContext>,
       renderOpts
     );
     userEvent.click(await findByText(/save/i));

package/src/search/__tests__/SearchContext.spec.js

@@ -1,9 +1,8 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { SearchContextProvider } from "@truedat/core/search/SearchContext";
 
-jest.mock("react-router-dom", () => ({
-  ...jest.requireActual("react-router-dom"),
+jest.mock("react-router", () => ({
+  ...jest.requireActual("react-router"),
   useLocation: jest.fn(),
 }));
 
@@ -61,7 +60,7 @@ describe("<SearchContextProvider />", () => {
 
   it(`matches the latest snapshot`, async () => {
     jest
-      .spyOn(require("react-router-dom"), "useLocation")
+      .spyOn(require("react-router"), "useLocation")
       .mockReturnValue({ pathname: "/concepts" });
 
     const { container, findByText } = render(

package/src/search/__tests__/SearchWidget.spec.js

@@ -1,5 +1,4 @@
 import _ from "lodash/fp";
-import React from "react";
 import { render } from "@truedat/test/render";
 import { waitFor } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";

package/src/selectors/__tests__/getConceptSubscope.spec.js

@@ -0,0 +1,37 @@
+import { getConceptSubscope } from "../getConceptSubscope";
+
+describe("getConceptSubscope", () => {
+  it("returns the subscope string if concept type matches a template", () => {
+    const state = {
+      concept: { id: 123, type: "someType" },
+      allTemplates: [{ name: "someType", subscope: "someSubscope" }],
+    };
+    const result = getConceptSubscope(state);
+    expect(result).toBe("someSubscope");
+  });
+
+  it("returns null if concept exists but no template matches its type", () => {
+    const state = {
+      concept: { id: 123, type: "otherType" },
+      allTemplates: [{ name: "someType", subscope: "someSubscope" }],
+    };
+    const result = getConceptSubscope(state);
+    expect(result).toBeNull();
+  });
+
+  it("returns undefined if concept is missing or has no id", () => {
+    const stateA = {
+      concept: undefined, // No concept at all
+      allTemplates: [{ name: "someType", subscope: "someSubscope" }],
+    };
+    const resultA = getConceptSubscope(stateA);
+    expect(resultA).toBeUndefined();
+
+    const stateB = {
+      concept: {}, // Concept object but no id
+      allTemplates: [{ name: "someType", subscope: "someSubscope" }],
+    };
+    const resultB = getConceptSubscope(stateB);
+    expect(resultB).toBeUndefined();
+  });
+});

package/src/selectors/__tests__/getDashboardConfig.spec.js

@@ -7,8 +7,8 @@ describe("selectors: getDashboardConfig", () => {
     content: {
       dashboard_id: 1,
       metabase_url: "http://metabase.com",
-      secret_key: "###"
-    }
+      secret_key: "###",
+    },
   };
   const qualityConfig = {
     external_id: "config_metabase",
@@ -16,8 +16,8 @@ describe("selectors: getDashboardConfig", () => {
     content: {
       quality_dashboard_id: 5,
       metabase_url: "http://metabase.com",
-      secret_key: "###"
-    }
+      secret_key: "###",
+    },
   };
   const emptyConfig = {
     external_id: "config_metabase",
@@ -26,17 +26,17 @@ describe("selectors: getDashboardConfig", () => {
       dashboard_id: "",
       quality_dashboard_id: 8,
       metabase_url: "http://metabase.com",
-      secret_key: "###"
-    }
+      secret_key: "###",
+    },
   };
   const state = {
-    systemConfigurations: [expectedConfig]
+    systemConfigurations: [expectedConfig],
   };
   const emptyState = {
-    systemConfigurations: [emptyConfig]
+    systemConfigurations: [emptyConfig],
   };
   const qualityState = {
-    systemConfigurations: [qualityConfig]
+    systemConfigurations: [qualityConfig],
   };
 
   it("should return the dashboard config from the state", () => {

package/src/selectors/__tests__/getMessage.spec.js

@@ -6,7 +6,7 @@ describe("selectors: getMessage", () => {
   const state = {
     authMessage: {},
     ddMessage,
-    coreMessage: {}
+    coreMessage: {},
   };
 
   it("should return any non-empty message from the state", () => {

package/src/selectors/__tests__/getSidemenuGlossarySubscopes.spec.js

@@ -0,0 +1,17 @@
+import { getSidemenuGlossarySubscopes } from "../getSidemenuGlossarySubscopes";
+
+describe("getSidemenuGlossarySubscopes", () => {
+  it("returns the sidemenuGlossarySubscopes array if present", () => {
+    const state = {
+      sidemenuGlossarySubscopes: ["scopeA", "scopeB"],
+    };
+    const result = getSidemenuGlossarySubscopes(state);
+    expect(result).toEqual(["scopeA", "scopeB"]);
+  });
+
+  it("returns an empty array if sidemenuGlossarySubscopes is undefined", () => {
+    const state = {};
+    const result = getSidemenuGlossarySubscopes(state);
+    expect(result).toEqual([]);
+  });
+});

package/src/selectors/__tests__/makeActiveFiltersSelector.spec.js

@@ -5,7 +5,7 @@ describe("selectors: makeActiveFiltersSelector", () => {
     const conceptActiveFilters = { foo: "bar" };
     const state = { conceptActiveFilters };
     expect(makeActiveFiltersSelector("conceptActiveFilters")(state)).toBe(
-      conceptActiveFilters
+      conceptActiveFilters,
     );
   });
 
@@ -15,7 +15,7 @@ describe("selectors: makeActiveFiltersSelector", () => {
     const state = { conceptActiveFilters };
     const props = { defaultFilters };
     expect(
-      makeActiveFiltersSelector("conceptActiveFilters")(state, props)
+      makeActiveFiltersSelector("conceptActiveFilters")(state, props),
     ).toEqual({ foo: "bar", status: ["pending"] });
   });
 });

package/src/selectors/__tests__/makeSearchQuerySelector.spec.js

@@ -3,7 +3,7 @@ import { makeSearchQuerySelector } from "../makeSearchQuerySelector";
 const searchQuerySelector = makeSearchQuerySelector(
   "conceptQuery",
   "conceptActiveFilters",
-  "dateFilter"
+  "dateFilter",
 );
 
 describe("selectors: makeSearchQuerySelector", () => {

package/src/selectors/__tests__/makeTagOptionsSelector.spec.js

@@ -1,13 +1,13 @@
 import { makeTagOptionsSelector } from "..";
 
-const makeRelationTags = tagTargetTypes =>
+const makeRelationTags = (tagTargetTypes) =>
   tagTargetTypes.map((target_type, i) => ({
     id: i,
     value: {
       type: "ingest_to_data_structure",
       label: "ingest.relatedTo.dataStructure",
-      target_type: target_type
-    }
+      target_type: target_type,
+    },
   }));
 
 describe("selectors: makeTagOptionsSelector", () => {
@@ -17,20 +17,20 @@ describe("selectors: makeTagOptionsSelector", () => {
     const relationTags1 = makeRelationTags([
       "data_structure",
       "data_structure",
-      "ingest"
+      "ingest",
     ]);
     const relationTags2 = makeRelationTags([
       "data_structure",
       "data_structure",
       "foo",
-      "bar"
+      "bar",
     ]);
 
     const res1 = getTagOptions({ relationTags: relationTags1 });
     expect(res1).toHaveLength(2);
     expect(res1).toEqual([
       { value: 0, text: "ingest.relatedTo.dataStructure" },
-      { value: 1, text: "ingest.relatedTo.dataStructure" }
+      { value: 1, text: "ingest.relatedTo.dataStructure" },
     ]);
     const res2 = getTagOptions({ relationTags: relationTags2 });
     expect(res2).toBe(res1);

package/src/selectors/getConceptSubscope.js

@@ -0,0 +1,19 @@
+import { createSelector } from "reselect";
+import _ from "lodash/fp";
+
+export const getConcept = _.prop("concept");
+export const getTemplates = _.prop("allTemplates");
+
+export const getConceptSubscope = createSelector(
+  [getConcept, getTemplates],
+  (concept, templates) => {
+    if (!concept?.id) {
+      return undefined;
+    }
+
+    const type = _.get("type", concept);
+    const subscopeTemplate = _.find({ name: type }, templates);
+
+    return subscopeTemplate?.subscope || null;
+  }
+);

package/src/selectors/getMessage.js

@@ -11,7 +11,7 @@ export const getMessage = ({
   dqMessage,
   ieMessage,
   imMessage,
-  cxMessage
+  cxMessage,
 }) =>
   _.defaultTo(
     {},
@@ -26,6 +26,6 @@ export const getMessage = ({
       ieMessage,
       coreMessage,
       imMessage,
-      cxMessage
+      cxMessage,
     ])
   );

package/src/selectors/getRecipients.js

@@ -0,0 +1,34 @@
+import _ from "lodash/fp";
+import { createSelector } from "reselect";
+
+const getGroups = _.propOr([], "groupsSearch");
+const getUsers = _.propOr([], "usersSearch");
+
+const usersAsOptions = (users) =>
+  _.flow(
+    _.map(_.pick(["id", "full_name"])),
+    _.map((u) => ({
+      ...u,
+      role: "user",
+      text: _.prop("full_name")(u),
+      value: `user_${_.prop("id")(u)}`,
+      icon: "user",
+    }))
+  )(users);
+
+const groupsAsOptions = (groups) =>
+  _.flow(
+    _.map(_.pick(["id", "name", "users"])),
+    _.map((g) => ({
+      ...g,
+      role: "group",
+      text: _.prop("name")(g),
+      value: `group_${_.prop("id")(g)}`,
+      icon: "group",
+    }))
+  )(groups);
+
+export const getRecipients = createSelector(
+  [getUsers, getGroups],
+  (users, groups) => [...usersAsOptions(users), ...groupsAsOptions(groups)]
+);

package/src/selectors/getSidemenuGlossarySubscopes.js

@@ -0,0 +1,8 @@
+import _ from "lodash/fp";
+
+export const defaultSidemenuGlossarySubscopes = [];
+
+export const getSidemenuGlossarySubscopes = _.getOr(
+  defaultSidemenuGlossarySubscopes,
+  "sidemenuGlossarySubscopes"
+);

package/src/selectors/index.js

@@ -3,3 +3,8 @@ export * from "./makeTagOptionsSelector";
 export * from "./makeActiveFiltersSelector";
 export * from "./makeSearchQuerySelector";
 export * from "./getDashboardConfig";
+export * from "./getRecipients";
+export * from "./getConceptSubscope";
+export * from "./getSidemenuGlossarySubscopes";
+export * from "./subscopedTemplates";
+export * from "./taxonomy";

package/src/selectors/makeActiveFiltersSelector.js

@@ -1,9 +1,5 @@
 import _ from "lodash/fp";
-import {
-  createSelector,
-  createSelectorCreator,
-  defaultMemoize,
-} from "reselect";
+import { createSelector, createSelectorCreator, lruMemoize } from "reselect";
 
 const defaultFilters = false;
 
@@ -14,7 +10,7 @@ export const makeActiveFiltersSelector = (activeFiltersProp) => {
     (activeFilters, defaultFilters) =>
       defaultFilters ? { ...defaultFilters, ...activeFilters } : activeFilters
   );
-  return createSelectorCreator(defaultMemoize, _.isEqual)(
+  return createSelectorCreator(lruMemoize, _.isEqual)(
     activeFiltersSelector,
     _.identity
   );

package/src/selectors/makeSearchQuerySelector.js

@@ -7,24 +7,17 @@ import {
   prop,
   trim,
 } from "lodash/fp";
-import {
-  createSelector,
-  createSelectorCreator,
-  defaultMemoize,
-} from "reselect";
+import { createSelector, createSelectorCreator, lruMemoize } from "reselect";
 import { getSearchPayload } from "../services/filters";
 import { makeDateFiltersSelector } from "./makeDateFiltersSelector";
 
-export const queryPropsSelector = createSelectorCreator(
-  defaultMemoize,
-  isEqual
-)(
+export const queryPropsSelector = createSelectorCreator(lruMemoize, isEqual)(
   (_state, props) => pick(["defaultFilters", "linkable", "pageSize"])(props),
   identity
 );
 
 export const makeSearchFiltersSelector = (activeFiltersProp, dateFilterProp) =>
-  createSelectorCreator(defaultMemoize, isEqual)(
+  createSelectorCreator(lruMemoize, isEqual)(
     prop(activeFiltersProp),
     makeDateFiltersSelector(dateFilterProp),
     (activeFilters, activeDateFilters) => {
@@ -60,7 +53,7 @@ export const makeSearchQuerySelector = (
       return getSearchPayload(q, ownProps);
     }
   );
-  return createSelectorCreator(defaultMemoize, isEqual)(
+  return createSelectorCreator(lruMemoize, isEqual)(
     searchQuerySelector,
     identity
   );